[GitHub] [beam] purbanow commented on a change in pull request #12117: [BEAM-10343] Add dispositions for SnowflakeIO.write

purbanow commented on a change in pull request #12117: URL: https://github.com/apache/beam/pull/12117#discussion_r451973374 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeServiceImpl.java ## @@ -25,7 +27,9 @@ import

[GitHub] [beam] purbanow commented on a change in pull request #12117: [BEAM-10343] Add dispositions for SnowflakeIO.write

purbanow commented on a change in pull request #12117: URL: https://github.com/apache/beam/pull/12117#discussion_r450218823 ## File path: sdks/java/io/snowflake/src/test/java/org/apache/beam/sdk/io/snowflake/test/unit/data/SnowflakeBooleanTest.java ## @@ -0,0 +1,32 @@ +/* + *

[GitHub] [beam] purbanow commented on a change in pull request #12117: [BEAM-10343] Add dispositions for SnowflakeIO.write

purbanow commented on a change in pull request #12117: URL: https://github.com/apache/beam/pull/12117#discussion_r450018838 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/data/text/SnowflakeVarchar.java ## @@ -0,0 +1,59 @@ +/* + * Licensed

[GitHub] [beam] purbanow commented on a change in pull request #12117: [BEAM-10343] Add dispositions for SnowflakeIO.write

purbanow commented on a change in pull request #12117: URL: https://github.com/apache/beam/pull/12117#discussion_r450018715 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/data/text/SnowflakeBinary.java ## @@ -0,0 +1,61 @@ +/* + * Licensed

[GitHub] [beam] purbanow commented on a change in pull request #12117: [BEAM-10343] Add dispositions for SnowflakeIO.write

purbanow commented on a change in pull request #12117: URL: https://github.com/apache/beam/pull/12117#discussion_r450015267 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeServiceImpl.java ## @@ -25,7 +27,9 @@ import

[GitHub] [beam] purbanow commented on a change in pull request #12117: [BEAM-10343] Add dispositions for SnowflakeIO.write

purbanow commented on a change in pull request #12117: URL: https://github.com/apache/beam/pull/12117#discussion_r450012687 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeServiceImpl.java ## @@ -169,6 +191,54 @@ private

[GitHub] [beam] purbanow commented on a change in pull request #12117: [BEAM-10343] Add dispositions for SnowflakeIO.write

purbanow commented on a change in pull request #12117: URL: https://github.com/apache/beam/pull/12117#discussion_r450011779 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -593,7 +606,7 @@ public void

[GitHub] [beam] purbanow commented on a change in pull request #12117: [BEAM-10343] Add dispositions for SnowflakeIO.write

purbanow commented on a change in pull request #12117: URL: https://github.com/apache/beam/pull/12117#discussion_r450011282 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -155,7 +157,7 @@ * items.apply( *