robertwb commented on code in PR #34404:
URL: https://github.com/apache/beam/pull/34404#discussion_r2011066080
##
sdks/python/apache_beam/yaml/yaml_provider.py:
##
@@ -661,16 +661,20 @@ def create_transform(self, type, args,
yaml_create_transform):
return self._transform_f
zilin commented on PR #34404:
URL: https://github.com/apache/beam/pull/34404#issuecomment-2749276881
> From a Beam perspective, this seems like a harmless change, but it seems
like a fragile thing to depend on (and something we could easily accidentally
(or intentionally need to) change
damccorm commented on code in PR #34404:
URL: https://github.com/apache/beam/pull/34404#discussion_r2010877814
##
sdks/python/apache_beam/yaml/yaml_provider.py:
##
@@ -661,16 +661,20 @@ def create_transform(self, type, args,
yaml_create_transform):
return self._transform_f
damccorm commented on code in PR #34404:
URL: https://github.com/apache/beam/pull/34404#discussion_r2010875137
##
sdks/python/apache_beam/yaml/yaml_provider.py:
##
@@ -661,16 +661,20 @@ def create_transform(self, type, args,
yaml_create_transform):
return self._transform_f
robertwb merged PR #34404:
URL: https://github.com/apache/beam/pull/34404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache
damccorm commented on PR #34404:
URL: https://github.com/apache/beam/pull/34404#issuecomment-2749234925
From a Beam perspective, this seems like a harmless change, but it seems
like a fragile thing to depend on (and something we could easily accidentally
(or intentionally need to) change
github-actions[bot] commented on PR #34404:
URL: https://github.com/apache/beam/pull/34404#issuecomment-2749142682
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @damccorm for label python.
Available commands:
- `stop
zilin opened a new pull request, #34404:
URL: https://github.com/apache/beam/pull/34404
This will allow other users to replace the default sql provider used by
'Join' and 'Combine-sql'.
**Please** add a meaningful description for your change here
