Re: [PR] Support BQ clustering with value provider [beam]

2024-04-18 Thread via GitHub
ahmedabu98 merged PR #30460: URL: https://github.com/apache/beam/pull/30460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support BQ clustering with value provider [beam]

2024-04-17 Thread via GitHub
ahmedabu98 commented on code in PR #30460: URL: https://github.com/apache/beam/pull/30460#discussion_r1569144621 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java: ## @@ -455,8 +454,8 @@ public Row

Re: [PR] Support BQ clustering with value provider [beam]

2024-04-17 Thread via GitHub
chamikaramj commented on code in PR #30460: URL: https://github.com/apache/beam/pull/30460#discussion_r1569109482 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java: ## @@ -455,8 +454,8 @@ public Row

Re: [PR] Support BQ clustering with value provider [beam]

2024-04-17 Thread via GitHub
ahmedabu98 commented on code in PR #30460: URL: https://github.com/apache/beam/pull/30460#discussion_r1568435582 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java: ## @@ -455,8 +454,8 @@ public Row

Re: [PR] Support BQ clustering with value provider [beam]

2024-04-16 Thread via GitHub
liferoad commented on PR #30460: URL: https://github.com/apache/beam/pull/30460#issuecomment-2059950154 This is requested by one customer. What is blocking this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Support BQ clustering with value provider [beam]

2024-04-16 Thread via GitHub
damccorm commented on PR #30460: URL: https://github.com/apache/beam/pull/30460#issuecomment-2059174192 @ahmedabu98 @chamikaramj @Abacn where are we on this PR? Does this need to be a release blocker? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Support BQ clustering with value provider [beam]

2024-03-27 Thread via GitHub
ahmedabu98 commented on code in PR #30460: URL: https://github.com/apache/beam/pull/30460#discussion_r1541909816 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java: ## @@ -2826,8 +2826,18 @@ public Write

Re: [PR] Support BQ clustering with value provider [beam]

2024-03-12 Thread via GitHub
chamikaramj commented on code in PR #30460: URL: https://github.com/apache/beam/pull/30460#discussion_r1521798958 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java: ## @@ -2826,8 +2826,18 @@ public Write

Re: [PR] Support BQ clustering with value provider [beam]

2024-03-07 Thread via GitHub
Abacn commented on code in PR #30460: URL: https://github.com/apache/beam/pull/30460#discussion_r1516560453 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java: ## @@ -455,8 +454,8 @@ public Row toConfigRow(Write

Re: [PR] Support BQ clustering with value provider [beam]

2024-03-04 Thread via GitHub
github-actions[bot] commented on PR #30460: URL: https://github.com/apache/beam/pull/30460#issuecomment-1977505227 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] Support BQ clustering with value provider [beam]

2024-03-04 Thread via GitHub
ahmedabu98 commented on PR #30460: URL: https://github.com/apache/beam/pull/30460#issuecomment-1977503059 R: @liferoad R: @chamikaramj (for the change to BigQueryIOTranslation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Support BQ clustering with value provider [beam]

2024-02-29 Thread via GitHub
github-actions[bot] commented on PR #30460: URL: https://github.com/apache/beam/pull/30460#issuecomment-1972122863 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

[PR] Support BQ clustering with value provider [beam]

2024-02-29 Thread via GitHub
ahmedabu98 opened a new pull request, #30460: URL: https://github.com/apache/beam/pull/30460 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,