[GitHub] [beam] mwalenia commented on pull request #11611: [BEAM-9634] Add natural language analysis transform

2020-05-14 Thread GitBox
mwalenia commented on pull request #11611: URL: https://github.com/apache/beam/pull/11611#issuecomment-628424342 @tysonjh I added an entry in CHANGES.md and squashed the commits. Please give your final approval and I'll merge this PR. Thank you for the code review!

[GitHub] [beam] kamilwu commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

2020-05-14 Thread GitBox
kamilwu commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-628468240 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] kamilwu commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

2020-05-14 Thread GitBox
kamilwu commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-628471461 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] kamilwu commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

2020-05-14 Thread GitBox
kamilwu commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-628471026 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] purbanow commented on a change in pull request #11360: [BEAM-9722] added SnowflakeIO with Read operation

2020-05-14 Thread GitBox
purbanow commented on a change in pull request #11360: URL: https://github.com/apache/beam/pull/11360#discussion_r424897088 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeCloudProvider.java ## @@ -0,0 +1,29 @@ +/* + * Licensed to

[GitHub] [beam] mwalenia commented on pull request #11676: [DO NOT MERGE] Java 11 Precommit

2020-05-14 Thread GitBox
mwalenia commented on pull request #11676: URL: https://github.com/apache/beam/pull/11676#issuecomment-628421629 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] kamilwu commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

2020-05-14 Thread GitBox
kamilwu commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-628470719 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] mwalenia commented on pull request #11676: [DO NOT MERGE] Java 11 Precommit

2020-05-14 Thread GitBox
mwalenia commented on pull request #11676: URL: https://github.com/apache/beam/pull/11676#issuecomment-628422768 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] mwalenia commented on pull request #11676: [DO NOT MERGE] Java 11 Precommit

2020-05-14 Thread GitBox
mwalenia commented on pull request #11676: URL: https://github.com/apache/beam/pull/11676#issuecomment-628427924 Run Java11 PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik commented on pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
lukecwik commented on pull request #11710: URL: https://github.com/apache/beam/pull/11710#issuecomment-628820475 > ahh this is great. We've been running a similar patch in our fork forever. Feel free to submit patches upstream

[GitHub] [beam] lukecwik commented on pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
lukecwik commented on pull request #11710: URL: https://github.com/apache/beam/pull/11710#issuecomment-628826053 > > > ahh this is great. We've been running a similar patch in our fork forever. > > > > > > Feel free to submit patches upstream > > heh, I've been choosing

[GitHub] [beam] jaketf commented on pull request #11339: [BEAM-9468] Fhir io

2020-05-14 Thread GitBox
jaketf commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-628846183 There is a separate crop of issues of ```java.lang.NoClassDefFoundError: Could not initialize class org.apache.beam.sdk.io.gcp.healthcare.FhirIOTestUtil``` In the

[GitHub] [beam] jaketf edited a comment on pull request #11339: [BEAM-9468] Fhir io

2020-05-14 Thread GitBox
jaketf edited a comment on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-628842736 Yeah all the FhirIO read tests are parameterized tests that are all failing like this: ``` WARNING: No terminal state was returned within allotted timeout. State

[GitHub] [beam] pabloem commented on pull request #11339: [BEAM-9468] Fhir io

2020-05-14 Thread GitBox
pabloem commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-628850532 afaik, the test classes should be bundled together (see

[GitHub] [beam] pabloem commented on pull request #11210: [BEAM-8949] SpannerIO integration tests

2020-05-14 Thread GitBox
pabloem commented on pull request #11210: URL: https://github.com/apache/beam/pull/11210#issuecomment-628850653 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aaltay commented on pull request #11705: Clarifies an error message in Katas to explain what is actually wrong.

2020-05-14 Thread GitBox
aaltay commented on pull request #11705: URL: https://github.com/apache/beam/pull/11705#issuecomment-628875430 Merging sounds good. What is https://stepik.org/ ? This is an automated message from the Apache Git Service. To

[GitHub] [beam] aaltay commented on pull request #11705: Clarifies an error message in Katas to explain what is actually wrong.

2020-05-14 Thread GitBox
aaltay commented on pull request #11705: URL: https://github.com/apache/beam/pull/11705#issuecomment-628875545 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11699: Update the range for pyarrow to qualify pyarrow 0.17.x

2020-05-14 Thread GitBox
aaltay commented on pull request #11699: URL: https://github.com/apache/beam/pull/11699#issuecomment-628880849 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aaltay merged pull request #11672: Clarify pubsub IO comment about timestamps

2020-05-14 Thread GitBox
aaltay merged pull request #11672: URL: https://github.com/apache/beam/pull/11672 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] lukecwik commented on pull request #11666: [BEAM-9941] Added a test of a GBK followed by a Flatten with an unknown output coder

2020-05-14 Thread GitBox
lukecwik commented on pull request #11666: URL: https://github.com/apache/beam/pull/11666#issuecomment-628807713 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11437: [BEAM-9770] Add BigQueryIO deadletter pattern

2020-05-14 Thread GitBox
aaltay commented on pull request #11437: URL: https://github.com/apache/beam/pull/11437#issuecomment-628834203 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11437: [BEAM-9770] Add BigQueryIO deadletter pattern

2020-05-14 Thread GitBox
aaltay commented on pull request #11437: URL: https://github.com/apache/beam/pull/11437#issuecomment-628874108 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11705: Clarifies an error message in Katas to explain what is actually wrong.

2020-05-14 Thread GitBox
pabloem commented on pull request #11705: URL: https://github.com/apache/beam/pull/11705#issuecomment-628884514 stepik is the platform where these courses are uploaded , an downloaded by intellij This is an automated

[GitHub] [beam] omarismail94 commented on pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
omarismail94 commented on pull request #11710: URL: https://github.com/apache/beam/pull/11710#issuecomment-62729 New changes passed ./gradlew -p runners/google-cloud-dataflow-java check on my computer This is an

[GitHub] [beam] aaltay edited a comment on pull request #11617: Update programming-guide.md with some typo fixes.

2020-05-14 Thread GitBox
aaltay edited a comment on pull request #11617: URL: https://github.com/apache/beam/pull/11617#issuecomment-628965432 @bashir2 - You can continue with your changes, however you will need to rebase. Alternatively, you can close this PR and start a new one.

[GitHub] [beam] aaltay commented on pull request #11617: Update programming-guide.md with some typo fixes.

2020-05-14 Thread GitBox
aaltay commented on pull request #11617: URL: https://github.com/apache/beam/pull/11617#issuecomment-628965432 @bashir2 - You can continue with your changes, however you will need to rebase. This is an automated message

[GitHub] [beam] lukecwik commented on pull request #11716: [BEAM-2939] Ensure that we don't checkpoint the initial restriction as it has been checkpointed in a prior bundle.

2020-05-14 Thread GitBox
lukecwik commented on pull request #11716: URL: https://github.com/apache/beam/pull/11716#issuecomment-628990029 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-14 Thread GitBox
lukecwik commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r425547978 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -0,0 +1,528 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] boyuanzz commented on a change in pull request #11715: [BEAM-9977] Implement GrowableOffsetRangeTracker

2020-05-14 Thread GitBox
boyuanzz commented on a change in pull request #11715: URL: https://github.com/apache/beam/pull/11715#discussion_r425553418 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/GrowableOffsetRangeTracker.java ## @@ -0,0 +1,103 @@ +/* + *

[GitHub] [beam] boyuanzz opened a new pull request #11715: [BEAM-9977] Implement GrowableOffsetRangeTracker

2020-05-14 Thread GitBox
boyuanzz opened a new pull request #11715: URL: https://github.com/apache/beam/pull/11715 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] lukecwik opened a new pull request #11716: [BEAM-2939] Ensure that we don't checkpoint the initial restriction as it has been checkpointed in a prior bundle.

2020-05-14 Thread GitBox
lukecwik opened a new pull request #11716: URL: https://github.com/apache/beam/pull/11716 This got rid of the NullPointerException for the Kafka checkpoint because the checkpoint itself isn't serializable. When it gets deserialized, the optional reader field is null which is what was

[GitHub] [beam] darshanj commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-14 Thread GitBox
darshanj commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r425529534 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -0,0 +1,528 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] rezarokni commented on pull request #11437: [BEAM-9770] Add BigQueryIO deadletter pattern

2020-05-14 Thread GitBox
rezarokni commented on pull request #11437: URL: https://github.com/apache/beam/pull/11437#issuecomment-629003109 Local tests ran ok, but also raised: https://issues.apache.org/jira/browse/BEAM-10003 So this PR is now just the code bits , rather than code + website bits.

[GitHub] [beam] darshanj commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-14 Thread GitBox
darshanj commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r425550940 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -0,0 +1,528 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] aaltay commented on pull request #11584: [BEAM-9136]support isRelease tag for docker build command & update release guide

2020-05-14 Thread GitBox
aaltay commented on pull request #11584: URL: https://github.com/apache/beam/pull/11584#issuecomment-628965737 @Hannah-Jiang - you can continue with this change now. However you will need to rebase. This is an automated

[GitHub] [beam] aaltay commented on pull request #11549: [BEAM-9136] Update doc about docker image license pulling

2020-05-14 Thread GitBox
aaltay commented on pull request #11549: URL: https://github.com/apache/beam/pull/11549#issuecomment-628965670 @Hannah-Jiang - you can continue with this change now. However you will need to rebase. This is an automated

[GitHub] [beam] lukecwik commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-14 Thread GitBox
lukecwik commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r425547978 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -0,0 +1,528 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] lukecwik commented on a change in pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-14 Thread GitBox
lukecwik commented on a change in pull request #11610: URL: https://github.com/apache/beam/pull/11610#discussion_r425547978 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SetFns.java ## @@ -0,0 +1,528 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] steveniemitz commented on pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
steveniemitz commented on pull request #11710: URL: https://github.com/apache/beam/pull/11710#issuecomment-628824973 > > ahh this is great. We've been running a similar patch in our fork forever. > > Feel free to submit patches upstream heh, I've been choosing my battles ;)

[GitHub] [beam] tvalentyn merged pull request #11705: Clarifies an error message in Katas to explain what is actually wrong.

2020-05-14 Thread GitBox
tvalentyn merged pull request #11705: URL: https://github.com/apache/beam/pull/11705 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] pabloem merged pull request #11210: [BEAM-8949] SpannerIO integration tests

2020-05-14 Thread GitBox
pabloem merged pull request #11210: URL: https://github.com/apache/beam/pull/11210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #11339: [BEAM-9468] Fhir io

2020-05-14 Thread GitBox
pabloem commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-628812777 Fhir postcomits are failing: https://builds.apache.org/job/beam_PostCommit_Java_PR/362/ This is an automated

[GitHub] [beam] steveniemitz commented on pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
steveniemitz commented on pull request #11710: URL: https://github.com/apache/beam/pull/11710#issuecomment-628818041 ahh this is great. We've been running a similar patch in our fork forever. This is an automated message

[GitHub] [beam] lukecwik merged pull request #11666: [BEAM-9941] Added a test of a GBK followed by a Flatten with an unknown output coder

2020-05-14 Thread GitBox
lukecwik merged pull request #11666: URL: https://github.com/apache/beam/pull/11666 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] jaketf commented on pull request #11339: [BEAM-9468] Fhir io

2020-05-14 Thread GitBox
jaketf commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-628872612 - [x] Fixed javadoc checkstyle issue - [x] Added pubsub.close() to the @After in FhirIOReadIT (this should fix the pubsub not shutdown properly message) - [x] Added KV

[GitHub] [beam] omarismail94 commented on a change in pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
omarismail94 commented on a change in pull request #11710: URL: https://github.com/apache/beam/pull/11710#discussion_r425430039 ## File path: runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WindmillStateCacheTest.java ## @@

[GitHub] [beam] ibzib commented on a change in pull request #11708: [BEAM-9577] Artifact v2 support for uber jars.

2020-05-14 Thread GitBox
ibzib commented on a change in pull request #11708: URL: https://github.com/apache/beam/pull/11708#discussion_r425439878 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/ClassLoaderFileSystem.java ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] mwalenia merged pull request #11611: [BEAM-9634] Add natural language analysis transform

2020-05-14 Thread GitBox
mwalenia merged pull request #11611: URL: https://github.com/apache/beam/pull/11611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

2020-05-14 Thread GitBox
pabloem commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-628803732 I'd think it's worth adding a tag to the commit, marking it as the first commit with hugo-based website. This

[GitHub] [beam] pabloem commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

2020-05-14 Thread GitBox
pabloem commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-628803919 (a committer can add this after merging) This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] pabloem commented on a change in pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
pabloem commented on a change in pull request #11710: URL: https://github.com/apache/beam/pull/11710#discussion_r425345741 ## File path: runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WindmillStateCacheTest.java ## @@ -130,7

[GitHub] [beam] lukecwik merged pull request #11607: [BEAM-9430] Fixes the bounds of initial watermark set to estimators instead of raising an error

2020-05-14 Thread GitBox
lukecwik merged pull request #11607: URL: https://github.com/apache/beam/pull/11607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] steveniemitz commented on pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
steveniemitz commented on pull request #11710: URL: https://github.com/apache/beam/pull/11710#issuecomment-628828183 > These shouldn't need to be battles but more like: > > ``` > you: dev@ hey we got this patch we use locally it is X > dev@: sounds great, submit a PR or we

[GitHub] [beam] jaketf edited a comment on pull request #11339: [BEAM-9468] Fhir io

2020-05-14 Thread GitBox
jaketf edited a comment on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-628833485 > I'm unsure if the failures are due to an issue with this PR. Feel free to inspect: > https://scans.gradle.com/s/c4wwwmeidugrc/failure#top=0 There's not much

[GitHub] [beam] ibzib opened a new pull request #11711: [BEAM-9993] Add option defaults for Flink Python tests.

2020-05-14 Thread GitBox
ibzib opened a new pull request #11711: URL: https://github.com/apache/beam/pull/11711 With this change, it is now possible to run Flink Python unit tests without any setup or options. R: @robertwb Thank you for your contribution! Follow this

[GitHub] [beam] omarismail94 commented on pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
omarismail94 commented on pull request #11710: URL: https://github.com/apache/beam/pull/11710#issuecomment-628886984 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] iemejia commented on pull request #11613: [BEAM-9833] Fix .asf.yaml issues, sort labels and disable rebase button

2020-05-14 Thread GitBox
iemejia commented on pull request #11613: URL: https://github.com/apache/beam/pull/11613#issuecomment-628891422 Done the changes suggested by @robertwb let only rebase disabled. Can someone PTAL. Thanks This is an automated

[GitHub] [beam] pabloem merged pull request #11700: [BEAM-9967] Adding support for BQ labels on Query/Export jobs. (Roll …

2020-05-14 Thread GitBox
pabloem merged pull request #11700: URL: https://github.com/apache/beam/pull/11700 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] amaliujia commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-14 Thread GitBox
amaliujia commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-628883607 Thank you! The Jira looks good to me! Will merge this PR tomorrow if there is no other comments. This

[GitHub] [beam] pabloem commented on pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
pabloem commented on pull request #11710: URL: https://github.com/apache/beam/pull/11710#issuecomment-628890978 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] omarismail94 opened a new pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
omarismail94 opened a new pull request #11710: URL: https://github.com/apache/beam/pull/11710 R:@ pabloem Setting --workerCacheMB seems to affect batch pipelines only. For Streaming, the cache seems to be hardcoded to 100Mb [1]. If possible, I would like to make it allowable to

[GitHub] [beam] pabloem commented on pull request #11210: [BEAM-8949] SpannerIO integration tests

2020-05-14 Thread GitBox
pabloem commented on pull request #11210: URL: https://github.com/apache/beam/pull/11210#issuecomment-628841388 retest this plesae This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11210: [BEAM-8949] SpannerIO integration tests

2020-05-14 Thread GitBox
pabloem commented on pull request #11210: URL: https://github.com/apache/beam/pull/11210#issuecomment-628841515 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] jaketf commented on pull request #11339: [BEAM-9468] Fhir io

2020-05-14 Thread GitBox
jaketf commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-628845239 [FhirIOReadIT](https://github.com/apache/beam/pull/11339/files#diff-7a1359c60a094e73275769adb69b35d3R57) borrows the

[GitHub] [beam] iemejia opened a new pull request #11712: [BEAM-6950] Upgrade spotbugs to version 4.0.3

2020-05-14 Thread GitBox
iemejia opened a new pull request #11712: URL: https://github.com/apache/beam/pull/11712 R: @pabloem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [beam] pabloem commented on pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
pabloem commented on pull request #11710: URL: https://github.com/apache/beam/pull/11710#issuecomment-628901207 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tvalentyn commented on pull request #11709: Throw an error when main output has the same tag as side outputs

2020-05-14 Thread GitBox
tvalentyn commented on pull request #11709: URL: https://github.com/apache/beam/pull/11709#issuecomment-628900722 PythonDocker PreCommit error is not related This is an automated message from the Apache Git Service. To

[GitHub] [beam] mxm commented on pull request #11693: [BEAM-9966] Use dataproc staging bucket for checkpoints directory

2020-05-14 Thread GitBox
mxm commented on pull request #11693: URL: https://github.com/apache/beam/pull/11693#issuecomment-628542657 Run Python Load Tests ParDo Flink Streaming This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] mxm commented on pull request #11693: [BEAM-9966] Use dataproc staging bucket for checkpoints directory

2020-05-14 Thread GitBox
mxm commented on pull request #11693: URL: https://github.com/apache/beam/pull/11693#issuecomment-628624282 Run Python Load Tests ParDo Flink Streaming This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] lukecwik commented on pull request #11703: [BEAM-9001, BEAM-6327] Ensure that all transforms (except for require…

2020-05-14 Thread GitBox
lukecwik commented on pull request #11703: URL: https://github.com/apache/beam/pull/11703#issuecomment-628625967 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik removed a comment on pull request #11703: [BEAM-9001, BEAM-6327] Ensure that all transforms (except for require…

2020-05-14 Thread GitBox
lukecwik removed a comment on pull request #11703: URL: https://github.com/apache/beam/pull/11703#issuecomment-628334315 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] kamilwu opened a new pull request #11707: [BEAM-9810] Add a Tox (precommit) suite for Python 3.8

2020-05-14 Thread GitBox
kamilwu opened a new pull request #11707: URL: https://github.com/apache/beam/pull/11707 List of changes: * added `py38`, `py38-cython` and `py38-cloud` tox suites (all suites pass) * made `preCommitPy38` a part of pythonPreCommit. I think it's acceptable to extend pythonPreCommit

[GitHub] [beam] pawelpasterz commented on pull request #11692: [BEAM-2530] Implement Zeta SQL precommit compile tests and run on java 11

2020-05-14 Thread GitBox
pawelpasterz commented on pull request #11692: URL: https://github.com/apache/beam/pull/11692#issuecomment-628510495 R: @kamilwu This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] mxm commented on pull request #11693: [BEAM-9966] Use dataproc staging bucket for checkpoints directory

2020-05-14 Thread GitBox
mxm commented on pull request #11693: URL: https://github.com/apache/beam/pull/11693#issuecomment-628527810 Run Python Load Tests ParDo Flink Streaming This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] mxm removed a comment on pull request #11693: [BEAM-9966] Use dataproc staging bucket for checkpoints directory

2020-05-14 Thread GitBox
mxm removed a comment on pull request #11693: URL: https://github.com/apache/beam/pull/11693#issuecomment-628102762 Run Python Load Tests ParDo Flink Streaming This is an automated message from the Apache Git Service. To

[GitHub] [beam] kamilwu commented on pull request #11691: [BEAM-2530] Sql precommit compile and run on java 11

2020-05-14 Thread GitBox
kamilwu commented on pull request #11691: URL: https://github.com/apache/beam/pull/11691#issuecomment-628641706 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] Hannah-Jiang commented on pull request #11549: [BEAM-9136] Update doc about docker image license pulling

2020-05-14 Thread GitBox
Hannah-Jiang commented on pull request #11549: URL: https://github.com/apache/beam/pull/11549#issuecomment-629024197 > @Hannah-Jiang - you can continue with this change now. However you will need to rebase. Thanks for letting me know. I created a new PR

[GitHub] [beam] Hannah-Jiang closed pull request #11549: [BEAM-9136] Update doc about docker image license pulling

2020-05-14 Thread GitBox
Hannah-Jiang closed pull request #11549: URL: https://github.com/apache/beam/pull/11549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] rezarokni commented on pull request #11437: [BEAM-9770] Add BigQueryIO deadletter pattern

2020-05-14 Thread GitBox
rezarokni commented on pull request #11437: URL: https://github.com/apache/beam/pull/11437#issuecomment-629039064 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] Hannah-Jiang opened a new pull request #11717: [BEAM-9136] Update doc about docker image license pulling

2020-05-14 Thread GitBox
Hannah-Jiang opened a new pull request #11717: URL: https://github.com/apache/beam/pull/11717 @Kyle Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] Hannah-Jiang commented on pull request #11584: [BEAM-9136]support isRelease tag for docker build command & update release guide

2020-05-14 Thread GitBox
Hannah-Jiang commented on pull request #11584: URL: https://github.com/apache/beam/pull/11584#issuecomment-629030902 It is rebased. Please take a look when you have time. This is an automated message from the Apache Git

[GitHub] [beam] Hannah-Jiang commented on pull request #11717: [BEAM-9136] Update doc about docker image license pulling

2020-05-14 Thread GitBox
Hannah-Jiang commented on pull request #11717: URL: https://github.com/apache/beam/pull/11717#issuecomment-629031663 Please merge it if it looks good. The PR was reviewed at https://github.com/apache/beam/pull/11549. This

[GitHub] [beam] mxm commented on pull request #11693: [BEAM-9966] Use dataproc staging bucket for checkpoints directory

2020-05-14 Thread GitBox
mxm commented on pull request #11693: URL: https://github.com/apache/beam/pull/11693#issuecomment-628544071 Run Python Load Tests ParDo Flink Streaming This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] mxm removed a comment on pull request #11693: [BEAM-9966] Use dataproc staging bucket for checkpoints directory

2020-05-14 Thread GitBox
mxm removed a comment on pull request #11693: URL: https://github.com/apache/beam/pull/11693#issuecomment-628544071 Run Python Load Tests ParDo Flink Streaming This is an automated message from the Apache Git Service. To

[GitHub] [beam] bsikander commented on pull request #9583: [BEAM-8240] Ensure that the pipeline proto contains the worker_harness_container_image override

2020-05-14 Thread GitBox
bsikander commented on pull request #9583: URL: https://github.com/apache/beam/pull/9583#issuecomment-628556648 Is this flag supposed to be overriden by users? Can i set a custom docker image that will run on dataflow workers (using `workerHarnessContainerImage`)?

[GitHub] [beam] bsikander edited a comment on pull request #9583: [BEAM-8240] Ensure that the pipeline proto contains the worker_harness_container_image override

2020-05-14 Thread GitBox
bsikander edited a comment on pull request #9583: URL: https://github.com/apache/beam/pull/9583#issuecomment-628556648 @lukecwik Is this flag supposed to be overriden by users? Can i set a custom docker image that will run on dataflow workers (using `workerHarnessContainerImage`)?

[GitHub] [beam] kamilwu commented on pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

2020-05-14 Thread GitBox
kamilwu commented on pull request #11554: URL: https://github.com/apache/beam/pull/11554#issuecomment-628484742 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] robinyqiu commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-14 Thread GitBox
robinyqiu commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-628914752 Rebased against master. Please run precommit tests again. This is an automated message from the Apache Git

[GitHub] [beam] ibzib merged pull request #11711: [BEAM-9993] Add option defaults for Flink Python tests.

2020-05-14 Thread GitBox
ibzib merged pull request #11711: URL: https://github.com/apache/beam/pull/11711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] youngoli commented on a change in pull request #11665: [BEAM-9951] Creating a synthetic source for the Go SDK.

2020-05-14 Thread GitBox
youngoli commented on a change in pull request #11665: URL: https://github.com/apache/beam/pull/11665#discussion_r425481703 ## File path: sdks/go/pkg/beam/io/synthetic/source.go ## @@ -33,22 +33,30 @@ import ( // generated KV<[]byte, []byte> elements. // // This transform

[GitHub] [beam] apilloud commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-14 Thread GitBox
apilloud commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-628945312 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tvalentyn commented on pull request #11709: Throw an error when main output has the same tag as side outputs

2020-05-14 Thread GitBox
tvalentyn commented on pull request #11709: URL: https://github.com/apache/beam/pull/11709#issuecomment-628945681 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] robertwb commented on pull request #11708: [BEAM-9577] Artifact v2 support for uber jars.

2020-05-14 Thread GitBox
robertwb commented on pull request #11708: URL: https://github.com/apache/beam/pull/11708#issuecomment-628956526 Still trying to figure out why the test fails on jenkins but passes locally, but other than that it should be ready to be looked at again.

[GitHub] [beam] yifanzou merged pull request #11713: Run Inventory jobs every 12 hours.

2020-05-14 Thread GitBox
yifanzou merged pull request #11713: URL: https://github.com/apache/beam/pull/11713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #11710: [BEAM-9964] Setting --workerCacheMB for Streaming Pipeline

2020-05-14 Thread GitBox
pabloem commented on pull request #11710: URL: https://github.com/apache/beam/pull/11710#issuecomment-628958485 Seems like java precommits are broken on master - but this change LGTM. I'll wait for precommits to be fixed if possible. Thanks @omarismail94 !

[GitHub] [beam] lostluck commented on pull request #11665: [BEAM-9951] Creating a synthetic source for the Go SDK.

2020-05-14 Thread GitBox
lostluck commented on pull request #11665: URL: https://github.com/apache/beam/pull/11665#issuecomment-628958995 I think this LGTM. Overall, it's probably fine either way. In terms of effort, the risk is often "the pipelines emit nothing/very little" and terminate very quickly, which

[GitHub] [beam] ibzib commented on pull request #11403: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-05-14 Thread GitBox
ibzib commented on pull request #11403: URL: https://github.com/apache/beam/pull/11403#issuecomment-628913388 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] ibzib commented on pull request #11403: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-05-14 Thread GitBox
ibzib commented on pull request #11403: URL: https://github.com/apache/beam/pull/11403#issuecomment-628913258 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pabloem merged pull request #11613: [BEAM-9833] Fix .asf.yaml issues, sort labels and disable rebase button

2020-05-14 Thread GitBox
pabloem merged pull request #11613: URL: https://github.com/apache/beam/pull/11613 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] apilloud commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-14 Thread GitBox
apilloud commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-628921575 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

  1   2   >