[GitHub] [beam] iindyk commented on a change in pull request #12420: Extending ApproximateQuantiles functionality to deal with non-uniform weights.

2020-08-11 Thread GitBox
iindyk commented on a change in pull request #12420: URL: https://github.com/apache/beam/pull/12420#discussion_r468937788 ## File path: sdks/python/apache_beam/transforms/stats.py ## @@ -398,8 +424,8 @@ class ApproximateQuantilesCombineFn(CombineFn):

[GitHub] [beam] iindyk commented on a change in pull request #12420: Extending ApproximateQuantiles functionality to deal with non-uniform weights.

2020-08-11 Thread GitBox
iindyk commented on a change in pull request #12420: URL: https://github.com/apache/beam/pull/12420#discussion_r468937924 ## File path: sdks/python/apache_beam/transforms/stats.py ## @@ -576,17 +633,34 @@ def _interpolate(self, i_buffers, count, step, offset):

[GitHub] [beam] iindyk commented on a change in pull request #12420: Extending ApproximateQuantiles functionality to deal with non-uniform weights.

2020-08-11 Thread GitBox
iindyk commented on a change in pull request #12420: URL: https://github.com/apache/beam/pull/12420#discussion_r468937732 ## File path: sdks/python/apache_beam/transforms/stats.py ## @@ -263,30 +265,38 @@ class Globally(PTransform): Args: num_quantiles: number of

[GitHub] [beam] udim commented on a change in pull request #12257: [BEAM-2762] Generate Python coverage reports during pre-commit

2020-08-11 Thread GitBox
udim commented on a change in pull request #12257: URL: https://github.com/apache/beam/pull/12257#discussion_r468946744 ## File path: sdks/python/tox.ini ## @@ -172,6 +172,17 @@ extras = test,gcp,interactive,aws commands = {toxinidir}/scripts/run_pytest.sh {envname}

[GitHub] [beam] KevinGG commented on a change in pull request #12444: Added a whitespace lint as part of python lint precommit

2020-08-11 Thread GitBox
KevinGG commented on a change in pull request #12444: URL: https://github.com/apache/beam/pull/12444#discussion_r468885295 ## File path: .test-infra/jenkins/job_PreCommit_Whitespace.groovy ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [beam] tvalentyn commented on a change in pull request #12513: [BEAM-BEAM-10667] Make gh-actions wheels bucket name stored as a secret

2020-08-11 Thread GitBox
tvalentyn commented on a change in pull request #12513: URL: https://github.com/apache/beam/pull/12513#discussion_r468884894 ## File path: CI.md ## @@ -89,7 +89,9 @@ Those jobs often have matrix run strategy which runs several different variation Some of the jobs require

[GitHub] [beam] TobKed commented on a change in pull request #12513: [BEAM-BEAM-10667] Make gh-actions wheels bucket name stored as a secret

2020-08-11 Thread GitBox
TobKed commented on a change in pull request #12513: URL: https://github.com/apache/beam/pull/12513#discussion_r468897533 ## File path: CI.md ## @@ -89,7 +89,9 @@ Those jobs often have matrix run strategy which runs several different variation Some of the jobs require

[GitHub] [beam] tvalentyn commented on a change in pull request #12263: [BEAM-10492] Add missing sideinput handling to DLP transforms

2020-08-11 Thread GitBox
tvalentyn commented on a change in pull request #12263: URL: https://github.com/apache/beam/pull/12263#discussion_r468935806 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java ## @@ -177,19 +177,24 @@ public

[GitHub] [beam] udim commented on pull request #12257: [BEAM-2762] Generate Python coverage reports during pre-commit

2020-08-11 Thread GitBox
udim commented on pull request #12257: URL: https://github.com/apache/beam/pull/12257#issuecomment-672414494 We can give this a try by adding this to `CommonJobProperties.groovy`: ``` credentialsBinding { // other values string("CODECOV_TOKEN",

[GitHub] [beam] udim commented on a change in pull request #12257: [BEAM-2762] Generate Python coverage reports during pre-commit

2020-08-11 Thread GitBox
udim commented on a change in pull request #12257: URL: https://github.com/apache/beam/pull/12257#discussion_r468943368 ## File path: sdks/python/tox.ini ## @@ -172,6 +172,17 @@ extras = test,gcp,interactive,aws commands = {toxinidir}/scripts/run_pytest.sh {envname}

[GitHub] [beam] pabloem commented on pull request #12489: [BEAM-6064] Add an option to avoid insert_ids on BQ in exchange for faster insertions

2020-08-11 Thread GitBox
pabloem commented on pull request #12489: URL: https://github.com/apache/beam/pull/12489#issuecomment-672302553 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] TobKed commented on a change in pull request #12452: [BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac platforms

2020-08-11 Thread GitBox
TobKed commented on a change in pull request #12452: URL: https://github.com/apache/beam/pull/12452#discussion_r468884891 ## File path: sdks/python/apache_beam/testing/util.py ## @@ -334,3 +335,19 @@ def open_shards(glob_pattern, mode='rt', encoding='utf-8'):

[GitHub] [beam] lukecwik commented on pull request #12519: [BEAM-10670] Make Read execute as a splittable DoFn by default for the Java DirectRunner.

2020-08-11 Thread GitBox
lukecwik commented on pull request #12519: URL: https://github.com/apache/beam/pull/12519#issuecomment-672327320 Thanks for taking a look, I'm going to break this up into a few PRs to separate it from what was needed for the DirectRunner.

[GitHub] [beam] tvalentyn merged pull request #12525: [BEAM-10644] Mark Beam 2.24.0 as the last release with Py2 and Py35 support.

2020-08-11 Thread GitBox
tvalentyn merged pull request #12525: URL: https://github.com/apache/beam/pull/12525 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] pabloem commented on pull request #12489: [BEAM-6064] Add an option to avoid insert_ids on BQ in exchange for faster insertions

2020-08-11 Thread GitBox
pabloem commented on pull request #12489: URL: https://github.com/apache/beam/pull/12489#issuecomment-672395931 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on pull request #12481: [BEAM-10571] Use schemas in ExternalConfigurationPayload

2020-08-11 Thread GitBox
TheNeuralBit commented on pull request #12481: URL: https://github.com/apache/beam/pull/12481#issuecomment-672308417 PreCommit seems to have passed, just no update here: https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/2603/ I've also validated this with some internal test

[GitHub] [beam] TheNeuralBit merged pull request #12481: [BEAM-10571] Use schemas in ExternalConfigurationPayload

2020-08-11 Thread GitBox
TheNeuralBit merged pull request #12481: URL: https://github.com/apache/beam/pull/12481 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] ibzib commented on pull request #12538: [BEAM-10681] Set metrics supported in Spark portable runner.

2020-08-11 Thread GitBox
ibzib commented on pull request #12538: URL: https://github.com/apache/beam/pull/12538#issuecomment-672390647 Run Java Spark PortableValidatesRunner Batch This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] ibzib opened a new pull request #12538: [BEAM-10681] Set metrics supported in Spark portable runner.

2020-08-11 Thread GitBox
ibzib opened a new pull request #12538: URL: https://github.com/apache/beam/pull/12538 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] y1chi opened a new pull request #12537: [BEAM-10200] Add optional experiment to enable heap dump through the …

2020-08-11 Thread GitBox
y1chi opened a new pull request #12537: URL: https://github.com/apache/beam/pull/12537 …status api for portable runners. **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help

[GitHub] [beam] y1chi commented on pull request #12537: [BEAM-10200] Add optional experiment to enable heap dump through the …

2020-08-11 Thread GitBox
y1chi commented on pull request #12537: URL: https://github.com/apache/beam/pull/12537#issuecomment-672338978 R: @angoenka This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] y1chi commented on a change in pull request #12537: [BEAM-10200] Add optional experiment to enable heap dump through the …

2020-08-11 Thread GitBox
y1chi commented on a change in pull request #12537: URL: https://github.com/apache/beam/pull/12537#discussion_r468939630 ## File path: sdks/python/apache_beam/runners/worker/worker_status.py ## @@ -152,7 +170,11 @@ def generate_status_response(self): all_status_sections =

[GitHub] [beam] angoenka commented on a change in pull request #12537: [BEAM-10200] Add optional experiment to enable heap dump through the …

2020-08-11 Thread GitBox
angoenka commented on a change in pull request #12537: URL: https://github.com/apache/beam/pull/12537#discussion_r468938985 ## File path: sdks/python/apache_beam/runners/worker/worker_status.py ## @@ -152,7 +170,11 @@ def generate_status_response(self):

[GitHub] [beam] piotr-szuberski commented on pull request #12526: [BEAM-10663] Disable python kafka integration tests

2020-08-11 Thread GitBox
piotr-szuberski commented on pull request #12526: URL: https://github.com/apache/beam/pull/12526#issuecomment-671776638 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] piotr-szuberski commented on pull request #12518: [BEAM-10663] Workaround of AutoValueSchema doesn't work with SchemaFieldName

2020-08-11 Thread GitBox
piotr-szuberski commented on pull request #12518: URL: https://github.com/apache/beam/pull/12518#issuecomment-671776295 I've created a PR that disables kafka test https://github.com/apache/beam/pull/12526 This is an

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

2020-08-11 Thread GitBox
piotr-szuberski commented on a change in pull request #12297: URL: https://github.com/apache/beam/pull/12297#discussion_r468391276 ## File path: sdks/python/apache_beam/io/kinesis.py ## @@ -0,0 +1,317 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [beam] kkucharc commented on pull request #12527: [BEAM-10672] Added Python Combine load tests for streaming on Dataflow

2020-08-11 Thread GitBox
kkucharc commented on pull request #12527: URL: https://github.com/apache/beam/pull/12527#issuecomment-671802138 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] piotr-szuberski opened a new pull request #12526: [BEAM-10663] Disable python kafka integration tests

2020-08-11 Thread GitBox
piotr-szuberski opened a new pull request #12526: URL: https://github.com/apache/beam/pull/12526 Enable again when BEAM-10633 is merged R: @TheNeuralBit @boyuanzz **Please** add a meaningful description for your change here Thank you

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

2020-08-11 Thread GitBox
piotr-szuberski commented on a change in pull request #12297: URL: https://github.com/apache/beam/pull/12297#discussion_r468394074 ## File path: sdks/python/apache_beam/io/external/xlang_kinesisio_it_test.py ## @@ -0,0 +1,304 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [beam] kkucharc opened a new pull request #12527: [BEAM-10672] Added Python Combine load tests for streaming on Dataflow

2020-08-11 Thread GitBox
kkucharc opened a new pull request #12527: URL: https://github.com/apache/beam/pull/12527 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] kkucharc commented on pull request #12527: [BEAM-10672] Added Python Combine load tests for streaming on Dataflow

2020-08-11 Thread GitBox
kkucharc commented on pull request #12527: URL: https://github.com/apache/beam/pull/12527#issuecomment-671808653 Run Python Load Tests Combine Dataflow Streaming This is an automated message from the Apache Git Service. To

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

2020-08-11 Thread GitBox
piotr-szuberski commented on a change in pull request #12297: URL: https://github.com/apache/beam/pull/12297#discussion_r468391526 ## File path: sdks/python/apache_beam/io/kinesis.py ## @@ -0,0 +1,317 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

2020-08-11 Thread GitBox
piotr-szuberski commented on a change in pull request #12297: URL: https://github.com/apache/beam/pull/12297#discussion_r468391828 ## File path: sdks/python/apache_beam/io/kinesis.py ## @@ -0,0 +1,317 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [beam] kkucharc commented on pull request #12527: [BEAM-10672] Added Python Combine load tests for streaming on Dataflow

2020-08-11 Thread GitBox
kkucharc commented on pull request #12527: URL: https://github.com/apache/beam/pull/12527#issuecomment-671797660 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] kkucharc commented on a change in pull request #12435: [BEAM-10616] Added Python Pardo load tests for streaming on Dataflow

2020-08-11 Thread GitBox
kkucharc commented on a change in pull request #12435: URL: https://github.com/apache/beam/pull/12435#discussion_r468464708 ## File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py ## @@ -125,7 +125,9 @@ def process(self, element, state=state_param):

[GitHub] [beam] aromanenko-dev commented on pull request #12422: [BEAM-601] Run KinesisIOIT with localstack

2020-08-11 Thread GitBox
aromanenko-dev commented on pull request #12422: URL: https://github.com/apache/beam/pull/12422#issuecomment-671841184 @TheNeuralBit Ok, thanks. I think it LGTM This is an automated message from the Apache Git Service. To

[GitHub] [beam] kkucharc commented on pull request #12527: [BEAM-10672] Added Python Combine load tests for streaming on Dataflow

2020-08-11 Thread GitBox
kkucharc commented on pull request #12527: URL: https://github.com/apache/beam/pull/12527#issuecomment-671844911 Run Python Load Tests Combine Dataflow Batch This is an automated message from the Apache Git Service. To

[GitHub] [beam] abhiy13 commented on a change in pull request #12490: [BEAM-10124] Add ContextualTextIO

2020-08-11 Thread GitBox
abhiy13 commented on a change in pull request #12490: URL: https://github.com/apache/beam/pull/12490#discussion_r468465389 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/ContextualTextIO/ContextualTextIO.java ## @@ -0,0 +1,554 @@ +/* + *

[GitHub] [beam] aromanenko-dev merged pull request #12422: [BEAM-601] Run KinesisIOIT with localstack

2020-08-11 Thread GitBox
aromanenko-dev merged pull request #12422: URL: https://github.com/apache/beam/pull/12422 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] damgad opened a new pull request #12529: Moving /tmp directory cleanup of CI workers to Inventory Jenkins job

2020-08-11 Thread GitBox
damgad opened a new pull request #12529: URL: https://github.com/apache/beam/pull/12529 This PR deletes the `beam_Clean_tmp_directory` job and integrates its functionality into `beam_Inventory_apache-beam-jenkins-XX` jobs. Thank you for your

[GitHub] [beam] damgad commented on pull request #12529: Moving /tmp directory cleanup of CI workers to Inventory Jenkins job

2020-08-11 Thread GitBox
damgad commented on pull request #12529: URL: https://github.com/apache/beam/pull/12529#issuecomment-672001509 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] kamilwu commented on a change in pull request #12527: [BEAM-10672] Added Python Combine load tests for streaming on Dataflow

2020-08-11 Thread GitBox
kamilwu commented on a change in pull request #12527: URL: https://github.com/apache/beam/pull/12527#discussion_r468671360 ## File path: .test-infra/jenkins/job_LoadTests_Combine_Python.groovy ## @@ -93,15 +93,23 @@ def loadTestConfigurations = { datasetName ->

[GitHub] [beam] kamilwu commented on a change in pull request #12527: [BEAM-10672] Added Python Combine load tests for streaming on Dataflow

2020-08-11 Thread GitBox
kamilwu commented on a change in pull request #12527: URL: https://github.com/apache/beam/pull/12527#discussion_r468672022 ## File path: .test-infra/jenkins/job_LoadTests_Combine_Python.groovy ## @@ -113,13 +121,31 @@ PhraseTriggeringPostCommitBuilder.postCommitJob( this

[GitHub] [beam] TheNeuralBit opened a new pull request #12530: [BEAM-7996] Add Python SqlTransform test that includes a MAP input and output

2020-08-11 Thread GitBox
TheNeuralBit opened a new pull request #12530: URL: https://github.com/apache/beam/pull/12530 Post-Commit Tests Status (on master branch) Lang | SDK | Dataflow | Flink | Samza | Spark

[GitHub] [beam] davidak09 commented on a change in pull request #12050: [BEAM-10292] DefaultFilenamePolicy.ParamsCoder uses ResourceIdCoder

2020-08-11 Thread GitBox
davidak09 commented on a change in pull request #12050: URL: https://github.com/apache/beam/pull/12050#discussion_r468538993 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/DefaultFilenamePolicy.java ## @@ -182,19 +184,26 @@ public void encode(Params value,

[GitHub] [beam] damgad opened a new pull request #12528: Extending archiveJunit Jenkins post-commit task with stability history

2020-08-11 Thread GitBox
damgad opened a new pull request #12528: URL: https://github.com/apache/beam/pull/12528 There is a new plugin installed in our Jenkins instance - Test stability history. To use it we have to enable it while archiving Junit test results. That PR enables it everywhere in the DSL job

[GitHub] [beam] damgad commented on pull request #12528: Extending archiveJunit Jenkins post-commit task with stability history

2020-08-11 Thread GitBox
damgad commented on pull request #12528: URL: https://github.com/apache/beam/pull/12528#issuecomment-671934387 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] damgad removed a comment on pull request #12528: Extending archiveJunit Jenkins post-commit task with stability history

2020-08-11 Thread GitBox
damgad removed a comment on pull request #12528: URL: https://github.com/apache/beam/pull/12528#issuecomment-671933592 run seed job This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] damgad commented on pull request #12528: Extending archiveJunit Jenkins post-commit task with stability history

2020-08-11 Thread GitBox
damgad commented on pull request #12528: URL: https://github.com/apache/beam/pull/12528#issuecomment-671944905 R: @aaltay This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] damgad commented on pull request #12528: Extending archiveJunit Jenkins post-commit task with stability history

2020-08-11 Thread GitBox
damgad commented on pull request #12528: URL: https://github.com/apache/beam/pull/12528#issuecomment-671933592 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] damgad removed a comment on pull request #12528: Extending archiveJunit Jenkins post-commit task with stability history

2020-08-11 Thread GitBox
damgad removed a comment on pull request #12528: URL: https://github.com/apache/beam/pull/12528#issuecomment-671933076 run seed job This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] damgad commented on pull request #12528: Extending archiveJunit Jenkins post-commit task with stability history

2020-08-11 Thread GitBox
damgad commented on pull request #12528: URL: https://github.com/apache/beam/pull/12528#issuecomment-671933076 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] mxm opened a new pull request #12531: [BEAM-10676] Use the fire timestamp as the output timestamp for timers

2020-08-11 Thread GitBox
mxm opened a new pull request #12531: URL: https://github.com/apache/beam/pull/12531 By default, the Python SDK adds a timer output timestamp equal to the current timestamp of an element. This is problematic because: 1. We hold back the output watermark on the current element's

[GitHub] [beam] Mark-Zeng opened a new pull request #12532: [Beam-9543] support MATCH_RECOGNIZE with NFA

2020-08-11 Thread GitBox
Mark-Zeng opened a new pull request #12532: URL: https://github.com/apache/beam/pull/12532 - Added a basic NFA class. - Removed redundant code. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] Mark-Zeng commented on pull request #12532: [Beam-9543] support MATCH_RECOGNIZE with NFA

2020-08-11 Thread GitBox
Mark-Zeng commented on pull request #12532: URL: https://github.com/apache/beam/pull/12532#issuecomment-672046274 R: @amaliujia cc: @jhnmora000 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on pull request #12530: [BEAM-7996] Add Python SqlTransform test that includes a MAP input and output

2020-08-11 Thread GitBox
TheNeuralBit commented on pull request #12530: URL: https://github.com/apache/beam/pull/12530#issuecomment-672054462 Run XVR_Direct PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on pull request #12520: [BEAM-10633] Fix @SchemaFieldName in AutoValueSchema

2020-08-11 Thread GitBox
TheNeuralBit commented on pull request #12520: URL: https://github.com/apache/beam/pull/12520#issuecomment-672062422 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on pull request #12526: [BEAM-10663] Disable python kafka integration tests

2020-08-11 Thread GitBox
TheNeuralBit commented on pull request #12526: URL: https://github.com/apache/beam/pull/12526#issuecomment-672066405 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] sclukas77 commented on a change in pull request #12498: [BEAM-10654] Implemented ExternalSchemaIOTransformRegistrar for jdbc

2020-08-11 Thread GitBox
sclukas77 commented on a change in pull request #12498: URL: https://github.com/apache/beam/pull/12498#discussion_r468718529 ## File path: sdks/java/extensions/schemaio-expansion-service/src/main/java/org/apache/beam/sdk/extensions/schemaio/expansion/package-info.java ## @@

[GitHub] [beam] sclukas77 commented on a change in pull request #12498: [BEAM-10654] Implemented ExternalSchemaIOTransformRegistrar for jdbc

2020-08-11 Thread GitBox
sclukas77 commented on a change in pull request #12498: URL: https://github.com/apache/beam/pull/12498#discussion_r468718319 ## File path: sdks/python/apache_beam/io/jdbc.py ## @@ -168,41 +182,33 @@ def __init__( :param expansion_service: The address (host:port) of the

[GitHub] [beam] sclukas77 commented on a change in pull request #12498: [BEAM-10654] Implemented ExternalSchemaIOTransformRegistrar for jdbc

2020-08-11 Thread GitBox
sclukas77 commented on a change in pull request #12498: URL: https://github.com/apache/beam/pull/12498#discussion_r468719581 ## File path: settings.gradle ## @@ -181,3 +181,4 @@ include "beam-test-tools" project(":beam-test-tools").dir = file(".test-infra/tools") include

[GitHub] [beam] sclukas77 commented on a change in pull request #12498: [BEAM-10654] Implemented ExternalSchemaIOTransformRegistrar for jdbc

2020-08-11 Thread GitBox
sclukas77 commented on a change in pull request #12498: URL: https://github.com/apache/beam/pull/12498#discussion_r468718975 ## File path:

[GitHub] [beam] sclukas77 commented on a change in pull request #12498: [BEAM-10654] Implemented ExternalSchemaIOTransformRegistrar for jdbc

2020-08-11 Thread GitBox
sclukas77 commented on a change in pull request #12498: URL: https://github.com/apache/beam/pull/12498#discussion_r468719290 ## File path:

<    1   2