kkucharc commented on a change in pull request #12435:
URL: https://github.com/apache/beam/pull/12435#discussion_r468464708
##########
File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py
##########
@@ -125,7 +125,9 @@ def process(self, element, state=state_param):
state.add(1)
yield element
- if self.get_option_or_default('streaming', False):
+ if self.get_option_or_default(
+ 'streaming',
+ False) and self.pipeline.get_option('runner') == "PortableRunner":
Review comment:
The PortableRunner is supposed to use `StatefulLoadGenerator` to enable
streaming.
To be honest I assumed that if we are comparing core operations, we should
be using the same source method - SyntheticSources.
On the other hand maybe `StatefulLoadGenerator` should be part of
SyntheticSources. WDYT @tysonjh ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
