chamikaramj commented on pull request #11846:
URL: https://github.com/apache/beam/pull/11846#issuecomment-635752368
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11846:
URL: https://github.com/apache/beam/pull/11846#issuecomment-635752434
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
chamikaramj commented on pull request #11847:
URL: https://github.com/apache/beam/pull/11847#issuecomment-635752517
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11847:
URL: https://github.com/apache/beam/pull/11847#issuecomment-635752197
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11847:
URL: https://github.com/apache/beam/pull/11847#issuecomment-635752138
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
darshanj commented on pull request #11855:
URL: https://github.com/apache/beam/pull/11855#issuecomment-635734663
R: @kennknowles
This is an automated message from the Apache Git Service.
To respond to the message, please log
darshanj opened a new pull request #11855:
URL: https://github.com/apache/beam/pull/11855
Added api combineFn that can be used for inputs windowed with non global
windows
**Please** add a meaningful description for your change here
Thank you
boyuanzz commented on a change in pull request #11642:
URL: https://github.com/apache/beam/pull/11642#discussion_r432230809
##
File path: sdks/python/apache_beam/runners/direct/sdf_direct_runner.py
##
@@ -464,7 +464,7 @@ def initiate_checkpoint():
with
lukecwik commented on pull request #11821:
URL: https://github.com/apache/beam/pull/11821#issuecomment-635722845
Run Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message,
aaltay commented on pull request #11642:
URL: https://github.com/apache/beam/pull/11642#issuecomment-635705379
> > This is a single line change and passing all the tests. If the change
make sense can we merge it? (question to @boyuanzz )
>
> I don't think the change is correct. I
chamikaramj commented on pull request #11846:
URL: https://github.com/apache/beam/pull/11846#issuecomment-635702404
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11846:
URL: https://github.com/apache/beam/pull/11846#issuecomment-635702360
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11846:
URL: https://github.com/apache/beam/pull/11846#issuecomment-635702305
LGTM. Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please
steveniemitz commented on pull request #11849:
URL: https://github.com/apache/beam/pull/11849#issuecomment-635697264
=/ looks like the dataflow precommit succeeded but the API call to update it
here failed.
This is an
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-635696787
@epicfaace Thanks for your initiative to help with Python 3.8.
Please see the discussion on introducing high-priority/low priority
versions:
steveniemitz commented on pull request #11849:
URL: https://github.com/apache/beam/pull/11849#issuecomment-635696194
> gahh so sorry that I missed this. I guess you did have to end up
contributing this : )
heh no problem, teamwork! :highfive:
chamikaramj commented on pull request #11814:
URL: https://github.com/apache/beam/pull/11814#issuecomment-635695779
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11847:
URL: https://github.com/apache/beam/pull/11847#issuecomment-635695687
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
robertwb commented on a change in pull request #11835:
URL: https://github.com/apache/beam/pull/11835#discussion_r432198245
##
File path: sdks/python/apache_beam/transforms/trigger_test.py
##
@@ -518,6 +519,28 @@ def format_result(k_v):
'B-3': {10, 15, 16},
boyuanzz commented on pull request #11642:
URL: https://github.com/apache/beam/pull/11642#issuecomment-635680691
> This is a single line change and passing all the tests. If the change make
sense can we merge it? (question to @boyuanzz )
I don't think the change is correct. I can
chamikaramj commented on pull request #11814:
URL: https://github.com/apache/beam/pull/11814#issuecomment-635677737
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chamikaramj commented on pull request #11847:
URL: https://github.com/apache/beam/pull/11847#issuecomment-635676513
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11847:
URL: https://github.com/apache/beam/pull/11847#issuecomment-635676452
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
aaltay commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-635675870
/cc @tvalentyn
This is an automated message from the Apache Git Service.
To respond to the message, please log
aaltay commented on pull request #11642:
URL: https://github.com/apache/beam/pull/11642#issuecomment-635675425
This is a single line change and passing all the tests. If the change make
sense can we merge it? (question to @boyuanzz )
aaltay commented on pull request #11758:
URL: https://github.com/apache/beam/pull/11758#issuecomment-635675525
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on pull request #11181:
URL: https://github.com/apache/beam/pull/11181#issuecomment-635674912
@piotr-szuberski - what is the next step for this PR? Is it still active?
Should we close it?
This is an
chamikaramj commented on pull request #11814:
URL: https://github.com/apache/beam/pull/11814#issuecomment-635674009
I don't think so. We changed from using "key=value" strings to StagedFile
objects in https://github.com/apache/beam/pull/11039/files.
aaltay commented on pull request #11706:
URL: https://github.com/apache/beam/pull/11706#issuecomment-635672892
R: @rosetn
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
TheNeuralBit commented on pull request #11814:
URL: https://github.com/apache/beam/pull/11814#issuecomment-635672193
@chamikaramj, @ihji is the `filesToStage` change a problem?
This is an automated message from the Apache
aaltay commented on pull request #11758:
URL: https://github.com/apache/beam/pull/11758#issuecomment-635672368
LGTM. I can merge it if tests pass.
This is an automated message from the Apache Git Service.
To respond to the
aaltay commented on pull request #11610:
URL: https://github.com/apache/beam/pull/11610#issuecomment-635672074
All tests passed. I do not see a LGTM, maybe I am missing. Is this ready to
be merged?
This is an automated
aaltay commented on pull request #11779:
URL: https://github.com/apache/beam/pull/11779#issuecomment-635671668
LGTM. I will merge after tests pass. Thank you @tedromer
This is an automated message from the Apache Git
aaltay commented on pull request #11779:
URL: https://github.com/apache/beam/pull/11779#issuecomment-635671566
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
chamikaramj commented on pull request #11847:
URL: https://github.com/apache/beam/pull/11847#issuecomment-635670461
LGTM. Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on pull request #11819:
URL: https://github.com/apache/beam/pull/11819#issuecomment-635669412
Should we close this pull request for now?
This is an automated message from the Apache Git Service.
To respond
aaltay commented on pull request #11682:
URL: https://github.com/apache/beam/pull/11682#issuecomment-635668922
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
lukecwik commented on pull request #11821:
URL: https://github.com/apache/beam/pull/11821#issuecomment-635664997
Run Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message,
rohdesamuel commented on pull request #11594:
URL: https://github.com/apache/beam/pull/11594#issuecomment-635664357
Looks like the PreCommit failed with "Exception: Dataflow only supports
Python versions 2 and 3.5+, got: (3, 8)". Is that a known failure?
pabloem commented on pull request #11849:
URL: https://github.com/apache/beam/pull/11849#issuecomment-635663865
gahh so sorry that I missed this. I guess you did have to end up
contributing this : )
This is an automated
robertwb commented on a change in pull request #11632:
URL: https://github.com/apache/beam/pull/11632#discussion_r432170796
##
File path: sdks/python/apache_beam/dataframe/transforms.py
##
@@ -16,13 +16,28 @@
from __future__ import absolute_import
+import typing
+from
chamikaramj opened a new pull request #11854:
URL: https://github.com/apache/beam/pull/11854
Without this cross-language KafkaIO users may have to do
pipeline.run(False)
instead of
pipeline.run()
when executing a pipeline using Dataflow.
@TheNeuralBit this should
chamikaramj commented on pull request #11854:
URL: https://github.com/apache/beam/pull/11854#issuecomment-635657611
R: @TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message,
robertwb merged pull request #11853:
URL: https://github.com/apache/beam/pull/11853
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chamikaramj commented on pull request #11844:
URL: https://github.com/apache/beam/pull/11844#issuecomment-635651784
Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
robertwb merged pull request #11844:
URL: https://github.com/apache/beam/pull/11844
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay commented on pull request #11851:
URL: https://github.com/apache/beam/pull/11851#issuecomment-635648807
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
iemejia commented on a change in pull request #11853:
URL: https://github.com/apache/beam/pull/11853#discussion_r432163908
##
File path: website/www/site/content/en/roadmap/connectors-multi-sdk.md
##
@@ -62,27 +62,29 @@ Work related to making cross-language transforms
damondouglas commented on pull request #11803:
URL: https://github.com/apache/beam/pull/11803#issuecomment-635644834
I updated [the stepik course](https://stepik.org/course/70387) and commited
the updated `*-remote.yaml` files to this PR. It is ready to merge into
master. Thank you,
lukecwik commented on pull request #11821:
URL: https://github.com/apache/beam/pull/11821#issuecomment-635644599
Run Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11594:
URL: https://github.com/apache/beam/pull/11594#issuecomment-635640799
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pabloem commented on pull request #11594:
URL: https://github.com/apache/beam/pull/11594#issuecomment-635640892
Run Python 2 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
rohdesamuel commented on pull request #11594:
URL: https://github.com/apache/beam/pull/11594#issuecomment-635640073
R: @pabloem
This is an automated message from the Apache Git Service.
To respond to the message, please log
udim merged pull request #11070:
URL: https://github.com/apache/beam/pull/11070
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lukecwik commented on pull request #11821:
URL: https://github.com/apache/beam/pull/11821#issuecomment-635630717
Run Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message,
ihji commented on a change in pull request #11847:
URL: https://github.com/apache/beam/pull/11847#discussion_r432142814
##
File path: sdks/python/apache_beam/io/external/xlang_kafkaio_it_test.py
##
@@ -0,0 +1,145 @@
+"""Integration test for Python cross-language pipelines for
ihji commented on a change in pull request #11847:
URL: https://github.com/apache/beam/pull/11847#discussion_r432142992
##
File path: sdks/python/apache_beam/io/external/xlang_kafkaio_it_test.py
##
@@ -0,0 +1,145 @@
+"""Integration test for Python cross-language pipelines for
ihji commented on a change in pull request #11847:
URL: https://github.com/apache/beam/pull/11847#discussion_r432142695
##
File path: sdks/python/apache_beam/io/external/xlang_kafkaio_it_test.py
##
@@ -0,0 +1,145 @@
+"""Integration test for Python cross-language pipelines for
jhnmora000 commented on pull request #11845:
URL: https://github.com/apache/beam/pull/11845#issuecomment-635624778
Thanks for your help @amaliujia . I will close this PR and continue
experimenting with BeamSQL/Calcite.
jhnmora000 closed pull request #11845:
URL: https://github.com/apache/beam/pull/11845
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
lukecwik commented on pull request #11821:
URL: https://github.com/apache/beam/pull/11821#issuecomment-635621052
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lukecwik commented on pull request #11821:
URL: https://github.com/apache/beam/pull/11821#issuecomment-635620991
Run Java Flink PortableValidatesRunner Streaming
This is an automated message from the Apache Git Service.
To
lukecwik commented on pull request #11821:
URL: https://github.com/apache/beam/pull/11821#issuecomment-635620885
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chamikaramj commented on pull request #11853:
URL: https://github.com/apache/beam/pull/11853#issuecomment-635620838
LGTM. Thanks for updating.
This is an automated message from the Apache Git Service.
To respond to the
youngoli merged pull request #11791:
URL: https://github.com/apache/beam/pull/11791
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
davidcavazos commented on pull request #11851:
URL: https://github.com/apache/beam/pull/11851#issuecomment-635618216
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11814:
URL: https://github.com/apache/beam/pull/11814#issuecomment-635615410
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
youngoli commented on pull request #11791:
URL: https://github.com/apache/beam/pull/11791#issuecomment-635615190
Run Go PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb opened a new pull request #11853:
URL: https://github.com/apache/beam/pull/11853
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
lukecwik commented on pull request #11821:
URL: https://github.com/apache/beam/pull/11821#issuecomment-635613803
Run Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message,
tvalentyn commented on a change in pull request #11086:
URL: https://github.com/apache/beam/pull/11086#discussion_r432112443
##
File path: sdks/python/apache_beam/io/gcp/big_query_query_to_table_it_test.py
##
@@ -254,11 +256,36 @@ def test_big_query_new_types(self):
tvalentyn commented on pull request #11661:
URL: https://github.com/apache/beam/pull/11661#issuecomment-635593321
@kamilwu - please merge once this looks good to you, I don't have other
input here.
This is an automated
tvalentyn commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r432107251
##
File path:
.test-infra/metrics/grafana/dashboards/perftests_metrics/Python_Performance_Tests.json
##
@@ -77,7 +77,7 @@
],
chamikaramj commented on pull request #11814:
URL: https://github.com/apache/beam/pull/11814#issuecomment-635591331
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tvalentyn commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r432106093
##
File path: sdks/python/apache_beam/examples/wordcount_it_test.py
##
@@ -84,11 +87,45 @@ def _run_wordcount_it(self, run_wordcount, **opts):
#
lostluck merged pull request #11207:
URL: https://github.com/apache/beam/pull/11207
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rionmonster commented on a change in pull request #11761:
URL: https://github.com/apache/beam/pull/11761#discussion_r432104332
##
File path: learning/katas/kotlin/Windowing/Fixed Time Window/Fixed Time
Window/test/org/apache/beam/learning/katas/windowing/fixedwindow/WindowedEvent.kt
rionmonster commented on a change in pull request #11761:
URL: https://github.com/apache/beam/pull/11761#discussion_r432103074
##
File path: learning/katas/kotlin/Core
Transforms/Combine/CombineFn/src/org/apache/beam/learning/katas/coretransforms/combine/combinefn/Task.kt
##
aaltay commented on pull request #11851:
URL: https://github.com/apache/beam/pull/11851#issuecomment-635587627
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
tvalentyn commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r432101289
##
File path:
.test-infra/metrics/grafana/dashboards/perftests_metrics/Python_Performance_Tests.json
##
@@ -0,0 +1,297 @@
+{
Review comment:
>
ihji commented on a change in pull request #11814:
URL: https://github.com/apache/beam/pull/11814#discussion_r432099933
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java
##
@@ -397,10 +397,21 @@ public static
ibzib opened a new pull request #11852:
URL: https://github.com/apache/beam/pull/11852
…ase guide.
Just some minor docs cleanup.
R: @TheNeuralBit
Thank you for your contribution! Follow this checklist to help us
incorporate your
chamikaramj commented on a change in pull request #11847:
URL: https://github.com/apache/beam/pull/11847#discussion_r432083261
##
File path: sdks/python/apache_beam/io/external/xlang_kafkaio_it_test.py
##
@@ -0,0 +1,145 @@
+"""Integration test for Python cross-language
robertwb commented on a change in pull request #11835:
URL: https://github.com/apache/beam/pull/11835#discussion_r432093237
##
File path: sdks/python/apache_beam/transforms/trigger_test.py
##
@@ -518,6 +519,28 @@ def format_result(k_v):
'B-3': {10, 15, 16},
pabloem removed a comment on pull request #11086:
URL: https://github.com/apache/beam/pull/11086#issuecomment-626066297
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lostluck merged pull request #11806:
URL: https://github.com/apache/beam/pull/11806
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lostluck commented on pull request #11806:
URL: https://github.com/apache/beam/pull/11806#issuecomment-635568870
@damondouglas That sounds correct to me as well, in order to avoid
colliding stepik updates.
This is an
pabloem removed a comment on pull request #11086:
URL: https://github.com/apache/beam/pull/11086#issuecomment-634947671
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
damondouglas commented on pull request #11806:
URL: https://github.com/apache/beam/pull/11806#issuecomment-635563478
@henryken Just confirming these steps:
1. @lostluck merges this PR #11806 to master
1. @damondouglas merges new changes from PR #11806 to PR #11803
1.
TheNeuralBit commented on pull request #11777:
URL: https://github.com/apache/beam/pull/11777#issuecomment-635549457
Are those tests sufficient though if they're passing before this PR?
This is an automated message from the
kennknowles commented on a change in pull request #11835:
URL: https://github.com/apache/beam/pull/11835#discussion_r432064924
##
File path: sdks/python/apache_beam/transforms/trigger_test.py
##
@@ -518,6 +519,28 @@ def format_result(k_v):
'B-3': {10, 15,
piotr-szuberski commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r432061809
##
File path: sdks/python/apache_beam/examples/wordcount_it_test.py
##
@@ -84,11 +87,45 @@ def _run_wordcount_it(self, run_wordcount, **opts):
piotr-szuberski commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r432061809
##
File path: sdks/python/apache_beam/examples/wordcount_it_test.py
##
@@ -84,11 +87,45 @@ def _run_wordcount_it(self, run_wordcount, **opts):
davidcavazos commented on a change in pull request #11851:
URL: https://github.com/apache/beam/pull/11851#discussion_r432049685
##
File path: sdks/python/apache_beam/examples/snippets/snippets.py
##
@@ -226,35 +227,33 @@ def _add_argparse_args(cls, parser):
# [END
lukecwik commented on a change in pull request #11792:
URL: https://github.com/apache/beam/pull/11792#discussion_r432050850
##
File path: runners/portability/java/build.gradle
##
@@ -31,9 +45,123 @@ dependencies {
compile project(path: ":sdks:java:harness", configuration:
davidcavazos commented on a change in pull request #11851:
URL: https://github.com/apache/beam/pull/11851#discussion_r432049685
##
File path: sdks/python/apache_beam/examples/snippets/snippets.py
##
@@ -226,35 +227,33 @@ def _add_argparse_args(cls, parser):
# [END
davidcavazos commented on a change in pull request #11851:
URL: https://github.com/apache/beam/pull/11851#discussion_r432049685
##
File path: sdks/python/apache_beam/examples/snippets/snippets.py
##
@@ -226,35 +227,33 @@ def _add_argparse_args(cls, parser):
# [END
davidcavazos commented on a change in pull request #11851:
URL: https://github.com/apache/beam/pull/11851#discussion_r432049685
##
File path: sdks/python/apache_beam/examples/snippets/snippets.py
##
@@ -226,35 +227,33 @@ def _add_argparse_args(cls, parser):
# [END
davidcavazos opened a new pull request #11851:
URL: https://github.com/apache/beam/pull/11851
Updating `PipelineOptions` snippets to mirror best practices. Making setting
pipeline options programmatically less cumbersome, and adding the necessary
imports to each snippet.
R: @aaltay
pabloem opened a new pull request #11850:
URL: https://github.com/apache/beam/pull/11850
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
1 - 100 of 172 matches
Mail list logo
