jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631805319
🚀
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631777614
are we able to run post commit?
This is an automated message from the Apache Git Service.
To respond to the me
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631768508
Seems pre-commit is stuck reporting back to github.
There's one unrelated test that failed
https://builds.apache.org/job/beam_PreCommit_Java_Commit/11508/testReport/org.apach
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631609714
We could stage these / pull these in from GCS.
This will mean devs would need access to this bucket to run the tests.
--
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631265943
I think that something about `TestPubsubSignal` does not play well with the
way this integration test suite runs on Dataflow.
Following in suit with `PubsubReadIT` (which al
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631203002
The issue with FhirIOReadIT seems to be some misuse of
[TestPubsubSignal](https://beam.apache.org/releases/javadoc/2.20.0/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.html)
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-629376974
@pabloem 843104d was a pretty simple fix for api surface test
```
git rev-parse HEAD && ./gradlew
:sdks:java:io:google-cloud-platform:cleanTest
:sdks:java:io:google-cloud-pl
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-629367380
@pabloem re: api surface.
So the history here is that the client library executeBundle method is
broken so we were forced to use out own http client (and our own exceptions).
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-629364334
@mwalenia
> What exactly causes this
error?https://builds.apache.org/job/beam_PostCommit_Java_PR/362/testReport/junit/org.apache.beam.sdk.io.gcp.healthcare/FhirIOWriteIT/testFh
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-628875209
@pabloem I'm not sure what's going on with the class loading IT issue but I
think we could re-run the precommit
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-628872612
- [x] Fixed javadoc checkstyle issue
- [x] Added pubsub.close() to the @After in FhirIOReadIT (this should fix
the pubsub not shutdown properly message)
- [x] Added KV coders
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-628846183
There is a separate crop of issues of
```java.lang.NoClassDefFoundError: Could not initialize class
org.apache.beam.sdk.io.gcp.healthcare.FhirIOTestUtil```
In the ex
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-628845239
[FhirIOReadIT](https://github.com/apache/beam/pull/11339/files#diff-7a1359c60a094e73275769adb69b35d3R57)
borrows the
[TestPubsubSignal](https://github.com/apache/beam/blob/44f3d3
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-628842736
Yeah they are parameterized tests that are all failing like this:
```
WARNING: No terminal state was returned within allotted timeout. State value
RUNNING
May 14, 2020 2:
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-628833485
> I'm unsure if the failures are due to an issue with this PR. Feel free to
inspect:
> https://scans.gradle.com/s/c4wwwmeidugrc/failure#top=0
There's not much information
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-621525975
@pabloem @lastomato the refactor to remove unnecessary use of `HttpBody`
model (and associated coder) in favor of `String` is complete, plus an adding
of HTTP status code similar
16 matches
Mail list logo