[GitHub] [beam] kennknowles commented on pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-06-10 Thread GitBox
kennknowles commented on pull request #11820: URL: https://github.com/apache/beam/pull/11820#issuecomment-642121612 Thanks for the review! Definitely made this simpler, better, more focused. This is an automated message from

[GitHub] [beam] kennknowles commented on pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-06-05 Thread GitBox
kennknowles commented on pull request #11820: URL: https://github.com/apache/beam/pull/11820#issuecomment-639689286 PTAL. The first commit is unchanged, the second is a total rewrite (or unwrite, if you like). - Modified each `SqlQuery2`, etc, class to have just the amount of varia

[GitHub] [beam] kennknowles commented on pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-06-02 Thread GitBox
kennknowles commented on pull request #11820: URL: https://github.com/apache/beam/pull/11820#issuecomment-637667567 Seems this is already known in https://issues.apache.org/jira/browse/BEAM-8101 This is an automated message

[GitHub] [beam] kennknowles commented on pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-06-02 Thread GitBox
kennknowles commented on pull request #11820: URL: https://github.com/apache/beam/pull/11820#issuecomment-637667327 run java precommit This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] kennknowles commented on pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-06-02 Thread GitBox
kennknowles commented on pull request #11820: URL: https://github.com/apache/beam/pull/11820#issuecomment-637667264 Flake in direct runner ParDoLifecycleTest https://builds.apache.org/job/beam_PreCommit_Java_Phrase/2267/testReport/junit/org.apache.beam.sdk.transforms/ParDoLifecycleTe

[GitHub] [beam] kennknowles commented on pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-05-29 Thread GitBox
kennknowles commented on pull request #11820: URL: https://github.com/apache/beam/pull/11820#issuecomment-636262451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [beam] kennknowles commented on pull request #11820: [BEAM-10093] ZetaSql Nexmark variant

2020-05-26 Thread GitBox
kennknowles commented on pull request #11820: URL: https://github.com/apache/beam/pull/11820#issuecomment-634292920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a