subject:"\[GitHub\] \[beam\] robertwb commented on a change in pull request #12391\: \[BEAM\-9839\] OnTimerContext should not create a new one when processing each element\/timer in FnApiDoFnRunner"

[GitHub] [beam] robertwb commented on a change in pull request #12391: [BEAM-9839] OnTimerContext should not create a new one when processing each element/timer in FnApiDoFnRunner

2020-08-03 Thread GitBox

robertwb commented on a change in pull request #12391: URL: https://github.com/apache/beam/pull/12391#discussion_r464538362 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -2118,8 +2113,8 @@ public TimeDomain timeDomain(DoFn

[GitHub] [beam] robertwb commented on a change in pull request #12391: [BEAM-9839] OnTimerContext should not create a new one when processing each element/timer in FnApiDoFnRunner

2020-07-29 Thread GitBox

robertwb commented on a change in pull request #12391: URL: https://github.com/apache/beam/pull/12391#discussion_r461870594 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -2118,8 +2113,8 @@ public TimeDomain timeDomain(DoFn