Re: [PR] Add insta for df testing [datafusion]

2025-03-11 Thread via GitHub
alamb commented on code in PR #15165: URL: https://github.com/apache/datafusion/pull/15165#discussion_r1990169442 ## datafusion/common/src/test_util.rs: ## @@ -73,6 +76,31 @@ macro_rules! assert_batches_eq { }; } +pub fn batches_to_string(batches: &[RecordBatch]) -> Stri

Re: [PR] Add insta for df testing [datafusion]

2025-03-11 Thread via GitHub
blaginin commented on code in PR #15165: URL: https://github.com/apache/datafusion/pull/15165#discussion_r1990159130 ## datafusion/core/tests/dataframe/mod.rs: ## @@ -429,16 +434,16 @@ async fn drop_with_quotes() -> Result<()> { let df_results = df.collect().await?; -

Re: [PR] Add insta for df testing [datafusion]

2025-03-11 Thread via GitHub
blaginin commented on code in PR #15165: URL: https://github.com/apache/datafusion/pull/15165#discussion_r1990156623 ## datafusion/common/src/test_util.rs: ## @@ -73,6 +76,31 @@ macro_rules! assert_batches_eq { }; } +pub fn batches_to_string(batches: &[RecordBatch]) -> S

[PR] Add insta for df testing [datafusion]

2025-03-11 Thread via GitHub
blaginin opened a new pull request, #15165: URL: https://github.com/apache/datafusion/pull/15165 ## Which issue does this PR close? Related to https://github.com/apache/datafusion/issues/10373 ## Rationale for this change Switch to insta snapshots so review and update