Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2133371545 Thank you for sticking with it @jayzhan211 -- so much is going on!@ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2132202451 Thanks @alamb and @appletreeisyellow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb merged PR #10268: URL: https://github.com/apache/datafusion/pull/10268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2132161104 Looks good, and existing tests are passing 👍 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1614656536 ## datafusion/sqllogictest/test_files/joins.slt: ## @@ -1778,7 +1778,7 @@ AS VALUES ('BB', 6, 1); query TII -select col1, col2, coalesce(sum_col3, 0) as sum

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1614656536 ## datafusion/sqllogictest/test_files/joins.slt: ## @@ -1778,7 +1778,7 @@ AS VALUES ('BB', 6, 1); query TII -select col1, col2, coalesce(sum_col3, 0) as sum

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1614654486 ## datafusion/sqllogictest/test_files/joins.slt: ## @@ -1778,7 +1778,7 @@ AS VALUES ('BB', 6, 1); query TII -select col1, col2, coalesce(sum_col3, 0) as sum_col3

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1614530863 ## datafusion/sqllogictest/test_files/select.slt: ## @@ -1473,7 +1473,7 @@ DROP TABLE t; # related to https://github.com/apache/datafusion/issues/8814 statement

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

appletreeisyellow commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2125344366 > I don't think this needs a performance test -- I was thinking just the main test suite I was thinking performance regression 😅 Got it! I can put up an Influxdata t

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2125115366 > I believe the coercion rule is quite messy as it currently stands. It would be more understandable and maintainable to move the coercion rule from coerced_from to each individual fun

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2125114372 I don't think this needs a performance test -- I was thinking just the main test suite -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

appletreeisyellow commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2123829586 > I am not sure I have the time to do that in the next week -- maybe @appletreeisyellow does 🤔 @alamb I'm happy to coordinate with our performance team and run an in

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2123600422 I believe the coercion rule is quite messy as it currently stands. It would be more understandable and maintainable to move the coercion rule from coerced_from to each individual

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2123378506 Basically I worry this is just changing behavior rather than fixing a bug and will result in churn for no benefit downstream. I may be mis understanding the change and rationale howeve

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2123377440 In general I am concerned about the potential downstream effects of this change. I don't fully understand them What I would ideally like to do is to run the influxdb_iox regress

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2101115286 Marking as draft as I think we are pursuing an alternate strategy, https://github.com/apache/datafusion/issues/10423, now -- This is an automated message from the Apache Git Service.

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1594086874 ## datafusion/sqllogictest/test_files/coalesce.slt: ## @@ -209,28 +209,20 @@ select [3, 4] List(Field { name: "item", data_type: Int64, nullable: true, dict_id: 0,

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1594036090 ## datafusion/sqllogictest/test_files/coalesce.slt: ## @@ -209,28 +209,20 @@ select [3, 4] List(Field { name: "item", data_type: Int64, nullable: true, dict_id: 0,

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1593511241 ## datafusion/sqllogictest/test_files/coalesce.slt: ## @@ -209,28 +209,20 @@ select [3, 4] List(Field { name: "item", data_type: Int64, nullable: true, dict_id

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1593511241 ## datafusion/sqllogictest/test_files/coalesce.slt: ## @@ -209,28 +209,20 @@ select [3, 4] List(Field { name: "item", data_type: Int64, nullable: true, dict_id

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1589198958 ## datafusion/sqllogictest/test_files/coalesce.slt: ## @@ -209,28 +209,20 @@ select [3, 4] List(Field { name: "item", data_type: Int64, nullable: true, dict_id

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1589198958 ## datafusion/sqllogictest/test_files/coalesce.slt: ## @@ -209,28 +209,20 @@ select [3, 4] List(Field { name: "item", data_type: Int64, nullable: true, dict_id

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1589198958 ## datafusion/sqllogictest/test_files/coalesce.slt: ## @@ -209,28 +209,20 @@ select [3, 4] List(Field { name: "item", data_type: Int64, nullable: true, dict_id

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1589198958 ## datafusion/sqllogictest/test_files/coalesce.slt: ## @@ -209,28 +209,20 @@ select [3, 4] List(Field { name: "item", data_type: Int64, nullable: true, dict_id

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1589169380 ## datafusion/sqllogictest/test_files/coalesce.slt: ## @@ -35,7 +35,7 @@ select coalesce(null, null); NULL # cast to float -query RT +query IT Review Comme

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1589169380 ## datafusion/sqllogictest/test_files/coalesce.slt: ## @@ -35,7 +35,7 @@ select coalesce(null, null); NULL # cast to float -query RT +query IT Review Comme

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1589137130 ## datafusion/sqllogictest/test_files/coalesce.slt: ## @@ -23,7 +23,7 @@ select coalesce(1, 2, 3); 1 # test with first null -query IT +query ?T Review Comment:

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1586956681 ## datafusion/expr/src/type_coercion/functions.rs: ## @@ -293,6 +314,32 @@ fn maybe_data_types( Some(new_type) } +/// Check if the current argument type

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1586956681 ## datafusion/expr/src/type_coercion/functions.rs: ## @@ -293,6 +314,32 @@ fn maybe_data_types( Some(new_type) } +/// Check if the current argument type

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1586956681 ## datafusion/expr/src/type_coercion/functions.rs: ## @@ -293,6 +314,32 @@ fn maybe_data_types( Some(new_type) } +/// Check if the current argument type

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1587073299 ## datafusion/expr/src/type_coercion/functions.rs: ## @@ -53,20 +54,31 @@ pub fn data_types( } } -let valid_types = get_valid_types(&signatu

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1587073726 ## datafusion/expr/src/type_coercion/functions.rs: ## @@ -53,20 +54,31 @@ pub fn data_types( } } -let valid_types = get_valid_types(&signatu

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1586960617 ## datafusion/expr/src/signature.rs: ## @@ -92,14 +92,22 @@ pub enum TypeSignature { /// A function such as `concat` is `Variadic(vec![DataType::Utf8, Dat

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1586955192 ## datafusion/expr/src/signature.rs: ## @@ -92,14 +92,22 @@ pub enum TypeSignature { /// A function such as `concat` is `Variadic(vec![DataType::Utf8, Dat

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1586955192 ## datafusion/expr/src/signature.rs: ## @@ -92,14 +92,22 @@ pub enum TypeSignature { /// A function such as `concat` is `Variadic(vec![DataType::Utf8, Dat

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1586955192 ## datafusion/expr/src/signature.rs: ## @@ -92,14 +92,22 @@ pub enum TypeSignature { /// A function such as `concat` is `Variadic(vec![DataType::Utf8, Dat

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1586955192 ## datafusion/expr/src/signature.rs: ## @@ -92,14 +92,22 @@ pub enum TypeSignature { /// A function such as `concat` is `Variadic(vec![DataType::Utf8, Dat

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1586956681 ## datafusion/expr/src/type_coercion/functions.rs: ## @@ -293,6 +314,32 @@ fn maybe_data_types( Some(new_type) } +/// Check if the current argument type

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1586955192 ## datafusion/expr/src/signature.rs: ## @@ -92,14 +92,22 @@ pub enum TypeSignature { /// A function such as `concat` is `Variadic(vec![DataType::Utf8, Dat

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2088998120 I made a PR with just your wonderful tests in https://github.com/apache/datafusion/pull/10334/files -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1586698773 ## datafusion/expr/src/type_coercion/functions.rs: ## @@ -53,20 +54,31 @@ pub fn data_types( } } -let valid_types = get_valid_types(&signature.ty

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2088447295 I am sorry I ran out of time to review this yesterday. I plan to do so later this morning -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1583906718 ## datafusion/expr/src/type_coercion/binary.rs: ## @@ -289,15 +290,164 @@ fn bitwise_coercion(left_type: &DataType, right_type: &DataType) -> Option TypeCatego

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1583906718 ## datafusion/expr/src/type_coercion/binary.rs: ## @@ -289,15 +290,164 @@ fn bitwise_coercion(left_type: &DataType, right_type: &DataType) -> Option TypeCatego

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1583906718 ## datafusion/expr/src/type_coercion/binary.rs: ## @@ -289,15 +290,164 @@ fn bitwise_coercion(left_type: &DataType, right_type: &DataType) -> Option TypeCatego

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

alamb commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2083625320 Thanks @jayzhan211 - I will check this out tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

erratic-pattern commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1583515399 ## datafusion/expr/src/type_coercion/binary.rs: ## @@ -289,15 +290,164 @@ fn bitwise_coercion(left_type: &DataType, right_type: &DataType) -> Option TypeC

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

erratic-pattern commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1583511505 ## datafusion/expr/src/type_coercion/binary.rs: ## @@ -289,15 +290,164 @@ fn bitwise_coercion(left_type: &DataType, right_type: &DataType) -> Option TypeC

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

erratic-pattern commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1583508138 ## datafusion/expr/src/type_coercion/binary.rs: ## @@ -289,15 +290,164 @@ fn bitwise_coercion(left_type: &DataType, right_type: &DataType) -> Option TypeC

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

erratic-pattern commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1583508138 ## datafusion/expr/src/type_coercion/binary.rs: ## @@ -289,15 +290,164 @@ fn bitwise_coercion(left_type: &DataType, right_type: &DataType) -> Option TypeC

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1583129464 ## datafusion/expr/src/type_coercion/binary.rs: ## @@ -289,15 +290,164 @@ fn bitwise_coercion(left_type: &DataType, right_type: &DataType) -> Option TypeCatego

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1583125654 ## datafusion/expr/src/signature.rs: ## @@ -92,14 +92,22 @@ pub enum TypeSignature { /// A function such as `concat` is `Variadic(vec![DataType::Utf8, Dat