alamb merged PR #10309:
URL: https://github.com/apache/datafusion/pull/10309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2096434696
Thanks again @lewiszlw and @metesynnada
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
alamb commented on PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2093387850
I pushed a unit test in
[30bf3bf](https://github.com/apache/datafusion/pull/10309/commits/30bf3bff74a6aa5a15da0fecf835effbac02231b)
--
This is an automated message from the Apache Gi
alamb commented on PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2093335288
> > If you don't have time to do this @lewiszlw I can try and help, or
perhaps we can file a ticket and do it as a follow on PR
>
> Yeah, I'm on vacation. So might not action in
lewiszlw commented on PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2090462354
> If you don't have time to do this @lewiszlw I can try and help, or perhaps
we can file a ticket and do it as a follow on PR
Yeah, I'm on vacation. So might not action in tim
alamb commented on PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2090433383
If you don't have time to do this @lewiszlw I can try and help, or perhaps
we can file a ticket and do it as a follow on PR
--
This is an automated message from the Apache Git Servi
alamb commented on PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2090432837
I think the idea would be to create a `StreamingTableExec` directly and then
read data from it, ensuring that the limit was applied
I didn't see any existing unit tests for `Stre
metesynnada commented on PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2089827370
> Hmm, I don't get the point. How should I add unit tests?
The executor should be capable of running independently within a test. For
more insight, refer to the hash join t
lewiszlw commented on PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2088509388
Hmm, I don't get the point. How should I add unit tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb commented on PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2088451059
> @alamb, this looks good to me. However, I'm concerned there might be
redundant `LimitStream` overhead when both `GlobalLimitExec` and
`StreamTableExec` are present in the plan, as `L
metesynnada commented on PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2088370977
@alamb, this looks good to me. However, I'm concerned there might be
redundant `LimitStream` overhead when both `GlobalLimitExec` and
`StreamTableExec` are present in the plan, a
alamb commented on PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2088322948
FYI @metesynnada
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
alamb commented on code in PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#discussion_r1586200317
##
datafusion/sqllogictest/test_files/limit.slt:
##
@@ -39,6 +39,26 @@ STORED AS CSV
WITH HEADER ROW
LOCATION '../../testing/data/csv/aggregate_test_100.csv'
+st
lewiszlw commented on PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2088134490
Seems due to filter, limit won't be pushed down to table provider. So I
added a simple test in limit.slt .
--
This is an automated message from the Apache Git Service.
To respond
lewiszlw commented on code in PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#discussion_r1586003700
##
datafusion/physical-plan/src/streaming.rs:
##
@@ -58,7 +60,9 @@ pub struct StreamingTableExec {
projected_schema: SchemaRef,
projected_output_orderin
alamb commented on code in PR #10309:
URL: https://github.com/apache/datafusion/pull/10309#discussion_r1585301149
##
datafusion/physical-plan/src/streaming.rs:
##
@@ -58,7 +60,9 @@ pub struct StreamingTableExec {
projected_schema: SchemaRef,
projected_output_ordering:
lewiszlw opened a new pull request, #10309:
URL: https://github.com/apache/datafusion/pull/10309
## Which issue does this PR close?
Closes todo.
## Rationale for this change
## What changes are included in this PR?
## Are these changes teste
17 matches
Mail list logo
