Re: [PR] feat: Add HasRowIdMapping interface [datafusion-comet]

2025-01-15 Thread via GitHub
viirya commented on PR #1288: URL: https://github.com/apache/datafusion-comet/pull/1288#issuecomment-2591897788 Thanks @huaxingao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] feat: Add HasRowIdMapping interface [datafusion-comet]

2025-01-15 Thread via GitHub
viirya merged PR #1288: URL: https://github.com/apache/datafusion-comet/pull/1288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dat

Re: [PR] feat: Add HasRowIdMapping interface [datafusion-comet]

2025-01-14 Thread via GitHub
viirya commented on code in PR #1288: URL: https://github.com/apache/datafusion-comet/pull/1288#discussion_r1915728249 ## common/src/main/java/org/apache/comet/vector/HasRowIdMapping.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[PR] feat: Add HasRowIdMapping interface [datafusion-comet]

2025-01-14 Thread via GitHub
viirya opened a new pull request, #1288: URL: https://github.com/apache/datafusion-comet/pull/1288 ## Which issue does this PR close? Closes #. ## Rationale for this change ## What changes are included in this PR? ## How are these changes te