andygrove commented on code in PR #1593:
URL: https://github.com/apache/datafusion-comet/pull/1593#discussion_r2044570361
##
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##
@@ -282,6 +282,7 @@ public void init() throws URISyntaxException, IOException {
//
parthchandra commented on code in PR #1593:
URL: https://github.com/apache/datafusion-comet/pull/1593#discussion_r2044994999
##
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##
@@ -282,6 +282,7 @@ public void init() throws URISyntaxException, IOException {
andygrove commented on code in PR #1593:
URL: https://github.com/apache/datafusion-comet/pull/1593#discussion_r2044569591
##
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##
@@ -282,6 +282,7 @@ public void init() throws URISyntaxException, IOException {
//
andygrove merged PR #1593:
URL: https://github.com/apache/datafusion-comet/pull/1593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove commented on PR #1593:
URL:
https://github.com/apache/datafusion-comet/pull/1593#issuecomment-2806145544
Sure. I just had a minor comment but it could be addressed separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
comphead commented on PR #1593:
URL:
https://github.com/apache/datafusion-comet/pull/1593#issuecomment-2806017077
are we okay to merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
parthchandra commented on PR #1593:
URL:
https://github.com/apache/datafusion-comet/pull/1593#issuecomment-2803362330
@andygrove I had introduced a regression which I fixed since your approval
(if you want to look again)
Basically, the results of the call to `findRowIndexColumnIndexInSch
andygrove commented on code in PR #1593:
URL: https://github.com/apache/datafusion-comet/pull/1593#discussion_r2040094303
##
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##
@@ -263,111 +272,129 @@ public void init() throws URISyntaxException,
IOExceptio
parthchandra commented on code in PR #1593:
URL: https://github.com/apache/datafusion-comet/pull/1593#discussion_r2037910025
##
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##
@@ -496,25 +526,25 @@ private int loadNextBatch() throws Throwable {
List
parthchandra commented on code in PR #1593:
URL: https://github.com/apache/datafusion-comet/pull/1593#discussion_r2037902270
##
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##
@@ -496,25 +526,25 @@ private int loadNextBatch() throws Throwable {
List
andygrove commented on code in PR #1593:
URL: https://github.com/apache/datafusion-comet/pull/1593#discussion_r2037886670
##
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##
@@ -496,25 +526,25 @@ private int loadNextBatch() throws Throwable {
List co
parthchandra commented on PR #1593:
URL:
https://github.com/apache/datafusion-comet/pull/1593#issuecomment-2794479553
@mbutrovich @andygrove this is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
codecov-commenter commented on PR #1593:
URL:
https://github.com/apache/datafusion-comet/pull/1593#issuecomment-2770961510
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1593?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
parthchandra opened a new pull request, #1593:
URL: https://github.com/apache/datafusion-comet/pull/1593
## Which issue does this PR close?
Part of #1542
## Rationale for this change
A bug in the logic of `NativeBatchReader` caused NPE and array index out of
bounds erro
14 matches
Mail list logo
