jayzhan211 closed issue #6747: Make it easier to create WindowFunctions with
the Expr API
URL: https://github.com/apache/datafusion/issues/6747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
timsaucer commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2239126528
I started a new branch off `main` with these changes. Tomorrow I'll review
the previous branch @shanretoo was working on to make sure I didn't miss any
unit tests he added. Othe
timsaucer commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2236314542
Good point. I was just thinking about it and came on here to remove that
from my comment! So we are well aligned. Great suggestions. I'll move forward
on working on this tomorro
jayzhan211 commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2236290278
The overall idea looks good to me, but I'm not sure about the `Case` you
mentioned, is there any Expr that is also possible be benefited from builder
mode?
My current id
timsaucer commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2236257604
I've started looking at this and coming up against one blocker that prevents
just following the exact pattern.
My first thought was to implement a trait like
```
pub
alamb commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2212416660
In case anyone is following along, @jayzhan211 added a really nice trait for
working with aggregate functions. Maybe we can do something similar for window
functions eventually
alamb commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2156133859
Update here is that @jayzhan211 and I have been working on a similar API for
creating `Aggregate` exprs on https://github.com/apache/datafusion/pull/10560.
I am quite pleased with h
shanretoo commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2125995127
Looks good. It is clearer to understand the results in this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
timsaucer commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2125128453
I think you're doing a great job, and good point on the sqllogictest. TBH I
find those tests harder to wrap my head around than the rust tests, but that's
more personal preferen
shanretoo commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2125106167
Have you checked tests in
[sqllogictest](https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/window.slt)?
If we want to make sure all the variant
shanretoo commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2125062735
Sorry, my fault. I haven't taken into account the ordering issue. Maybe we
could add a following match arm in the macro to omit the `order_by` parameter
and add the output colum
timsaucer commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2124691067
The one thing I think we're missing is the other variants for these. I don't
think it's covered in other unit tests that I can find. So for example, for
lead we would want to va
timsaucer commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2124676884
Thank you. I pulled your branch and many of the tests are failing for me
even though **the functions are returning correct values** when I add
additional debug statements. I thi
shanretoo commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2123697634
You can check it in the unit test:
[`test_fn_lead`](https://github.com/shanretoo/datafusion/blob/65a8895d948152845dda1934b404399919ebe23c/datafusion/core/tests/dataframe/datafram
timsaucer commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2123031753
Oh, great. Have you been able to run the [example code
above](https://github.com/apache/datafusion/issues/6747#issuecomment-2090260284)
using the new easy interface?
--
This
shanretoo commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2122870652
@timsaucer I have fixed the calls of `expr::WindowFunction` to meet the
changes and add tests for those window functions in `dataframe_functions.rs`.
Let me know if I missed a
shanretoo commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2119039796
Thanks for your update! I'll work on the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
timsaucer commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2118864412
Great! I've rebased @alamb 's branch and added the changes I suggested. I
was about to start testing the code and then I was going to write up the unit
tests. My work in progres
shanretoo commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2118840627
I am willing to help with this task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alamb commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2090267577
Note I have some code in https://github.com/apache/datafusion/pull/6746 that
had some part of it (along with an example)
--
This is an automated message from the Apache Git Servic
alamb commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2090266602
🤔 it seems like spark's API is like
> count("dt").over(w).alias("count")).show()
https://stackoverflow.com/questions/32769328/how-to-use-window-functions-in-pyspark-u
alamb commented on issue #6747:
URL: https://github.com/apache/datafusion/issues/6747#issuecomment-2090260284
Here is another example from https://github.com/apache/datafusion/pull/10345
/ @timsaucer showing how non easy it is to create a window function via the
expr API
```rust
22 matches
Mail list logo
