vaibhawvipul commented on issue #846:
URL:
https://github.com/apache/datafusion-comet/issues/846#issuecomment-2308171051
I can take this up if more details are provided :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
2010YOUY01 commented on issue #11752:
URL: https://github.com/apache/datafusion/issues/11752#issuecomment-2308176932
Do we have tickets for regexp binary operators? (like `~`, `!~`...)
https://datafusion.apache.org/user-guide/sql/operators.html#op-re-match
I noticed stringview is no
theirix commented on issue #12137:
URL: https://github.com/apache/datafusion/issues/12137#issuecomment-2308212251
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
findepi commented on issue #1468:
URL: https://github.com/apache/datafusion/issues/1468#issuecomment-2308237517
I run into this recently. When constructing VALUES via API, the Alias
expression can be thought to allow aliasing the VALUES columns, but this didn't
work, alias got (silently) ig
jonahgao merged PR #12132:
URL: https://github.com/apache/datafusion/pull/12132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
jonahgao closed issue #12058: Internal Error in `APPROX_PERCENTILE_CONT` window
function (SQLancer)
URL: https://github.com/apache/datafusion/issues/12058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jonahgao commented on PR #12132:
URL: https://github.com/apache/datafusion/pull/12132#issuecomment-2308260674
Thanks @lewiszlw for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb opened a new pull request, #12145:
URL: https://github.com/apache/datafusion/pull/12145
## Which issue does this PR close?
Closes #.
## Rationale for this change
I was looking for the page on
[`Partitioning`](https://docs.rs/datafusion/latest/datafusion/phy
alamb commented on code in PR #12145:
URL: https://github.com/apache/datafusion/pull/12145#discussion_r1729875428
##
datafusion/physical-expr/src/partitioning.rs:
##
@@ -24,8 +24,8 @@ use crate::{physical_exprs_equal, EquivalenceProperties,
PhysicalExpr};
/// Output partitio
alamb commented on PR #12127:
URL: https://github.com/apache/datafusion/pull/12127#issuecomment-2308269131
Thanks again @2010YOUY01 and @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb merged PR #12127:
URL: https://github.com/apache/datafusion/pull/12127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on issue #1468:
URL: https://github.com/apache/datafusion/issues/1468#issuecomment-2308275476
> I run into this recently. When constructing VALUES via API, the Alias
expression can be thought to allow aliasing the VALUES columns, but this didn't
work, alias got (silently) ig
dharanad commented on PR #12063:
URL: https://github.com/apache/datafusion/pull/12063#issuecomment-2308277945
Thank You @alamb Really appreciate your help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
alamb commented on issue #12119:
URL: https://github.com/apache/datafusion/issues/12119#issuecomment-2308278756
>
> One question -- do we need a flag though?
My rationale is that converting from Utf8View --> Utf8 is not free. Thus
users should have the option of not paying the
alamb commented on issue #12119:
URL: https://github.com/apache/datafusion/issues/12119#issuecomment-2308280118
BTW with this conversion in place, I think we could contemplate more
interesting changes, like `substr` always outputing `Utf8View` even when the
input was `Utf8`
--
This is a
alamb commented on issue #11752:
URL: https://github.com/apache/datafusion/issues/11752#issuecomment-2308284524
> Do we have tickets for regexp binary operators? (like ~, !~...)
Not that I know of -- it would be great to add them
--
This is an automated message from the Apache Git S
alamb commented on PR #12063:
URL: https://github.com/apache/datafusion/pull/12063#issuecomment-2308283412
> Thank You @alamb Really appreciate your help
Likewise!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
alamb merged PR #12138:
URL: https://github.com/apache/datafusion/pull/12138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #11855: Update `LOWER` scalar function to support `Utf8View`
URL: https://github.com/apache/datafusion/issues/11855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
alamb commented on code in PR #12138:
URL: https://github.com/apache/datafusion/pull/12138#discussion_r1729894839
##
datafusion/functions/src/string/common.rs:
##
@@ -214,6 +214,23 @@ where
i64,
_,
>(array, op)?)),
+Data
findepi commented on PR #12141:
URL: https://github.com/apache/datafusion/pull/12141#issuecomment-2308318540
> and @2010YOUY01 for finding it!
i remain eternally impressed by this part.
https://github.com/apache/datafusion/issues/11030 is sooo awesome!
--
This is an automated me
alamb opened a new pull request, #12146:
URL: https://github.com/apache/datafusion/pull/12146
## Which issue does this PR close?
Part of
## Rationale for this change
@ejbyfeldt's great PR to improve STDDEV and VAR
https://github.com/apache/datafusion/pull/12095 did not
findepi commented on issue #12119:
URL: https://github.com/apache/datafusion/issues/12119#issuecomment-2308323576
> My rationale is that converting from Utf8View --> Utf8 is not free.
it is not
but transmitting non-compacted string views isn't free either.
also, we're transit
timsaucer commented on PR #808:
URL:
https://github.com/apache/datafusion-python/pull/808#issuecomment-2308338644
Since this is already getting a bit long, I'd like to merge it with just the
window functions and deal with the aggregate functions in a different PR.
--
This is an automated
alamb commented on code in PR #12095:
URL: https://github.com/apache/datafusion/pull/12095#discussion_r1729934151
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -500,6 +500,85 @@ select stddev(sq.column1) from (values (1.1), (2.0),
(3.0)) as sq
0.950438495292
alamb merged PR #12143:
URL: https://github.com/apache/datafusion/pull/12143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
Weijun-H opened a new issue, #12147:
URL: https://github.com/apache/datafusion/issues/12147
### Is your feature request related to a problem or challenge?
Description | Return a list of all keys in the map.
-- | --
Example | map_keys(map([100, 5], [42,43]))
Result | [100,
alamb closed issue #12101: Cannot infer common string type for string concat
operation Dictionary(Int32, Utf8) || Dictionary(Int32, Utf8)
URL: https://github.com/apache/datafusion/issues/12101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
Weijun-H opened a new issue, #12148:
URL: https://github.com/apache/datafusion/issues/12148
### Is your feature request related to a problem or challenge?
Description | Return a list of all values in the map.
-- | --
Example | map_values(map([100, 5], [42, 43]))
Result | [
alamb commented on code in PR #12126:
URL: https://github.com/apache/datafusion/pull/12126#discussion_r1729937785
##
datafusion/optimizer/src/utils.rs:
##
@@ -28,6 +28,10 @@ use datafusion_expr::{logical_plan::LogicalPlan, Expr,
Operator};
use log::{debug, trace};
+/// Re-
Weijun-H commented on issue #11429:
URL: https://github.com/apache/datafusion/issues/11429#issuecomment-2308356004
related
- #12147
- #12148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb commented on code in PR #12125:
URL: https://github.com/apache/datafusion/pull/12125#discussion_r1729938966
##
datafusion/functions-nested/src/array_has.rs:
##
@@ -95,25 +96,138 @@ impl ScalarUDFImpl for ArrayHas {
}
fn invoke(&self, args: &[ColumnarValue]) ->
2010YOUY01 opened a new issue, #12149:
URL: https://github.com/apache/datafusion/issues/12149
### Describe the bug
Native StringView support for `octet_length()` has been added
https://github.com/apache/datafusion/issues/11858
However it's not working for StringView column inside t
andygrove commented on issue #846:
URL:
https://github.com/apache/datafusion-comet/issues/846#issuecomment-2308359967
> I can take this up if more details are provided :)
We need to implement an equivalent of Spark's
`org.apache.spark.sql.catalyst.expressions.aggregate.BloomFilterAgg
karlovnv commented on PR #12126:
URL: https://github.com/apache/datafusion/pull/12126#issuecomment-2308360188
@jonahgao @alamb Amazing!
A query like ```select count (case when f_1 > $1 then f_0 else null end)
from table1``` for now is working as well!
--
This is an automated me
2010YOUY01 opened a new issue, #12150:
URL: https://github.com/apache/datafusion/issues/12150
### Describe the bug
One query can run successfully on a table with a regular string column
If we convert this string column's physical representation to `StringView`,
the query failed
2010YOUY01 commented on issue #12150:
URL: https://github.com/apache/datafusion/issues/12150#issuecomment-2308361597
Maybe this can be fixed together while working on
https://github.com/apache/datafusion/issues/11912
--
This is an automated message from the Apache Git Service.
To respond
2010YOUY01 commented on issue #11912:
URL: https://github.com/apache/datafusion/issues/11912#issuecomment-2308361901
This internal error bug might be related
https://github.com/apache/datafusion/issues/12150
--
This is an automated message from the Apache Git Service.
To respond to the me
jayzhan211 commented on code in PR #12125:
URL: https://github.com/apache/datafusion/pull/12125#discussion_r1729948604
##
datafusion/functions-nested/src/array_has.rs:
##
@@ -95,25 +96,138 @@ impl ScalarUDFImpl for ArrayHas {
}
fn invoke(&self, args: &[ColumnarValue]
jayzhan211 commented on code in PR #12125:
URL: https://github.com/apache/datafusion/pull/12125#discussion_r1729948847
##
datafusion/sqllogictest/test_files/array.slt:
##
@@ -4972,11 +4972,19 @@ NULL 1 1
## array_has/array_has_all/array_has_any
-query BB
+# If lhs is empty,
alamb commented on issue #4028:
URL: https://github.com/apache/datafusion/issues/4028#issuecomment-2308370920
There is a nice PR here for this feature:
https://github.com/apache/datafusion/pull/12135
--
This is an automated message from the Apache Git Service.
To respond to the message, p
jayzhan211 commented on code in PR #12125:
URL: https://github.com/apache/datafusion/pull/12125#discussion_r1729948949
##
datafusion/sqllogictest/test_files/array.slt:
##
@@ -4972,11 +4972,19 @@ NULL 1 1
## array_has/array_has_all/array_has_any
-query BB
+# If lhs is empty,
theirix opened a new pull request, #12151:
URL: https://github.com/apache/datafusion/pull/12151
## Which issue does this PR close?
Closes #12137
## Rationale for this change
Allow to create `RuntimeEnv` directly from the config instance.
## What changes are include
codecov-commenter commented on PR #866:
URL: https://github.com/apache/datafusion-comet/pull/866#issuecomment-2308374193
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/866?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campai
alamb commented on code in PR #12135:
URL: https://github.com/apache/datafusion/pull/12135#discussion_r1729945409
##
datafusion/core/src/datasource/listing/helpers.rs:
##
@@ -51,69 +51,67 @@ use object_store::{ObjectMeta, ObjectStore};
/// - the table provider can filter the ta
goldmedal commented on PR #12133:
URL: https://github.com/apache/datafusion/pull/12133#issuecomment-2308381885
Thanks @alamb @jayzhan211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
jayzhan211 merged PR #12125:
URL: https://github.com/apache/datafusion/pull/12125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
jayzhan211 commented on PR #12125:
URL: https://github.com/apache/datafusion/pull/12125#issuecomment-2308405719
Thanks @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
timsaucer commented on PR #825:
URL:
https://github.com/apache/datafusion-python/pull/825#issuecomment-2308418797
Ok, added the requested schema and unit tests for export. All that I think
is left is unit tests on the import. I'm not sure if I should keep the
nanoarrow in the unit test. If
dharanad commented on issue #12147:
URL: https://github.com/apache/datafusion/issues/12147#issuecomment-2308436942
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
dharanad commented on issue #12148:
URL: https://github.com/apache/datafusion/issues/12148#issuecomment-2308436972
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
andygrove commented on PR #866:
URL: https://github.com/apache/datafusion-comet/pull/866#issuecomment-2308446464
@kazuyukitanimura I added the TPC-DS results
@comphead Let's show the improvement since 0.1.0 in the blog post for now. I
like the idea of adding a section in the documenta
kylebarron commented on code in PR #825:
URL: https://github.com/apache/datafusion-python/pull/825#discussion_r1730041170
##
src/context.rs:
##
@@ -471,18 +474,31 @@ impl PySessionContext {
name: Option<&str>,
py: Python,
) -> PyResult {
-// Instan
Michael-J-Ward commented on code in PR #808:
URL: https://github.com/apache/datafusion-python/pull/808#discussion_r1730026984
##
docs/source/user-guide/common-operations/windows.rst:
##
@@ -40,54 +43,86 @@ We'll use the pokemon dataset (from Ritchie Vink) in the
following examp
Michael-J-Ward commented on PR #808:
URL:
https://github.com/apache/datafusion-python/pull/808#issuecomment-2308460179
IDK if you have used `polars` much, but I found their approach to
aggregation and windowing pretty intuitive and powerful.
Maybe I should do a deeper comparison by w
matthewmturner commented on issue #11979:
URL: https://github.com/apache/datafusion/issues/11979#issuecomment-2308465273
@alamb When did you plan on starting to work on this? On my flight home i
managed to get a good chunk through a clean rewrite leveraging the setup from
my other app which
dependabot[bot] opened a new pull request, #835:
URL: https://github.com/apache/datafusion-python/pull/835
Bumps [syn](https://github.com/dtolnay/syn) from 2.0.72 to 2.0.76.
Release notes
Sourced from https://github.com/dtolnay/syn/releases";>syn's
releases.
2.0.76
En
dependabot[bot] commented on PR #834:
URL:
https://github.com/apache/datafusion-python/pull/834#issuecomment-2308501272
Superseded by #835.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
dependabot[bot] closed pull request #834: build(deps): bump syn from 2.0.72 to
2.0.75
URL: https://github.com/apache/datafusion-python/pull/834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Omega359 commented on PR #12027:
URL: https://github.com/apache/datafusion/pull/12027#issuecomment-2308528161
> @Omega359 and @XiangpengHao -- what do you think we should do with the
conversation above? [#12027
(comment)](https://github.com/apache/datafusion/pull/12027#issuecomment-22953329
timsaucer commented on code in PR #825:
URL: https://github.com/apache/datafusion-python/pull/825#discussion_r1730131523
##
src/context.rs:
##
@@ -471,18 +474,31 @@ impl PySessionContext {
name: Option<&str>,
py: Python,
) -> PyResult {
-// Instant
comphead commented on code in PR #12145:
URL: https://github.com/apache/datafusion/pull/12145#discussion_r1730133136
##
datafusion/physical-expr/src/partitioning.rs:
##
@@ -24,8 +24,8 @@ use crate::{physical_exprs_equal, EquivalenceProperties,
PhysicalExpr};
/// Output parti
comphead merged PR #12141:
URL: https://github.com/apache/datafusion/pull/12141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead closed issue #12129: Panic in `substring()` scalar function (SQLancer)
URL: https://github.com/apache/datafusion/issues/12129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
comphead merged PR #12134:
URL: https://github.com/apache/datafusion/pull/12134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead commented on PR #12134:
URL: https://github.com/apache/datafusion/pull/12134#issuecomment-2308537137
Thanks everyone for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
comphead commented on code in PR #12142:
URL: https://github.com/apache/datafusion/pull/12142#discussion_r1730134134
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -1331,7 +1331,17 @@ pub fn validate_unique_names<'a>(
})
}
-/// Union two logical plans.
+/// Union
comphead commented on code in PR #12142:
URL: https://github.com/apache/datafusion/pull/12142#discussion_r1730134229
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -1331,7 +1331,17 @@ pub fn validate_unique_names<'a>(
})
}
-/// Union two logical plans.
+/// Union
comphead merged PR #12139:
URL: https://github.com/apache/datafusion/pull/12139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead commented on code in PR #12151:
URL: https://github.com/apache/datafusion/pull/12151#discussion_r1730134993
##
datafusion/core/tests/fuzz_cases/sort_fuzz.rs:
##
@@ -136,9 +136,9 @@ impl SortTest {
.sort_spill_reservation_bytes,
);
-
comphead commented on code in PR #12151:
URL: https://github.com/apache/datafusion/pull/12151#discussion_r1730137020
##
datafusion/core/tests/fuzz_cases/sort_fuzz.rs:
##
@@ -136,9 +136,9 @@ impl SortTest {
.sort_spill_reservation_bytes,
);
-
comphead commented on PR #12151:
URL: https://github.com/apache/datafusion/pull/12151#issuecomment-2308540626
Thanks @theirix for you contribution, I started the pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Omega359 commented on issue #12149:
URL: https://github.com/apache/datafusion/issues/12149#issuecomment-2308556963
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
github-actions[bot] closed pull request #10937: [DRAFT 2 times slower] Multiple
group by optimization
URL: https://github.com/apache/datafusion/pull/10937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Lordworms commented on issue #12117:
URL: https://github.com/apache/datafusion/issues/12117#issuecomment-2308620069
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Weijun-H commented on issue #11437:
URL: https://github.com/apache/datafusion/issues/11437#issuecomment-2308631035
Hi @dharanad, if you're no longer working on this ticket, I can take over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
dharanad commented on issue #11437:
URL: https://github.com/apache/datafusion/issues/11437#issuecomment-2308636390
> Hi @dharanad, if you're no longer working on this ticket, I can take over.
Hey, please feel free to take it
--
This is an automated message from the Apache Git Servic
vaibhawvipul commented on issue #846:
URL:
https://github.com/apache/datafusion-comet/issues/846#issuecomment-2308650972
ok, taking this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
ozankabak commented on PR #12096:
URL: https://github.com/apache/datafusion/pull/12096#issuecomment-2308653765
Let's have @berkaysynnada take one final look tomorrow and then merge 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
Dandandan commented on code in PR #12095:
URL: https://github.com/apache/datafusion/pull/12095#discussion_r1730213887
##
datafusion/functions-aggregate/src/variance.rs:
##
@@ -344,3 +391,181 @@ impl Accumulator for VarianceAccumulator {
true
}
}
+
+#[derive(Debug)
80 matches
Mail list logo