kazuyukitanimura commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1613948812
##
core/src/execution/datafusion/expressions/scalar_funcs/hex.rs:
##
@@ -0,0 +1,371 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+/
tshauck commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1613950678
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1038,6 +1038,20 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpa
duongcongtoai opened a new pull request, #10657:
URL: https://github.com/apache/datafusion/pull/10657
## Which issue does this PR close?
Closes #10656
## Rationale for this change
## What changes are included in this PR?
## Are these change
duongcongtoai commented on code in PR #10657:
URL: https://github.com/apache/datafusion/pull/10657#discussion_r1613955127
##
datafusion/sql/src/utils.rs:
##
@@ -311,7 +311,7 @@ pub(crate) fn recursive_transform_unnest(
tnr: _,
} = original_expr.transform_up
andygrove commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1613955491
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -622,14 +590,89 @@ impl Cast {
self.eval_mode,
from_type,
alamb opened a new issue, #10658:
URL: https://github.com/apache/datafusion/issues/10658
### Describe the bug
We noticed some additional expected log messages upstream in InfluxDB. I
found the same messages are present in `datafusion-cli`
### To Reproduce
```
andrewl
andygrove commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1613955491
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -622,14 +590,89 @@ impl Cast {
self.eval_mode,
from_type,
andygrove commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1613955491
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -622,14 +590,89 @@ impl Cast {
self.eval_mode,
from_type,
kazuyukitanimura commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1613963307
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1038,6 +1038,20 @@ class CometExpressionSuite extends CometTestBase with
Ad
tshauck commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1613965861
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1038,6 +1038,20 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpa
tshauck commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1613965861
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1038,6 +1038,20 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpa
edmondop commented on issue #10380:
URL: https://github.com/apache/datafusion/issues/10380#issuecomment-2130287032
@comphead can I pick this or are you arleady working on a solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
kazuyukitanimura commented on code in PR #469:
URL: https://github.com/apache/datafusion-comet/pull/469#discussion_r1613974875
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -1094,24 +1094,46 @@ object QueryPlanSerde extends Logging with
ShimQueryPla
davisp commented on PR #10590:
URL: https://github.com/apache/datafusion/pull/10590#issuecomment-2130307887
@metegenez Of course on it being a community decision. It is an ASF project
after all. 😄
I've probably led everyone astray by naming this "BigQuery Options" because
that just
andygrove opened a new pull request, #716:
URL: https://github.com/apache/datafusion-python/pull/716
# Which issue does this PR close?
N/A
# Rationale for this change
We cannot upload 38.0.0 RC2 to test.pypi.org so bumping to 38.0.1
# What changes
edmondop commented on issue #7306:
URL: https://github.com/apache/datafusion/issues/7306#issuecomment-2130346827
@alamb I checked the previous @andygrove PR and it seems like we have a good
setup. I read the docs, and noticed they lack a paragraph on how to translate
the LogicalPlan into Ph
alamb commented on code in PR #10650:
URL: https://github.com/apache/datafusion/pull/10650#discussion_r1614042615
##
datafusion/functions/Cargo.toml:
##
@@ -80,7 +80,7 @@ itertools = { workspace = true }
log = { workspace = true }
md-5 = { version = "^0.10.0", optional = true
alamb commented on PR #10623:
URL: https://github.com/apache/datafusion/pull/10623#issuecomment-2130400446
Thank you @metegenez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
comphead commented on PR #455:
URL: https://github.com/apache/datafusion-comet/pull/455#issuecomment-2130409303
@andygrove @advancedxy I fixed the test, implementing extra parsing and
manual small tests if the parsing is complicated. I hope now we have better
picture.
--
This is an auto
alamb commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1614057653
##
datafusion/physical-plan/src/work_table.rs:
##
@@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec {
&self.cache
}
-fn children(&self) ->
comphead commented on issue #10380:
URL: https://github.com/apache/datafusion/issues/10380#issuecomment-2130415661
Thanks @edmondop I'm already working on it, if you have spare time and would
like to work on SMJ its really needed to add fuzz tests for SMJ when the filter
set, I'll create a
comphead opened a new issue, #10659:
URL: https://github.com/apache/datafusion/issues/10659
### Is your feature request related to a problem or challenge?
SMJ now is in experimental state, and the test coverage can be improved.
Because of poor test coverage it was found multiple bugs
edmondop commented on issue #10380:
URL: https://github.com/apache/datafusion/issues/10380#issuecomment-2130435075
Thanks. Will work on #10659 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
xinlifoobar commented on PR #10645:
URL: https://github.com/apache/datafusion/pull/10645#issuecomment-2130457023
The gate issue is not related to the PR.. could we rerun?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
tshauck commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1614116423
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1038,6 +1038,20 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpa
tshauck commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1614116423
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1038,6 +1038,20 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpa
jayzhan211 commented on issue #10658:
URL: https://github.com/apache/datafusion/issues/10658#issuecomment-2130541520
Just cleanup aliases in those functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jayzhan211 commented on code in PR #10655:
URL: https://github.com/apache/datafusion/pull/10655#discussion_r1614200131
##
datafusion/functions/src/core/getfield.rs:
##
@@ -106,6 +106,9 @@ impl ScalarUDFImpl for GetFieldFunc {
};
let access_schema = GetFieldAcce
jayzhan211 commented on code in PR #10655:
URL: https://github.com/apache/datafusion/pull/10655#discussion_r1614200131
##
datafusion/functions/src/core/getfield.rs:
##
@@ -106,6 +106,9 @@ impl ScalarUDFImpl for GetFieldFunc {
};
let access_schema = GetFieldAcce
jayzhan211 commented on code in PR #10655:
URL: https://github.com/apache/datafusion/pull/10655#discussion_r1614200131
##
datafusion/functions/src/core/getfield.rs:
##
@@ -106,6 +106,9 @@ impl ScalarUDFImpl for GetFieldFunc {
};
let access_schema = GetFieldAcce
sonhmai commented on issue #463:
URL:
https://github.com/apache/datafusion-comet/issues/463#issuecomment-2130650900
i'm working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
goldmedal commented on issue #10658:
URL: https://github.com/apache/datafusion/issues/10658#issuecomment-2130807751
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
duongcongtoai opened a new issue, #10660:
URL: https://github.com/apache/datafusion/issues/10660
### Is your feature request related to a problem or challenge?
These sql are not supported
```
##recursive unnest(list->list)
query ?
select * from unnest(unnest(
[[1,2,3
duongcongtoai commented on issue #2326:
URL: https://github.com/apache/datafusion/issues/2326#issuecomment-2130882122
I added an issue to support recursive unnest:
https://github.com/apache/datafusion/issues/10660
--
This is an automated message from the Apache Git Service.
To respond to
ozankabak commented on code in PR #10650:
URL: https://github.com/apache/datafusion/pull/10650#discussion_r1614446423
##
datafusion/physical-expr/src/expressions/cast.rs:
##
@@ -170,7 +170,8 @@ impl PhysicalExpr for CastExpr {
let target_type = &self.cast_type;
ozankabak commented on PR #10650:
URL: https://github.com/apache/datafusion/pull/10650#issuecomment-2131118238
Maybe I can help clarify things a little bit. The purpose of the PR is not
to change the current fallback behavior, just simplify its implementation.
AFAICT @berkaysynnada is movin
peter-toth commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1614462365
##
datafusion/physical-plan/src/work_table.rs:
##
@@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec {
&self.cache
}
-fn children(&sel
ozankabak commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1614484172
##
datafusion/physical-plan/src/work_table.rs:
##
@@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec {
&self.cache
}
-fn children(&self
ozankabak commented on PR #10590:
URL: https://github.com/apache/datafusion/pull/10590#issuecomment-2131154079
The aim has been to make the `COPY` and `CREATE EXTERNAL TABLE` statements
use the same `OPTIONS` syntax. The PR you mention was actually a part of
multi-PR effort to make this so
goldmedal opened a new pull request, #10661:
URL: https://github.com/apache/datafusion/pull/10661
## Which issue does this PR close?
Closes #10658
## Rationale for this change
## What changes are included in this PR?
## Are these changes te
peter-toth commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1614503459
##
datafusion/physical-plan/src/work_table.rs:
##
@@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec {
&self.cache
}
-fn children(&sel
peter-toth commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1614503459
##
datafusion/physical-plan/src/work_table.rs:
##
@@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec {
&self.cache
}
-fn children(&sel
peter-toth commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1614503459
##
datafusion/physical-plan/src/work_table.rs:
##
@@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec {
&self.cache
}
-fn children(&sel
alamb commented on code in PR #10648:
URL: https://github.com/apache/datafusion/pull/10648#discussion_r1614514043
##
datafusion/physical-expr-common/src/utils.rs:
##
@@ -100,15 +103,37 @@ pub fn reverse_order_bys(order_bys: &[PhysicalSortExpr])
-> Vec`.
+/// If conversion is no
sonhmai opened a new pull request, #470:
URL: https://github.com/apache/datafusion-comet/pull/470
## Which issue does this PR close?
Closes #463
## Rationale for this change
Fix for substring with negative indices produces incorrect results
## What changes are
alamb commented on issue #8708:
URL: https://github.com/apache/datafusion/issues/8708#issuecomment-2131167747
After https://github.com/apache/datafusion/pull/10648 and
https://github.com/apache/datafusion/issues/10389 I think we have a pretty good
set of examples of how to move aggregates o
alamb commented on PR #10645:
URL: https://github.com/apache/datafusion/pull/10645#issuecomment-2131168957
> The gate issue is not related to the PR.. could we rerun?
I restarted it
FYI another trick we have found is if you close the PR and then reopen it,
github will rerun al
advancedxy commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1614516643
##
core/src/execution/datafusion/expressions/scalar_funcs/hex.rs:
##
@@ -0,0 +1,371 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or m
peter-toth commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1614522462
##
datafusion/physical-plan/src/work_table.rs:
##
@@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec {
&self.cache
}
-fn children(&sel
alamb opened a new pull request, #10662:
URL: https://github.com/apache/datafusion/pull/10662
## Which issue does this PR close?
Closes #.
## Rationale for this change
When running `cargo build` locally I see
```
warning:
/Users/andrewlamb/Software/data
peter-toth commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1614522462
##
datafusion/physical-plan/src/work_table.rs:
##
@@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec {
&self.cache
}
-fn children(&sel
peter-toth commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1614522462
##
datafusion/physical-plan/src/work_table.rs:
##
@@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec {
&self.cache
}
-fn children(&sel
alamb commented on PR #10627:
URL: https://github.com/apache/datafusion/pull/10627#issuecomment-2131171739
> If this is the case then there is divergence between postgres and
arrow-rs. Which takes priority?
I would personally suggest we do whatever is consistent with arrow (and
easie
sonhmai commented on PR #470:
URL: https://github.com/apache/datafusion-comet/pull/470#issuecomment-2131173613
@viirya @andygrove can you take a look. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
alamb commented on code in PR #10268:
URL: https://github.com/apache/datafusion/pull/10268#discussion_r1614530863
##
datafusion/sqllogictest/test_files/select.slt:
##
@@ -1473,7 +1473,7 @@ DROP TABLE t;
# related to https://github.com/apache/datafusion/issues/8814
statement
peter-toth commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1614503459
##
datafusion/physical-plan/src/work_table.rs:
##
@@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec {
&self.cache
}
-fn children(&sel
peter-toth commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1614522462
##
datafusion/physical-plan/src/work_table.rs:
##
@@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec {
&self.cache
}
-fn children(&sel
advancedxy commented on code in PR #455:
URL: https://github.com/apache/datafusion-comet/pull/455#discussion_r1614532699
##
spark/src/test/scala/org/apache/comet/CometExpressionCoverageSuite.scala:
##
@@ -217,6 +325,25 @@ class CometExpressionCoverageSuite extends CometTestBase
alamb commented on code in PR #10646:
URL: https://github.com/apache/datafusion/pull/10646#discussion_r1614534288
##
datafusion/substrait/src/variation_const.rs:
##
@@ -37,3 +38,58 @@ pub const DEFAULT_CONTAINER_TYPE_REF: u32 = 0;
pub const LARGE_CONTAINER_TYPE_REF: u32 = 1;
p
alamb merged PR #10657:
URL: https://github.com/apache/datafusion/pull/10657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #10656: Wrong error thrown when unnesting a list of struct
URL: https://github.com/apache/datafusion/issues/10656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
alamb merged PR #10645:
URL: https://github.com/apache/datafusion/pull/10645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #10605: Incorrect statistics read for binary columns in
parquet
URL: https://github.com/apache/datafusion/issues/10605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
alamb commented on code in PR #10655:
URL: https://github.com/apache/datafusion/pull/10655#discussion_r1614536504
##
datafusion/functions/src/core/getfield.rs:
##
@@ -106,6 +106,9 @@ impl ScalarUDFImpl for GetFieldFunc {
};
let access_schema = GetFieldAccessSch
alamb closed issue #10654: Error on `NULL["field_name"]`: The expression to get
an indexed field is only valid for `List`, `Struct`, or `Map` types, got Null
URL: https://github.com/apache/datafusion/issues/10654
--
This is an automated message from the Apache Git Service.
To respond to the m
alamb commented on PR #10655:
URL: https://github.com/apache/datafusion/pull/10655#issuecomment-2131186851
Thank you for the speedy review @jayzhan211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
alamb merged PR #10655:
URL: https://github.com/apache/datafusion/pull/10655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
goldmedal commented on code in PR #10661:
URL: https://github.com/apache/datafusion/pull/10661#discussion_r1614539494
##
datafusion/optimizer/src/push_down_limit.rs:
##
@@ -65,7 +65,6 @@ impl OptimizerRule for PushDownLimit {
};
let Limit { skip, fetch, input
goldmedal commented on code in PR #10661:
URL: https://github.com/apache/datafusion/pull/10661#discussion_r1614539989
##
datafusion/core/src/execution/context/mod.rs:
##
@@ -2893,21 +2893,21 @@ mod tests {
for function in all_default_functions() {
let udf =
goldmedal commented on code in PR #10661:
URL: https://github.com/apache/datafusion/pull/10661#discussion_r1614539989
##
datafusion/core/src/execution/context/mod.rs:
##
@@ -2893,21 +2893,21 @@ mod tests {
for function in all_default_functions() {
let udf =
alamb commented on code in PR #10644:
URL: https://github.com/apache/datafusion/pull/10644#discussion_r1614539590
##
datafusion/functions-aggregate/src/median.rs:
##
@@ -15,71 +15,105 @@
// specific language governing permissions and limitations
// under the License.
-//! #
alamb merged PR #10632:
URL: https://github.com/apache/datafusion/pull/10632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on code in PR #10661:
URL: https://github.com/apache/datafusion/pull/10661#discussion_r1614546056
##
datafusion/core/src/execution/context/mod.rs:
##
@@ -2860,6 +2863,57 @@ mod tests {
Ok(())
}
+#[tokio::test]
+async fn test_register_defau
alamb commented on PR #10661:
URL: https://github.com/apache/datafusion/pull/10661#issuecomment-2131195735
Thank you @goldmedal 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
alamb commented on issue #10639:
URL: https://github.com/apache/datafusion/issues/10639#issuecomment-2131196191
Thanks @jamesmcm -- this would be a good first issue I think for someone
with Rust experience looking to help with DataFusion. The protobuf
serialization code is a bit hairy I fi
alamb commented on issue #10631:
URL: https://github.com/apache/datafusion/issues/10631#issuecomment-2131197268
> I see TaskContext is just part of SessionState. Could we just make
TaskContext wrap SessionState?
I can't remember why TaskContext doesn't wrap SessionState -- maybe
@tu
tustvold commented on issue #10631:
URL: https://github.com/apache/datafusion/issues/10631#issuecomment-2131201943
IIRC SessionConfig is the static configuration used to create a
SessionContext, which is an interior mutable wrapper around SessionState.
The idea was a query is planned
jonahgao merged PR #10662:
URL: https://github.com/apache/datafusion/pull/10662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
alamb opened a new issue, #10663:
URL: https://github.com/apache/datafusion/issues/10663
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9726 to complete the
LogialPlan --> SQL conversion
Converting `LogicalPlan
alamb opened a new issue, #10664:
URL: https://github.com/apache/datafusion/issues/10664
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9726 to complete the
LogialPlan --> SQL conversion
Converting `LogicalPlan
alamb commented on issue #10652:
URL: https://github.com/apache/datafusion/issues/10652#issuecomment-2131211386
> Is there any plan to support them?
I think we should make plans to support them!
I started collecting issues on
https://github.com/apache/datafusion/issues/8661
alamb merged PR #10623:
URL: https://github.com/apache/datafusion/pull/10623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #10623:
URL: https://github.com/apache/datafusion/pull/10623#issuecomment-2131213174
Thanks everyone for the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
alamb commented on issue #2326:
URL: https://github.com/apache/datafusion/issues/2326#issuecomment-2131214534
> I added an issue to support recursive unnest: #10660, i think it shoul
belong to this epic
Added
--
This is an automated message from the Apache Git Service.
To respond t
Abdullahsab3 commented on issue #10602:
URL: https://github.com/apache/datafusion/issues/10602#issuecomment-2131223669
Thanks for filing the ticket and for all the detailed explanations! very
enriching
I wonder whether the Postgres behavior is actually that bad. Though it looks
weird
timsaucer commented on issue #715:
URL:
https://github.com/apache/datafusion-python/issues/715#issuecomment-2131229316
My statement above about testing on rust side is likely incorrect. I ran the
same test above but loading the dataframe from a parquet file instead of
creating in memory an
alamb commented on issue #7306:
URL: https://github.com/apache/datafusion/issues/7306#issuecomment-2131234075
> What do you think we should do? I can add that paragraph, but maybe we
also want to link the examples? What else do you think it's needed to close this
Those both sound like
alamb commented on PR #10650:
URL: https://github.com/apache/datafusion/pull/10650#issuecomment-2131235103
> Maybe we can do the following: Instead of making every
TableProviderFactory responsible for implementing this behavior in create, we
can add some general mechanism at the trait level
alamb commented on PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#issuecomment-2131235504
> This shouldn't have passed checks.
>
> ```
> + cargo fmt --all -- --check
> `cargo metadata` exited with an error: error: failed to load manifest for
workspace member `/o
alamb commented on PR #10640:
URL: https://github.com/apache/datafusion/pull/10640#issuecomment-2131235829
Thanks @Blizzara and @jonahgao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
alamb commented on code in PR #10634:
URL: https://github.com/apache/datafusion/pull/10634#discussion_r1614628009
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -4374,6 +4374,42 @@ GROUP BY dummy
text1, text1, text1
+# Tests for aggregating with NaN values
+
goldmedal commented on PR #10661:
URL: https://github.com/apache/datafusion/pull/10661#issuecomment-2131238078
Thanks, @alamb!
Actually, I tried to add some tests for `MemoryFunctionRegistry` before I
fixed it, but I found everything was fine. I guess the reason is that we don't
inse
jayzhan211 opened a new pull request, #10665:
URL: https://github.com/apache/datafusion/pull/10665
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested
andygrove commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1614638361
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -622,14 +590,89 @@ impl Cast {
self.eval_mode,
from_type,
andygrove commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1614639502
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -622,14 +590,89 @@ impl Cast {
self.eval_mode,
from_type,
andygrove merged PR #716:
URL: https://github.com/apache/datafusion-python/pull/716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
jayzhan211 commented on code in PR #10644:
URL: https://github.com/apache/datafusion/pull/10644#discussion_r1614640283
##
datafusion/functions-aggregate/Cargo.toml:
##
@@ -39,6 +39,7 @@ path = "src/lib.rs"
[dependencies]
arrow = { workspace = true }
+arrow-schema = { workspa
dependabot[bot] opened a new pull request, #717:
URL: https://github.com/apache/datafusion-python/pull/717
Bumps [syn](https://github.com/dtolnay/syn) from 2.0.63 to 2.0.66.
Release notes
Sourced from https://github.com/dtolnay/syn/releases";>syn's
releases.
2.0.66
Al
dependabot[bot] closed pull request #706: build(deps): bump syn from 2.0.63 to
2.0.64
URL: https://github.com/apache/datafusion-python/pull/706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
dependabot[bot] commented on PR #706:
URL:
https://github.com/apache/datafusion-python/pull/706#issuecomment-2131243514
Superseded by #717.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
801 - 900 of 75795 matches
Mail list logo
