codebrainz commented on this pull request.
>
> -DGEANYPY_PYTHON_DIR="\"$(libdir)/geany/geanypy\"" \
-DGEANYPY_PLUGIN_DIR="\"$(libdir)/geany\"" \
codebrainz commented on this pull request.
>
> -DGEANYPY_PYTHON_DIR="\"$(libdir)/geany/geanypy\"" \
-DGEANYPY_PLUGIN_DIR="\"$(libdir)/geany\"" \
One thing, the rest looks good to me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/527#issuecomment-280569305
kugel- commented on this pull request.
>
> -DGEANYPY_PYTHON_DIR="\"$(libdir)/geany/geanypy\"" \
-DGEANYPY_PLUGIN_DIR="\"$(libdir)/geany\"" \
@codebrainz pushed 1 commit.
ea0a634 Fix typo on untested win32 build
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
codebrainz commented on this pull request.
> @@ -62,7 +62,7 @@ Editor_get_property(Editor *self, const gchar *prop_name)
PyObject *py_doc;
py_doc = (PyObject *) Document_create_new_from_geany_document(
Closes #526
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/527
-- Commit Summary --
* Sync with latest upstream
-- File Changes --
M geanypy/geany/Makefile.am (1)
M geanypy/geany/__init__.py (2)
A
After bringing in fixes and a few small changes to reduce diff noise:
https://gist.github.com/codebrainz/990345f4010523a49a9556b3160171f1#file-gpy-gpgpy-after-backports-diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
For `diff -bur geanypy geany-plugins/geanypy` output [see
here](https://gist.github.com/codebrainz/990345f4010523a49a9556b3160171f1).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
[Git Submodules](https://git-scm.com/book/en/v2/Git-Tools-Submodules) FTW!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/526#issuecomment-280541306
> something that other editors use too.
Something other **normal** editors use, vi and emacs don't count :smile:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@Dfred Geany is a _small_ project, the workflow tends to be left to the
contributors, not all of whom are professional programmers following a formal
requirements/design/code process (and even the professionals want a break from
it from time to time), and many changes just turn up as PRs so the
Agreed: the setting resides best in a plugin preference tab. An explicit visual
shouldn't be needed.
Is the mailing list the best place to describe a design feature? Wouldn't a
document such as Python's PIP be more suited? My first guess for this was to
look in the wiki, with no luck.
Design
> Let's finalize the shortcuts! If I were to give a PR I would give shortcuts
> as I'd like
Good, but it shouldn't be something non-standard but rather something that
other editors use too.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
@techee It is not that I don't use geany, but my primary coding editor is Vi
:-)
Let's finalize the shortcuts! If I were to give a PR I would give shortcuts as
I'd like
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Apprently
https://github.com/codebrainz/geanypy/commit/b71408716bda9575c6222113edd1c4b96d4f9765
(and maybe others) was never merged into g-p
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Must be, [upstream doesn't have this
typo](https://github.com/codebrainz/geanypy/blob/master/src/geanypy-document.c#L114).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Looks ok to me, and definitely better than "having half the defaults
`#ifdef`ed" as @b4n put it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1395#issuecomment-280350100
@kugel- @codebrainz Mind having a look? I assume that `Py_RETURN_NONE` here was
a typo or copy-paste error.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/526
-- Commit Summary --
* GeanyPy: fix Document.text_changed
-- File
@elextr Well, explicitly setting `use-underline` doesn’t seem to do any harm,
so I added it. See the updated PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@thewhitetulip That would be great! But don't worry too much if it takes you
too much time and if you don't use Geany anyway.
It depends on what @b4n and others think about #1395 - e.g. the filename can
change etc. But for now you could for example just write a comment #1395 and
paste the
> @elextr Are you sure that’s necessary?
No. But but it certainly didn't work at some point in the past, hence the
workaround in the first place :)
But maybe GTK has "standardised" on an undocumented behaviour of
More in the comment.
Fixes https://github.com/geany/geany/issues/1277
Even if the call gets replaced with something non-blocking in GDK, we can't be
sure against which version of GTK Geany gets built (e.g. if someone is using
Homebrew) so better to handle it in Geany too.
You can view, comment
@elextr
> if it has an option and the default is current behaviour
Of course! I just haven’t yet figured out what this option should look like in
the UI to be understandable.
@codebrainz Do you mean by connecting to `project-open` and then opening my
own set of files? I think that would
@elextr Are you sure that’s necessary? The items [are
created](https://github.com/vfaronov/geany/blob/73476315635faab9a30102956362dce19a39ba1a/src/build.c#L1320)
using
@b4n I was also thinking about this and of users not having access to
internet. We should find a general solution here but for now the patch did
improve things a little IMHO
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
26 matches
Mail list logo
