@kugel-
> Maybe I missed something but on my system it doesn't seem to work. Hitting
> ctrl+f does nothing, wit h either top or bottom options.
What's your system?
> I would accept this only if it can replace the search dialog entirely,
> including replace functionality.
I suggested in https:
Maybe I missed something but on my system it doesn't seem to work. Hitting
ctrl+f does nothing, wit h either top or bottom options. With the "none" option
the dialog appears.
Also, some more opinions from my side:
1) I would accept this only if it can replace the search dialog entirely,
includi
ok, that will do.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2234#issuecomment-518456250
Or just `project_[get|set]_save_open_files_list()` or something. My main gripe
is that "session" is rather ambiguous/overloaded unless you know Geany's
history/internals. And then the doc comments referring to a poorly named
preference which is documented elsewhere, as well as an internal struct
> I meant better names for these new functions, before they're published into
> the API for the first time
Ahh right, `project_(get/set)_save_session_pref()` maybe?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://g
The changes certainly no longer reflect the title of the PR, but it still seems
like useful information.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1690#issuecomment-518441233
> yes, but which plugin features will you choose to make core?
It's actually less "features" than even the builtin project support, let alone
plugins. You just run `geany some/dir` and it takes the directory passed to it
as the base path of the project, and the basename of the directory as the
> new names would be nice, but whilst we keep exposing Geany internals we
> should leave the names the same otherwise we have to change all uses to the
> new name.
You misunderstood me, I meant better names for these **new** functions, before
they're published into the API for the first time, s
IMHO, no, its no longer the simplest, which was the point of my original, its
now TL;DR, but I don't care either way.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1690#issuecomment-5184
@codebrainz sure, new names would be nice, but whilst we keep exposing Geany
internals we should leave the names the same otherwise we have to change all
uses to the new name.
Or a function with a new name that calls the old one and is `inline` in the
`.h` file so it will always be optimised aw
@codebrainz yes, but __which__ plugin features will you choose to make core?
The fact that there is more than one says to me that there isn't agreement on
what those features should be, and then people like me don't have the project
file in the git directory but the one above, that also contains
codebrainz approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2114#pullrequestreview-271015791
@b4n any other feedback? Would you be fine with merging this PR and let
@codebrainz or whoever do the rest later?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2114#issuecomment-51840513
Related to and/or duplicate of #450, #1171,
http://geany-users.466218.n3.nabble.com/Geany-Users-open-folder-td4025296.html
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2245#issuecomme
Ahhh, good catch! Thanks, see 41227a4.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2114#issuecomment-518402783
@eht16 pushed 1 commit.
41227a4084879de554cda8e982229ed788847353 Document new emission of
"project-save" signal
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/2114/files/f7d298846d4f18d358217725ddc4407952e1..4122
Was just browsing the issues and found PR #1222 that I made some years ago
which seems related.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2234#issuecomment-518400366
I stumbled back upon this looking for something else, should it be merged?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1690#issuecomment-518391385
@chrisgraham I fully agree, and have been considering making a pull request to
do this, or least investigating how difficult it would be. Being able to change
into a source directory and type `geany .` and not have fiddle with
making/closing/opening projects would be super handy. SublimeText and
19 matches
Mail list logo