[Github-comments] Re: [geany/geany] Mark tags as "local" only for files with a known C/C++ source extension (PR #3490)

2023-05-08 Thread Colomban Wendling via Github-comments
I'll try to test it properly tomorrow, but the approach, although a bit of a workaround (as it's basically overriding a similar check in uctags), it looks pretty good indeed (esp. with the discussion on the uctags PR). -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Scrolling using Alt+Arrow keys moves cursor when end of visible region is reached (Issue #3489)

2023-05-08 Thread Colomban Wendling via Github-comments
Although @elextr is right that there's nothing actually stating what it really does, it doesn't feel very intuitive nor useful to me as is (I either want the caret to move, or I don't, I rarely don't care). So it's not technically a bug as it behaves just the way the code intends, but it feels

[Github-comments] Re: [geany/geany] Remove obsolete helper scripts (PR #3486)

2023-05-08 Thread Colomban Wendling via Github-comments
I don't use them, and I don't care much. *scripts/fix-alignment.pl* and *scripts/fix-cxx-comments.pl* *look like* they could be useful (basically, poor man's code formatter), but I don't read Perl and didn't use them in ages, if ever. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)

2023-05-08 Thread Colomban Wendling via Github-comments
@cwendling commented on this pull request. I don't know much PHP anymore either, but at least the script seems to still work, the difference seem to be in the JSON itself (I only checked a couple things, but they match). Sadly the JSON seems to have a few flaws with the types in signatures (no

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-05-08 Thread Enrico Tröger via Github-comments
> Seriously though, this is the stuff that kills projects. I am already eyeing > out another open source project. What exactly is this referring to? What should kill the project and why? -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Cannot go to tag if using an unconventional file extension (Issue #3454)

2023-05-08 Thread Jiří Techet via Github-comments
In tag manager, it's called "local", in uctags it's called "isFileScope" (which is a better name). It's those definitions/declarations that are valid only within a single file and which cannot be legally used outside of that file (like static functions for instance). -- Reply to this email

[Github-comments] Re: [geany/geany] Cannot go to tag if using an unconventional file extension (Issue #3454)

2023-05-08 Thread elextr via Github-comments
I'm confused, what does uctags mean by "local"? Its only at C++20 that the concept of "TU local" is formalised but "extern" and "static" have been about since C. Or do they mean "function locals", ie what C++ calls "automatic" and "thread_local"? I presume they don't mean "block locals"

[Github-comments] Re: [geany/geany] [WIP] [D] Switch to mainline ctags parser (PR #3479)

2023-05-08 Thread Nick Treleaven via Github-comments
@ntrel pushed 3 commits. aaaf750eeb6ad019c12c40c0ab5d3518cf10113a Sync templates.d with ctags PR dc8cab25b0b7da8b9ae7d0846b4b63a40dc366a5 backport ctags tweaks d3fa78adb5747a9612261433a817a47566c1366e D: fix parsing parameter with pointer -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Vimode in Geany not working (Issue #1248)

2023-05-08 Thread Jiří Techet via Github-comments
Yeah, I merged all I could from projectorganizer and vimode yesterday ;-) Regarding quality control I think I could have prevented some of the vimode problems before the release if the PRs got merged to master earlier as I didn't notice the issues when I worked on the individual PRs and then

[Github-comments] Re: [geany/geany-plugins] vimode: support some more commands (Issue #1155)

2023-05-08 Thread Jiří Techet via Github-comments
Closed #1155 as completed via #1240. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1155#event-9189824590 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] vimode: implement "iw", "ow", "iW" and "oW" text objects (PR #1240)

2023-05-08 Thread Jiří Techet via Github-comments
Merged #1240 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1240#event-9189824392 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Port "main.py" template to Python3 (PR #3485)

2023-05-08 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. It's a bit more than making it python 3, but LGTM still -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3485#pullrequestreview-1416696377 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode in Geany not working (Issue #1248)

2023-05-08 Thread Colomban Wendling via Github-comments
@frlan could give his opinion, but I agree with @elextr : the plugins themselves are the responsibility of their maintainers, not really @frlan that can't know them all inside out anyway. And as a maintainer, although I am fine with people merging stuff to plugins I maintain when I clearly

[Github-comments] Re: [geany/geany] Cannot go to tag if using an unconventional file extension (Issue #3454)

2023-05-08 Thread Jiří Techet via Github-comments
See #3490 for a possible fix of this issue. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3454#issuecomment-1538244012 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-05-08 Thread Jiří Techet via Github-comments
Closing as this PR is obsoleted by #3490. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3457#issuecomment-1538242734 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-05-08 Thread Jiří Techet via Github-comments
Closed #3457. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3457#event-9189611694 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Mark tags as "local" only for files with a known C/C++ source extension (PR #3490)

2023-05-08 Thread Jiří Techet via Github-comments
After some more thinking about it, we can fix #3454 very easily by ourselves by checking whether the tag originates from a source file with a known/common C/C++ extension - if not, always set local to FALSE. The first patch adds `is_c_source` flag to TMSourceFile to indicate whether the file

[Github-comments] Re: [geany/geany] Add tooltips for goto tag menu items (PR #3467)

2023-05-08 Thread Nick Treleaven via Github-comments
Closed #3467. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3467#event-9189488827 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add tooltips for goto tag menu items (PR #3467)

2023-05-08 Thread Nick Treleaven via Github-comments
Superceded by #3475 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3467#issuecomment-1538225019 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Make Go to Symbol commands show symbol type/signature in list (PR #3475)

2023-05-08 Thread Nick Treleaven via Github-comments
Merged #3475 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3475#event-9189469656 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Scrolling using Alt+Arrow keys moves cursor when end of visible region is reached (Issue #3489)

2023-05-08 Thread elextr via Github-comments
> I thought using Alt + Arrow keys (up, down) should emulate mouse wheel > behaviour Where did you get that impression? I can't find anywhere that exactly defines what that key combination does, but nothing I can find says its a mouse replacement. All the [Geany

[Github-comments] Re: [geany/geany] Scrolling using Alt+Arrow keys moves cursor when end of visible region is reached (Issue #3489)

2023-05-08 Thread pgp via Github-comments
gif attached https://ibb.co/k8RM2tX -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3489#issuecomment-1537984183 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Scrolling using Alt+Arrow keys moves cursor when end of visible region is reached (Issue #3489)

2023-05-08 Thread pgp via Github-comments
Is this intended behaviour? I thought using Alt + Arrow keys (up, down) should emulate mouse wheel behaviour, i.e. NOT move the text cursor, but only the visible region of the text file. This is clearly uncomfortable if we have a text selection greater than the visible region, because in that