[Github-comments] Re: [geany/geany] update czech translation (PR #3595)

2023-10-13 Thread Frank Lanitz via Github-comments
Hi, Why are you removing a bigger number of punctuation? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3595#issuecomment-1762633359 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-13 Thread elextr via Github-comments
@elextr commented on this pull request. > @@ -1785,6 +1786,25 @@ This works basically the same as on other platforms:: "c:\program files\geany\bin\geany" -g c:\mytags.php.tags c:\code\somefile.php +Generating tags files using ctags +* +Geany supports

[Github-comments] Re: [geany/geany] ctags: Matlab: ignore defs within block comments and allow spaces before function defs (PR #3563)

2023-10-13 Thread cousteau via Github-comments
Thanks! I'll see what I can do. I'll start with something that does exactly what their parser does, which shouldn't be hard since I already have the parsing done (although I need to understand how to integrate the parsing function with the rest of ctags, and whether something extra needs to be

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Colomban Wendling via Github-comments
Merged #1280 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1280#event-10648933358 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Change popup not working in git-changebar after updating to Scintilla to 5.3.7 (Issue #1279)

2023-10-13 Thread Colomban Wendling via Github-comments
Closed #1279 as completed via #1280. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1279#event-10648933493 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Colomban Wendling via Github-comments
> It's actually kind of surprising that it works now because > `SCI_POINTXFROMPOSITION` didn't work when I removed `SCI_SETFIRSTVISIBLELINE` > in front of the size request and moved it behind - so > `SCI_POINTXFROMPOSITION` works only for the displayed editor area but in this > case it isn't

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Jiří Techet via Github-comments
> Thanks a lot for debugging this up to that point! Essential plugin, life would be unbearable without it :-). > I somehow didn't notice this until fairly recently, and was puzzled (and > frightened) at what it could be, yet didn't have time to dig in. I was worried it could be some

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM. I don't understand what's actually going on, especially as from my tests it seems to work alright without this for lines <= 182 for me (yes, that feels random). Changes on later lines are stuck starting at line 182… Anyway, this works and shouldn't cause

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -878,6 +878,10 @@ get_widget_for_buf_range (GeanyDocument *doc, MIN (width + 2, alloc.width), MIN (height + 1, alloc.height)); + /* Size request seems to scroll Scintilla view so we

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 9ad218bcdd6f57550bbcc2932c01bc71d89f2316 git-changebar: Re-set first visible line after Scintilla size request -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Spellecheck: Update style mappings (PR #1277)

2023-10-13 Thread Colomban Wendling via Github-comments
> Implicitly require Geany 2.0 for G-P as the SpellCheck plugin makes uses of > new Scintilla API. > > Is this OK? It is, especially as I just merged #1281 which also uses newer API :smile: -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] GitChangebar: disable Scintilla's Change History in diff tooltip (PR #1281)

2023-10-13 Thread Colomban Wendling via Github-comments
Thanks! I didn't see it behave so badly as your screenshot, but it also looks weird if the inline option is enabled, so disabling it altogether in the popup seems the way to go -- and no, we don't need it anyway :) -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] GitChangebar: disable Scintilla's Change History in diff tooltip (PR #1281)

2023-10-13 Thread Colomban Wendling via Github-comments
Merged #1281 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1281#event-10648370202 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. Thanks a lot for debugging this up to that point! I somehow didn't notice this until fairly recently, and was puzzled (and frightened) at what it could be, yet didn't have time to dig in. And now I see you did, yay! I don't see a problem re-asking for the

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -878,6 +878,10 @@ get_widget_for_buf_range (GeanyDocument *doc, MIN (width + 2, alloc.width), MIN (height + 1, alloc.height)); + /* Size request seems to scroll Scintilla view so we

[Github-comments] Re: [geany/geany] ctags: Matlab: ignore defs within block comments and allow spaces before function defs (PR #3563)

2023-10-13 Thread Jiří Techet via Github-comments
@cousteaulecommandant Sorry for the late response :-( If it's not a big problem (and it shouldn't be, you should be able to simulate what the regex parser does), I'd suggest that you update your parser with all features that the universal-ctags regex parser has (otherwise it won't be accepted)

[Github-comments] Re: [geany/geany] Update to Scintilla 4.x (#2519)

2023-10-13 Thread Jiří Techet via Github-comments
Closed #2519 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2519#event-10646868613 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] GitChangebar: disable Scintilla's Change History in diff tooltip (PR #1281)

2023-10-13 Thread Enrico Tröger via Github-comments
If the Change history feature is enabled in Geany, it might lead to styling issues in the tooltip displaying the diff of the current hunk. So always disable this feature for the tooltip where it is not needed. I dont think we ever need the Change history in the diff tooltip, as the tooltip

[Github-comments] Re: [geany/geany] Fix goto popup location (PR #3316)

2023-10-13 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + if (sci_get_line_from_position(sci, pos_next) == line) + char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x; > I went ahead and implemented the more basic version that is similar to what > was there but don't produce

[Github-comments] Re: [geany/geany] Fix meson build without git repo (PR #3597)

2023-10-13 Thread Jiří Techet via Github-comments
Works for me (tested both with and without a git repo) and I think it's cleaner than https://github.com/geany/geany/pull/3578. So I vote for merging this version. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3597#issuecomment-1761550314 You are

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-13 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > case-sensitive. This helps Geany to read the file properly. If this line is missing, Geany tries to auto-detect the used format but this -might fail. +might fail. Tag files using the CTags format should be left unmodified in the OK. -- Reply to

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-13 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -1689,12 +1689,13 @@ Global tags files can have three different formats: * Pipe-separated format * CTags format -The first line of global tags files should be a comment, introduced -by ``#`` followed by a space and a string like ``format=pipe``,

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-13 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -1785,6 +1786,25 @@ This works basically the same as on other platforms:: "c:\program files\geany\bin\geany" -g c:\mytags.php.tags c:\code\somefile.php +Generating tags files using ctags +* +Geany supports