[Github-comments] Re: [geany/geany] Use constructor method calltip only if available (PR #3334)

2023-01-01 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -1886,6 +1867,53 @@ static gchar *find_calltip(const gchar *word, > GeanyFiletype *ft) g_ptr_array_free(constructor_tags, TRUE); } } + return tags; +} + + +static void

[Github-comments] Re: [geany/geany] Use constructor method calltip only if available (PR #3334)

2023-01-01 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -1886,6 +1867,53 @@ static gchar *find_calltip(const gchar *word, > GeanyFiletype *ft) g_ptr_array_free(constructor_tags, TRUE); } } + return tags; +} + + +static void

[Github-comments] Re: [geany/geany] Use constructor method calltip only if available (PR #3334)

2023-01-01 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 1efa45da50dbf5ce2161ff54d8cdcb83d6794fdf Improve naming and function signatures -- View it on GitHub: https://github.com/geany/geany/pull/3334/files/9ae174288c7f9adcf12e212ab234ad7ffeba69c8..1efa45da50dbf5ce2161ff54d8cdcb83d6794fdf You are receiving this because you are

[Github-comments] Re: [geany/geany] Use constructor method calltip only if available (PR #3334)

2022-12-17 Thread Enrico Tröger via Github-comments
Thanks @techee! This was great. I also felt that modifying the tags array is not a good idea but I didn't see why. Thanks. Your suggestion is great, I fine tuned it a bit to not work on `__init__` tags directly (then their scope would be removed) because I needed to remove the scope from the

[Github-comments] Re: [geany/geany] Use constructor method calltip only if available (PR #3334)

2022-12-17 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 9ae174288c7f9adcf12e212ab234ad7ffeba69c8 Use constructor method calltip only if available -- View it on GitHub: https://github.com/geany/geany/pull/3334/files/87ca905615cd99abd05da59656e287bc34e604a6..9ae174288c7f9adcf12e212ab234ad7ffeba69c8 You are receiving this

[Github-comments] Re: [geany/geany] Use constructor method calltip only if available (PR #3334)

2022-12-17 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 87ca905615cd99abd05da59656e287bc34e604a6 Use constructor method calltip only if available -- View it on GitHub: https://github.com/geany/geany/pull/3334/files/e15ed3fe9b8200e0dc69b200f8c20f2ac1663c70..87ca905615cd99abd05da59656e287bc34e604a6 You are receiving this

[Github-comments] Re: [geany/geany-plugins] Update bundled gpgme.m4 (PR #1214)

2022-12-17 Thread Enrico Tröger via Github-comments
Merged #1214 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1214#event-8061739160 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Outdated gpgme.m4 is blocking Debian package migration (Issue #1213)

2022-12-17 Thread Enrico Tröger via Github-comments
Closed #1213 as completed via #1214. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1213#event-8061739187 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Update bundled gpgme.m4 (PR #1214)

2022-12-17 Thread Enrico Tröger via Github-comments
Thanks @hyperair! Tested successfully with the nightly build setup for Windows, Debian Sid and Debian Bullseye. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1214#issuecomment-1356225824 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] CI: Use MSYS2 for Windows build (PR #3315)

2022-12-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 4bdd15c1aa86f916a8dc362c4d09af570c51b344 GH Actions: Replace deprecated "set-output" command -- View it on GitHub: https://github.com/geany/geany/pull/3315/files/30becfd0c152969510490f13e3b42778e74e8d4d..4bdd15c1aa86f916a8dc362c4d09af570c51b344 You are receiving this

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2022-12-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 8e3ec88fbaad0427faa06f675bf0e62c69a6859c GH Actions: Replace deprecated "set-output" command -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1201/files/938187533de3877c93aefb4fe18a2857ec4abb72..8e3ec88fbaad0427faa06f675bf0e62c69a6859c You are

[Github-comments] [geany/infrastructure] Builders: Use the "pacman" package from Debian to avoid building it (PR #8)

2022-12-11 Thread Enrico Tröger via Github-comments
Debian recently added a pacman package and also backported it for Debian Bullseye. So we can use this package instead of building it ourselves. You can view, comment on, or merge this pull request online at: https://github.com/geany/infrastructure/pull/8 -- Commit Summary -- * Builders:

[Github-comments] Re: [geany/geany] Feature request: Hilighting, run external app options (Issue #3307)

2022-12-11 Thread Enrico Tröger via Github-comments
> * Hilighting all matches a selected word/part Already possible with the "Mark all" keybinding and by double clicking on a word with the Addons plugin enabled. > Hilighting every exact match at message when doing "find document usage" Should be possible but need to implemented by

[Github-comments] [geany/geany-plugins] Addons: Fix Wordwrap wrong keybinding use (PR #1212)

2022-12-11 Thread Enrico Tröger via Github-comments
Instead of hardcoding the count of previously defined keybindings in the Addons plugin, use the already available enum counter. While testing #1182, I noticed that there is a mismatch between the pressed keybinding with the configured replacement. The Wordwrap plugin had the keybinding count

[Github-comments] Re: [geany/geany-plugins] Discrepancy between loops in ao_wrapwords.c which might result in potential buffer overflows (Issue #1182)

2022-12-11 Thread Enrico Tröger via Github-comments
Closed #1182 as completed via 6314f9977f2357a1830d366349c403013d0e8eef. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1182#event-8007878770 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2022-12-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 938187533de3877c93aefb4fe18a2857ec4abb72 Remove CRLF text conversion -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1201/files/da9424e7249745ac2292448852dd356df4b0caa0..938187533de3877c93aefb4fe18a2857ec4abb72 You are receiving this because you are

[Github-comments] Re: [geany/geany] CI: Use MSYS2 for Windows build (PR #3315)

2022-12-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 30becfd0c152969510490f13e3b42778e74e8d4d Remove CRLF text conversion -- View it on GitHub: https://github.com/geany/geany/pull/3315/files/4ed3402359d70b0d63afafd62e96945bc95ff6ab..30becfd0c152969510490f13e3b42778e74e8d4d You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany] CI: Use MSYS2 for Windows build (PR #3315)

2022-12-11 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > + log "Signing Geany binary files" + for binary_file_pattern in ${GEANY_RELEASE_BINARY_PATTERNS[@]}; do + for binary_file in $(ls ${binary_file_pattern}); do + sign_file ${binary_file} + done +

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2022-12-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 9 commits. 0baba64ff6f0e128af6ff8dba432bc93ec21dd76 CI: Add Windows build 8f64a5e4d5220dab0a852a38c2d3113e95e4cb33 CI: Upgrade Linux builds to Ubuntu 20.04 f6b8391e29d429da6c59ebe2726fc89b744ab45f Add Geany-Plugins CI build script 48fca75c8b5f7b9509e5758680766d681cb5570b Add

[Github-comments] Re: [geany/geany] CI: Use MSYS2 for Windows build (PR #3315)

2022-12-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 4ed3402359d70b0d63afafd62e96945bc95ff6ab Remove CRLF text conversion -- View it on GitHub: https://github.com/geany/geany/pull/3315/files/47d397e52155d4510452030de3d7a966b29a22dc..4ed3402359d70b0d63afafd62e96945bc95ff6ab You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany] Use constructor method calltip only if available (PR #3334)

2022-12-11 Thread Enrico Tröger via Github-comments
The changes below replace the `__init__` method name on the calltip with its class and so make the calltip look more consistent with the others, as shown in https://github.com/geany/geany/pull/3334#issuecomment-1321212468. ```diff diff --git a/src/editor.c b/src/editor.c index

[Github-comments] Re: [geany/geany] CI: Use MSYS2 for Windows build (PR #3315)

2022-12-04 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 47d397e52155d4510452030de3d7a966b29a22dc Change infrastructure builders branch -- View it on GitHub: https://github.com/geany/geany/pull/3315/files/ef2b6e5039e021b1b5d613eff90996f9c53da709..47d397e52155d4510452030de3d7a966b29a22dc You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2022-12-04 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 75fe1ac709ce54cc40766b974243316143099abe Change infrastructure builders branch -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1201/files/2e6ef9a1967751dabd5216372481a97d7cb06d4c..75fe1ac709ce54cc40766b974243316143099abe You are receiving this because

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-12-04 Thread Enrico Tröger via Github-comments
Merged #7 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/infrastructure/pull/7#event-7948860313 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-12-04 Thread Enrico Tröger via Github-comments
I guess I was waiting for a final "ok" and then forgot about it. Thanks for the review. I fixed a final typo and now it's going to be merged. Yay. -- Reply to this email directly or view it on GitHub: https://github.com/geany/infrastructure/pull/7#issuecomment-1336475400 You are receiving this

[Github-comments] Re: [geany/geany] Feature Request: Preference option for file display size (Issue #3344)

2022-12-04 Thread Enrico Tröger via Github-comments
> I don't know why it is truncated, its lost in the mists of time, maybe one of > the Geany elephants with long memories might know. It was requested a "few" years ago :) https://sourceforge.net/p/geany/bugs/298/ > There are three places that `document_get_pathname_for_display()` is called >

[Github-comments] Re: [geany/geany] How reduce scrolling speed in Geany ? (#2768)

2022-11-30 Thread Enrico Tröger via Github-comments
> > I can scroll neither with mouse wheel nor with trackpoint (didn't try > > touchpad). > > Ahh, ok, needs to set `cLineScroll` to something, maybe remove the #if too, > so the apple code is used for all platforms. Done: only the macOS code path is active. @Gershy @clark713 @kcvinker here is

[Github-comments] Re: [geany/geany] Use constructor method calltip only if available (PR #3334)

2022-11-20 Thread Enrico Tröger
With this PR class tooltips would look like: ![geany_py_calltip_custom_class_original](https://user-images.githubusercontent.com/617017/202919909-22f90ee2-d9ff-4583-872e-b9ac4fba66b0.png)

[Github-comments] Re: [geany/geany-plugins] Add --library=gtk to cppcheck (PR #1197)

2022-11-20 Thread Enrico Tröger
Thanks for the review. I commented on @techee's comment. If you agree, we could merge it then in a few days. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1197#issuecomment-1321180509 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany-plugins] Add --library=gtk to cppcheck (PR #1197)

2022-11-20 Thread Enrico Tröger
@eht16 commented on this pull request. > else new_dir_path = g_build_filename(directory_ref, new_dir, NULL); /* Build the new file list for completion */ completion_list = build_file_list(new_dir_path, new_dir); gtk_entry_completion_set_model (completion,

[Github-comments] Re: [geany/geany-plugins] Add --library=gtk to cppcheck (PR #1197)

2022-11-19 Thread Enrico Tröger
@elextr @techee @kugel- anyone for review? I guess we all agree that we want a succeeding CI again :). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1197#issuecomment-1320873119 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] CI: Use MSYS2 for Windows build (PR #3315)

2022-11-19 Thread Enrico Tröger
@eht16 commented on this pull request. > + log "Signing Geany binary files" + for binary_file_pattern in ${GEANY_RELEASE_BINARY_PATTERNS[@]}; do + for binary_file in $(ls ${binary_file_pattern}); do + sign_file ${binary_file} + done +

[Github-comments] Re: [geany/geany] Use constructor method calltip only if available (PR #3334)

2022-11-19 Thread Enrico Tröger
> > Hmm, this would add an **init** tag for each class in the generated tags > > file only to satify this special logic for Python (and D). > > True, but this is how the command-line ctags works. And it also works this > way for user-written code. So for > > ``` > MyClass( > ``` > > you get

[Github-comments] Re: [geany/geany-plugins] cppcheck throws error - warning: There is an unknown macro here somewhere G_DEFINE_TYPE (Issue #1196)

2022-11-15 Thread Enrico Tröger
> Maybe is there a way to provide our own cppcheck config file where we define > what we need? What a great idea, it's green! https://github.com/geany/geany-plugins/pull/1197/checks Thanks for the input, replacing the GTK library configuration with a custom one with only a few macros, worked

[Github-comments] Re: [geany/geany-plugins] Add --library=gtk to cppcheck (PR #1197)

2022-11-15 Thread Enrico Tröger
@eht16 commented on this pull request. > @@ -4,6 +4,7 @@ if HAVE_CPPCHECK check-cppcheck: $(srcdir) $(CPPCHECK) \ -q --template gcc --error-exitcode=2 \ + --library=$(top_srcdir)/build/cppcheck-geany-plugins.cfg \ Is `$top_srcdir` correct here? -- Reply

[Github-comments] Re: [geany/geany-plugins] Add --library=gtk to cppcheck (PR #1197)

2022-11-15 Thread Enrico Tröger
@eht16 pushed 1 commit. 90ee71202eacb920d51c42469e7d88544637e066 Use a custom library configuration for cppcheck to define unknown macros -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Add --library=gtk to cppcheck (PR #1197)

2022-11-15 Thread Enrico Tröger
@eht16 pushed 4 commits. d965a59f7fc20b6ece976dea4be0c58306d7ad26 Add --library=gtk to cppcheck c496bb4cf6831f88ce08f9809d562d5fe3fc5294 Fix memory leaks reported by cppcheck 849b523fa206d8c503550d4cf4d53e88e77901e9 Fix resp. ignore memory leaks reported by cppcheck

[Github-comments] Re: [geany/geany] Use constructor method calltip only if available (PR #3334)

2022-11-15 Thread Enrico Tröger
> I think the code shouldn't hurt anything but I don't think real ctags (unlike > the tag generation script) adds parameters to class tags and leaves them only > in the constructor methods. So I think it would be better to rather simulate > the ctags behavior in the script so this code wouldn't

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2022-11-15 Thread Enrico Tröger
> > Classes found by ctags have no signature (the one of the corrsponding > > **init** method) while the ones of my script have > > Curious about this one - how does it behave when there are multiple > corresponding `__init__` functions with a different signature? Will it pick > just one of

[Github-comments] Re: [geany/geany-plugins] cppcheck throws error - warning: There is an unknown macro here somewhere G_DEFINE_TYPE (Issue #1196)

2022-11-13 Thread Enrico Tröger
Sigh, the old cppcheck version in the CI doesn't seem to respect the inline suppressions :(. In #1201 we switched the CI system to Ubuntu 20.04. Should I cherry-pick the commit https://github.com/geany/geany-plugins/pull/1201/commits/de6304c5d63a9b5902313695b56bc0b8d15f4510 into here? --

[Github-comments] Re: [geany/geany-plugins] cppcheck throws error - warning: There is an unknown macro here somewhere G_DEFINE_TYPE (Issue #1196)

2022-11-13 Thread Enrico Tröger
> Either my testing is wrong or cppcheck ignores these macros. cppcheck seems to test with different combinations of preprocessor macros. See https://cppcheck.sourceforge.io/manual.html#preprocessor-settings. However, I still don't understand why it always chokes on the `argv` array. For now, I

[Github-comments] Re: [geany/geany-plugins] Add --library=gtk to cppcheck (PR #1197)

2022-11-13 Thread Enrico Tröger
@eht16 commented on this pull request. > @@ -347,7 +348,7 @@ static void gdb_finalize(void) if (send_channel) { g_io_channel_shutdown(send_channel, FALSE, NULL); - g_io_channel_unref(send_channel); + g_io_channel_unref(send_channel);

[Github-comments] Re: [geany/geany-plugins] Add --library=gtk to cppcheck (PR #1197)

2022-11-13 Thread Enrico Tröger
@eht16 commented on this pull request. > @@ -377,7 +381,10 @@ static gchar *pastebin_get_language(const Pastebin > *pastebin, gchar *lang = g_key_file_get_string(pastebin->config, PASTEBIN_GROUP_LANGUAGES, geany_ft_name, NULL); -return lang

[Github-comments] Re: [geany/geany-plugins] Add --library=gtk to cppcheck (PR #1197)

2022-11-13 Thread Enrico Tröger
@eht16 commented on this pull request. > @@ -102,6 +102,10 @@ PLUGIN_SET_TRANSLATABLE_INFO(LOCALEDIR, GETTEXT_PACKAGE, > PLUGIN_NAME, PLUGIN_VERSION, "Enrico Trotta ") +static void show_msgbox(GtkMessageType type, GtkButtonsType buttons, This is to trick

[Github-comments] Re: [geany/geany-plugins] Add --library=gtk to cppcheck (PR #1197)

2022-11-13 Thread Enrico Tröger
@eht16 pushed 1 commit. d1d631a9bcc644d6453f0da6805a852c0f543ab0 Fix resp. ignore memory leaks reported by cppcheck -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1197/files/38940c4341178e4ac09d4c1422d94d2c47c270f9..d1d631a9bcc644d6453f0da6805a852c0f543ab0 You are receiving

[Github-comments] Re: [geany/geany-plugins] Add --library=gtk to cppcheck (PR #1197)

2022-11-13 Thread Enrico Tröger
@eht16 pushed 9 commits. 4eca3fe1073b15addf1805f024a7cddae7a950b6 git-changebar: Simplify libgit2 version checks c25006972ce897a1ed446e56584d1fb316378d5a git-changebar: Add support for libgit2 1.4 4b49d2dd6742bc3c8820ea0b5f23554357633245 git-changebar: Avoid harmless warnings

[Github-comments] Re: [geany/geany] preview mode? or say an editor tab for impersistently showing a file in R/O mode (Issue #3327)

2022-11-13 Thread Enrico Tröger
What kind of answer do you expect? An amount of hours? Relative to another feature? It highly depends on how it will be implemented and also how experienced the person implementing it is. I saw this feature in VSCode at colleagues and it made me cry mentally. At least if not implemented

[Github-comments] [geany/geany] Use constructor method calltip only if available (PR #3334)

2022-11-13 Thread Enrico Tröger
For D and Python, we try to read the calltip from the constructor method (e.g. __init__ for Python) instead of from the class tag itself. If we dont find a matching constructor method tag, now we continue looking at the class tag itself. This is useful for global tags where the constructor

[Github-comments] Re: [geany/geany] CI: Use MSYS2 for Windows build (PR #3315)

2022-11-13 Thread Enrico Tröger
@eht16 commented on this pull request. > + sed -i -E "s/^!define PRODUCT_VERSION_ID \"@VERSION@.0.0\"/!define > PRODUCT_VERSION_ID \"${MAJOR}.${MINOR}.${PATCH}.90\"/" > ${GEANY_BUILD_DIR}/geany.nsi.in +} + + +build_geany() { + cd ${GEANY_BUILD_DIR} + log "Running autogen.sh" +

[Github-comments] Re: [geany/geany] CI: Use MSYS2 for Windows build (PR #3315)

2022-11-13 Thread Enrico Tröger
> Can you add a stub with an (perhaps commented out) example on how to build > new dependencies for CI builds? I don't get it :(. Where should I add the example and what do you mean by "build new dependencies"? -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Add mingw-w64 (Windows) CI build (PR #1201)

2022-11-13 Thread Enrico Tröger
@eht16 pushed 1 commit. 2e6ef9a1967751dabd5216372481a97d7cb06d4c Remove unnecessary directory changes -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1201/files/bbbee5b915604c3148cf32e5623c2b1312dfdc6a..2e6ef9a1967751dabd5216372481a97d7cb06d4c You are receiving this because

[Github-comments] Re: [geany/geany] CI: Use MSYS2 for Windows build (PR #3315)

2022-11-13 Thread Enrico Tröger
@eht16 pushed 1 commit. ef2b6e5039e021b1b5d613eff90996f9c53da709 Remove unnecessary directory changes -- View it on GitHub: https://github.com/geany/geany/pull/3315/files/94b6e948360cd7a6bcc1dbe2e52a12ec737fda5e..ef2b6e5039e021b1b5d613eff90996f9c53da709 You are receiving this because you are

[Github-comments] Re: [geany/geany] CI: Use MSYS2 for Windows build (PR #3315)

2022-11-13 Thread Enrico Tröger
@eht16 commented on this pull request. > + -ts http://zeitstempel.dfn.de/ \ + -h sha512 \ + -in ${1} \ + -out ${1}-signed + mv ${1}-signed ${1} + else + echo "Skip signing due

[Github-comments] Re: [geany/geany] CI: Use MSYS2 for Windows build (PR #3315)

2022-11-13 Thread Enrico Tröger
@eht16 commented on this pull request. > + log "Signing Geany binary files" + for binary_file_pattern in ${GEANY_RELEASE_BINARY_PATTERNS[@]}; do + for binary_file in $(ls ${binary_file_pattern}); do + sign_file ${binary_file} + done +

[Github-comments] Re: [geany/geany-plugins] TreeBrowser: Fix refresh from popup menu with a selected file (PR #1195)

2022-11-13 Thread Enrico Tröger
Merged #1195 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1195#event-7798356676 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] [Tree Browser ] Refresh is not working (Issue #1194)

2022-11-13 Thread Enrico Tröger
Closed #1194 as completed via #1195. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1194#event-7798356732 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] treebrowser issue: Open externally and Open Terminal don't work on Windows 10 (#556)

2022-11-13 Thread Enrico Tröger
Closed #556 as completed via #973. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/556#event-7798356244 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] TreeBrowser: Port spawning external commands to the spawn API (#973)

2022-11-13 Thread Enrico Tröger
Merged #973 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/973#event-7798356222 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add soft keywords to Python keyword list (PR #3277)

2022-11-13 Thread Enrico Tröger
Merged #3277 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3277#event-7798342596 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Filedef for Python missing "match" and "case" (Issue #3263)

2022-11-13 Thread Enrico Tröger
Closed #3263 as completed via #3277. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3263#event-7798342612 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add option to only show line endings if they differ from file default (PR #3287)

2022-11-13 Thread Enrico Tröger
Merged #3287 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3287#event-7798341396 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2022-11-13 Thread Enrico Tröger
> > I followed your suggestion and changed the output format of the tags file > > to ctags. > > Well, it isn't something I'm one hundred percent sure we should do, but > rather something I wanted to discuss. Also, I had something different in mind > - to use `ctags` directly to generate the

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2022-11-13 Thread Enrico Tröger
@eht16 pushed 3 commits. a4d49ce4d82040109168b995f76638c3e81a39eb Do not set the base class as parent erroneously in tags 6e326ffc904e42ac4fff21794f2225701e1e8da0 Use kind "member" for methods 0546fef7d1eb4fe35a6fe0e4e3ce979f681f9522 Update docs, ignored modules and classes to Python 3.11

[Github-comments] Re: [geany/geany] Restore startup behavior to focus files from the command line after session files (PR #3267)

2022-10-30 Thread Enrico Tröger
Looks fine. The notebook page is properly saved and restored across Geany restarts, also for projects, even independently. Great. While testing I noticed one minor issue though I'm not sure whether it's new or not: when I close a project, the previous session is restored but the "current_page"

[Github-comments] Re: [geany/geany] Skip activating last active page from session when opening cli files (PR #3318)

2022-10-30 Thread Enrico Tröger
@kugel- your implementation seems better to me, so let's close this in favor of your one. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3318#issuecomment-1296300598 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Skip activating last active page from session when opening cli files (PR #3318)

2022-10-30 Thread Enrico Tröger
Closed #3318. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3318#event-7699403542 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-ev-charter] Update charter for online general assemblies (PR #2)

2022-10-29 Thread Enrico Tröger
@eht16 pushed 1 commit. e5d9bcc6f15435ff83ac4df48e72c11f7cc25e29 Revert date change and improve wording -- View it on GitHub: https://github.com/geany/geany-ev-charter/pull/2/files/f1476da107a373061114515104854f014e6ecbf6..e5d9bcc6f15435ff83ac4df48e72c11f7cc25e29 You are receiving this because

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-27 Thread Enrico Tröger
@kugel- are you fine when I squash the commits together or do you still need the history? -- Reply to this email directly or view it on GitHub: https://github.com/geany/infrastructure/pull/7#issuecomment-1294204226 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-27 Thread Enrico Tröger
@eht16 pushed 1 commit. 2d9af0c771bd64254fd62fb368f7f44923d04daa Enable pipeline on push and schedule -- View it on GitHub: https://github.com/geany/infrastructure/pull/7/files/77f945c0de8a01bc40f44fde3cf26707205de2fc..2d9af0c771bd64254fd62fb368f7f44923d04daa You are receiving this because you

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-27 Thread Enrico Tröger
@eht16 commented on this pull request. > + +RUN set -ex && \ +apt-get update && \ +apt-get install --no-install-recommends --assume-yes \ +build-essential meson wget xz-utils zstd gnupg2 file zstd ca-certificates \ +pkg-config m4 libarchive-dev libssl-dev libcurl4-gnutls-dev

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-27 Thread Enrico Tröger
@eht16 pushed 1 commit. 77f945c0de8a01bc40f44fde3cf26707205de2fc Use ldconfig to update ldcache -- View it on GitHub: https://github.com/geany/infrastructure/pull/7/files/fa386a7474bf8561b6cb3724ec8fe2a4c68271e6..77f945c0de8a01bc40f44fde3cf26707205de2fc You are receiving this because you are

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2022-10-27 Thread Enrico Tröger
I followed your suggestion and changed the output format of the tags file to ctags. In my tests the tags worked but I don't know the format that well, so it would be cool if you could spend a look at it, @techee. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Rewrite Python standard library tags creation script for Python 3 (PR #3039)

2022-10-27 Thread Enrico Tröger
@eht16 pushed 2 commits. 916cefdc04684568bab968085551e337b2afdea1 Remove unused code c1387f831dc24eb58fa228839cd1de19dfacaeff Change the generated tags file to ctags format -- View it on GitHub:

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-27 Thread Enrico Tröger
@eht16 commented on this pull request. > + +RUN set -ex && \ +apt-get update && \ +apt-get install --no-install-recommends --assume-yes \ +build-essential meson wget xz-utils zstd gnupg2 file zstd ca-certificates \ +pkg-config m4 libarchive-dev libssl-dev libcurl4-gnutls-dev

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-27 Thread Enrico Tröger
@eht16 commented on this pull request. > + +RUN set -ex && \ +apt-get update && \ +apt-get install --no-install-recommends --assume-yes \ +build-essential meson wget xz-utils zstd gnupg2 file zstd ca-certificates \ +pkg-config m4 libarchive-dev libssl-dev libcurl4-gnutls-dev

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-27 Thread Enrico Tröger
@eht16 commented on this pull request. > + COMPILER_VERSION=$(gcc -dumpfullversion) + + echo "Debian Distribution : $(grep PRETTY_NAME /etc/os-release | cut -d '=' -f 2)" + echo "Geany version: ${GEANY_VERSION}" + echo "Geany GIT revision :

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-27 Thread Enrico Tröger
@eht16 commented on this pull request. > + create_tarball_for_debuild + + git_clone_debian_geany + install_build_dependencies + add_changelog_entry + + build_package + copy_results + + log_and_store_build_environment + + log "Done." +} + + +main

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-27 Thread Enrico Tröger
@eht16 pushed 2 commits. 9727d956fc284077df99c9aa41560c9e842707b7 Remove Debian parts as these are still in WIP fa386a7474bf8561b6cb3724ec8fe2a4c68271e6 Install pacman into /usr/local -- View it on GitHub:

[Github-comments] [geany/geany-ev-charter] Update charter for online general assemblies (PR #2)

2022-10-26 Thread Enrico Tröger
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-ev-charter/pull/2 -- Commit Summary -- * Update charter for online general assemblies -- File Changes -- M satzung.pdf (0) M satzung.tex (17) -- Patch Links --

[Github-comments] Re: [geany/geany] File specified on command line not becoming active when session is loaded (Issue #3136)

2022-10-23 Thread Enrico Tröger
I don't remember exactly but there definetely a good reason. Maybe postponing it to wait for other GUI components to be initialized and only then switch the active document once so all other widgets (e.g. symbol tree and similar) are up to date. https://github.com/geany/geany/pull/3318 tries

[Github-comments] [geany/geany] Skip activating last active page from session when opening cli files (PR #3318)

2022-10-23 Thread Enrico Tröger
Closes #3136. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3318 -- Commit Summary -- * Skip activating last active page from session when opening cli files -- File Changes -- M src/keyfile.c (8) M src/keyfile.h (4) M

[Github-comments] Re: [geany/geany] WIP: Add script checking our unit test coverage of the mapped kinds (PR #3182)

2022-10-23 Thread Enrico Tröger
Cool! LGTM. Maybe we could add parts of the PR's description to the script itself to explain what it is doing and what the output means. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3182#issuecomment-1288108546 You are receiving this because you are

[Github-comments] Re: [geany/geany] Add soft keywords to Python keyword list (PR #3277)

2022-10-23 Thread Enrico Tröger
If there won't be objections, I'll merge this in a few days. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3277#issuecomment-1288104231 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] TreeBrowser: Port spawning external commands to the spawn API (#973)

2022-10-23 Thread Enrico Tröger
Since this has been confirmed working in https://github.com/geany/geany-plugins/issues/1194#issuecomment-1279998807, I would like to merge this in a few days. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/973#issuecomment-1288103770 You are

[Github-comments] Re: [geany/geany-plugins] TreeBrowser: Fix refresh from popup menu with a selected file (PR #1195)

2022-10-23 Thread Enrico Tröger
Since this has been confirmed working in https://github.com/geany/geany-plugins/issues/1194#issuecomment-1279998807, I would like to merge this in a few days. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1195#issuecomment-1288103804 You are

[Github-comments] Re: [geany/geany] Fix goto popup location (PR #3316)

2022-10-23 Thread Enrico Tröger
@eht16 commented on this pull request. > @@ -1404,90 +1404,10 @@ static guint get_tag_class(const TMTag *tag) } -/* positions a popup at the caret from the ScintillaObject in @p data */ -static void goto_popup_position_func(GtkMenu *menu, gint *x, gint *y, gboolean *push_in, gpointer

[Github-comments] Re: [geany/geany] Fix goto popup location (PR #3316)

2022-10-23 Thread Enrico Tröger
@eht16 commented on this pull request. > { - /* Use appropriate function for menu popup: - - gtk_menu_popup_at_pointer is not available on GTK older than 3.22 - - gtk_menu_popup is deprecated and causes issues on multimonitor wayland setups */ -#if

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-23 Thread Enrico Tröger
> > I think the current restrictions are OK. Perhaps we could auto-update the > > image based on CI but I wouldn't trigger that from Geany repos but this > > repository (this is where the dockerfile is after all). > > Sounds good to me. I added a CI workflow on this repository to build the

[Github-comments] Re: [geany/geany] CI: Use MSYS2 for Windows build (PR #3315)

2022-10-22 Thread Enrico Tröger
@eht16 commented on this pull request. > + log "Signing Geany binary files" + for binary_file_pattern in ${GEANY_RELEASE_BINARY_PATTERNS[@]}; do + for binary_file in $(ls ${binary_file_pattern}); do + sign_file ${binary_file} + done +

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-22 Thread Enrico Tröger
@eht16 commented on this pull request. > + PACKAGE_VERSION="${GEANY_VERSION}-1~$(date > '+%Y%m%d')git${GEANY_GIT_REVISION}" +} + + +run_autogen_sh() { + log "Run ./autogen.sh" + cd ${GEANY_BUILD_DIR} + # run ./autogen.sh as the Debian package won't run ./autogen.sh for us

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-22 Thread Enrico Tröger
@eht16 commented on this pull request. > +#!/bin/bash +# +# Copyright 2022 The Geany contributors +# License: GPLv2 +# +# Create a Debian repository for the Debian distribution +# requested in the environment variable ${DISTRO}. +# The repository will be signed with the GnuPG key as found +# in

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-22 Thread Enrico Tröger
@eht16 pushed 1 commit. 5fa145ae657a0e697ca1bab9e29ca82846d4c8aa Fix wrong tarball name and update codename for Debian stable -- View it on GitHub: https://github.com/geany/infrastructure/pull/7/files/d434dc4383327c9de4daf1e19ead64fdc3a1ec3c..5fa145ae657a0e697ca1bab9e29ca82846d4c8aa You are

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-22 Thread Enrico Tröger
@eht16 commented on this pull request. > + create_tarball_for_debuild + + git_clone_debian_geany + install_build_dependencies + add_changelog_entry + + build_package + copy_results + + log_and_store_build_environment + + log "Done." +} + + +main

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-22 Thread Enrico Tröger
@eht16 commented on this pull request. > + COMPILER_VERSION=$(gcc -dumpfullversion) + + echo "Debian Distribution : $(grep PRETTY_NAME /etc/os-release | cut -d '=' -f 2)" + echo "Geany version: ${GEANY_VERSION}" + echo "Geany GIT revision :

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-22 Thread Enrico Tröger
@eht16 commented on this pull request. > +libcurl3-gnutls libgpgme11 libarchive13 libssl1.1 \ +# common useful utilities \ +wget curl less nano git gnupg2 file ca-certificates dos2unix \ +zip unzip xz-utils zstd \ +# build tools \ +build-essential automake autoconf

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-22 Thread Enrico Tröger
@eht16 commented on this pull request. > +python3-lxml python3-docutils + + +# copy pacman and scripts +COPY --from=build-pacman /windows /windows +COPY --from=build-pacman /usr/local/pacman /usr/local/pacman +COPY mingw64/bin/ /usr/local/bin/ +RUN ln -s /usr/local/pacman/bin/*

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-22 Thread Enrico Tröger
@eht16 commented on this pull request. > + +RUN set -ex && \ +apt-get update && \ +apt-get install --no-install-recommends --assume-yes \ +build-essential meson wget xz-utils zstd gnupg2 file zstd ca-certificates \ +pkg-config m4 libarchive-dev libssl-dev libcurl4-gnutls-dev

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-17 Thread Enrico Tröger
@eht16 pushed 1 commit. 6a3b28232993cacca9fa411dcc4733501d14f039 CI: Add workflow to build geany-mingw64-ci Docker image -- View it on GitHub: https://github.com/geany/infrastructure/pull/7/files/6241c776bee06fa520ea0480ce3db7d0fe339852..6a3b28232993cacca9fa411dcc4733501d14f039 You are

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-17 Thread Enrico Tröger
@eht16 pushed 1 commit. 6241c776bee06fa520ea0480ce3db7d0fe339852 CI: Add workflow to build geany-mingw64-ci Docker image -- View it on GitHub: https://github.com/geany/infrastructure/pull/7/files/7f07a62e42326f0a7b96facfeb5c3fd6a02b1f59..6241c776bee06fa520ea0480ce3db7d0fe339852 You are

[Github-comments] Re: [geany/infrastructure] Add nightly and CI build scripts to create Windows installers (PR #7)

2022-10-17 Thread Enrico Tröger
@eht16 pushed 1 commit. 7f07a62e42326f0a7b96facfeb5c3fd6a02b1f59 CI: Add workflow to build geany-mingw64-ci Docker image -- View it on GitHub: https://github.com/geany/infrastructure/pull/7/files/b24701987e4b03a896956741a7f906b4e82b37d0..7f07a62e42326f0a7b96facfeb5c3fd6a02b1f59 You are

<    2   3   4   5   6   7   8   9   10   11   >