[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-07-10 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + gboolean (*goto_perform)(GeanyDocument *doc, gint pos, gboolean > definition, gpointer data); + + /** +* Pointer to function called by Geany to check whether the plugin implements +* additional symbol (e.g. type) highlightin

[Github-comments] Re: [geany/geany-plugins] Make updatechecker plugin for MacOS (Issue #1314)

2024-07-08 Thread Jiří Techet via Github-comments
> @techee if you release a bugfix maybe you need to version it 2.0-1 like > Ubuntu does with its packages. Not sure it the plugin needs updating to > handle that. Yes, but how to get this version "inside" the package so the updatechecker plugin knows it's 2.0-1 and can compare it with what the

[Github-comments] Re: [geany/geany-plugins] Make updatechecker plugin for MacOS (Issue #1314)

2024-07-07 Thread Jiří Techet via Github-comments
@eht16 OK (especially if you plan to have the Geany web site static). For macOS and Windows we'd have to decide how to detect the updated installer - let's say I make a new macOS release now with updated GTK fixing some bug - the version will still be 2.0 and the only other thing I see we could

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-07-07 Thread Jiří Techet via Github-comments
@LiquidCake Thanks for the updates! I definitely like that the temp files are preserved across project opens/closes and it seems to work very well for me. Some more observations when playing with the feature: - when closing a temp file and choosing "Save", I'd suggest using some other default di

[Github-comments] Re: [geany/geany] Fix some runtime warnings (PR #3921)

2024-07-07 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 8056d620bc067d153197ae5b4b5fae00163c711a Fix open document check in document_get_from_page() -- View it on GitHub: https://github.com/geany/geany/pull/3921/files/a8c86ae122bab83e17b089baacec1994009d4dff..8056d620bc067d153197ae5b4b5fae00163c711a You are receiving this b

[Github-comments] Re: [geany/geany] Fix some runtime warnings (PR #3921)

2024-07-06 Thread Jiří Techet via Github-comments
Couldn't resist ;-) The check here https://github.com/geany/geany/blob/9bf5769f582cbf3d82a1faca035e7f63e8908afe/src/document.c#L356 isn't right, is it? `documents_array->len` isn't the number of currently open documents - all of them could be invalid (which happens after closing a session). It

[Github-comments] Re: [geany/geany] Fix some runtime warnings (PR #3921)

2024-07-06 Thread Jiří Techet via Github-comments
> I'm a tad worried about the second commit where the document_array doesn't > seem to match the notebook content… I'll try and have a quick look whenever I > can to see if the deeper cause isn't too problematic (unless you beat me to > it 😉 😉 ) Just a preliminary analysis. First, the stack tr

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-07-02 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + gboolean (*goto_perform)(GeanyDocument *doc, gint pos, gboolean > definition, gpointer data); + + /** +* Pointer to function called by Geany to check whether the plugin implements +* additional symbol (e.g. type) highlightin

[Github-comments] [geany/geany] Fix some runtime warnings (PR #3921)

2024-07-02 Thread Jiří Techet via Github-comments
For details, check the individual commit messages. I suspect this is a result of https://github.com/geany/geany/pull/3891 and some different timings of when the affected functions get called. I haven't investigated the exact reasons, the extra added checks are probably just fine. You can view, c

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-06-30 Thread Jiří Techet via Github-comments
I've updated this PR to use https://github.com/geany/geany/pull/3916. What's still missing is updating the required Geany API once we bump it in Geany. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1341#issuecomment-2198664923 You are receiving

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-06-30 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 52ad718c2a847c145781d8b0750984e4f713364e Use newly introduced Geany API to access symbol icons -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1341/files/4e9eb962e79cca3b0939f41729536d75aafa334e..52ad718c2a847c145781d8b0750984e4f713364e You are receiv

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-30 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + gboolean (*goto_perform)(GeanyDocument *doc, gint pos, gboolean > definition, gpointer data); + + /** +* Pointer to function called by Geany to check whether the plugin implements +* additional symbol (e.g. type) highlightin

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-30 Thread Jiří Techet via Github-comments
> I'd like > https://github.com/geany/geany/commit/d34a0a36e761cb2844ae50ffaceaee18fee0d348 > (and its fix(es?)) be separate; for the rest it's your call. I'd keep the > same separation as you initially did and squash the changes, but if it > becomes too complicated you can also just squash the

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-30 Thread Jiří Techet via Github-comments
@techee pushed 9 commits. 52295a212df524b89808222d60478577940ccc1b Add interface used by plugins to replace some Geany functionality with their own implementation f115ec2ac883f4ef5a658372e70a289a215d8dff Add Geany code delegating autocompletion to plugins 9dda177389b276f6846394af9f82c4b3f09f13

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-29 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + * + * Then copy or symlink the plugins/demopluginext.so file to ~/.config/geany/plugins + * - it will be loaded at next startup. + */ + +#include + +static gboolean autocomplete_provided(GeanyDocument *doc, gpointer data) +{ +return doc->file_typ

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-29 Thread Jiří Techet via Github-comments
> Minor nitpicks, but looks pretty good now I'd say 👍 @b4n If it's kind of alright, what should I do now - squash into a single commit or try to preserve the history and squash just the various fixes? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3849

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-29 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + Geany built-in functionality. + +When the plugin returns @c TRUE from the function assigned to the @c _provided +member of @c PluginExtension, it indicates +it wants to take control of the particular feature and disable Geany's +implementation. Howev

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-29 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 53a16a2ce0d8d58107c8dd8d3d4ad27013421f9e Add clarification to plugins.dox -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/036ef8e8ead976f52b842c760fb81bbcdb8c51b9..53a16a2ce0d8d58107c8dd8d3d4ad27013421f9e You are receiving this because you are subsc

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-29 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + * cd plugins + * make demopluginext.so I basically just copied this from `demoplugin.c`. So we should either modify both or leave them as they are - IMO it doesn't matter much, I imagine someone would just copy/paste the code from here to their own

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-29 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 036ef8e8ead976f52b842c760fb81bbcdb8c51b9 Update src/pluginextension.c -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/c72f22bd6cf3563f72f9f088fbd538dcfd0381a7..036ef8e8ead976f52b842c760fb81bbcdb8c51b9 You are receiving this because you are subscribe

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-29 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. c72f22bd6cf3563f72f9f088fbd538dcfd0381a7 Update src/pluginextension.c -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/ec9365127e980d81656f1c5184388ae80ddd7945..c72f22bd6cf3563f72f9f088fbd538dcfd0381a7 You are receiving this because you are subscribe

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-29 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. ec9365127e980d81656f1c5184388ae80ddd7945 Update src/pluginextension.c -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/f5da5508c2c4fe5cf6557f4769e93e590b9397b5..ec9365127e980d81656f1c5184388ae80ddd7945 You are receiving this because you are subscribe

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-29 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + * + * Then copy or symlink the plugins/demopluginext.so file to ~/.config/geany/plugins + * - it will be loaded at next startup. + */ + +#include + +static gboolean autocomplete_provided(GeanyDocument *doc, gpointer data) +{ +return doc->file_typ

[Github-comments] Re: [geany/geany] Export some types/functions so plugins have access to Geany symbol icons (PR #3916)

2024-06-29 Thread Jiří Techet via Github-comments
Merged #3916 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3916#event-13339498997 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Make updatechecker plugin for MacOS (Issue #1314)

2024-06-28 Thread Jiří Techet via Github-comments
My thinking is that if we make a bug in the plugin's update logic, we'll have to make a new release to fix it while we can update the server's code any time without any release and it also offers more flexibility in case we need to change something in the future. -- Reply to this email directl

[Github-comments] Re: [geany/geany-plugins] Make updatechecker plugin for MacOS (Issue #1314)

2024-06-27 Thread Jiří Techet via Github-comments
> Yeah, then it can reply: > 2.1.0 > Macos 2.1.0.1 > Windows 2.0.0. I was actually thinking the plugin would send e.g. ``` platform: macOS version: 2.0.0 build_date: 2024-06-21 ``` and the server would only reply `TRUE` or `FALSE` based on whether the update is available for the given platfor

[Github-comments] Re: [geany/geany-plugins] Make updatechecker plugin for MacOS (Issue #1314)

2024-06-27 Thread Jiří Techet via Github-comments
I managed to get the update checker plugin running (didn't really do anything, it started working with the latest library versions from gtk-osx). So I might add it to the next macOS release. > I thought I had seen @techee make bugfix builds on the geany-osx repository, > I guess if they get upl

[Github-comments] Re: [geany/geany] Geany does not use native "file opener" for Mac (#1310)

2024-06-27 Thread Jiří Techet via Github-comments
Fixed by https://github.com/geany/geany/pull/3861. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1310#issuecomment-2194804264 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Geany does not use native "file opener" for Mac (#1310)

2024-06-27 Thread Jiří Techet via Github-comments
Closed #1310 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1310#event-13318179374 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] TOML configuration language support (#1268)

2024-06-27 Thread Jiří Techet via Github-comments
I just asked here https://github.com/zufuliu/notepad4/issues/806 and it's some custom lexer for Notepad4 only so we'd really have to implement the lexer by ourselves. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1268#issuecomment-2194639604 You a

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-06-26 Thread Jiří Techet via Github-comments
One more thing. The plugin should pre-fill `default_persistent_temp_files_dir_utf8` into the directory entry in the plugin configuration. When you delete the saveactions configuration file, this entry is empty by default. Also, when this empty directory gets confirmed, the plugin shows a dialog

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-06-26 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + + +static void show_unsaved_dialog_for_persistent_temp_files_tab_closing( + GeanyDocument *doc, const gchar *short_filename) +{ + gchar *msg, *old_file_path, *locale_file_path; + const gchar *msg2; + gint response; + + msg

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-25 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. f5da5508c2c4fe5cf6557f4769e93e590b9397b5 Update the priority of the example extension based on the guidelines -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/935a24f93aa3c053b24c2b53cdb4a2173fc330d7..f5da5508c2c4fe5cf6557f4769e93e590b9397b5 You are

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-25 Thread Jiří Techet via Github-comments
Alright, I hope I addressed all the review comments and didn't forget about anything. I tried to replace most of the `_provided()` functions and friends by something like "functions assigned to the PluginExtension members ending with _provided". I think there were a few exceptions where I referr

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-25 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -258,6 +259,23 @@ const gchar *symbols_get_context_separator(gint ft_id) } +/** Gets the icon data corresponding to the provided TMIcon. + * @param icon TMIcon. + * + * Returns the GdkPixbuf corresponding to the provided TMIcon. + * + * @since 2.

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-25 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + * functions can be left to contain the NULL pointer. + * + * Typically, functions from this interface come in pairs. Functins ending with + * @c _provided() inform Geany whether the plugin implements the given feature + * for the passed document. Func

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-25 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + +#ifndef GEANY_PLUGIN_EXTENSION_H +#define GEANY_PLUGIN_EXTENSION_H 1 + +#include "document.h" + + +G_BEGIN_DECLS + +/** + * Structure serving as an interface between plugins and Geany allowing + * plugins inform Geany about what features they provide

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-25 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 935a24f93aa3c053b24c2b53cdb4a2173fc330d7 Update documentation based on review comments -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/4e1adce4ef6ee7cacd4d069fe824246b59a71cd2..935a24f93aa3c053b24c2b53cdb4a2173fc330d7 You are receiving this because

[Github-comments] [geany/geany] Export some types/functions so plugins have access to Geany symbol icons (PR #3916)

2024-06-25 Thread Jiří Techet via Github-comments
As requested, this has been removed from https://github.com/geany/geany/pull/3849 and posted as a separate PR. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3916 -- Commit Summary -- * Export some types/functions so plugins have access t

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-25 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 4e1adce4ef6ee7cacd4d069fe824246b59a71cd2 Revert "Export some types/functions so plugins have access to Geany symbol icons" -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/f99af6648bbfd4b2b16b20e6bcfca5e1b6486e00..4e1adce4ef6ee7cacd4d069fe824246b59a

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-06-24 Thread Jiří Techet via Github-comments
@techee requested changes on this pull request. Looks pretty good, I've just added a few more comments. There are two things that should still be resolved: 1. The naming of this feature and its placement in preferences 2. How it should behave on project opens/closes. For (1) my current suggestio

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-24 Thread Jiří Techet via Github-comments
> But you already do understand it, so you are a bad judge of that, there is a > name for this [curse of > knowledge](https://en.wikipedia.org/wiki/Curse_of_knowledge). Better that you > believe the advice from someone who was initially confused (me) that it is > not as obvious as you think it

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-24 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + +Since Geany 2.1 the PluginExtension API allows plugins to take over some of +the core Geany functionality, such as autocopletion, calltip display, symbol goto, +typename highlighting inside document, etc. + +@section plugin_extension_init Initializat

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-24 Thread Jiří Techet via Github-comments
> It is confusing the way function pointers that are members of struct > PluginExtension are referred to as eg "_perform() function". They are not > functions, they are function pointers with specific member names that end in > _perform and _provided, the functions they point to are in the plugi

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-24 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + * or dynamically. When allocated dynamically, plugins should always + * zero-fill the structure before use. + * + * Depending on the functionality they provide, plugins should assign the + * pointers from the structure to the functions implementing th

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-24 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > +#include "document.h" + + +G_BEGIN_DECLS + +/** + * Structure serving as an interface between plugins and Geany allowing + * plugins inform Geany about what features they provide and allowing + * Geany to delegate its functionality to the plugins. + *

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-24 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -258,6 +259,23 @@ const gchar *symbols_get_context_separator(gint ft_id) } +/** Gets the icon data corresponding to the provided TMIcon. + * @param icon TMIcon. + * + * Returns the GdkPixbuf corresponding to the provided TMIcon. + * + * @since 2.

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-24 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + */ +#define CALL_PROVIDED(f, doc, ext) \ + G_STMT_START {

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-24 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + +Since Geany 2.1 the PluginExtension API allows plugins to take over some of +the core Geany functionality, such as autocopletion, calltip display, symbol goto, +typename highlighting inside document, etc. + +@section plugin_extension_init Initializat

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-24 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -1116,4 +1118,130 @@ static void proxy_cleanup(GeanyPlugin *plugin, > gpointer pdata) @endcode +@page plugin_extension Plugin Extension HowTo + +@section plugin_extension_intro Introduction + +Since Geany 2.1 the PluginExtension API allows plugi

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-06-24 Thread Jiří Techet via Github-comments
> I know the scribble window is very limited, thats why I'm confused by you > wanting to call this "scribble". Well, it doesn't really have to be called this way, I'd just call it based on what it's supposed to do instead of how it's implemented (i.e. "persistent temp files"). Could be for inst

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-06-24 Thread Jiří Techet via Github-comments
> Whilst I didn't get the "persistent temp files" either and I still don't know > what the use-case is beyond persisting unnamed buffers and I don't understand > what the reason for saving unnamed buffers is, if its unnamed how do I know > whats in it to switch to it when they are all named "Unt

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-06-23 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -462,6 +462,18 @@ gboolean main_is_realized(void) } +/** + * Checks whether Geany is quitting completely right now. + * + * @return @c TRUE if the Geany is exiting right now or @c FALSE otherwise. + **/ +GEANY_API_SYMBOL +gboolean geany_is_quit

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-06-23 Thread Jiří Techet via Github-comments
@techee requested changes on this pull request. See some more review comments. > Maybe one more idea - wouldn't it be better to introduce this feature just as > a special mode of "Instant save"? Because I think that's what this feature > really is - it just picks the file names automatically, p

[Github-comments] Re: [geany/geany] Support for remote files without gvfs-fuse or fuse (#1414)

2024-06-23 Thread Jiří Techet via Github-comments
Closed #1414. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1414#event-13255567481 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)

2024-06-23 Thread Jiří Techet via Github-comments
Closed #3592. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3592#event-13255548575 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] If project is open, use base_path as a search path in find in files (#454)

2024-06-23 Thread Jiří Techet via Github-comments
Closed #454. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/454#event-13255544867 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Open files session files after entering main loop (#924)

2024-06-23 Thread Jiří Techet via Github-comments
Closed #924. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/924#event-13255539863 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Only show recent file menu entries for files which exist (#364)

2024-06-23 Thread Jiří Techet via Github-comments
Closed #364. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/364#event-13255537690 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Set correct sidebar/message window positions before showing the… (#576)

2024-06-23 Thread Jiří Techet via Github-comments
Closed #576. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/576#event-13255536768 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-06-22 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. d50c6c64b39cdb86ceb53fed1af717689fb5792e Reduce the number of lsp_utils_doc_ft_has_tags() calls in on_editor_notify() 78a2cd6b62643d53deb876b1e8bf6a9d60128d30 Make progress reporting configurable -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-06-22 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -462,6 +462,18 @@ gboolean main_is_realized(void) } +/** + * Checks whether Geany is quitting completely right now. + * + * @return @c TRUE if the Geany is exiting right now or @c FALSE otherwise. + **/ +GEANY_API_SYMBOL +gboolean geany_is_quit

[Github-comments] Re: [geany/geany] Fix a problem when multiple project opens clear the default session (PR #3898)

2024-06-22 Thread Jiří Techet via Github-comments
> Maybe the session should be saved before opening a project (at step 2 in the > OP or step 4 above) so the right thing can be restored after? The trouble with this session management code is that it gets called from many different places and on different occasions so the "before opening project

[Github-comments] Re: [geany/geany] Drop win32_message_dialog()s (PR #3903)

2024-06-22 Thread Jiří Techet via Github-comments
Merged #3903 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3903#event-13249976716 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-21 Thread Jiří Techet via Github-comments
I've added the howto and a simple example under `plugins/demopluginext.c`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3849#issuecomment-2183290111 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-21 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. f99af6648bbfd4b2b16b20e6bcfca5e1b6486e00 Add PluginExtension HowTo to API documentation -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/b111bc160a2176e158fe83c4d476b8a018d65b59..f99af6648bbfd4b2b16b20e6bcfca5e1b6486e00 You are receiving this becaus

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-06-21 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -462,6 +462,18 @@ gboolean main_is_realized(void) } +/** + * Checks whether Geany is quitting completely right now. + * + * @return @c TRUE if the Geany is exiting right now or @c FALSE otherwise. + **/ +GEANY_API_SYMBOL +gboolean geany_is_quit

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-06-21 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + + if (file_path == NULL) + { + return FALSE; + } + + filename = g_path_get_basename(file_path); + matched = is_temp_saved_file(filename); + + g_free(filename); + + return matched; +} + + +static v

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-21 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. 64a2f5a6b5a72f238cfc303c6a2395ee25c0047b Improve demopluginext.c a little b111bc160a2176e158fe83c4d476b8a018d65b59 Use "modern" Geany API when talking about init() and cleanup() functions -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/2b0b55df39

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-20 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. e5287871054759c45d3f19871daa5d4db2bec769 Fix parameter name 2b0b55df399eb3685c88e254a290f89fb0fb3efd Add simple PluginExtension demo -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/3785bc92bf24e2898ffc2b40abbc516e3a9ba04d..2b0b55df399eb3685c88e254

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-06-20 Thread Jiří Techet via Github-comments
@techee requested changes on this pull request. Thanks for the patch - looks good to me in general except for some of the notes below. I personally think that having such a feature in Geany (i.e. multi-tab Scrilbble backed by Scintilla with all the Geany features) would be nice, but depends wha

[Github-comments] Re: [geany/geany] Fix a problem when multiple project opens clear the default session (PR #3898)

2024-06-20 Thread Jiří Techet via Github-comments
> Even though I was worried that this would break saving default session when > all its files get closed and then a project is loaded, it doesn't seem to be > the case (I haven't investigated deep enough why). The reason why this doesn't happen is the default ``` save_config_on_file_change=TRUE

[Github-comments] Re: [geany/geany] Fix a problem when multiple project opens clear the default session (PR #3898)

2024-06-20 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 6c1fdf6f8e78512bd43ba2e84169f0321979eebf Add an explanation comment -- View it on GitHub: https://github.com/geany/geany/pull/3898/files/d267fa2d92b069a9c0c19675a0b88a842d967181..6c1fdf6f8e78512bd43ba2e84169f0321979eebf You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany] Don't include geanyfunctions.h from geanyplugin.h (PR #3913)

2024-06-20 Thread Jiří Techet via Github-comments
Merged #3913 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3913#event-13226158594 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Move utils_utf8_strdown() under GEANY_PRIVATE in utils.h (PR #3912)

2024-06-20 Thread Jiří Techet via Github-comments
Merged #3912 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3912#event-13226030069 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Don't include geanyfunctions.h from geanyplugin.h (PR #3913)

2024-06-19 Thread Jiří Techet via Github-comments
Clangd complains with ``` main file cannot be included recursively when building a preamble ``` and I suspect geanyfunctions.h is the old (and now empty) version of geanyplugin.h so there's no need to include it anyway. You can view, comment on, or merge this pull request online at: https://git

[Github-comments] [geany/geany] Move utils_utf8_strdown() under GEANY_PRIVATE in utils.h (PR #3912)

2024-06-19 Thread Jiří Techet via Github-comments
It isn't part of Geany's public API. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3912 -- Commit Summary -- * Move utils_utf8_strdown() under GEANY_PRIVATE in utils.h -- File Changes -- M src/utils.h (4) -- Patch Links -- https:/

[Github-comments] Re: [geany/geany] Fix elevated CPU usage after ui_progress_bar_start/stop() is used (PR #3902)

2024-06-19 Thread Jiří Techet via Github-comments
> I think I'll report this to GTK because this is very unexpected Done in https://gitlab.gnome.org/GNOME/gtk/-/issues/6793 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3902#issuecomment-2179430032 You are receiving this because you are subscribed to t

[Github-comments] Re: [geany/geany] Possible plugin extension interface for symbol tree (PR #3910)

2024-06-19 Thread Jiří Techet via Github-comments
> GObjects are nice for language inteop with GI indeed, but they aren't as cheap That's a good point, it should be cheap because for the symbol tree code, all the `TMTag`s have to be wrapped by `GeanySymbol` first and it would be best to have the overhead as small as possible. If we wanted, we c

[Github-comments] Re: [geany/geany] Fix stuck MRU dialog when Geany loses focus (PR #3907)

2024-06-19 Thread Jiří Techet via Github-comments
> @techee I shamelessly pushed 2 more commits, please see if that works better > for you as well (your commit didn't seem to work really well for me…) Thanks! It really seems to work! Nice! I've added two more commits on top of that - not sure if they are completely needed but may prevent some

[Github-comments] Re: [geany/geany] Fix stuck MRU dialog when Geany loses focus (PR #3907)

2024-06-19 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. 4cfbf9e14e79d53bdffc1febcad701a526baf3b2 Connect notify::is-active on main_widgets.window only once a2548b66de7bd79c9811ebd244a952edbcf5a46a Make sure that there is at most one scheduled on_switch_timeout() -- View it on GitHub: https://github.com/geany/geany/pull/3

[Github-comments] Re: [geany/geany] Support for multiple carets (PR #3899)

2024-06-18 Thread Jiří Techet via Github-comments
> Also, shouldn't we enable these for multiple carets (also affects rectangular > selection): If I understand correctly #625, this should fix it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3899#issuecomment-2176750376 You are receiving this because

[Github-comments] Re: [geany/geany] Issue with the terminal of the mac (Issue #3369)

2024-06-18 Thread Jiří Techet via Github-comments
Closed #3369 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3369#event-13204668841 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Support for multiple carets (PR #3899)

2024-06-18 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 58557119565ef34fb17b3ffac712c96ba45159b6 Fix defines in keyfile.c and indent them a bit to avoid similar problem in the future -- View it on GitHub: https://github.com/geany/geany/pull/3899/files/979a79a5faffbd01bdc6c154abdbb64d515c0291..58557119565ef34fb17b3ffac712c96

[Github-comments] Re: [geany/geany] Support for multiple carets (PR #3899)

2024-06-18 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 979a79a5faffbd01bdc6c154abdbb64d515c0291 Merge branch 'master' into multi_cursor -- View it on GitHub: https://github.com/geany/geany/pull/3899/files/e221a9886cc146e4483364b984b04e627c677b53..979a79a5faffbd01bdc6c154abdbb64d515c0291 You are receiving this because you a

[Github-comments] Re: [geany/geany] Support for multiple carets (PR #3899)

2024-06-18 Thread Jiří Techet via Github-comments
Also, shouldn't we enable these for multiple carets (also affects rectangular selection): - `SCI_SETMULTIPASTE` - paste is performed at all caret positions instead of the main one - `SCI_AUTOCSETMULTI` - autocompletion is performed at all caret positions When someone creates a multiple selection

[Github-comments] Re: [geany/geany] Support for multiple carets (PR #3899)

2024-06-18 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. e221a9886cc146e4483364b984b04e627c677b53 Don't use event->state directly -- View it on GitHub: https://github.com/geany/geany/pull/3899/files/fc5bdd6f969e84f94ae00302ee4a974aad16b0d9..e221a9886cc146e4483364b984b04e627c677b53 You are receiving this because you are subscr

[Github-comments] Re: [geany/geany] Support for multiple carets (PR #3899)

2024-06-18 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -288,6 +288,21 @@ void editor_snippets_init(void) } +gboolean motion_notify_event(GtkWidget* widget, GdkEventMotion event, gpointer data) +{ + GeanyEditor *editor = data; + + if (event.state & GDK_BUTTON1_MASK && event.state & GDK_MO

[Github-comments] Re: [geany/geany] Support for multiple carets (PR #3899)

2024-06-18 Thread Jiří Techet via Github-comments
Alright, I added the configurability of modifiers - for now it's under Editor->Features, could be placed somewhere else if someone has a better idea: https://github.com/geany/geany/assets/713965/7ceb31e3-b9fa-4a59-9553-bd82256da463";> For - "Goto definition" and "Multiple carets", one can choos

[Github-comments] Re: [geany/geany] Support for multiple carets (PR #3899)

2024-06-18 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. fc5bdd6f969e84f94ae00302ee4a974aad16b0d9 Disallow overlapping selections -- View it on GitHub: https://github.com/geany/geany/pull/3899/files/e01bd7fe10324eddc4219bf96a33b68e041d567b..fc5bdd6f969e84f94ae00302ee4a974aad16b0d9 You are receiving this because you are subscr

[Github-comments] Re: [geany/geany] Support for multiple carets (PR #3899)

2024-06-17 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. e01bd7fe10324eddc4219bf96a33b68e041d567b Make click modifiers configurable -- View it on GitHub: https://github.com/geany/geany/pull/3899/files/be7c8c9a73930104e111e6ead069e8d2e3fbe74c..e01bd7fe10324eddc4219bf96a33b68e041d567b You are receiving this because you are subs

[Github-comments] Re: [geany/geany] Possible plugin extension interface for symbol tree (PR #3910)

2024-06-17 Thread Jiří Techet via Github-comments
> Have you looked the gtkdoc that's generated from the new interfaces? What should I look for exactly? My main worry is ```C typedef struct { gboolean (*autocomplete_provided)(GeanyDocument *doc, gpointer data); void (*autocomplete_perform)(GeanyDocument *doc, gboolean force, gpoi

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-06-17 Thread Jiří Techet via Github-comments
@elextr Agree, I was thinking about it myself too - the documentation looks the whole thing is much more complicated than it really is. I think I'll create some `PluginExtension` howto similarly to e.g. `Proxy Plugin HowTo` https://www.geany.org/manual/reference/proxy.html with some minimal plu

[Github-comments] Re: [geany/geany] Possible plugin extension interface for symbol tree (PR #3910)

2024-06-17 Thread Jiří Techet via Github-comments
> If it has a refcount, why not make it a GObject so that it's easy to create > from non-C plugins (python via peasy for example). I just copied what was in `TMTag` to implement it quickly but good point, it could be a `GObject`. I'm not so familiar with what might be necessary for non-C plugin

[Github-comments] Re: [geany/geany] Ctrl-Tab "popup" stays on screen (Issue #3330)

2024-06-17 Thread Jiří Techet via Github-comments
@b4n Is there anything else other than the `focus-out-event` signal we could use? When I tested it in #3907, the signal was fired when the window lost focus for some "real" window such as a dialog but not for the case reported by OP here with the menus. To be precise, I connected `main_widgets.w

[Github-comments] [geany/geany] Possible plugin extension interface for symbol tree (PR #3910)

2024-06-17 Thread Jiří Techet via Github-comments
This is one more attempt on unifying `TMTag`s and externally provided symbols for the symbol tree before giving up and making the plugins create the symbol tree by themselves (which leads to quite a significant code duplication). This time (unlike the previous attempts) I'm quite happy with the

[Github-comments] Re: [geany/geany] Avoid unwanted selection when infobar shows by mouse click in Scintilla (PR #3909)

2024-06-16 Thread Jiří Techet via Github-comments
Merged #3909 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3909#event-13176481433 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Single click inside editor makes selection when modified warning appears (Issue #3906)

2024-06-16 Thread Jiří Techet via Github-comments
Closed #3906 as completed via #3909. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3906#event-13176481471 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Single click inside editor makes selection when modified warning appears (Issue #3906)

2024-06-16 Thread Jiří Techet via Github-comments
Closed #3906 as completed via abbe1c984f6da1f1a1fa89851b9d010e5d3a19ae. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3906#event-13176481473 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Avoid unwanted selection when infobar shows by mouse click in Scintilla (PR #3909)

2024-06-16 Thread Jiří Techet via Github-comments
@eht16 Thanks for testing! Merging now. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3909#issuecomment-2171772577 You are receiving this because you are subscribed to this thread. Message ID:

<    1   2   3   4   5   6   7   8   9   10   >