Merged #1295 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#event-12632694851
You are receiving this because you are subscribed to this thread.
Message ID:
@elextr commented on this pull request.
> @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self,
g_free (real_uri);
}
+gboolean
+gwh_browser_set_uri_from_document (GwhBrowser*self,
+ GeanyDocument *doc)
+{
+ gchar *uri;
+
+ /* document must ex
@b4n commented on this pull request.
> @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self,
g_free (real_uri);
}
+gboolean
+gwh_browser_set_uri_from_document (GwhBrowser*self,
+ GeanyDocument *doc)
+{
+ gchar *uri;
+
+ /* document must exist
@elextr approved this pull request.
LGBI except for one query.
> @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self,
g_free (real_uri);
}
+gboolean
+gwh_browser_set_uri_from_document (GwhBrowser*self,
+ GeanyDocument *doc)
+{
+ gchar *uri;
+
And voila, I got plagued with another round of cleanups :)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#issuecomment-2078136827
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself, y
@b4n pushed 5 commits.
52ab3ebefc8fdf805b081bac74efaec442c82529 webhelper: Use modern GObject private
data
9f420e09447cc2f8a57e4880dfa99bebc67734e7 webhelper: Replace use of deprecated
GtkVBox with GtkBox
3edea3f891cdbe241d63d2b4b37ef4c5eea035c4 webhelper: Remove use of deprecated
g_thread_i
@elextr commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself
@xiota commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself,
@b4n commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself, y
@elextr commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself
@b4n commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself, y
@elextr commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself
@b4n commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself, y
@elextr commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself
@elextr I just did the bare minimum, see update
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#issuecomment-2075710224
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 1 commit.
8ee8a92a9eb7276ae210e376e0b80d271f885162 webhelper: Update dependencies in
README
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1295/files/d19aee697472477c0e53c12a75303121e47f5b64..8ee8a92a9eb7276ae210e376e0b80d271f885162
You are receiving this because
Maybe should update the requirements section of README as well.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#issuecomment-2074716996
You are receiving this because you are subscribed to this thread.
Message ID:
* Loads and seems to function when built with either webkit2gtk 4.0 or 4.1.
* Key bindings all work when conditions for their function are met.
* The reload on save function works.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#issuecomment-
@xiota if you'd like to try, just look at the PR's commit messages. Basically,
try building against WebKit2GTK 4.1, enable the plugin and try loading pages,
editing an HTML displayed there, etc. But all should be good in theory
:crossed_fingers:
--
Reply to this email directly or view it on
@jbicha could you make a PR with your Markdown changes, assuming they are not
too Ubunut/Debian-specific?
@elextr @jbicha I'll merge this (which at least *allows* building webhelper
with 4.1, although not forcing it), and try to update the rest to match, as
indeed it will cause issues if various
Which plugin did you mean? There are four listed in the previous two comments.
Since I would think that it is not possible to load old and new versions of
webkit2gtk and libsoup at the same time probably the version needs to be
selected once and builds of all four need to disable them if the n
I don't use this plugin, but can test it to help facilitate its update if
provided a list of things to check.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#issuecomment-2073071561
You are receiving this because you are subscribed to this t
Maintainers are:
- Webhelper - @b4n, this PR
- Markdown - in theory @codebrainz, but hasn't contributed to it for 8 years,
the markdown plugin died for a while until others ported to GTK3, maybe @b4n
could port the (small) webkit4.1 change to markdown, or it can die again until
a new maintain
Switching from webkit2gtk 4.0 to 4.1 is important. Fedora has
[stopped](https://fedoraproject.org/wiki/Changes/Remove_webkit2gtk-4.0_API_Version)
building the 4.0 API in preparation for their Fedora 40 release in a few
months.
Debian and Ubuntu are preparing to do the same thing.
Ideally, all
Documentation looks ok, rest went zooming over my head.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#issuecomment-1821933103
You are receiving this because you are subscribed to this thread.
Message ID:
26 matches
Mail list logo
