Thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1806#issuecomment-405150192
Merged #1806.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1806#event-1734360209
@b4n: I increased the API version again to resolve conflicts. It would be nice
if this could be merged before the API gets increased elsewhere again.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
codebrainz commented on this pull request.
> @@ -274,6 +274,8 @@ enum GeanyKeyBindingID
GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
Keybinding. */
LarsGit223 commented on this pull request.
> @@ -59,7 +59,7 @@ G_BEGIN_DECLS
* @warning You should not test for values below 200 as previously
* @c GEANY_API_VERSION was defined as an enum value, not a macro.
*/
-#define GEANY_API_VERSION 235
+#define GEANY_API_VERSION 236
So I go up to
b4n commented on this pull request.
> @@ -59,7 +59,7 @@ G_BEGIN_DECLS
* @warning You should not test for values below 200 as previously
* @c GEANY_API_VERSION was defined as an enum value, not a macro.
*/
-#define GEANY_API_VERSION 235
+#define GEANY_API_VERSION 236
This is the version
@elextr: sorry for not checking HACKING (in my mind I said **RTFM** to myself
:wink: )
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1806#issuecomment-379293444
@elextr: seems to look correct:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
b4n commented on this pull request.
> @@ -274,6 +274,8 @@ enum GeanyKeyBindingID
GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
Keybinding. */
@kugel- thats what I suspected, but thought maybe it would still work if its
all part of the same comment?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1806#issuecomment-379154587
@LarsGit223 from HACKING
```
* Pass the *--enable-api-docs* option to ``configure``.
* Run ``make`` from the doc/ subdirectory.
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I think the trailing doc comment supports only a brief description (not
detail), such that enums/struct members can still be one-liners. But it may be
possible to add commands like @since to that, have to try (but I'd expect it
should be on the same line still).
In any event, you can make
@elextr: no I didn't. That's doxygen building the API docs right? How do I run
it on build or is it started on every build?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@LarsGit223 just a question, did you look at the generated API docs to check
that putting the @since on another line looked alright in the output?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
LarsGit223 commented on this pull request.
> @@ -274,6 +274,8 @@ enum GeanyKeyBindingID
GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
Keybinding. */
elextr commented on this pull request.
> @@ -274,6 +274,8 @@ enum GeanyKeyBindingID
GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
Keybinding. */
@LarsGit223 pushed 1 commit.
39ec770 keybindings: adjusted '@since' comment, increased API version
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
codebrainz commented on this pull request.
> @@ -274,6 +274,8 @@ enum GeanyKeyBindingID
GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
Keybinding. */
elextr commented on this pull request.
> @@ -274,6 +274,8 @@ enum GeanyKeyBindingID
GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
Keybinding. */
Apart from the `@since` bikeshed, LGTM (tested working)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1806#issuecomment-379066503
b4n commented on this pull request.
> @@ -274,6 +274,8 @@ enum GeanyKeyBindingID
GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
Keybinding. */
LarsGit223 commented on this pull request.
> @@ -274,6 +274,8 @@ enum GeanyKeyBindingID
GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
Keybinding. */
b4n commented on this pull request.
> @@ -274,6 +274,8 @@ enum GeanyKeyBindingID
GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
Keybinding. */
b4n commented on this pull request.
> @@ -274,6 +274,8 @@ enum GeanyKeyBindingID
GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
Keybinding. */
Friendly ping. It would be cool if this simple fix could be merged at the next
opportunity. So we would make sure it's in 1.34, have another issue closed, and
I could remove my branch :smile:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
Done, added the ```@since``` tag.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1806#issuecomment-373460604
b4n commented on this pull request.
LGBI, but for the doc comment
> @@ -274,6 +274,7 @@ enum GeanyKeyBindingID
GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
Keybinding. */
LGBI
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1806#issuecomment-373197996
28 matches
Mail list logo
