[Github-comments] Re: [geany/geany] Add GPLv3 note and header template (PR #3549)

2023-10-15 Thread Enrico Tröger via Github-comments
@eht16 requested changes on this pull request. On po/ar.po: Please remove all the translation changes in the *.po files. These are not necessary in the pull request. The translation files will be updated later as part of the release process. > @@ -168,7 +171,7 @@ void

[Github-comments] [geany/geany] Linux light themes render geany toolbar icons invisible (Issue #3601)

2023-10-15 Thread ineuw via Github-comments
I am using Geany in Linux Mint and Kubuntu, so I comfortable with KDE and GTK. This problem is identical in both and has nothing to do with a selected color scheme. Dark system themes are not always preferred.

[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)

2023-10-15 Thread inonehp via Github-comments
@inonehp commented on this pull request. > @@ -0,0 +1,108 @@ +# I tried to add a theme in AUTHORS. I tried to update the license. Thank you. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/62#discussion_r1359867442 You are receiving this

[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)

2023-10-15 Thread inonehp via Github-comments
@inonehp pushed 1 commit. 587b459c0b440c54ae67ab74e0792c2b993223d2 Delete colorschemes/dark-abc.conf -- View it on GitHub: https://github.com/geany/geany-themes/pull/62/files/399abb4f8d1127b93528ad066393db15708e8953..587b459c0b440c54ae67ab74e0792c2b993223d2 You are receiving this because you

[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)

2023-10-15 Thread inonehp via Github-comments
@inonehp pushed 1 commit. 399abb4f8d1127b93528ad066393db15708e8953 Delete colorschemes/light-abc.conf -- View it on GitHub: https://github.com/geany/geany-themes/pull/62/files/649f91ba6f2114fba7d60d5ae1b1203808a394da..399abb4f8d1127b93528ad066393db15708e8953 You are receiving this because you

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-15 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 4ca132618802e4114c5ee08cbd8a7e55c8609e4c Improve wording of geany.txt -- View it on GitHub: https://github.com/geany/geany/pull/3049/files/bb64384a6af2631ff6f4168118ff27e0dff1c4b5..4ca132618802e4114c5ee08cbd8a7e55c8609e4c You are receiving this because you are

[Github-comments] Re: [geany/geany] Linux light themes render geany toolbar icons invisible (Issue #3601)

2023-10-15 Thread ineuw via Github-comments
I found the reason but wasn't quick enough to let you know what causes the problem and cancel the post. Kubuntu's incorrectly defined group rights blocks standard geany from accessing the system icons. I noticed the difference when I used "sudo geany" to edit the **/etc/sudoers file**. I hope

[Github-comments] Re: [geany/geany] Windows: Include "Prof-Gnome" GTK theme from geany-osx (PR #3129)

2023-10-15 Thread Enrico Tröger via Github-comments
> I NAK'd the theme but I don't want to block any Adwaita-replacement so please > go for it. Alright. https://www.geany.org/documentation/faq/#how-to-change-the-gtk-theme provides users with instructions on how to change the theme and there are also alternatives linked. I guess this is all an

[Github-comments] Re: [geany/geany] Build geany & geany-plugins on windows(using MSYS2), but geany.exe can not find and load any geany-plugins (Issue #3532)

2023-10-15 Thread Enrico Tröger via Github-comments
@baoliubin sorry for the late answer. It might help or might not but it's worth a try: Set the environment variable "lt_cv_deplibs_check_method" to "pass_all", e.g. by executing the following command in the same shell where you compile Geany afterwards: ```export

[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)

2023-10-15 Thread inonehp via Github-comments
@inonehp pushed 1 commit. 649f91ba6f2114fba7d60d5ae1b1203808a394da Update AUTHORS -- View it on GitHub: https://github.com/geany/geany-themes/pull/62/files/1978a77b9358bd7b6feba35a0e5187100499eb36..649f91ba6f2114fba7d60d5ae1b1203808a394da You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-15 Thread Colomban Wendling via Github-comments
What about simply adding a `q` command after the first replacement so only that one is handled? Le 15 octobre 2023 10:05:04 GMT+02:00, "Enrico Tröger" ***@***.***> a écrit : >@eht16 commented on this pull request. > > > >> @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^

[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-15 Thread Jan Dolinár via Github-comments
@dolik-rce commented on this pull request. > @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/ ' -i geany_private.rc sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac +sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i

[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-15 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/ ' -i geany_private.rc sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac +sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build

[Github-comments] Re: [geany/geany] Windows: Include "Prof-Gnome" GTK theme from geany-osx (PR #3129)

2023-10-15 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 704aaa1e622b4d41ecf8a53109b64aaa574a50c2 Add Prof-Gnome Windows specific patch -- View it on GitHub: https://github.com/geany/geany/pull/3129/files/18886248cb10c53e2a140d213e613c93a73aa011..704aaa1e622b4d41ecf8a53109b64aaa574a50c2 You are receiving this because you are

[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)

2023-10-15 Thread Enrico Tröger via Github-comments
@eht16 requested changes on this pull request. Could you please add your themes to the `AUTHORS` file? > @@ -0,0 +1,108 @@ +# Would you mind adding a full file header with license and copyright information? Like this one:

[Github-comments] Re: [geany/geany-plugins] Cannot install webhelper (Issue #1269)

2023-10-15 Thread Enrico Tröger via Github-comments
@TomCarroll09 I'm closing this. Geany and Geany-Plugins 2.0 are going to be released in a few days and then the mentioned update for Webkit will be included in the new release. If you disagree or need further support, just re-open. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Cannot install webhelper (Issue #1269)

2023-10-15 Thread Enrico Tröger via Github-comments
Closed #1269 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1269#event-10657327244 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Help command should check browser tool's return value (Issue #3468)

2023-10-15 Thread Enrico Tröger via Github-comments
I think we can close this now since #3178 is merged. @ntrel when use start current GIT master Geany with a fresh config, will it use the correct browser? FTR, the "sensible-browser" default is patched in by Debian (and Ubuntu inherits this change). As pointed out earlier, Geany had the default

[Github-comments] Re: [geany/geany-osx] Add a patch with Windows-specific theme changes (c79e60f)

2023-10-15 Thread Jiří Techet via Github-comments
Yeah, done now. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/commit/c79e60f1cc0c25106ab803b2b4c9e61926ce12fa#r130019403 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Build geany & geany-plugins on windows(using MSYS2), but geany.exe can not find and load any geany-plugins (Issue #3532)

2023-10-15 Thread Bran via Github-comments
thank you very much Replied Message | From | Enrico ***@***.***> | | Date | 10/15/2023 17:46 | | To | ***@***.***> | | Cc | ***@***.***>***@***.***> | | Subject | Re: [geany/geany] Build geany & geany-plugins on windows(using MSYS2), but geany.exe can not find and load any

[Github-comments] Re: [geany/geany-plugins] startup always opens the file from /tmp/_dc~~~/ that contains the opened files (Issue #1243)

2023-10-15 Thread Enrico Tröger via Github-comments
Closed #1243 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1243#event-10657346524 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] startup always opens the file from /tmp/_dc~~~/ that contains the opened files (Issue #1243)

2023-10-15 Thread Enrico Tröger via Github-comments
Closing this after no more feedback. @WhitehawkTailor re-open if it still is a problem. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1243#issuecomment-1763342195 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)

2023-10-15 Thread inonehp via Github-comments
@inonehp pushed 1 commit. 1978a77b9358bd7b6feba35a0e5187100499eb36 Add files via upload -- View it on GitHub: https://github.com/geany/geany-themes/pull/62/files/ee93c74d6f85e619724f42c272faac00cc6bd90b..1978a77b9358bd7b6feba35a0e5187100499eb36 You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany-osx] Add a patch with Windows-specific theme changes (c79e60f)

2023-10-15 Thread Enrico Tröger via Github-comments
Sorry for being late, I just thought this might be also good for the dark variant of the theme? Currently it uses the large statusbar. ![Screenshot_2023-10-15_10-15-16](https://github.com/geany/geany-osx/assets/617017/254a6d28-ce42-4602-b20b-e92826cc4f9f) -- Reply to this email directly or

[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-15 Thread Enrico Tröger via Github-comments
> What about simply adding a `q` command after the first replacement so only > that one is handled? I don't know how to do, my sed skills are still on a beginner level and I guess this will remain so :). Tried: `sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/;q' -i meson.build` but

[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)

2023-10-15 Thread inonehp via Github-comments
@inonehp pushed 1 commit. ee93c74d6f85e619724f42c272faac00cc6bd90b Update Abc theme name -- View it on GitHub: https://github.com/geany/geany-themes/pull/62/files/6847d284c91f3858a9a491761a76a477bc575812..ee93c74d6f85e619724f42c272faac00cc6bd90b You are receiving this because you are

[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)

2023-10-15 Thread inonehp via Github-comments
@inonehp commented on this pull request. > @@ -0,0 +1,108 @@ +# +# GNU General Public License +# +#https://github.com/geany/geany/blob/d9f8cdbad58d09f0c18ca8acccb49209263018f0/data/filedefs/filetypes.common#L2 +# Inspired by Github, Sublime Text, Geany + + + +[theme_info] +name=Dark Abc Sorry,

[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)

2023-10-15 Thread inonehp via Github-comments
@inonehp pushed 1 commit. e34a8269bd9bc2f36c320316a029f2582b3af2bd Delete screenshots/light-abc.png -- View it on GitHub: https://github.com/geany/geany-themes/pull/62/files/587b459c0b440c54ae67ab74e0792c2b993223d2..e34a8269bd9bc2f36c320316a029f2582b3af2bd You are receiving this because you

[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)

2023-10-15 Thread inonehp via Github-comments
@inonehp pushed 1 commit. abeb3d66ddc0203165410af2515e47ecdb804db8 Delete screenshots/dark-abc.png -- View it on GitHub: https://github.com/geany/geany-themes/pull/62/files/e34a8269bd9bc2f36c320316a029f2582b3af2bd..abeb3d66ddc0203165410af2515e47ecdb804db8 You are receiving this because you are

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-15 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > +Generating tags files using ctags +* +Geany supports loading tag files generated using the ``ctags`` command-line +tool from the universal-ctags project (https://github.com/universal-ctags/ctags). +Even though Geany

[Github-comments] Re: [geany/geany] Fix goto popup location (PR #3316)

2023-10-15 Thread Colomban Wendling via Github-comments
@b4n pushed 3 commits. 869606ee1427b3611d01ee37c4811942241bb320 Pass the event to gtk_menu_popup_at_pointer() when possible 705dc3c8eb39c43e54daf171811b412d6eaa5032 Use gtk_menu_popup_at_pointer() in filebrowser as well d10cfb503d30ee9bb7848f171dc857e2e90f0de5 Position goto popup at the

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-15 Thread Colomban Wendling via Github-comments
@b4n requested changes on this pull request. First pass only based on *code* review, no actual testing yet. > + TMParserType lang = > tm_ctags_get_named_lang(value); + if (lang >= 0) + tag->lang =

[Github-comments] Re: [geany/geany] Markdown syntax highlighting confused by empty image title (#2798)

2023-10-15 Thread rdipardo via Github-comments
@eht16, @elextr This issue can be closed as fixed in the forthcoming Geany. ![Screenshot_2023-10-15_17-11-08](https://github.com/geany/geany/assets/59004801/ece88b02-7ee5-49ba-aeca-31b29e1f5de1) -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Fix goto popup location (PR #3316)

2023-10-15 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3316#pullrequestreview-1678848601 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix goto popup location (PR #3316)

2023-10-15 Thread Colomban Wendling via Github-comments
I added a few minor changes, including a small behavioral one: the goto popup is again positioned at the mouse if triggered with it, which makes it slightly better for that use case. -- Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany] Enable EOL-filled Markdown headings (PR #3602)

2023-10-15 Thread rdipardo via Github-comments
Before ![markd-headings-current-git](https://github.com/geany/geany/assets/59004801/025b0f7c-598d-4214-bb8d-4e286818e732) After *with `lexer.markdown.header.eolfill=1`* ![markd-headings-git-eolfill](https://github.com/geany/geany/assets/59004801/94920a1c-9ff5-45a5-b7c2-a48f0ec467de)

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-15 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. a088e452fbbef8bc08d0bc350265d98e45f048f0 Fix some compiler warnings -- View it on GitHub: https://github.com/geany/geany/pull/3049/files/4ca132618802e4114c5ee08cbd8a7e55c8609e4c..a088e452fbbef8bc08d0bc350265d98e45f048f0 You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany] Fix goto popup location (PR #3316)

2023-10-15 Thread Jiří Techet via Github-comments
> I added a few minor changes, including a small behavioral one: the goto popup > is again positioned at the mouse if triggered with it, which makes it > slightly better for that use case. Looks good (and works too from what I've tried) - though the previous version was just fine too.

[Github-comments] Re: [geany/geany] Fix goto popup location (PR #3316)

2023-10-15 Thread Colomban Wendling via Github-comments
Merged #3316 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3316#event-10658414985 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] Consider to add a plugin to support Asciidoctor (Issue #1282)

2023-10-15 Thread Manuel Jordan Elera via Github-comments
I installed Geany on Linux Peppermint OS based on 32 bits for a very old notebook, it works fine, really huge thanks for this editor. About the plugins, at the https://plugins.geany.org page does not appear nothing about https://asciidoctor.org. I did realize exists a plugin for `Markdown` to

[Github-comments] Re: [geany/geany] Do not enable Scintilla's Change History by default (PR #3591)

2023-10-15 Thread rdipardo via Github-comments
> Maybe Scintilla needs to export some controls, such as resetting when the > user does reload, although of course that can be undone, so maybe not. Some downstream projects have actually resorted to emptying the undo buffer on file reload, then toggling Scintilla's edit tracker off and on, to

[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-15 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/ ' -i geany_private.rc sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac +sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-15 Thread elextr via Github-comments
@elextr commented on this pull request. > { - if ((NULL == fgets(buf, BUFSIZ, fp)) || ('\0' == *buf)) - return FALSE; - } - while (strncmp(buf, "!_TAG_", 6) == 0); /* skip !_TAG_ lines */ + TMTagType type; + TMTag

[Github-comments] Re: [geany/geany-plugins] Consider to add a plugin to support Asciidoctor (Issue #1282)

2023-10-15 Thread elextr via Github-comments
Geany has some support for asciidoc built in. If "somebody" was willing to contribute a plugin for Geany to provide a preview it would probably be accepted. Note that the plugin for Vscode is provided by `asciidoctor.org` so maybe you could ask there. -- Reply to this email directly or view

[Github-comments] Re: [geany/geany] update czech translation (PR #3595)

2023-10-15 Thread Frank Lanitz via Github-comments
Merged #3595 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3595#event-10656894364 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Linux light themes render geany toolbar icons invisible (Issue #3601)

2023-10-15 Thread elextr via Github-comments
Closed #3601 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3601#event-10657591539 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Linux light themes render geany toolbar icons invisible (Issue #3601)

2023-10-15 Thread elextr via Github-comments
All toolbar icons are standard icons and their selection and rendering is up to the GTK theme. On Linux Mint using Mint-Y theme I can get the effect you show by setting the icons to Mint-Y-dark using the desktop preferences. Its not something Geany can control. -- Reply to this email