Re: [Github-comments] [geany/geany] HTML comments inserted in PHP files (#1758)

2018-02-02 Thread elextr
@b4n thanks, I don't know any PHP so just tried to add comments to an empty PHP 
file and got HTML ones and said "Oh!! the OP on the ML is right".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1758#issuecomment-362738639

Re: [Github-comments] [geany/geany] HTML comments inserted in PHP files (#1758)

2018-02-02 Thread Colomban Wendling
Agreed with @codebrainz it's not very clear, but I guess I got it:

When *filetypes.php* has an empty `comment_single`, it uses HTML comments 
(``) instead of multi-line PHP comments (`/* */`) for some reason.
To test:

1. Open Geany with a stock configuration (`geany -c /tmp/temp-config`)
2. Create a new PHP file from template
3. Insert a non-empty line in the PHP section (e.g. `echo "hello!";` on line 24)
 1. Try and comment line 24 with Ctrl+E: it inserts `//~ ` at 
the start of the line.  Good!  Try and the same on line 31: it inserts ``.  Good again!  Toggle both back to not commented.
4. Open *filetypes.php* (*Tools → Configuration files → Filetype configuration 
files → Scripting languages → filetypes.php*)
5. Change the value of `comment_single` to make it empty.  Save it.
6. Try commenting line 24: it inserts ``  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1758#issuecomment-362671288

Re: [Github-comments] [geany/geany] HTML comments inserted in PHP files (#1758)

2018-02-02 Thread Matthew Brush
More information please.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1758#issuecomment-362619370

[Github-comments] [geany/geany] HTML comments inserted in PHP files (#1758)

2018-02-02 Thread elextr
Reported on the ML.  Possibly due to 
[this](https://github.com/geany/geany/blob/16020ddc6cd32a3aa121b89edc8aeb6a45e78775/src/editor.c#L2815)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1758

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-02-02 Thread elextr
> appending a note like "this setting might be overridden by open projects" or 
> something like this.
I guess users know when they have a project opened.

Yeah, thats easier, but the tooltip doesn't show unless the user hovers for a 
period, so the insensitive is important too.

> Another solution could be to show some sort of symbol, like warning sign or 
> the like, 

Trouble is no symbol is an obvious "this is overridden" especially that new 
users will understand automatically, and its new users who need the warning the 
most.  Thats why setting insensitive is useful, it makes the user stop and 
think for a moment :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-362541635

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-02-02 Thread Enrico Tröger
I like the approach to tell the user that some global settings will be 
overridden by projects to reduce confusion.

When changing tooltips, it might be easier to change the original tooltips in 
the Glade file by simply appending a note like "this setting might be 
overridden by open projects" or something like this.
I guess users know when they have a project opened.

Another solution could be to show some sort of symbol, like warning sign or the 
like, next to those settings which can be overridden by projects in the 
preferences dialog. Those symbols could then have a generic tooltip.

Changing tooltips of all settings which can be overridden is probably a tedious 
work and might make the code less readable for little effect.


Just my 2cents.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-362538574

Re: [Github-comments] [geany/geany] Selecting Interface language (#1757)

2018-02-02 Thread Enrico Tröger
One of the mentioned ways to set the LANG environment variable is described on 
https://www.geany.org/Documentation/FAQ#QQuestions11.

Not sure about the RTL issue. The mentioned bug in Gimp doesn't apply to Geany 
I think.
You could try setting the `LANG`, `LC_ALL` and `LANGUAGE` environment 
variables, ideally one of them also affects the RTL settings.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1757#issuecomment-362536232