Re: [Github-comments] [geany/geany-plugins] Build error with 1.37 release (#1023)

2020-11-07 Thread Matthew Brush
Reopened #1023. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1023#event-3970334423

Re: [Github-comments] [geany/geany-plugins] Build error with 1.37 release (#1023)

2020-11-07 Thread Matthew Brush
Then it is a bug. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1023#issuecomment-723514866

Re: [Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)

2020-11-07 Thread Colomban Wendling
OK, I confirm this *if the comment marker is set to a single space ` `*. The default is ` ~`, in which case the issue doesn't appear. However, there indeed is a bug here; it looks like we're using the *toggle comment* feature, which has the side effect of possibly *un*commenting lines, which

[Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)

2020-11-07 Thread Ian Kenney
Geany version: 1.36 Attempting to create a `snippets.conf` by Tools -> Configuration Files -> snippets.conf brings up a file with comments that are all inverted. ``` Geany's snippets configuration file # # use \n or %newline% for a new line (it will be replaced by the used EOL char(s) - LF,

Re: [Github-comments] [geany/geany] User defined snippets not being detected (#2646)

2020-11-07 Thread Ian Kenney
Yup that does it. Thanks for the clarification. The confusion stems from another potential issue, which I will open soon. This one is closed though. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] User defined snippets not being detected (#2646)

2020-11-07 Thread Ian Kenney
Closed #2646. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2646#event-3970270957

Re: [Github-comments] [geany/geany-plugins] Problem with "Lua Script" after upgrade (GTK 3) (#690)

2020-11-07 Thread Colomban Wendling
@Skif-off try: ```diff diff --git a/geanylua/glspi_dlg.c b/geanylua/glspi_dlg.c index f0553853..c7d9718a 100644 --- a/geanylua/glspi_dlg.c +++ b/geanylua/glspi_dlg.c @@ -163,10 +163,14 @@ static gint glspi_choose(lua_State* L) scroll=gtk_scrolled_window_new(NULL, NULL);

Re: [Github-comments] [geany/geany-plugins] Build error with 1.37 release (#1023)

2020-11-07 Thread rezso
Closed #1023. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1023#event-3970265416

Re: [Github-comments] [geany/geany-plugins] Build error with 1.37 release (#1023)

2020-11-07 Thread rezso
I tried it, and works. Thank you. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1023#issuecomment-723503381

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread elextr
@b4n, ok, so long as whatever mechanism is simple for users to override if the theme is inappropriate, not all themes are done well, and when it comes to colours peoples vision differs markedly. And the override is documented in the Geany manual!!! [getting in ahead of time] -- You are

Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)

2020-11-07 Thread Colomban Wendling
> Yeah but I was wondering about @lmforget, @Bergamask and @Chicopower who had > problems with the original 1.37 installer but got it working with the "-2" > installer. This might indicate there was additionally an independent problem. As @Chicopower said, they might all have tried something

Re: [Github-comments] [geany/www.geany.org] Geany e. V. General Assembly 2020 was done (#27)

2020-11-07 Thread elextr
Well, as the subject line is not part of a specific meeting report it does not relate to a specific date, so no need to use terms like "so far" or the formal "at this time" that relate to a point in time. I would just say "None scheduled". Then you can have "unscheduled" meetings at any

Re: [Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-07 Thread Colomban Wendling
> What about cherry-picking > [3ab2518](https://github.com/geany/geany/commit/3ab2518bc254994ea7fd789eda721f9514210e40) > into the `1.37` branch, update NEWS et. al and release. > In this PR we could then afterwards simplify the code as suggested for 1.38+. Sounds good to me. I prep'd the 1.37

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread Colomban Wendling
@elextr well, yes and no; in theory you can't really get any color from CSS, as there might not be any -- could be image, gradient or whatnot, although it's less true for text. What you would normally do is use the appropriate CSS class and it'd be styled the right way whatever that is. In

Re: [Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-07 Thread elextr
@elextr commented on this pull request. > @@ -406,7 +406,7 @@ static gint get_windows_socket_port(void) if (! g_file_test(configfile, G_FILE_TEST_IS_REGULAR)) { geany_debug( - "No user config file found, use default TCP port (%s).", +

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread elextr
> I wonder if it's possible to access the colours based on GtkMessageType like > GtkInfoBar does, so they come from the theme? This is sort of like web CSS > frameworks that provide basic colours for ex. warning, danger, primary, etc. Good idea for the default if not user custom colour is

Re: [Github-comments] [geany/geany] Mac OS dark mode complier color in the Message Window (#2647)

2020-11-07 Thread Matthew Brush
I have no idea about Macos, I was just linking your issue to the others about the bad colours when dark mode/themes are used, sorry. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Mac OS dark mode complier color in the Message Window (#2647)

2020-11-07 Thread zz273
Hi @codebrainz, thank you for your reply. But I was wondering maybe I can block the dark mode specific to Geany? Do you think it is possible? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Mac OS dark mode complier color in the Message Window (#2647)

2020-11-07 Thread Matthew Brush
Sounds related to the recent https://github.com/geany/geany/issues/2644 and similar previous issues. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2647#issuecomment-723495024

Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)

2020-11-07 Thread Matthew Brush
I noticed the slow startup on Windows since pre-releases of 1.37, I assumed it was something with my computer/Windows. It's not a huge deal, but it certainly seems slower than it ought to be. Possibly related: https://github.com/geany/geany-osx/issues/20 Startup time in Ubuntu 20.04 seem

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread Colomban Wendling
I think there are style classes for that yes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723493984

[Github-comments] [geany/geany] Mac OS dark mode complier color in the Message Window (#2647)

2020-11-07 Thread zz273
Hi all, I just downloaded Geany 1.37. The full dark mode is beautiful. But when I compile the code, the color in the Complier Window is not clear. (attached) https://user-images.githubusercontent.com/60077140/98450956-5b01c200-210f-11eb-8e9f-4e017c3ee89d.png;> I also try to block the dark

Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)

2020-11-07 Thread Bergamask
I don't know if it helps but what I notice is that 1.37-2 takes more time to load than 1.36. 1.36 opened immediately after the click instead 1.37-2 need some second. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-osx] Long startup times after upgrade to 1.37 (#20)

2020-11-07 Thread Jiří Techet
At least on my machine it's around 2s to start with 1 file open - and I think it was about the same time with previous releases too (I think it's mainly because all the dylibs that have to be loaded plus signing verification). -- You are receiving this because you are subscribed to this

Re: [Github-comments] [geany/geany-plugins] Build error with 1.37 release (#1023)

2020-11-07 Thread Matthew Brush
Could be a clash with another file including `stdbool.h` or also defining own `bool` type. IMO, it should either include `stdbool.h` and use the standard `bool` (alias of `_Bool`) or else use `gboolean` that is already available via the `glib.h` include. @rezso if you want to test, try

Re: [Github-comments] [geany/geany] User defined snippets not being detected (#2646)

2020-11-07 Thread Matthew Brush
All lines starting with `#` are comments, same as with Python. Try uncommenting at least `[Python]` line and the line you added. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread Matthew Brush
I wonder if it's possible to access the colours based on `GtkMessageType` like `GtkInfoBar` does, so they come from the theme? This is sort of like web CSS frameworks that provide basic colours for ex. warning, danger, primary, etc. -- You are receiving this because you are subscribed to this

Re: [Github-comments] [geany/geany-osx] Long startup times after upgrade to 1.37 (#20)

2020-11-07 Thread Matthew Brush
Likely totally unrelated, but I noticed on Windows it takes quite a while to startup too, maybe 5-10 seconds with 0-1 files open. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany-plugins] Build error with 1.37 release (#1023)

2020-11-07 Thread rezso
The build fails in prettyprinter plugin: In file included from /usr/include/unicode/umachine.h:52, from /usr/include/unicode/utypes.h:38, from /usr/include/unicode/ucnv_err.h:88, from /usr/include/unicode/ucnv.h:52, from

[Github-comments] [geany/geany] User defined snippets not being detected (#2646)

2020-11-07 Thread Ian Kenney
Geany version: 1.36 OS: Linux Mint 20 Copying `/usr/share/geany/snippets.conf` to `$HOME/.config/geany/snippets.conf` and replacing the block ``` # [Python] # for=for i in xrange(%cursor%):\n\t%cursor% # if=if %cursor%:\n\t # elif=elif %cursor%:\n\t # else=else:\n\t # while=while %cursor%:\n\t

Re: [Github-comments] [geany/geany-osx] Long startup times after upgrade to 1.37 (#20)

2020-11-07 Thread Jiří Techet
Have you also tried 1.37-3? Are there any differences in startup times when no files are opened? Do you use some plugins, e.g. ProjectOrganizer that could do some extra work? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] Problem with "Lua Script" after upgrade (GTK 3) (#690)

2020-11-07 Thread Colomban Wendling
Doesn't look like a theme problem from @Skif-off's screenshots (I can't see the first one from the OP BTW), looks like incorrect widget packing with GTK3's defaults. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Colomban Wendling
@b4n commented on this pull request. > fi done - rmdir mingw32 + rmdir mingw64 + fi +} + +delayed_post_install() { + if [ "$run_pi" ]; then + echo "Execute delayed post install tasks" + #

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread carlos157oliveira
I had a idea. It would involve a little bit code. As my original idea, we would do some basic calculations to detect light and dark themes through _GtkStyleContext_, then load _geany.css_ or _geany-dark.css_ accordingly. I think this solution is more maintainable than caring for every theme. It

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Colomban Wendling
@b4n commented on this pull request. > ls $cachedir/mingw-w64-${ABI}-${1}-${package_version}-* | sort > -V | tail -n 1 else - pacman -Sp mingw-w64-${ABI}-${1} + # -dd to ignore dependencies as we listed them already above in $packages OK. I

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Colomban Wendling
@b4n commented on this pull request. > @@ -1,43 +1,51 @@ -#!/bin/sh +#!/bin/bash `$(…)` is no bashism :) But OK, your answer fair enough, color me convinced. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Enrico Tröger
@eht16 commented on this pull request. > ls $cachedir/mingw-w64-${ABI}-${1}-${package_version}-* | sort > -V | tail -n 1 else - pacman -Sp mingw-w64-${ABI}-${1} + # -dd to ignore dependencies as we listed them already above in $packages Even

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Enrico Tröger
@eht16 commented on this pull request. > @@ -1,43 +1,51 @@ -#!/bin/sh +#!/bin/bash There are a couple of `$(command...)` in there even though I might added them after I set it to bash :+1: The reason is this way we don't need to care whether to use bashisms or not. And shell portability

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Enrico Tröger
@eht16 commented on this pull request. > fi done - rmdir mingw32 + rmdir mingw64 + fi +} + +delayed_post_install() { + if [ "$run_pi" ]; then + echo "Execute delayed post install tasks" + #

Re: [Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-07 Thread Enrico Tröger
> LGTM. Changing the wording might be good and I'm not against it here, but as > a rule of the thumb I usually prefer to avoid unnecessary changes in bugfix > releases. Yeah, right you are. What about cherry-picking 3ab2518 into the `1.37` branch, update NEWS et. al and release. In this PR we

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Colomban Wendling
@b4n commented on this pull request. > @@ -1,43 +1,51 @@ -#!/bin/sh +#!/bin/bash why? I didn't test, but didn't spot any obvious bashisms, are there any (really) required? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Colomban Wendling
@b4n commented on this pull request. > ls $cachedir/mingw-w64-${ABI}-${1}-${package_version}-* | sort > -V | tail -n 1 else - pacman -Sp mingw-w64-${ABI}-${1} + # -dd to ignore dependencies as we listed them already above in $packages curious

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Colomban Wendling
@b4n commented on this pull request. > fi done - rmdir mingw32 + rmdir mingw64 + fi +} + +delayed_post_install() { + if [ "$run_pi" ]; then + echo "Execute delayed post install tasks" + #

Re: [Github-comments] [geany/www.geany.org] Geany e. V. General Assembly 2020 was done (#27)

2020-11-07 Thread Enrico Tröger
Previously we used "None planned" (see https://github.com/geany/www.geany.org/commit/d82f9412bae876a3764d0259a73d8b13e35141db). @elextr what would you prefer? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] Problem with "Lua Script" after upgrade (GTK 3) (#690)

2020-11-07 Thread Skif-off
GTK2 vs. GTK3: ![geany choose](https://user-images.githubusercontent.com/6333198/98442970-c5236280-2121-11eb-995b-c6a2065680bf.png) Xubuntu 20.04, Geany 1.37, GTK 3.24.20, GLib 2.64.3. Is this the same problem? I tried Adwaita, Greybird (my default theme), Numix, but with the same result. Is

[Github-comments] [geany/www.geany.org] Geany e. V. General Assembly 2020 was done (#27)

2020-11-07 Thread Frank Lanitz
You can view, comment on, or merge this pull request online at: https://github.com/geany/www.geany.org/pull/27 -- Commit Summary -- * Geany e. V. General Assembly 2020 was done -- File Changes -- M page_content/association.md (6) -- Patch Links --

Re: [Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-07 Thread Colomban Wendling
@b4n approved this pull request. LGTM. Changing the wording might be good and I'm not against it here, but as a rule of the thumb I usually prefer to avoid unnecessary changes in bugfix releases. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-07 Thread Colomban Wendling
@b4n commented on this pull request. > @@ -406,7 +406,7 @@ static gint get_windows_socket_port(void) if (! g_file_test(configfile, G_FILE_TEST_IS_REGULAR)) This code could actually be simplified by basically having the same code path for the with and without config cases: just don't

Re: [Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-07 Thread Enrico Tröger
@eht16 commented on this pull request. > @@ -406,7 +406,7 @@ static gint get_windows_socket_port(void) if (! g_file_test(configfile, G_FILE_TEST_IS_REGULAR)) { geany_debug( - "No user config file found, use default TCP port (%s).", +

Re: [Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-07 Thread Enrico Tröger
@eht16 pushed 1 commit. 3efe4a8df7150802c14b986c7af089a067e6e1ae Improve debug message wording -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)

2020-11-07 Thread Chicopower
In my case, this was the first Geany installation on my machine when i tried 1.37. Not working then i installed 1.36 and it worked. I was able to use it a little bit and customize some preferences settings. After that, i uninstalled 1.36 and installed 1.37-2. It worked and my preferences from

Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)

2020-11-07 Thread Enrico Tröger
Yeah but I was wondering about @lmforget, @Bergamask and @Chicopower who had problems with the original 1.37 installer but got it working with the "-2" installer. This might indicate there was additionally an independent problem. @ndroock1 and @Rasbats could you please try:

Re: [Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-07 Thread elextr
@elextr commented on this pull request. > @@ -406,7 +406,7 @@ static gint get_windows_socket_port(void) if (! g_file_test(configfile, G_FILE_TEST_IS_REGULAR)) { geany_debug( - "No user config file found, use default TCP port (%s).", +

Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)

2020-11-07 Thread elextr
Presuming you mean user config, probably people it worked for simply continued to use their existing config so they always had one. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany-osx] Long startup times after upgrade to 1.37 (#20)

2020-11-07 Thread Frank Lanitz
After upgrading to 1.37-2 the startup with about 20-30 files takes ~10s on my 10.15,7 -- before it was <<5s -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/20

[Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-07 Thread Enrico Tröger
This led to crashes on Windows when starting without an existing configuration file. Closes #2639. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2645 -- Commit Summary -- * Fix wrong format specifier in debug message -- File Changes --

Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)

2020-11-07 Thread Enrico Tröger
Oh, great. I found the cause and it's just a stupid typo in a debug message :(. If Geany is started without an existing configuration file, we log a message that the default TCP port for IPC is used (#2585). But in this log message I specified the wrong format specified for logging an integer

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Enrico Tröger
Just pushed 15101c2 to replace GTK2 by GTK4 and updated PR description accordingly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2590#issuecomment-723431848

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Enrico Tröger
@eht16 pushed 2 commits. 3ff72532e434f5fa3884ae459ef62e667f2cca9f Remove hard-coded paths and installer name from NSIS installer script 15101c26b00f8c256a690ac6c7c4f260be1bf6d0 Windows: Replace GTK2 by (upcoming) GTK4 in bundle script -- You are receiving this because you are subscribed to

Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)

2020-11-07 Thread Rasbats
Enrico... Win8.1 was where I had the problem with 1.37 not starting. Yesterday I upgraded to Win10 and today before doing anything else the debug version works, after uninstalling 1.36 and installing 1.37. As a test I renamed config folder and disabled firewall. Geany did not start. Went back

Re: [Github-comments] [geany/geany] . key is not working properly (#1902)

2020-11-07 Thread Enrico Tröger
Duplicate of #2472, #2408, #2527 and https://stackoverflow.com/questions/63897516/why-are-the-new-releases-of-geany-editor-having-problems-with-some-characters. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread Colomban Wendling
One workaround that has been implemented in e.g. MATE's file manager Caja is the ability to load custom CSS based on theme name. E.g., we could imagine try and load geany-$THEME.css, if it exists. That would clearly not be perfect, but could allows us (or the user) to provide support for some

Re: [Github-comments] [geany/www.geany.org] Add donation information via Liberapay (#26)

2020-11-07 Thread Enrico Tröger
Merged #26 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/26#event-3969749989

Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)

2020-11-07 Thread Enrico Tröger
@ndroock1 > Will this install has any effect on 1.36? ( I am in a busy project at the > moment. Can't afford to jeopardize it. ) I don't think so, it should be safe to try. To start with a fresh config simply rename the Geany config folder, so you can rename it back again later