[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)

2024-04-21 Thread elextr via Github-comments
@b4n the only one that I would question is the one that @eht16 had questioned, so I was waiting until that was decided. :-P "Data contains NULs" is referring to the result of the conversion, but the user doesn't know that, they only have the input file and it may not contain NULs, eg it might

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

2024-04-21 Thread elextr via Github-comments
@elextr requested changes on this pull request. LGBI except the ABI thing. > @@ -60,6 +60,8 @@ typedef struct GeanySearchPrefs gbooleanuse_current_file_dir; /* find in files directory to use on showing dialog */ gbooleanhide_find_dialog; /* hide

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-21 Thread elextr via Github-comments
Well, Ubuntu LTS 20.04 has a year of support left (April 2025) and it has Meson 0.54, maybe it has to be `#ifdef`ed (or whatever the meson equivalent is) to change what it uses at 0.56 to get rid of the message. Kind of annoying that a Windows only feature causes a message on Linux, maybe

[Github-comments] Re: [geany/geany-plugins] BUG during tab-browsing with the keyboard in the sidebar when a new tab is in the sidebar (Issue #1318)

2024-04-21 Thread ralf3u via Github-comments
I can't reproduce the issue in Geany 2.0 in Lubuntu 23.10. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1318#issuecomment-2068219856 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] BUG during tab-browsing with the keyboard in the sidebar when a new tab is in the sidebar (Issue #1318)

2024-04-21 Thread ralf3u via Github-comments
Closed #1318 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1318#event-12552123490 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)

2024-04-21 Thread Colomban Wendling via Github-comments
didn't you have a fresh install before already? Not sure, but maybe your hardware (hard drive maybe) is faulty? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2068206133 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)

2024-04-21 Thread Colomban Wendling via Github-comments
Closed #3843 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#event-12552031399 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)

2024-04-21 Thread FxZng via Github-comments
Thank you. I have decided to take an easy way out and do fresh install. All works now. Cheers. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2068202888 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Indentation on pasting of a multiline text (Issue #3845)

2024-04-21 Thread Lost Valley via Github-comments
> it probably also cannot be the default Agree > What if the clipboard already has indentation for the subsequent lines? > ... Good point, nice dissection of the problem. I would go with a rather simplistic algo, that IMO covers a lot of cases without trying to be too smart: ``` During

[Github-comments] Re: [geany/geany-plugins] Fix handling of locals (PR #1294)

2024-04-21 Thread Frank Lanitz via Github-comments
I did not yet plan any – maybe a point-release of Geany would be useful, too – but we should do it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1294#issuecomment-2068199943 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany-plugins] Fix handling of locals (PR #1294)

2024-04-21 Thread Colomban Wendling via Github-comments
@frlan do you plan on making a point-release, given the above-mentioned reasons? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1294#issuecomment-2068187873 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-21 Thread Colomban Wendling via Github-comments
@b4n requested changes on this pull request. ```console ../meson.build:887: WARNING: Project targets '>= 0.53' but uses feature introduced in '0.56.0': win_subsystem arg in executable. […] WARNING: Project specifies a minimum meson_version '>= 0.53' but uses features which were added in newer

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-21 Thread Colomban Wendling via Github-comments
@eht16 This doesn't seem to have any impact on Linux, so looks fine on that end. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2068186588 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)

2024-04-21 Thread Colomban Wendling via Github-comments
>From looking at the backtrace and the relevant GTK source code, this seems >entirely unrelated to Geany itself (apart for Geany using GTK3, that is). It >looks like either there is a bug in your `XVisualIDFromVisual()` (which could >come from a driver bug maybe?), or a bug in GTK on how it

[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)

2024-04-21 Thread Colomban Wendling via Github-comments
@elextr Tell me if there are still strings to be updated or better error to report, I can make another follow-up :wink: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3716#issuecomment-2068175821 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] Encodings UI improvements (PR #3720)

2024-04-21 Thread Colomban Wendling via Github-comments
Merged #3720 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3720#event-12551819882 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)

2024-04-21 Thread Colomban Wendling via Github-comments
Merged #3716 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3716#event-12551817780 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add Ocaml ctags parser (PR #3163)

2024-04-21 Thread Colomban Wendling via Github-comments
Merged #3163 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3163#event-12551564071 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)

2024-04-21 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > geany_debug("Couldn't convert from %s to UTF-8.", > charset); + g_set_error(error, G_CONVERT_ERROR, G_CONVERT_ERROR_ILLEGAL_SEQUENCE, + _("Data contains NULs")); Yes, if

[Github-comments] Re: [geany/geany] Add Ocaml ctags parser (PR #3163)

2024-04-21 Thread Enrico Tröger via Github-comments
I tested this last week and forgot to comment :). It works fine and parses the random Ocaml code I found on the net properly. Though I don't know the language at all :D. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3163#issuecomment-2068120694 You

[Github-comments] Re: [geany/geany-plugins] Error: Most Plugins not binary compatible with this release of geany. Therefore not available in Plugin Manager Dialog (Issue #1292)

2024-04-21 Thread Enrico Tröger via Github-comments
@masla84 if this still persists, please check Help->Debug Messages in Geany, at the beginning loading of plugins is logged and also if there any errors occurred. Alternatively, uninstall all of your Geanys, remove the config folder (or at least clean the plugin paths manually) and try again.

[Github-comments] Re: [geany/geany-plugins] Error: Most Plugins not binary compatible with this release of geany. Therefore not available in Plugin Manager Dialog (Issue #1292)

2024-04-21 Thread Enrico Tröger via Github-comments
Closed #1292 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1292#event-12551239724 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Allow to disable: Are you sure to replace in the whole session? (Issue #3702)

2024-04-21 Thread Enrico Tröger via Github-comments
A new various pref to disable the confirmation dialog is added in #3851. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3702#issuecomment-2068108109 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Allow to disable: Are you sure to replace in the whole session? (Issue #3702)

2024-04-21 Thread Enrico Tröger via Github-comments
Reopened #3702. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3702#event-12551227374 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Add various pref replace in session (PR #3851)

2024-04-21 Thread Enrico Tröger via Github-comments
Allow brave users to disable the confirmation dialog when replacing text in the whole session. While modifying the docs, I noticed a missing various pref in the table and added it. Because of the long names of the other and the new setting, the table grew and needed reformatting. I put this

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-21 Thread Frank Lanitz via Github-comments
@frlan pushed 1 commit. 6728529322b028c0e0791ba8ecec968042ac8c6d LaTeX: Switch handling of insert (list) environments over to snippets workflow -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-21 Thread Frank Lanitz via Github-comments
@frlan commented on this pull request. > if (utils_str_equal(environment, "block") == TRUE) { - g_string_append(tmpstring, "}{}"); + tmpstring =

[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)

2024-04-21 Thread Enrico Tröger via Github-comments
Merged #3656 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3656#event-12551171089 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fortran function random_init not highlighted (Issue #3362)

2024-04-21 Thread Enrico Tröger via Github-comments
Closed #3362 as completed via #3656. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3362#event-12551171193 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Bazel build config files are based on Python (#2088)

2024-04-21 Thread Enrico Tröger via Github-comments
Closed #2088. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2088#event-12551166960 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-21 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > if (utils_str_equal(environment, "block") == TRUE) { - g_string_append(tmpstring, "}{}"); + tmpstring =

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-21 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. Looks good. As you know I'm not LaTeX expert and so I'm wondering if it is on purpose that different environments produce quite different stylings: ``` \begin{block}{} _ \end{block} \begin{itemize} \item _ \end{itemize} \begin{table} _

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-04-21 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 1931fcc2f4d5de46871c85a782903d8c4d41e699 Export some types/functions so plugins have access to Geany symbol icons -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/6db24b8a5f6eb56d3b883ea7c1ae2f78401e4692..1931fcc2f4d5de46871c85a782903d8c4d41e699

[Github-comments] [geany/geany] Complete plugin extensions patches (PR #3850)

2024-04-21 Thread Jiří Techet via Github-comments
This is the complete counterpart of #3849, including the sidebar symbol patches and also https://github.com/geany/geany/pull/3707 and https://github.com/geany/geany/pull/3572. These are all the diffs against Geany itself from https://github.com/techee/geany-lsp. You can view, comment on, or

[Github-comments] [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-04-21 Thread Jiří Techet via Github-comments
This is my second attempt on the LSP API as originally proposed by #3571. I changed several things: 1. I renamed the struct `Lsp` to `PluginExtension` - theres nothing LSP-specific in this interface and it could be used by other plugins too (or possibly extended in the future if some plugins

[Github-comments] [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

2024-04-21 Thread Frank Lanitz via Github-comments
This MR migrates the feature to insert any environment over to Geanys snippets workflow. Hence we dont need to bother about indention, like breaks etc. this much anymore. Also due to the cursor-feature it ensures to position the cursor at the right place , independent from the line break,

[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)

2024-04-21 Thread elextr via Github-comments
@eht16 sure, doesn't break anything if nobody wants to fix it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3656#issuecomment-2068044244 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Bazel build config files are based on Python (#2088)

2024-04-21 Thread Stephen Wassell via Github-comments
I no longer use Geany so if nobody else is interested you're welcome to close. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2088#issuecomment-2068043452 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Bazel build config files are based on Python (#2088)

2024-04-21 Thread Enrico Tröger via Github-comments
@StephenWassell is this still relevant or can we close this? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2088#issuecomment-2068040167 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix search entry after editing the toolbar (PR #3838)

2024-04-21 Thread Enrico Tröger via Github-comments
It seems to work without the guard as well. The connect_proxy function is called four times here, but it's the same on Linux and Windows and in either way, the search toolbar item still works after re-ordering. Since we cannot reproduce this anymore and the "fix" is so long ago, maybe it was

[Github-comments] Re: [geany/geany] Help command should check browser tool's return value (Issue #3468)

2024-04-21 Thread Enrico Tröger via Github-comments
Closed #3468 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3468#event-12550837837 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Encodings UI improvements (PR #3720)

2024-04-21 Thread Enrico Tröger via Github-comments
Looks and works great, tested on Linux and Windows! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3720#issuecomment-2068035433 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)

2024-04-21 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > geany_debug("Couldn't convert from %s to UTF-8.", > charset); + g_set_error(error, G_CONVERT_ERROR, G_CONVERT_ERROR_ILLEGAL_SEQUENCE, + _("Data contains NULs")); Do we

[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)

2024-04-21 Thread Enrico Tröger via Github-comments
There are actually some encodings which seem not support on Windows: ``` 15:31:32.356445: Geany INFO : Encoding ISO-8859-10 is not supported by the system 15:31:32.356445: Geany INFO : Encoding ISO-8859-14 is not supported by the system 15:31:32.356445: Geany INFO

[Github-comments] Re: [geany/geany-plugins] lineoperations: Removed debug code (fixes #1322) (PR #1323)

2024-04-21 Thread Enrico Tröger via Github-comments
Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1323#issuecomment-2068027676 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Line Operations plugin outputs "Value: 0" to terminal when Geany launches (Issue #1322)

2024-04-21 Thread Enrico Tröger via Github-comments
Closed #1322 as completed via #1323. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1322#event-12550784189 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] lineoperations: Removed debug code (fixes #1322) (PR #1323)

2024-04-21 Thread Enrico Tröger via Github-comments
Merged #1323 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1323#event-12550784154 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)

2024-04-21 Thread Enrico Tröger via Github-comments
Don't we want to merge this anyway? Maybe the performance impact is tolerable and then it is still an improvement for Fortran users. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3656#issuecomment-2068027071 You are receiving this because you are

[Github-comments] Re: [geany/geany] in document.c symbols_find_typenames_as_string returns always empty string, if tag_parser=Pascal (Issue #3848)

2024-04-21 Thread elextr via Github-comments
The problem with loading all external tags into the wordlists is that the lexers only recognise syntactic elements, in this case "identifier" and not the semantics that it is a typename or a function name. Also they have no knowledge of scope and no way to pass that information to them. The

[Github-comments] Re: [geany/geany] in document.c symbols_find_typenames_as_string returns always empty string, if tag_parser=Pascal (Issue #3848)

2024-04-21 Thread HoTschir via Github-comments
Ok, thats the cause of current behavior. But from my point of view, it should not be so. Then at least for every file type an own TM_GLOBAL_TYPE_MASK should be definable. tm_workspace.c seems to be written for C/C++ language only. I see also in other parts of source code to much focus on C and

[Github-comments] Re: [geany/geany] in document.c symbols_find_typenames_as_string returns always empty string, if tag_parser=Pascal (Issue #3848)

2024-04-21 Thread HoTschir via Github-comments
Closed #3848 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3848#event-12550086680 You are receiving this because you are subscribed to this thread. Message ID: