Closed #645.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/645#event-1990602940
Closed in favour of #791
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/645#issuecomment-442193851
This PR is still on the 1.34.0 milestone and should maybe be replaced with PR
#791.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/645#issuecomment-442192011
FYI I created a new pull request that doesn't break compatibility with GTK2:
#790.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/645#issuecomment-440274221
>From a glance, it appears the only thing making this GTK3-only is the changes
>to the build system which require GTK3 instead of either major version.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Just to be clear, the policy of refusing GTK3 only changes is now meaning most
new or updating users have no debugger with Geany.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Because it only supports GTK3 and no longer supports GTK2.
@frlan @b4n given Fedora and Debian and all its derivatives now distribute a
GTK3 version of Geany thats the majority of users. There are not many left
distributing the GTK2 versions of Geany. You are gonna have to decide at some
with multiple people having confirmed that this works, is there any reason why
this is currently staled?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/645#issuecomment-410554305
This pull-request works for me also.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/645#issuecomment-400243525
Thanks @pmjobin. I tried this out, and I can confirm that the updated code runs
without errors, and I am able to change the active frame in the stack.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@mattcaswell Thanks for your help. I pushed a fix to simplify handling of
GTK_CELL_RENDERER_MODE based on an earlier suggestion by @b4n. Changing the
current active frame in the stack seems to work as expected with this fix
applied.
--
You are receiving this because you are subscribed to this
@pmjobin pushed 1 commit.
04f58bb Simplified syntax for initialization of debugger plugin icons.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
mattcaswell requested changes on this pull request.
>
cell->enabled = TRUE;
cell->condition = NULL;
cell->hitscount = 0;
-
- cell_renderer->mode = GTK_CELL_RENDERER_MODE_ACTIVATABLE;
+
+ g_value_init(, G_TYPE_ENUM);
This should be:
> As for the permission, as clever as it is the plugin is unmaintained (no
> matter what the MAINTAINERS file states, Alexander is gone as of the latest
> news I had) anyway, so it's up for grabs :)
Wasn't aware of that, so yeah, its up to the contributor.
As for GTK4, thats a whole other
@elextr myeah maybe as it's not really maintained it could make some sense.
Yet, from past experience only a few things are tricky to keep compatible
between both versions, so (without having looked carefully) I wouldn't think
most of is would be hard to keep compatible. And removing
> Anyway, it's just my 2ยข and it's up to the maintainer of the plugin (which,
> even if I fixed a bunch of big issues I'm not), and for myself I don't really
> care as I use GTK3 but for testing purposes anyway.
A new plugin doesn't need the permission of the maintainer of the GTK2 version,
so
> I feel like having both is meant to lead to duplication of effort, or worse
> having some people contributing to the GTK2 and some to the GTK3 version.
@b4n, yes I would agree totally, if there was active development going on, but
last commit on debugger is December __2016__.
--
You are
@elextr I don't really see this as a valid approach to support both, more of a
way of not having the gut of saying GTK2 version is gone (no offense, I just
didn't find a nice way to put it). If really the other one is dead, just say
that if somebody wants the GTK2 version they oughta use the
> I didn't check how hard it'd be to support both GTK2 and GTK3, but it seems a
> little sad to switch from one restriction to the other. Well, I guess it
> becomes less and less mandatory to support GTK2, but still.
@b4n, @pmjobin suggest the same thing I have said elsewhere, don't support
b4n commented on this pull request.
> @@ -1,9 +1,9 @@
AC_DEFUN([GP_CHECK_DEBUGGER],
[
GP_ARG_DISABLE([Debugger], [auto])
-GP_CHECK_PLUGIN_GTK2_ONLY([Debugger])
+GP_CHECK_PLUGIN_GTK3_ONLY([Debugger])
I didn't check how hard it'd be to support both GTK2 and GTK3, but it seems a
b4n commented on this pull request.
>
cell->enabled = TRUE;
cell->condition = NULL;
cell->hitscount = 0;
-
- cell_renderer->mode = GTK_CELL_RENDERER_MODE_ACTIVATABLE;
+
+ g_value_init(, G_TYPE_ENUM);
+ g_value_set_enum(,
@cesspit Can you please review?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/645#issuecomment-345516482
Tested on Fedora 27 using stock Geany available from repo.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/645
-- Commit Summary --
* Ported 'Debugger' plugin to GTK+3.
-- File Changes --
M build/debugger.m4 (4)
M
23 matches
Mail list logo
