> Yes, that was what I was asking, describing a feature as "I want it to work
> like Vscode" is unhelpful if the reader doesn't use Vscode or that feature of
> Vscode, whereas "I want it to do xyz when I click blah because I have found
> it useful in Vscode" is of course fine.
Sounds like
> but I acknowledge that sometimes comparisons aren't always adequate and
> shouldn't be solely relied upon to express a desired feature.
Yes, that was what I was asking, describing a feature as "I want it to work
like Vscode" is unhelpful if the reader doesn't use Vscode or that feature of
I forgot to mention, based on your feedback @elextr , I expanded the
[README.md](https://github.com/andy5995/pinner/blob/trunk/README.md) with
hopefully a better explanation of the goal of the plugin, and added a link to a
demo video.
--
Reply to this email directly or view it on GitHub:
>write the documentation explaining what this plugin is supposed to do, sounds
>like it does something different to what @eht16 understood "pin" to mean, and
>I have always been confused about what it was meant to do.
I'm happy to elaborate an idea or re-frame a goal if I haven't made myself
Couple of comments:
1. write the documentation explaining what this plugin is supposed to do,
sounds like it does something different to what @eht16 understood "pin" to
mean, and I have always been confused about what it was meant to do. (and do
not describe it in terms of some other
> @eht16 It looks like we were working on something different but similar? ;) I
> think incorporating something like that into this plugin would be suitable.
Yes, my approach was for a different use case. I like to have a tab/document
always in the visible area of the notebook tab list for easy
I moved this to https://github.com/andy5995/pinner
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#issuecomment-1951367227
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #1308.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#event-11840560015
You are receiving this because you are subscribed to this thread.
Message ID:
"Unpin Document" available by right-clicking
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#issuecomment-1950262978
You are receiving
@andy5995 pushed 2 commits.
b3c3b671e74e406d95374ea0fbdd301430b1783c Add "unpin document" to right-click
menu
b58b98b4c8948e2d9d7081ddbcdfc0cae6a7a5b1 Add "Unpin" item to right-click popup
menu
--
View it on GitHub:
@andy5995 pushed 1 commit.
cd1f6876eb21e9943b097f58d584aa9101cacb34 Implment keybindings and add README.md
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/7aa35e595b1cb1cfe69f291e6597eccc78a23fbb..cd1f6876eb21e9943b097f58d584aa9101cacb34
You are receiving this
Longer filenames are now handled better, and they're left-justified with a 10
pixel margin on both sides.
@luigifab
--
Reply to this email directly or view it on GitHub:
@andy5995 pushed 1 commit.
7aa35e595b1cb1cfe69f291e6597eccc78a23fbb Acommodate for long filenames by
using an ellipse
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/e0d734c2d260f6d5634df335dff103be40afb2b0..7aa35e595b1cb1cfe69f291e6597eccc78a23fbb
You are
@andy5995 pushed 1 commit.
e0d734c2d260f6d5634df335dff103be40afb2b0 Don't use 'with_mnemonic' (fix
missing underscores)
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/259571ebebba229bffdaea28aa09e07549cf72c5..e0d734c2d260f6d5634df335dff103be40afb2b0
You are
Do you have a final screenshot?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#issuecomment-1948827375
You are receiving this because you are subscribed to this thread.
Message ID:
Ready for review and testing
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#issuecomment-1948486163
You are receiving this because you are subscribed to this thread.
Message ID:
@andy5995 pushed 1 commit.
259571ebebba229bffdaea28aa09e07549cf72c5 remove sanitize flag
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/a0f4bc8e37569afea0390306f79793099fc674a4..259571ebebba229bffdaea28aa09e07549cf72c5
You are receiving this because you are
@andy5995 commented on this pull request.
> +
+static gboolean pin_init(GeanyPlugin *plugin, gpointer pdata)
+{
+ GtkWidget *main_menu_item;
+
+ struct pindata *container = init_pindata();
+ container->plugin = plugin;
+
+ // Create a new menu item and show it
+
@andy5995 pushed 1 commit.
0c0a34fe8e14049b0210cf95a4bf7460dcfd610e Add credit for ChatGPT [skip ci]
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/295737b2721da29ee3f6586bba6a47216876a486..0c0a34fe8e14049b0210cf95a4bf7460dcfd610e
You are receiving this because
@andy5995 pushed 2 commits.
87b8b4e27b856d27296727c84bacb62c0c1ebf5b Add right-click menu/option to clear
pinned list
295737b2721da29ee3f6586bba6a47216876a486 Conditionally add sanitize flag
--
View it on GitHub:
@andy5995 pushed 3 commits.
a1fe9573bb09b841a96e01354b65a71a10c31a20 fix double-free error when freeing
list
cf40001168fa9e3b9bae629edf72d6af9af04027 fix 'stack-use-after-return` in
pin_cleanup
5391654fb522550bfab02bbebcfb7c6b3b01254f implement unpin, use hashtable
instead of GSList
--
At this point, clicking on a document in the "Pinned" tab, will open (switch
to) it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#issuecomment-1946417676
You are receiving this because you are subscribed to this thread.
Message ID:
@andy5995 pushed 1 commit.
b8d66c4101dfb12d366beb30b4d1ebb2b551d0a5 Don't auto-switch to the "Pinned" tab
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/6a96d0c7f3932fd68bf281ff8b895126e66df719..b8d66c4101dfb12d366beb30b4d1ebb2b551d0a5
You are receiving this
@andy5995 pushed 2 commits.
093184d081fdce62111d39cddc69fda07eb74088 Add UNpin function
6a96d0c7f3932fd68bf281ff8b895126e66df719 Make documents clickable and open them
--
View it on GitHub:
> I just found some old code and it seems I started with a similar approach
> some time ago: https://gist.github.com/eht16/15afd001f238f77f100a43e4129b8d20
> Use what is helpful but with care . I don't remember much its state except
> that it was working to some extend but quite buggy and
@andy5995 pushed 1 commit.
9ff65479c9e788045fdf4dc7fde471be404253a3 Add UNpin function
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/afeeb5952c1f9a56aa15117c723ecebfe2c20ba1..9ff65479c9e788045fdf4dc7fde471be404253a3
You are receiving this because you are
@andy5995 pushed 1 commit.
afeeb5952c1f9a56aa15117c723ecebfe2c20ba1 Remove header, make all functions
static
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/c1899e4369a9f5aea2266439e4355231640957b8..afeeb5952c1f9a56aa15117c723ecebfe2c20ba1
You are receiving this
> One thing I'm not sure of yet is how to pass the the list to the cleanup
> function so I can free it.
I made the list global.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#issuecomment-1944274058
You are receiving this because you
@andy5995 pushed 1 commit.
c1899e4369a9f5aea2266439e4355231640957b8 Make list global
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/73322e4a185e3e50bbd546e1bccbabc5080824e9..c1899e4369a9f5aea2266439e4355231640957b8
You are receiving this because you are subscribed
@andy5995 pushed 1 commit.
73322e4a185e3e50bbd546e1bccbabc5080824e9 add header to Makefile.am
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/18b58b305ff01e989ca5322dbe12323fc44a7289..73322e4a185e3e50bbd546e1bccbabc5080824e9
You are receiving this because you are
@andy5995 commented on this pull request.
> +
+static gboolean pin_init(GeanyPlugin *plugin, gpointer pdata)
+{
+ GtkWidget *main_menu_item;
+
+ struct pindata *container = init_pindata();
+ container->plugin = plugin;
+
+ // Create a new menu item and show it
+
@andy5995 pushed 1 commit.
18b58b305ff01e989ca5322dbe12323fc44a7289 Add non-working popup menu and func
to clear list
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/4bb86a95810c5da704794d924e11cfae11a44fef..18b58b305ff01e989ca5322dbe12323fc44a7289
You are
Duplicate checking works now. Any feedback on how I'm implementing this so far?
One thing I'm not sure of yet is how to pass the the list to the cleanup
function so I can free it.
--
Reply to this email directly or view it on GitHub:
@andy5995 commented on this pull request.
> + *
+ *
+ */
+
+#include
+#include
+
+static GtkWidget *pinned_view_vbox;
+static gint page_number = 0;
+
+struct pindata {
+ GeanyPlugin *plugin;
+GSList *list;
+};
+
+static struct pindata *init_pindata(void)
Ok to use a
@andy5995 pushed 4 commits.
50209670e24d25b8188f4d2aad5336749d72a7d0 Add Pinner plugin
5def3d767465a138aee70a8ce81787b8e83da130 Check for duplicates
3a293072756b34cee614c80ac329fd1e0bf2f3df check if doc eq NULL
4bb86a95810c5da704794d924e11cfae11a44fef use g_strdup instead of strlcpy,
point
@andy5995 pushed 1 commit.
c8dbb27032f54b13503594bbc4da240eca827e7c Check for duplicates
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/565320a5358b49939288035ad6566f05683f85e9..c8dbb27032f54b13503594bbc4da240eca827e7c
You are receiving this because you are
@andy5995 commented on this pull request.
> @@ -0,0 +1,25 @@
+include $(top_srcdir)/build/vars.build.mk
+
+plugin = pinner
+
+geanyplugins_LTLIBRARIES = pinner.la
+
+pinner_la_SOURCES = \
+ pinner.c
+
+pinner_la_CPPFLAGS = $(AM_CPPFLAGS) \
+
What I have so far works as expected.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#issuecomment-1943634516
You are receiving this
@andy5995 commented on this pull request.
> + GeanyDocument *doc = document_get_current();
+
+ if (doc != NULL && pin_list == NULL)
+ {
+ GtkWidget *label = gtk_label_new_with_mnemonic(doc->file_name);
+ gtk_widget_show(label);
+
@andy5995 pushed 1 commit.
565320a5358b49939288035ad6566f05683f85e9 Add Pinner plugin
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/8431a100f118aacf438af159a4b822469534077f..565320a5358b49939288035ad6566f05683f85e9
You are receiving this because you are
> Uhhh, that sounds interesting and like something I want to implement since
> some years already :).
I just found some old code and it seems I started with a similar approach some
time ago: https://gist.github.com/eht16/15afd001f238f77f100a43e4129b8d20
Use what is helpful but with care
@eht16 commented on this pull request.
> + GeanyDocument *doc = document_get_current();
+
+ if (doc != NULL && pin_list == NULL)
+ {
+ GtkWidget *label = gtk_label_new_with_mnemonic(doc->file_name);
+ gtk_widget_show(label);
+
Uhhh, that sounds interesting and like something I want to implement since some
years already :).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#issuecomment-1942664495
You are receiving this because you are subscribed to this thread.
@andy5995 pushed 1 commit.
8431a100f118aacf438af159a4b822469534077f Add Pinner plugin
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1308/files/3d954c351a0489fd7e45e82e168ba677e9b11d97..8431a100f118aacf438af159a4b822469534077f
You are receiving this because you are
@andy5995 commented on this pull request.
> + GeanyDocument *doc = document_get_current();
+
+ if (doc != NULL && pin_list == NULL)
+ {
+ GtkWidget *label = gtk_label_new_with_mnemonic(doc->file_name);
+ gtk_widget_show(label);
+
46 matches
Mail list logo
