@eht16 approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3178#pullrequestreview-1630059824
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #1254 as completed via #1257.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1254#event-10391068948
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #1257 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1257#event-10391068900
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 commented on this pull request.
> @@ -21,6 +21,7 @@ fstring=string_1
fcharacter=character
ftriple=string_2
ftripledouble=string_2
+attribute=identifier_1ö
`ö` :)
--
Reply to this email directly or view it on GitHub:
Merged #1264 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1264#event-10391068465
You are receiving this because you are subscribed to this thread.
Message ID:
Tested and works fine.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3178#issuecomment-1722434483
You are receiving this because you are subscribed to this thread.
Message ID:
Looks good to me. I'd be ok to merge it for 2.0.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3602#issuecomment-1764281983
You are receiving this because you are subscribed to this thread.
Message ID:
> Thanks for updating the docs - I made a few tweaks.
Thank you, applied them all.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#issuecomment-1757863336
You are receiving this because you are subscribed to this thread.
Message ID:
Implicitly require Geany 2.0 for G-P as the SpellCheck plugin makes uses of new
Scintilla API.
Is this OK?
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1277
-- Commit Summary --
* Add missing style mappings for new and updated
@eht16 pushed 1 commit.
e754f79d16dcac69bcad0da13a0fd2aaf03e6a65 Update NEWS
--
View it on GitHub:
https://github.com/geany/geany/pull/3593/files/6601ca02e3e589f1dc76ad89893cbf929420fe50..e754f79d16dcac69bcad0da13a0fd2aaf03e6a65
You are receiving this because you are subscribed to this thread.
@eht16 pushed 1 commit.
6601ca02e3e589f1dc76ad89893cbf929420fe50 Apply geany.txt suggestions from code
review
--
View it on GitHub:
https://github.com/geany/geany/pull/3593/files/02238c4c91b84fc5acd1907dcc6e015490f0fc2e..6601ca02e3e589f1dc76ad89893cbf929420fe50
You are receiving this because
@eht16 commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
I totally don't mind how we create the screenshots.
I just don't want to do it 10 times and do not want to install a dozen VMs :).
Trying X11 might get better results.
Within Gnome, I didn't find any way to
@eht16 commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
I booted up a Debian Bookworm VM from the live ISO image without any
modifications to the theme. The only thing changed was to reduce the font size,
otherwise everything would be even bigger.
There was
The previous logic failed on 2.0 to make the new version number 1.99.99. This
is fixed now even though the code is not perfect or good at all but should work
well enough for its purposes.
See also https://github.com/geany/geany/pull/3594.
The additional log information are in pair with Geany
JFYI, it's even tested this time (left is the result, right is the input
version):
```
1.38.0 - 1.38.1_git_2023103518_173744b2b
1.37.99 - 1.38_git_2023103518_173744b2b
2.0.0 - 2.0.1
1.99.99 - 2.0_git_2023103518_173744b2b
2.1.89 - 2.1.90
2.0.99 - 2.1
2.2.0 - 2.2.1
2.89.99 - 2.90
```
The previous logic failed on 2.0 to make the new version number 1.99.99. This
is fixed now even though the code is not perfect or good at all but should work
well enough for its purposes.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3594
@eht16 requested changes on this pull request.
On po/ar.po:
Please remove all the translation changes in the *.po files. These are not
necessary in the pull request. The translation files will be updated later as
part of the release process.
> @@ -168,7 +171,7 @@ void
> I NAK'd the theme but I don't want to block any Adwaita-replacement so please
> go for it.
Alright.
https://www.geany.org/documentation/faq/#how-to-change-the-gtk-theme provides
users with instructions on how to change the theme and there are also
alternatives linked. I guess this is all an
@baoliubin sorry for the late answer.
It might help or might not but it's worth a try:
Set the environment variable "lt_cv_deplibs_check_method" to "pass_all", e.g.
by executing the following command in the same shell where you compile Geany
afterwards:
```export
@eht16 commented on this pull request.
> @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/
' -i geany_private.rc
sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac
+sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build
@eht16 pushed 1 commit.
704aaa1e622b4d41ecf8a53109b64aaa574a50c2 Add Prof-Gnome Windows specific patch
--
View it on GitHub:
https://github.com/geany/geany/pull/3129/files/18886248cb10c53e2a140d213e613c93a73aa011..704aaa1e622b4d41ecf8a53109b64aaa574a50c2
You are receiving this because you are
@eht16 requested changes on this pull request.
Could you please add your themes to the `AUTHORS` file?
> @@ -0,0 +1,108 @@
+#
Would you mind adding a full file header with license and copyright information?
Like this one:
@TomCarroll09 I'm closing this. Geany and Geany-Plugins 2.0 are going to be
released in a few days and then the mentioned update for Webkit will be
included in the new release.
If you disagree or need further support, just re-open.
--
Reply to this email directly or view it on GitHub:
Closed #1269 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1269#event-10657327244
You are receiving this because you are subscribed to this thread.
Message ID:
I think we can close this now since #3178 is merged.
@ntrel when use start current GIT master Geany with a fresh config, will it use
the correct browser?
FTR, the "sensible-browser" default is patched in by Debian (and Ubuntu
inherits this change). As pointed out earlier, Geany had the default
Closed #1243 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1243#event-10657346524
You are receiving this because you are subscribed to this thread.
Message ID:
Closing this after no more feedback.
@WhitehawkTailor re-open if it still is a problem.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1243#issuecomment-1763342195
You are receiving this because you are subscribed to this thread.
Message ID:
Sorry for being late, I just thought this might be also good for the dark
variant of the theme?
Currently it uses the large statusbar.
--
Reply to this email directly or
> What about simply adding a `q` command after the first replacement so only
> that one is handled?
I don't know how to do, my sed skills are still on a beginner level and I guess
this will remain so :).
Tried: `sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/;q' -i
meson.build`
but
We use to name tags with the full version, including the patch level.
The rest mostly uses the short version and for API requirements it is fully
sufficient to check for major.minor as patch level versions never should
increase the API version.
What "additional assets" do you refer to?
--
> Or we mention it somewhere in the announcement email? @eht16
Done.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3613#issuecomment-1771510213
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 commented on this pull request.
> +True
+False
+12
+
+
+True
+False
+
@eht16 approved this pull request.
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3643#pullrequestreview-1709036794
You are receiving this because you are subscribed to this thread.
Message ID:
Is there any point in putting efforts into this?
As @elextr pointed out already a good option for the OP problem
(`Edit->Preferences->General->Startup->Startup Path`), I think Geany is already
customisable enough to leave it as is.
--
Reply to this email directly or view it on GitHub:
Just to clarify, the described behavior is not implemented.
To me it first read like a bug report but it is not, the current
behavior is rather intended. Though it could be changed if someone wants to.
It is completely unrelated to Windows, on Linux Geany behaves the same
(except that the default
Closed #3630 as completed via #3637.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3630#event-10797660596
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3637 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3637#event-10797660582
You are receiving this because you are subscribed to this thread.
Message ID:
Forgot to mention, tested and works perfect.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3657#issuecomment-1783785517
You are receiving this because you are subscribed to this thread.
Message ID:
I can confirm the behavior @b4n described and this is the result of
https://sourceforge.net/p/scintilla/bugs/2287/ which is the result of #2629.
The previous behavior (pasting the same selection multiple times) was more
convenient, I agree. As Neil stated on
So in the end, it should be reported to Scintilla, I think.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3658#issuecomment-1783787337
You are receiving this because you are subscribed to this thread.
Message ID:
As said in #3637, the default sidebar width is increased so that it should
match better the default window size.
Further improvements like modifying the entry's minimal size or ellipsizing the
tab labels can be done separately if someone considers it important enough.
--
Reply to this email
I merged it because this PR was only about to increase the default sidebar
width for only the default window size.
As most users probably will resize and use a bigger window size after all, I'm
not sure if the efforts are worth to also modify the entry's minimal size.
--
Reply to this email
Yay!
I just noticed, Thunar seems to IEC units and so displays the same values as
the old code. Though the GLib docs suggest to rather use the SI units.
I don't mind much which unit we use, I'm happy that old, copied, not well
understood code will be removed! :tada:
--
Reply to this email
@eht16 pushed 1 commit.
1b2d4f04b7a1026148a12eee3e0a39f789f9797c Update screenshots - without super
bloated Adwaita legacy icons
--
View it on GitHub:
https://github.com/geany/geany/pull/3593/files/36930bc6bfff50be25831760db3aec9311b519fd..1b2d4f04b7a1026148a12eee3e0a39f789f9797c
You are
@eht16 commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
Mighty @b4n, that's it.
Screenshots are updated again and look a lot better now.
The Gnome default screenshot tool adds a think transparent border around the
images. I could remove it but actually I think
@eht16 commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
> @eht16 do you want me to take care of the screenshots, or can you do it with
> what I mentioned?
Decide yourself :).
I was too busy with making screenshots to notice your comment.
--
Reply to this email
@eht16 pushed 1 commit.
c0b429f59fd2dc4436366e146a5016ccedf2f4fa Update NEWS
--
View it on GitHub:
https://github.com/geany/geany/pull/3593/files/1b2d4f04b7a1026148a12eee3e0a39f789f9797c..c0b429f59fd2dc4436366e146a5016ccedf2f4fa
You are receiving this because you are subscribed to this thread.
@eht16 commented on this pull request.
On doc/images/pref_dialog_templ.png:
Last chance to get you out of there :).
To be honest, I just re-used the values from the 1.38 screenshot.
--
Reply to this email directly or view it on GitHub:
I don't know Meson nor macOS very well but the changes look good.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3608#issuecomment-1766918324
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 pushed 1 commit.
36930bc6bfff50be25831760db3aec9311b519fd Update NEWS
--
View it on GitHub:
https://github.com/geany/geany/pull/3593/files/b11817519cb0e9d2232958c54ce6c3d37c1ec599..36930bc6bfff50be25831760db3aec9311b519fd
You are receiving this because you are subscribed to this thread.
Add NEWS for 2.0.
Remarks for the NEWS items:
- I skipped many smaller or non user visible changes or follow-up PRs to not
bloat the list too much
- if anyone miss his favorite PR or so, shout out
You can view, comment on, or merge this pull request online at:
I don't know if I got all of the discussion here. I find the OP confusing as on
the screenshot there is Geany and Pluma but the text refers to different
distributions.
Anyway and apart of personal preferences about this feature, the next release
of Geany will contain the setting @elextr
> @eht16 what version of g++/libstdc++ is used for windows, nowhere does the
> version get printed in configure or build, g?
In
https://github.com/geany/geany/actions/runs/6322193707/job/17167381804?pr=3551#step:9:23
we show basic build environment information. Adding the gcc/g++ version
@eht16 pushed 1 commit.
52a5e88a710a7c3f504f6a4982113f617deb3bc4 Builders: Ensure /etc/mtab is
available on Docker mingw64 image build
--
View it on GitHub:
https://github.com/geany/infrastructure/pull/10/files/74e457a668ecedc6b776f051114720686f9f7fdb..52a5e88a710a7c3f504f6a4982113f617deb3bc4
> > Is gcc 10 fine in general?
>
> On an old machine (note to self: upgrade it) linux `g++ (Ubuntu
> 9.4.0-1ubuntu1~20.04.2) 9.4.0` works here (this PR builds and runs fine).
>
> I really don't know what is wrong with the mingw build at this point.
Me neither.
@eht16 pushed 1 commit.
f8e81de9c6b829c4b9657f66a37b8d0fca6e43b4 Builders: Ensure /etc/mtab is
available on Docker mingw64 image build
--
View it on GitHub:
https://github.com/geany/infrastructure/pull/10/files/52a5e88a710a7c3f504f6a4982113f617deb3bc4..f8e81de9c6b829c4b9657f66a37b8d0fca6e43b4
@eht16 pushed 1 commit.
74e457a668ecedc6b776f051114720686f9f7fdb Temporarily enable PR pipelines
--
View it on GitHub:
https://github.com/geany/infrastructure/pull/10/files/ea90fbb49f148e3e7086e93f49b1f7d99437de76..74e457a668ecedc6b776f051114720686f9f7fdb
You are receiving this because you are
> @eht16 do you know what's wrong with the Windows CI?
No :(.
I can succesfully build the image with normal Docker on a native Linux system.
Either something changed on how the Gitlab runners are implemented or something
in `pacman` changed, still unsure what is causing this.
So far I didn't
You can view, comment on, or merge this pull request online at:
https://github.com/geany/infrastructure/pull/10
-- Commit Summary --
* Builders: Ensure /etc/mtab is available on Docker mingw64 image build
-- File Changes --
M builders/Dockerfile.mingw64 (2)
-- Patch Links --
I'm fine with merge. The failed Windows CI build is handled seperately.
Only one minor thing, I guess we should bump plugin API version because
`GeanyIndentPrefs` and Scintilla itself are part of the plugin API.
--
Reply to this email directly or view it on GitHub:
LGBI.
Maybe updating the translation files is not necessary at all. It would happen
with the next string freeze automatically.
For the upcoming release it's too late, I think :(.
I didn't check the GIT history and I don't remember but there is a certain
probability that it was me introducing
Since we are going towards the next release and we were thinking about a magic
2.0 version number already for some time, maybe the time is now to just do it
:).
Any objections?
@elextr @kugel- @techee @b4n @frlan
You can view, comment on, or merge this pull request online at:
We could make these changes on the Geany side, I put it here explicitly
to ensure we use the same compiler variant for Geany *and* G-P.
Alternatively, we could end up in compiling Geany with the -posix
variant and G-P with the -win32 variant which may work or may not.
Or we had to duplicate the
Yes, it builds fine on native Windows as there the compiler from MSYS2
is used.
Sorry forgot to mention this, all the build problems are
specific to the used cross compiler toolchain used in the CI builds.
--
Reply to this email directly or view it on GitHub:
How should we fix it in Geany?
An external library which we include in our build (Scintilla) uses
features a special compiler toolchain does not support.
It's not a problem with our code that we could fix.
--
Reply to this email directly or view it on GitHub:
The mingw64 cross compiler lacks support at least for std:future
feature in C++ (https://sourceforge.net/p/mingw-w64/bugs/959/). Debian offers a
posix variant which implements it.
https://sourceforge.net/p/mingw-w64/bugs/959/ describes the problem.
This is the partner PR to https://github.com/geany/infrastructure/pull/11:
the latest Scintilla version doesnt compile in the Mingw64 cross compiler
CI job. This is because the used cross compiler toolchain doesnt support
C++ features like std:future.
See
@eht16 pushed 1 commit.
30372ece08c0d4986b36afcb1652b2cc3f26689f CI: Log compiler and library versions
in build output
--
View it on GitHub:
https://github.com/geany/geany/pull/3568/files/23a07d7d3c7c65c630dc2700a62584376a25a9bb..30372ece08c0d4986b36afcb1652b2cc3f26689f
You are receiving this
The build failures are not because the used compiler is too old but it's
missing features: https://sourceforge.net/p/mingw-w64/bugs/959/
https://github.com/geany/geany/pull/3568 changes the used cross compiler
toolchain to its "posix" variant which has all necessary C++ features and so
the
@eht16 pushed 2 commits.
354c7ba4e66803f16d9e0452b7829d47cb742587 CI: Copy used C++ runtime library
into the GTK bundle
b18c76edc9eb10a5c0097d4231c387885e2f266f CI: Log compiler and library versions
in build output
--
View it on GitHub:
@kugel- @elextr should we include the patch from
https://groups.google.com/g/scintilla-interest/c/_tiE_nSaiG4/m/v0e8lzTjAQAJ
here?
I'd say yes because the next Scintilla release might be after the upcoming
Geany release and the issue might also affect Geany users.
--
Reply to this email
Agreed. Let's merge.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3541#issuecomment-1744980801
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 pushed 1 commit.
b11817519cb0e9d2232958c54ce6c3d37c1ec599 Improve wording for PR3042 item
--
View it on GitHub:
https://github.com/geany/geany/pull/3593/files/e754f79d16dcac69bcad0da13a0fd2aaf03e6a65..b11817519cb0e9d2232958c54ce6c3d37c1ec599
You are receiving this because you are
@eht16 pushed 1 commit.
15ef1d536971a3c3be9eb0d6b4cd2363ab21fb08 Use b4n's simpler version
--
View it on GitHub:
https://github.com/geany/geany/pull/3594/files/2fa22afbb8e80683afa2ae8b5f35dcd8e8c1299e..15ef1d536971a3c3be9eb0d6b4cd2363ab21fb08
You are receiving this because you are subscribed
@eht16 pushed 1 commit.
3613117b9573798b17f1535cfa9e4b4973f6c4d6 Use b4n's simpler version
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1278/files/ee46cc185c39ac7e5ccbd1df5f078f76627119d8..3613117b9573798b17f1535cfa9e4b4973f6c4d6
You are receiving this because you are
@eht16 commented on this pull request.
> - if [ -z "${PATCH}" ] || [ "${PATCH}" = "0" ]; then
- MINOR="$((MINOR-1))"
- PATCH="90"
+ if [[ "${MINOR}" = "0" && (-z "${PATCH}" || "${PATCH}" = "0")
]]; then
+
@eht16 commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
I'll give it another try tomorrow.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#discussion_r1355787792
You are receiving this because you are subscribed to
> > Should we maybe better highlight the many ctags changes?
>
> I don't think it's necessary, the big refactorings weren't user-visible. But
> maybe if #3049 gets merged, an "improved support of ctags file format" could
> be mentioned so users know they can use these files and there should be
Awesome, thanks!
I'd vote for early merge to have as much testing via master as possible.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3580#issuecomment-1752091164
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 commented on this pull request.
On doc/images/build_menu_commands_dialog.png:
It won't get better. No idea what I'm doing wrong.
I managed to scale the display to 60% (after enabling some experimental feature
in mutter via gsettings and then changing the scale in some XML file) but it
> > We'll still need the "unknown" check to support older ctags binaries
> > unfortunately.
At least we can easily change the PHP tags generation script when needed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1760373686
You are
I don't see how it should get better by postponing to 2.1.
To me, switching to @techee's version of the Prof-Gnome theme is a big
improvement over the default theme. In the mean time, the website FAQ explains
how to change the GTK theme on Windows, so users who do not like it, can change
it
Merged #1278 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1278#event-10637128409
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3594 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3594#event-10636857656
You are receiving this because you are subscribed to this thread.
Message ID:
Didn't you like the second commit's message? :D
Done and thanks for review.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3594#issuecomment-1760362118
You are receiving this because you are subscribed to this thread.
Message ID:
Maybe you could open a new issue to discuss how we can rework the CI
infrastructure, if you like.
IMO this is out of scope of this PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3568#issuecomment-1749672450
You are receiving this because you are
Merged #3569 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3569#event-10568542023
You are receiving this because you are subscribed to this thread.
Message ID:
What exactly do you request? I don't understand the sentence fully.
If it is about changing the website, maybe it is better to open a new issue in
the Geany-Plugins repository (https://github.com/geany/geany-plugins).
--
Reply to this email directly or view it on GitHub:
> stable", I'm kind of neutral here. But in the spirit of linux kernel
> numbering "when the number behind the dot gets too big, let's bump the major
> version", it's a good move.)
I didn't know this is the Linux kernel numbering scheme but it's pragmatic :).
Actually, I happened to confused
G-P pendant to https://github.com/geany/geany/pull/3569.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1274
-- Commit Summary --
* Pre-release version bump
-- File Changes --
M NEWS (2)
M build/geany-plugins.nsi (6)
> Don't strings have file/line in their lookup, so "Templates" and "Files" menu
> items would likely show untranslated until updated?
How do you think so? AFAIK the lookup is made solely on the string itself.
Either it matches or not.
Before further speculating, just test it. Check out the
@eht16 commented on this pull request.
On doc/images/main_window.png:
Ok, so it's just getting bigger again. I pushed a variant with similar
dimensions as @b4n's demo.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#discussion_r1363460371
You
@eht16 commented on this pull request.
> +.. image:: ./images/edit_change_history.png
+
+The image shows the default visuals:
+
+* inserted characters appear with coloured underlines
+* points where characters were deleted are shown with small triangles
+* the margin shows a block indicating
Merged #62 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/pull/62#event-10683074972
You are receiving this because you are subscribed to this thread.
Message ID:
> Perhaps after the first screenshot add "Screenshots in the document are the
> default GTK Adwaita theme, but Geany will adapt to the desktop GTK theme that
> is set."
Done.
--
Reply to this email directly or view it on GitHub:
@eht16 pushed 2 commits.
86754ddaf839503681e6f3939424883ed3e1d97d Update main window screenshot
50f76291b2e9b3ff55fe655109d532ed221f46a1 Add note about screenshots GTK theme
--
View it on GitHub:
@eht16 approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/pull/55#pullrequestreview-1683241926
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #55 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/pull/55#event-10683069370
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 commented on this pull request.
On doc/images/pref_dialog_various.png:
This is also theme-dependent, isn't it? I don't remember we changed anything in
the dialog?
We could discuss if we do not want to use that theme for screenshots but given
the time left, I would postpone this
@eht16 commented on this pull request.
On doc/images/main_window.png:
So far I tried to keep the width and height of the old screenshot. But I don't
mind much.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#discussion_r1362754296
You are
1 - 100 of 643 matches
Mail list logo
