Re: [Github-comments] [geany/geany] Renamed pep8 to pycodestyle (#1776)

2018-03-22 Thread elextr
>  Geany doesn't install pep8 or pycodestyle, but rather uses what is already 
> on the system.

Correct, all we are talking about is the default command Geany runs for python 
linting.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776#issuecomment-375198728

Re: [Github-comments] [geany/geany] Renamed pep8 to pycodestyle (#1776)

2018-03-21 Thread Hugo
Ah, I see: Geany doesn't install pep8 or pycodestyle, but rather uses what is 
already on the system.

Thank you!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776#issuecomment-375196229

Re: [Github-comments] [geany/geany] Renamed pep8 to pycodestyle (#1776)

2018-03-21 Thread elextr
Just to add, current LTS systems do not have pycodestyle in their distros, but 
new LTS releases are due soon (eg Ubuntu next month) and hopefully they will be 
updated.  Thats why another 6-12 months is needed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776#issuecomment-375191001

Re: [Github-comments] [geany/geany] Renamed pep8 to pycodestyle (#1776)

2018-03-21 Thread elextr
Because not everybody will have updated immediately something is changed, so a 
reasonable time should be allowed before changing the default, especially as I 
understand it, the old name still works in many cases.

In the meantime its very simple to change yourself.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776#issuecomment-375190475

Re: [Github-comments] [geany/geany] Renamed pep8 to pycodestyle (#1776)

2018-03-21 Thread Hugo
Thanks, read it, but didn't quite get the reason for waiting and keeping the 
outdated version. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776#issuecomment-375187065

Re: [Github-comments] [geany/geany] Renamed pep8 to pycodestyle (#1776)

2018-03-21 Thread elextr
@hugovk that is understood, please read the post by @eht16 above yours.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776#issuecomment-375117397

Re: [Github-comments] [geany/geany] Renamed pep8 to pycodestyle (#1776)

2018-03-21 Thread Hugo
The `pep8` tool was renamed to `pycodestyle`, and development continues as 
`pycodestyle`. 

So running `pep8` is essentially the same as running an old version of 
`pycodestyle`, but of course without new features and bug fixes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776#issuecomment-374911632

Re: [Github-comments] [geany/geany] Renamed pep8 to pycodestyle (#1776)

2018-02-19 Thread Enrico Tröger
I agree with @ban that waiting some time before applying the change might help 
users with not so recent systems.

Maybe wait six to twelve months or something like this?
The good thing is the change is very simple and can be done by "affected" users 
on their own until the default is being updated.

Btw, I just updated https://wiki.geany.org/howtos/check_python_code.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776#issuecomment-366819002

Re: [Github-comments] [geany/geany] Renamed pep8 to pycodestyle (#1776)

2018-02-19 Thread Colomban Wendling
Hum, why not, although people having a system predating this change (which is 
exactly 2 years old apparently) will suffer from this, while more recent 
systems are likely to provide compatibility for a while, given how widespread 
use of the `pep8` tool is. For example, my Debian system has a link from `pep8` 
to `pycodestyle` which makes this a non-issue there ATM.

So… I don't feel strongly either way, but it probably makes sense to merge this 
*at some point*, but I don't know if now's the time?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776#issuecomment-366798851

[Github-comments] [geany/geany] Renamed pep8 to pycodestyle (#1776)

2018-02-19 Thread Abel Serrano Juste
pep8 has been renamed to pycodestyle, see 
[this](https://github.com/PyCQA/pycodestyle/issues/466) , 
[this](https://github.com/PyCQA/pycodestyle/issues/481) and 
[this](https://github.com/PyCQA/pycodestyle/commit/2344a34a628b2f2e9df1c2539d9316005a35053d)
 for more info.

In fact, if I run the lint option from Geany I get the following warning:
```
/usr/local/lib/python3.5/dist-packages/pep8.py:2124: UserWarning: 

pep8 has been renamed to pycodestyle (GitHub issue #466)
Use of the pep8 tool will be removed in a future release.
Please install and use `pycodestyle` instead.

$ pip install pycodestyle
$ pycodestyle ...

  '\n\n'
```

This PR replaces pep8 by pycodestyle, thus removing the warning.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1776

-- Commit Summary --

  * Renamed pep8 to pycodestyle

-- File Changes --

M data/filedefs/filetypes.python (2)
M doc/geany.txt (2)

-- Patch Links --

https://github.com/geany/geany/pull/1776.patch
https://github.com/geany/geany/pull/1776.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776