Re: [Github-comments] [geany/geany-plugins] [spellchecker] Apostrophes (`'`, ascii 39) at string boundary are spell-checked (#484)

2016-10-14 Thread Enrico Tröger
Closed #484 via #487. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/484#event-823822685

Re: [Github-comments] [geany/geany-plugins] [spellchecker] Apostrophes (`'`, ascii 39) at string boundary are spell-checked (#484)

2016-10-14 Thread Enrico Tröger
Heh, this is also possible even as you said some sort of brutal :). Thanks for testing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/484#issuecomment-253771946

Re: [Github-comments] [geany/geany-plugins] [spellchecker] Apostrophes (`'`, ascii 39) at string boundary are spell-checked (#484)

2016-10-13 Thread Andrea Stacchiotti
I brutally replaced `spellcheck.so` in `/usr/lib` and tested it a bit. It seems to work perfectly well. Thanks for the fix. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/484#is

Re: [Github-comments] [geany/geany-plugins] [spellchecker] Apostrophes (`'`, ascii 39) at string boundary are spell-checked (#484)

2016-10-13 Thread Enrico Tröger
It depends what OS you use. On Linux compiling from source is quite easy: ```sh git clone git://github.com/geany/geany cd geany ./autogen.sh --prefix=/tmp/geany_test make make install cd .. git clone git://github.com/geany/geany-plugins cd geany-plugins git checkout -b spellcheck_strip_quotes_issu

Re: [Github-comments] [geany/geany-plugins] [spellchecker] Apostrophes (`'`, ascii 39) at string boundary are spell-checked (#484)

2016-10-12 Thread Andrea Stacchiotti
Any way I can (easily) get the new version? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/484#issuecomment-253164536

Re: [Github-comments] [geany/geany-plugins] [spellchecker] Apostrophes (`'`, ascii 39) at string boundary are spell-checked (#484)

2016-10-11 Thread Enrico Tröger
Thanks for the feedback. In my tests `po'` was not marked as mispelled but that might because the dictionary knows the word `Po` as the river already. I assume there might be other examples like this one, as long as there are somewhat rare, that might be ok. I created #487 to fix the issues you

Re: [Github-comments] [geany/geany-plugins] [spellchecker] Apostrophes (`'`, ascii 39) at string boundary are spell-checked (#484)

2016-09-20 Thread Andrea Stacchiotti
Your second solution will generate some problems in languages like Italian, where `po'` is a word, but `po` isn't, but these are few corner cases that can be added to the dictionary when you meet them and a huge improvement wrt the current state. -- You are receiving this because you are subs

Re: [Github-comments] [geany/geany-plugins] [spellchecker] Apostrophes (`'`, ascii 39) at string boundary are spell-checked (#484)

2016-09-18 Thread Enrico Tröger
Yes, this is a regression from #322. I tried a quick hack which strips the apostrophe from the word beginning and end if the style before resp. after the word is different. In this context `style` means highlighting types like string, identifier, keyword and similar. This works pretty good for

[Github-comments] [geany/geany-plugins] [spellchecker] Apostrophes (`'`, ascii 39) at string boundary are spell-checked (#484)

2016-09-18 Thread Andrea Stacchiotti
Testcases: * `'word'` all underlined * `"word"` not underlined * `'very long phrase'` `'very` and `long'` are underlined This was probably introduced in #322 . The spellchecker ought to strip the quotes before checking, otherwise using it in python is a huge pain. I understand it's difficult to