@AnishGRao see #942
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#issuecomment-575414592
To repeat "the version of Geany and GTK it uses (see near the top of help debug
messages)." Just copy and paste the information from there.
When you are asked for information you need to answer the question or grumpy
olde sods like me will tell you off :grin: and as I said above, if its a
My apologies, I am on an ubuntu 18.04 system, and noticed that the debugger was
not on my plugin list, and through some digging found it was due to having
GTK3, rather than GTK2. I want to know how I would download the debugger that
is in this repo, and use it on my machine. I am also using
When you post to github or mailing lists (which is where you should ask for
help, github is for software improvements and bug reports) you should always
provide more than "Linux" which is meaningless, you need to provide your
distribution and version and the version of Geany and GTK it uses
As someone who enjoys using Geany, but is quite new to Linux in general, how
would I be able to use this debugger on my machine? I have noted that I cannot
use it, and tracked down the issue to here, but am unsure as to how I would use
this, or even where to download these plugins from. Thanks
Merged #791 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#event-2332439551
Well...let's go forward.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#issuecomment-491207414
This didn't make it into 1.35 but maybe we can put it to milestone 1.36. As
written earlier the little overflow problem is acceptable to me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@elextr, @bxgaillard: if the behavior is really caused by a different behavior
of gtk2 and gtk3 then it is OK for me. As I wrote I couldn't find anything in
the code between the two versions which looked like a porting fault. Also, if
someone enables the debugger plugin it doesn't really make
> @bxgaillard have you tried setting sizes and resize and shrink and stuff from
> CSS, setting minimum sizes in apps is not very portable.
I have made some research and CSS seems not to be appropriate for setting
dimensions. On the other hand the correct way to fix it seems to be the Glade
@bxgaillard have you tried setting sizes and resize and shrink and stuff from
CSS, setting minimum sizes in apps is not very portable. Note also the comment
from @LarsGit223 that showed the behaviour was different on different versions
of gtk. which did you test on?
--
You are receiving this
I've looked into it and from what I can tell this is normal behaviour.
The main Geany GUI uses GtkPaneds for side panels (document browser, symbols,
messages...), including the bottom one. When such a panel is too small to
display its contents, the latter is located in hidden overflow.
This
I had another look at the changes made by the PR but I cannot find the reason
why the re-sizing of the message window does not work as expected under gtk3 if
the debugger plugin is enabled.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
@andy5995: Yes it does.
Tested with your repository branch ```debugger-gtk3```:
- Ubuntu 18.04.02, gtk 3.22.30, glib 2.56.3: the arrow is missing
- Ubuntu 18.04.02, gtk 2.24.32, glib 2.56.3: the arrow is showing
Just in case you did not notice because "the down arrow is missing" does not
> One problem I noticed on Debian Buster and Slackware-current: when the
> Debugger plug-in is enabled, the "down arrow" disappears
Does that reproduce on Ubuntu as well? @LarsGit223 ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
My debug info from Buster:
```
15:36:41: Geany INFO: Using alternate configuration directory
15:36:41: Geany INFO: Geany 1.35 (git >= bf5c9edd), en_US.utf8
15:36:41: Geany INFO: GTK 3.24.3, GLib 2.58.2
15:36:41: Geany INFO: System data dir:
One problem I noticed on Debian Buster and Slackware-current: when the Debugger
plug-in is enabled, the "down arrow" disappears (screenshot below).
--
You are receiving this because
#815 fixed the build issue and configure warnings on OpenBSD.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#issuecomment-457345926
Apparently we've got a portability issue with the GTK version check. @andy5995
could you check out #815 and see if it helps? It should get rid of the
*"unexpected operator/operand"* issues, and hopefully maybe more.
--
You are receiving this because you are subscribed to this thread.
Reply
> > `./configure[15275]: test: 3: unexpected operator/operand`
>
> Could you paste your generated `configure`? The error probably comes from
> there and a `test` call that doesn't please your shell
Sure...
https://gist.github.com/andy5995/fb2b16eb9dab45d9ab8160cdd6f2a48e
Also noticed it
> `./configure[15275]: test: 3: unexpected operator/operand`
Could you paste your generated `configure`? The error probably comes from
there and a `test` call that doesn't please your shell
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
I installed the vte-0.28.2p19 package and that problem was solved. New problem
is that the built fails with an undefined reference error:
https://gist.github.com/andy5995/0b0fab05c70336bfff86ac4a3354d5a6#file-gistfile1-txt-L59
> Hi @andy5995,
> The problem you mention is with utilslib, which is part of geany-plugins and
> now used by the debugger plugin (it contains some compatibility functions).
> Did you activate it at configure time?
[config.log](https://github.com/geany/geany-plugins/files/2788940/config.log)
I
I noticed the line ```...PTY_LIBS="-lutil"]``` in ```scope.m4```. Do we need
this in ```debugger.m4``` also?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Hi @andy5995,
The problem you mention is with utilslib, which is part of geany-plugins and
now used by the debugger plugin (it contains some compatibility functions). Did
you activate it at configure time? It may need some other dependencies besides
libvte.
--
You are receiving this because
So far, mostly looks good on Buster (I set a breakpoint, watched a variable.
One very minor thing.. when debugging a program that uses ncurses, I was able
to view the screen in the Debug terminal as expected. The cursor keys worked
within the terminal fine.
But when I hit the green arrow
bxgaillard commented on this pull request.
> }
g_list_free(modules);
gtk_combo_box_set_active(GTK_COMBO_BOX(debugger_cmb), 0);
/* arguments */
args_frame = gtk_frame_new(_("Command Line Arguments"));
+#if GTK_CHECK_VERSION(3, 0, 0)
+ hbox =
b4n commented on this pull request.
> @@ -1048,12 +1068,24 @@ void debug_init(void)
NULL);
grantpt(pty_master);
unlockpt(pty_master);
+#if GTK_CHECK_VERSION(3, 0, 0)
+ pty = vte_pty_new_foreign_sync(pty_master, NULL, NULL);
+
b4n commented on this pull request.
> }
g_list_free(modules);
gtk_combo_box_set_active(GTK_COMBO_BOX(debugger_cmb), 0);
/* arguments */
args_frame = gtk_frame_new(_("Command Line Arguments"));
+#if GTK_CHECK_VERSION(3, 0, 0)
+ hbox =
Thank you @b4n for your review. I applied your proposals, squashed the commits
and pushed it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#issuecomment-61148
bxgaillard commented on this pull request.
> @@ -1048,12 +1068,24 @@ void debug_init(void)
NULL);
grantpt(pty_master);
unlockpt(pty_master);
+#if GTK_CHECK_VERSION(3, 0, 0)
+ pty = vte_pty_new_foreign_sync(pty_master, NULL, NULL);
+
bxgaillard commented on this pull request.
> @@ -279,8 +336,15 @@ static void tpage_create_widgets(void)
/* environment */
env_frame = gtk_frame_new(_("Environment Variables"));
+#if GTK_CHECK_VERSION(3, 0, 0)
+ hbox = gtk_scrolled_window_new(
+
bxgaillard commented on this pull request.
> }
g_list_free(modules);
gtk_combo_box_set_active(GTK_COMBO_BOX(debugger_cmb), 0);
/* arguments */
args_frame = gtk_frame_new(_("Command Line Arguments"));
+#if GTK_CHECK_VERSION(3, 0, 0)
+ hbox =
bxgaillard commented on this pull request.
>
- GdkPixbuf *GSEAL (pixbuf_active);
- GdkPixbuf *GSEAL (pixbuf_highlighted);
+ GdkPixbuf *pixbuf_active;
+ GdkPixbuf *pixbuf_highlighted;
Same answer as above.
--
You are receiving this because you are subscribed to this thread.
Reply to
bxgaillard commented on this pull request.
>
- GdkPixbuf *GSEAL (pixbuf_enabled);
- GdkPixbuf *GSEAL (pixbuf_disabled);
- GdkPixbuf *GSEAL (pixbuf_conditional);
- GdkPixbuf *GSEAL (pixbuf_file);
+ GdkPixbuf *pixbuf_enabled;
+ GdkPixbuf *pixbuf_disabled;
+ GdkPixbuf *pixbuf_conditional;
bxgaillard commented on this pull request.
> cell_renderer->mode = GTK_CELL_RENDERER_MODE_ACTIVATABLE;
+#endif
Fixed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
b4n commented on this pull request.
>
- GdkPixbuf *GSEAL (pixbuf_enabled);
- GdkPixbuf *GSEAL (pixbuf_disabled);
- GdkPixbuf *GSEAL (pixbuf_conditional);
- GdkPixbuf *GSEAL (pixbuf_file);
+ GdkPixbuf *pixbuf_enabled;
+ GdkPixbuf *pixbuf_disabled;
+ GdkPixbuf *pixbuf_conditional;
+
elextr commented on this pull request.
>
- GdkPixbuf *GSEAL (pixbuf_enabled);
- GdkPixbuf *GSEAL (pixbuf_disabled);
- GdkPixbuf *GSEAL (pixbuf_conditional);
- GdkPixbuf *GSEAL (pixbuf_file);
+ GdkPixbuf *pixbuf_enabled;
+ GdkPixbuf *pixbuf_disabled;
+ GdkPixbuf *pixbuf_conditional;
+
b4n requested changes on this pull request.
Looks mostly OK and harmless, although I'm not fond of the style used to
support both GTK versions.
There's a few suspicious thing around the end though.
> return;
+
+ g_object_get_property(G_OBJECT(cell), "is-expander",
@elextr, @b4n: Yes, I reviewed this. I have to admit that I never wrote a
debugger myself. But the things changed here only apply to the GUI, not to the
debugger related internals.
I tested the following:
- building under Ubuntu with GTK2 and 3
- simple test under Ubuntu with GTK2 and 3: run a
An IDE without a debugger, blocked in this state for the lifetime of the next
stable Debian release, that would be very sad.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Oh well, no debugger for Debian and descendants with 1.34. Note that
@LarsGit223 reviewed and presumably tested and he is scope maintainer.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I did work on the debugger plugin and am willing to look at this, but I won't
have time for 1.34
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#issuecomment-444090762
@b4n @frlan are you going to wait for the maintainer or will you merge for 1.34?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#issuecomment-444038594
> Therefore thanks for putting time in it even though it wasn't your PR
> originally :+1:
My pleasure.
> Once the others agree to merge it, the only thing left to do would be to
> squash the commits into one.
Done.
--
You are receiving this because you are subscribed to this thread.
Reply
> I'm not a GTK+ expert at all, that's why I didn'y dive in the documentation
> and just applied the changes from #645 with preprocessing conditionals.
Therefore thanks for putting time in it even though it wasn't your PR
originally :+1: Once the others agree to merge it, the only thing left to
LarsGit223 approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#pullrequestreview-178477829
LarsGit223 approved this pull request.
This looks much better now because of all the code that is now shared between
gtk2 and 3. Also, the deprecation warnings I mentioned when compiling for gtk2
seem to be gone.
Compiled/installed/tested debugging shortly on gtk2 and 3 again, still works.
So
LarsGit223 commented on this pull request.
> @@ -196,27 +223,45 @@ void tpage_pack_widgets(gboolean tabbed)
{
GtkWidget *lbox, *rbox, *hbox;
+#if GTK_CHECK_VERSION(3, 0, 0)
+ root = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, SPACING);
+
LarsGit223 commented on this pull request.
> gtk_box_pack_start(GTK_BOX(root), hbox, FALSE, FALSE, 0);
gtk_box_pack_start(GTK_BOX(hbox), target_label, FALSE, FALSE,
0);
gtk_box_pack_start(GTK_BOX(hbox), target_name, TRUE, TRUE, 0);
Thank you @LarsGit223 for the thorough PR review! I'm not a GTK+ expert at all,
that's why I didn'y dive in the documentation and just applied the changes from
#645 with preprocessing conditionals. As indicated in my replies I've applied
your suggestions and pushed a new commit which should be
bxgaillard commented on this pull request.
> gtk_widget_set_size_request(target_button_browse, BROWSE_BUTTON_WIDTH,
> 0);
g_signal_connect(G_OBJECT(target_button_browse), "clicked", G_CALLBACK
(on_target_browse_clicked), NULL);
/* debugger */
debugger_label =
bxgaillard commented on this pull request.
> @@ -366,7 +442,11 @@ int tpage_get_debug_module_index(void)
*/
gchar* tpage_get_debugger(void)
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+ return
gtk_combo_box_text_get_active_text(GTK_COMBO_BOX_TEXT(debugger_cmb));
I agree. Fixed.
--
You are
bxgaillard commented on this pull request.
> modules = debug_get_modules();
for (iter = modules; iter; iter = iter->next)
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+
gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(debugger_cmb),
(gchar*)iter->data);
I agree.
bxgaillard commented on this pull request.
> gtk_box_pack_start(GTK_BOX(root), hbox, FALSE, FALSE, 0);
gtk_box_pack_start(GTK_BOX(hbox), target_label, FALSE, FALSE,
0);
gtk_box_pack_start(GTK_BOX(hbox), target_name, TRUE, TRUE, 0);
bxgaillard commented on this pull request.
> }
+#if GTK_CHECK_VERSION(3, 0, 0)
+ while (!g_cond_wait_until(, _config_mutex, interval));
+ g_mutex_unlock(_config_mutex);
Fixed: the old code has been replaced with the new one.
--
You are receiving this because you are
bxgaillard commented on this pull request.
> @@ -197,7 +197,11 @@ static void on_render_line(GtkTreeViewColumn
> *tree_column, GtkCellRenderer *cell
g_object_set(cell, "text", "", NULL);
else
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+ GValue value =
bxgaillard commented on this pull request.
> @@ -287,8 +288,13 @@ void dpaned_init(void)
/* setup notebooks */
gtk_notebook_set_scrollable(GTK_NOTEBOOK(debug_notebook_left), TRUE);
gtk_notebook_set_scrollable(GTK_NOTEBOOK(debug_notebook_right), TRUE);
+#if
bxgaillard commented on this pull request.
> @@ -1066,7 +1105,13 @@ void debug_init(void)
configfile = g_strconcat(geany_data->app->configdir, G_DIR_SEPARATOR_S,
"geany.conf", NULL);
g_key_file_load_from_file(config, configfile, G_KEY_FILE_NONE, NULL);
font =
bxgaillard commented on this pull request.
> @@ -269,8 +274,13 @@ static void save_to_keyfile(GKeyFile *keyfile)
*/
static gpointer saving_thread_func(gpointer data)
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+ gint64 interval;
+ g_mutex_lock(_config_mutex);
+#else
I agree. I replaced
bxgaillard commented on this pull request.
> @@ -320,7 +324,11 @@ static void on_watch_dragged_callback(GtkWidget *wgt,
> GdkDragContext *context, i
gpointer userdata)
{
/* string that is dragged */
+#if GTK_CHECK_VERSION(3, 0, 0)
+ gchar *expression =
bxgaillard commented on this pull request.
> @@ -458,21 +493,36 @@ void config_init(void)
g_free(data);
}
+#if GTK_CHECK_VERSION(3, 0, 0)
+ g_mutex_init(_config_mutex);
+ g_cond_init();
+ saving_thread = g_thread_new(NULL, saving_thread_func, NULL);
bxgaillard commented on this pull request.
> @@ -308,11 +318,20 @@ static gpointer saving_thread_func(gpointer data)
debug_config_changed = FALSE;
}
+#if GTK_CHECK_VERSION(3, 0, 0)
+ interval = g_get_monotonic_time() + SAVING_INTERVAL;
bxgaillard commented on this pull request.
> @@ -136,21 +152,37 @@ static void
> cell_renderer_frame_icon_get_size(GtkCellRenderer *cell, GtkWidget *
pixbuf_height = MAX (pixbuf_height, gdk_pixbuf_get_height
(cellframe->pixbuf_highlighted));
}
+#if
bxgaillard commented on this pull request.
> @@ -82,17 +82,28 @@ static void on_execute_until(GtkButton *button, gpointer
> user_data)
*/
GtkWidget* btnpanel_create(on_toggle cb)
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+ GtkWidget *vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL,
bxgaillard commented on this pull request.
>
cell_renderer_frame_icon_get_size (cell, widget, cell_area,
_rect.x,
_rect.y,
_rect.width,
_rect.height);
+#if GTK_CHECK_VERSION(3, 0, 0)
+
bxgaillard commented on this pull request.
> calc_width = (gint) cell->xpad * 2 + pixbuf_width;
calc_height = (gint) cell->ypad * 2 + pixbuf_height;
+#endif
I agree. Fixed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
bxgaillard commented on this pull request.
> @@ -67,8 +67,13 @@ static GKeyFile *keyfile_project = NULL;
static gboolean debug_config_loading = FALSE;
/* saving thread staff */
+#if GTK_CHECK_VERSION(3, 0, 0)
+static GMutex change_config_mutex;
+static GCond cond;
+#else
I agree. I
bxgaillard commented on this pull request.
>
cell_renderer_break_icon_get_size (cell, widget, cell_area,
_rect.x,
_rect.y,
_rect.width,
_rect.height);
+#if GTK_CHECK_VERSION(3, 0, 0)
+
@bxgaillard pushed 1 commit.
5eec7fd Factorize some code between GTK2 and GTK3.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
I'll try to have a look on it at the weekend.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#issuecomment-440539370
The maintainer of debugger is not very active lately, so anybody should feel
free to review/test/comment otherwise this may be fairly slow to be added.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
72 matches
Mail list logo
