[GitHub] [arrow] nevi-me commented on pull request #7043: ARROW-8598: [Rust] `simd_compare_op` creates buffer of incorrect length

2020-04-27 Thread GitBox
nevi-me commented on pull request #7043: URL: https://github.com/apache/arrow/pull/7043#issuecomment-619853175 @paddyhoran do we need to worry about this, as it'd get removed by #7037? This is an automated message from the

[GitHub] [arrow] zhztheplayer commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

2020-04-27 Thread GitBox
zhztheplayer commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r415667244 ## File path: cpp/src/jni/dataset/jni_wrapper.cpp ## @@ -0,0 +1,577 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] kszucs commented on pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-27 Thread GitBox
kszucs commented on pull request #7026: URL: https://github.com/apache/arrow/pull/7026#issuecomment-619902102 Agree that exposing `ds.field` and `ds.scalar` should be sufficient on the python side. This is an automated

[GitHub] [arrow] durch commented on pull request #7042: ARROW-8597 [Rust] Lints and readability improvements for arrow crate

2020-04-27 Thread GitBox
durch commented on pull request #7042: URL: https://github.com/apache/arrow/pull/7042#issuecomment-619798711 @nevi-me I left it as is for now, did not want to actually write any new code in this PR. After this one gets merged I'll make another pass and write some code, in addition to the

[GitHub] [arrow] vertexclique commented on a change in pull request #7036: ARROW-8591: [Rust] Reverse lookup for a key in DictionaryArray

2020-04-27 Thread GitBox
vertexclique commented on a change in pull request #7036: URL: https://github.com/apache/arrow/pull/7036#discussion_r415653220 ## File path: rust/arrow/src/array/array.rs ## @@ -1786,38 +1786,34 @@ impl From<(Vec<(Field, ArrayRef)>, Buffer, usize)> for StructArray { /// This

[GitHub] [arrow] jianxind edited a comment on pull request #7029: ARROW-8579 [C++] Add AVX512 SIMD for spaced decoding and encoding.

2020-04-27 Thread GitBox
jianxind edited a comment on pull request #7029: URL: https://github.com/apache/arrow/pull/7029#issuecomment-618855696 cc @emkornfield The AVX512 path is straightforward as the helper of mask_compress/mask_expand API provide by AVX512. For potential path-finding of SSE/AVX2, as

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-27 Thread GitBox
jorisvandenbossche commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r415703472 ## File path: python/pyarrow/_dataset.pyx ## @@ -269,20 +454,21 @@ cdef class FileSystemDataset(Dataset): cdef:

[GitHub] [arrow] fsaintjacques commented on pull request #6731: [WIP] ARROW-8601: [Go][Flight] Added implementation of FlightDataWriter

2020-04-27 Thread GitBox
fsaintjacques commented on pull request #6731: URL: https://github.com/apache/arrow/pull/6731#issuecomment-619959812 Created https://jira.apache.org/jira/browse/ARROW-8601 for this This is an automated message from the

[GitHub] [arrow] fsaintjacques commented on a change in pull request #6731: feat(flight): Added implementation of FlightDataWriter

2020-04-27 Thread GitBox
fsaintjacques commented on a change in pull request #6731: URL: https://github.com/apache/arrow/pull/6731#discussion_r415775496 ## File path: format/Flight.proto ## @@ -19,8 +19,17 @@ syntax = "proto3"; option java_package = "org.apache.arrow.flight.impl"; +option

[GitHub] [arrow] pitrou commented on pull request #6154: ARROW-7531: [C++] Reduce header cost

2020-04-27 Thread GitBox
pitrou commented on pull request #6154: URL: https://github.com/apache/arrow/pull/6154#issuecomment-619959114 Given the diffusion of changes accross the codebase, rebasing this wholesale would probably be painful. A better strategy would probably to retry and do some of the changes one by

[GitHub] [arrow] paddyhoran commented on pull request #7043: ARROW-8598: [Rust] `simd_compare_op` creates buffer of incorrect length

2020-04-27 Thread GitBox
paddyhoran commented on pull request #7043: URL: https://github.com/apache/arrow/pull/7043#issuecomment-619967530 @nevi-me when I added this fix I hadn't looked at your PR removing packed_simd. I introduced this bug so wanted to get a fix posted. Also, I wasn't sure what your

[GitHub] [arrow] github-actions[bot] commented on pull request #7045: ARROW-8603: [C++][Documentation] Add missing params comment

2020-04-27 Thread GitBox
github-actions[bot] commented on pull request #7045: URL: https://github.com/apache/arrow/pull/7045#issuecomment-619997013 https://issues.apache.org/jira/browse/ARROW-8603 This is an automated message from the Apache Git

[GitHub] [arrow] fsaintjacques commented on pull request #6154: ARROW-7531: [C++] Reduce header cost

2020-04-27 Thread GitBox
fsaintjacques commented on pull request #6154: URL: https://github.com/apache/arrow/pull/6154#issuecomment-619954274 @pitrou close or rebase? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
fsaintjacques commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415798798 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] fsaintjacques opened a new pull request #7045: ARROW-8603: [C++][Documentation] Add missing params comment

2020-04-27 Thread GitBox
fsaintjacques opened a new pull request #7045: URL: https://github.com/apache/arrow/pull/7045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] nealrichardson commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
nealrichardson commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415887520 ## File path: cpp/src/arrow/dataset/file_csv.h ## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] fsaintjacques edited a comment on pull request #6645: ARROW-8074: [Dataset][Python] FileFragments from Buffers

2020-04-27 Thread GitBox
fsaintjacques edited a comment on pull request #6645: URL: https://github.com/apache/arrow/pull/6645#issuecomment-619957568 I'll close this for now, ARROW-8318 will remove this limitation and FileSystemDataset will be created from a list of FileFragment, which themselves can be created

[GitHub] [arrow] yonidavidson commented on pull request #6731: [WIP] ARROW-8601: [Go][Flight] Added implementation of FlightDataWriter

2020-04-27 Thread GitBox
yonidavidson commented on pull request #6731: URL: https://github.com/apache/arrow/pull/6731#issuecomment-620017093 Hi All, I am working on https://github.com/353solutions/carrow/tree/issue/46-flight . This is a Go project that wraps the C++ one but wanted everyone to know that it's

[GitHub] [arrow] fsaintjacques commented on pull request #7001: ARROW-8602: [C++][CMake] Fix ws2_32 link issue when cross-compiling on Linux

2020-04-27 Thread GitBox
fsaintjacques commented on pull request #7001: URL: https://github.com/apache/arrow/pull/7001#issuecomment-619964385 @davidanthoff feel free to create an account on JIRA so that I can assign you the ticket https://issues.apache.org/jira/browse/ARROW-8602

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416049921 ## File path: csharp/src/Apache.Arrow/Arrays/ArrayData.cs ## @@ -84,7 +84,7 @@ public ArrayData Slice(int offset, int length) length =

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415971988 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415958451 ## File path: cpp/src/arrow/dataset/file_csv.h ## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415971888 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] pitrou commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
pitrou commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415949596 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415958451 ## File path: cpp/src/arrow/dataset/file_csv.h ## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] sunchao commented on pull request #6949: ARROW-7681: [Rust] Explicitly seeking a BufReader will discard the internal buffer (2)

2020-04-27 Thread GitBox
sunchao commented on pull request #6949: URL: https://github.com/apache/arrow/pull/6949#issuecomment-620113014 Merged. Thanks @rdettai ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416050847 ## File path: csharp/src/Apache.Arrow/Arrays/PrimitiveArrayBuilder.cs ## @@ -99,43 +105,63 @@ public abstract class PrimitiveArrayBuilder : IArrowArrayBu

[GitHub] [arrow] github-actions[bot] commented on pull request #7046: ARROW-8606: [CI] Don't trigger all builds on a change to any file in ci/

2020-04-27 Thread GitBox
github-actions[bot] commented on pull request #7046: URL: https://github.com/apache/arrow/pull/7046#issuecomment-620134352 https://issues.apache.org/jira/browse/ARROW-8606 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson opened a new pull request #7046: ARROW-8606: [CI] Don't trigger all builds on a change to any file in ci/

2020-04-27 Thread GitBox
nealrichardson opened a new pull request #7046: URL: https://github.com/apache/arrow/pull/7046 If I edit an R build script, we shouldn't be running JS and Go builds. This is an automated message from the Apache Git Service.

[GitHub] [arrow] fsaintjacques commented on a change in pull request #6979: ARROW-7800 [Python] implement iter_batches() method for ParquetFile and ParquetReader

2020-04-27 Thread GitBox
fsaintjacques commented on a change in pull request #6979: URL: https://github.com/apache/arrow/pull/6979#discussion_r416018166 ## File path: python/pyarrow/_parquet.pyx ## @@ -1083,6 +1084,50 @@ cdef class ParquetReader: def set_use_threads(self, bint use_threads):

[GitHub] [arrow] fsaintjacques commented on a change in pull request #6979: ARROW-7800 [Python] implement iter_batches() method for ParquetFile and ParquetReader

2020-04-27 Thread GitBox
fsaintjacques commented on a change in pull request #6979: URL: https://github.com/apache/arrow/pull/6979#discussion_r416028395 ## File path: python/pyarrow/parquet.py ## @@ -310,6 +310,44 @@ def read_row_groups(self, row_groups, columns=None, use_threads=True,

[GitHub] [arrow] fsaintjacques commented on a change in pull request #6979: ARROW-7800 [Python] implement iter_batches() method for ParquetFile and ParquetReader

2020-04-27 Thread GitBox
fsaintjacques commented on a change in pull request #6979: URL: https://github.com/apache/arrow/pull/6979#discussion_r416027477 ## File path: python/pyarrow/_parquet.pyx ## @@ -1077,6 +1078,54 @@ cdef class ParquetReader: def set_use_threads(self, bint use_threads):

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r415955058 ## File path: csharp/src/Apache.Arrow/Apache.Arrow.csproj ## @@ -4,7 +4,7 @@ netstandard1.3;netcoreapp2.1 true

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r415963714 ## File path: csharp/Directory.Build.props ## @@ -21,6 +21,12 @@ $(CSharpDir)ApacheArrow.snk + + Review comment: This was

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415981809 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] BryanCutler commented on pull request #6323: ARROW-7610: [Java] Finish support for 64 bit int allocations

2020-04-27 Thread GitBox
BryanCutler commented on pull request #6323: URL: https://github.com/apache/arrow/pull/6323#issuecomment-620174537 test failure is unrelated, merged to master. Thanks @liyafan82 ! This is an automated message from the Apache

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416092312 ## File path: csharp/src/Apache.Arrow/Arrays/BooleanArray.cs ## @@ -24,25 +24,38 @@ public class BooleanArray: Array { public class Builder

[GitHub] [arrow] bkietz commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r416092830 ## File path: python/pyarrow/_dataset.pyx ## @@ -269,20 +454,21 @@ cdef class FileSystemDataset(Dataset): cdef: CFileSystemDataset*

[GitHub] [arrow] chrish42 commented on a change in pull request #7025: ARROW-2260: [C++][Plasma] Use Gflags for command-line parsing

2020-04-27 Thread GitBox
chrish42 commented on a change in pull request #7025: URL: https://github.com/apache/arrow/pull/7025#discussion_r416057944 ## File path: cpp/src/plasma/store.cc ## @@ -1207,65 +1211,77 @@ void StartServer(char* socket_name, std::string plasma_directory, bool hugepages

[GitHub] [arrow] bkietz commented on pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-27 Thread GitBox
bkietz commented on pull request #7026: URL: https://github.com/apache/arrow/pull/7026#issuecomment-620196068 @kszucs @jorisvandenbossche PTAL This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416155042 ## File path: csharp/src/Apache.Arrow/Arrays/BooleanArray.cs ## @@ -153,17 +182,25 @@ private void CheckIndex(int index) new[] {

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416115591 ## File path: csharp/test/Apache.Arrow.Tests/ArrayBuilderTests.cs ## @@ -149,8 +180,8 @@ public void ProducesExpectedArray()

[GitHub] [arrow] wesm commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

2020-04-27 Thread GitBox
wesm commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r416073397 ## File path: cpp/src/jni/dataset/proto/Types.proto ## @@ -0,0 +1,149 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416090623 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416089870 ## File path: csharp/src/Apache.Arrow/Arrays/PrimitiveArrayBuilder.cs ## @@ -162,8 +188,8 @@ public TBuilder Swap(int i, int j) public TArray

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416097760 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] github-actions[bot] commented on pull request #7047: ARROW-8607: [R][CI] Unbreak builds following R 4.0 release

2020-04-27 Thread GitBox
github-actions[bot] commented on pull request #7047: URL: https://github.com/apache/arrow/pull/7047#issuecomment-620239462 https://issues.apache.org/jira/browse/ARROW-8607 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson commented on pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-27 Thread GitBox
nealrichardson commented on pull request #7026: URL: https://github.com/apache/arrow/pull/7026#issuecomment-620245767 @github-actions autotune everything This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] pitrou commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
pitrou commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416093398 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] zgramana commented on pull request #7032: ARROW-6603: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on pull request #7032: URL: https://github.com/apache/arrow/pull/7032#issuecomment-620266004 @eerhardt thanks for the excellent review and feedback. I believe that I have pushed fixes for everything. I also noticed I had missed validity buffer state management in

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416235260 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416253903 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] github-actions[bot] commented on pull request #7048: ARROW-8609: [C++] fix orc jni crash

2020-04-27 Thread GitBox
github-actions[bot] commented on pull request #7048: URL: https://github.com/apache/arrow/pull/7048#issuecomment-620323735 https://issues.apache.org/jira/browse/ARROW-8609 This is an automated message from the Apache Git

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416239202 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] zhouyuan opened a new pull request #7048: ARROW-8609: [C++] fix orc jni crash

2020-04-27 Thread GitBox
zhouyuan opened a new pull request #7048: URL: https://github.com/apache/arrow/pull/7048 check if arrow buffer is null before passing to the constructor Signed-off-by: Yuan Zhou This is an automated message from the

[GitHub] [arrow] zhouyuan commented on pull request #6953: [Java] Reproduce ORC JNI binding crash [WIP]

2020-04-27 Thread GitBox
zhouyuan commented on pull request #6953: URL: https://github.com/apache/arrow/pull/6953#issuecomment-620321153 @kszucs ran into similar issue on parquet side, not sure if this #7048 works This is an automated message

[GitHub] [arrow] zhztheplayer commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

2020-04-27 Thread GitBox
zhztheplayer commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r416295541 ## File path: cpp/src/jni/dataset/proto/Types.proto ## @@ -0,0 +1,149 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] rtyler commented on pull request #7049: Avoid loading simd_load_set_invalid which doesn't exist on aarch64

2020-04-27 Thread GitBox
rtyler commented on pull request #7049: URL: https://github.com/apache/arrow/pull/7049#issuecomment-620377892 Fixing this also helps surface [ARROW-8610](https://issues.apache.org/jira/browse/ARROW-8610), which I have had a hell of a time fixing

[GitHub] [arrow] liyafan82 commented on pull request #6323: ARROW-7610: [Java] Finish support for 64 bit int allocations

2020-04-27 Thread GitBox
liyafan82 commented on pull request #6323: URL: https://github.com/apache/arrow/pull/6323#issuecomment-620338202 @BryanCutler @emkornfield Thanks a lot for your effort. This is an automated message from the Apache Git

[GitHub] [arrow] zhztheplayer commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

2020-04-27 Thread GitBox
zhztheplayer commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r416295541 ## File path: cpp/src/jni/dataset/proto/Types.proto ## @@ -0,0 +1,149 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] rtyler opened a new pull request #7049: Avoid loading simd_load_set_invalid which doesn't exist on aarch64

2020-04-27 Thread GitBox
rtyler opened a new pull request #7049: URL: https://github.com/apache/arrow/pull/7049 error[E0432]: unresolved import `crate::compute::util::simd_load_set_invalid` -->

[GitHub] [arrow] zhztheplayer commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

2020-04-27 Thread GitBox
zhztheplayer commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r416295541 ## File path: cpp/src/jni/dataset/proto/Types.proto ## @@ -0,0 +1,149 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more