liyafan82 opened a new pull request #7248:
URL: https://github.com/apache/arrow/pull/7248
In this PR, we provide the validateFull functionalities, and refactor the
validate logic. We separate the validation logic into 3 visitors:
1. Type validation: validate vector type information (
github-actions[bot] commented on pull request #7248:
URL: https://github.com/apache/arrow/pull/7248#issuecomment-632542028
https://issues.apache.org/jira/browse/ARROW-8402
This is an automated message from the Apache Git Serv
liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-632603791
@BryanCutler @emkornfield Sorry for my late response.
I have removed the skip. Let's see if the integration tests can pass this
time.
-
fsaintjacques commented on pull request #7244:
URL: https://github.com/apache/arrow/pull/7244#issuecomment-632657355
Spurious s3 failure.
This is an automated message from the Apache Git Service.
To respond to the message, pl
fsaintjacques closed pull request #7245:
URL: https://github.com/apache/arrow/pull/7245
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
andygrove commented on pull request #4140:
URL: https://github.com/apache/arrow/pull/4140#issuecomment-632665136
Sorry, I didn't get to this yet. I have learned how to wrangle these release
scripts now so will address this today or over the weekend.
---
liyafan82 commented on pull request #7149:
URL: https://github.com/apache/arrow/pull/7149#issuecomment-632669016
@wesm Thanks a lot for your effort, and sorry for my late response.
Thank all reviewers for the good comments.
lidavidm opened a new pull request #7249:
URL: https://github.com/apache/arrow/pull/7249
This avoids passing an invalid (null) reference to C++.
This is an automated message from the Apache Git Service.
To respond to the mess
github-actions[bot] commented on pull request #7249:
URL: https://github.com/apache/arrow/pull/7249#issuecomment-632673037
https://issues.apache.org/jira/browse/ARROW-8889
This is an automated message from the Apache Git Serv
fsaintjacques commented on pull request #7249:
URL: https://github.com/apache/arrow/pull/7249#issuecomment-632696516
The lint failure was introduced by me, ignore.
This is an automated message from the Apache Git Service.
To
fsaintjacques closed pull request #7249:
URL: https://github.com/apache/arrow/pull/7249
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wesm opened a new pull request #7250:
URL: https://github.com/apache/arrow/pull/7250
The RC verification script fails without this.
This is an automated message from the Apache Git Service.
To respond to the message, please
github-actions[bot] commented on pull request #7250:
URL: https://github.com/apache/arrow/pull/7250#issuecomment-632705636
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
fsaintjacques commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r426869642
##
File path:
java/dataset/src/main/java/org/apache/arrow/dataset/jni/JniLoader.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foun
fsaintjacques opened a new pull request #7251:
URL: https://github.com/apache/arrow/pull/7251
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
paddyhoran commented on pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#issuecomment-632715411
Sorry @maxburke, I'm snowed under at work at the moment. Once @sunchao or
@sadikovi approves we are good, they are the Parquet experts.
--
github-actions[bot] commented on pull request #7251:
URL: https://github.com/apache/arrow/pull/7251#issuecomment-632716197
https://issues.apache.org/jira/browse/ARROW-8890
This is an automated message from the Apache Git Serv
nealrichardson commented on a change in pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#discussion_r429303750
##
File path: r/src/arrow_types.h
##
@@ -176,64 +37,21 @@ inline constexpr Rbyte default_value() {
} // namespace Rcpp
-namespace arrow {
-name
zgramana commented on pull request #7246:
URL: https://github.com/apache/arrow/pull/7246#issuecomment-632754359
This is helpful, thanks @eerhardt! Editorconfig is preferable for those of
us using VS Code on *nix.
This is an
fsaintjacques commented on pull request #7251:
URL: https://github.com/apache/arrow/pull/7251#issuecomment-632774031
It was [failing](https://github.com/apache/arrow/runs/699629364) on master,
weirdly, the autotune commit didn't lunch any build.
---
wesm commented on pull request #7213:
URL: https://github.com/apache/arrow/pull/7213#issuecomment-632819189
I just stumbled on failures on MSVC in these benchmarks (see
https://issues.apache.org/jira/browse/ARROW-8892). I'm fixing the immediate
issues that I found but the problem of checki
fsaintjacques commented on a change in pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#discussion_r429369559
##
File path: r/src/array_from_vector.cpp
##
@@ -20,6 +20,11 @@
#include "./arrow_types.h"
#if defined(ARROW_R_WITH_ARROW)
+#include
+#include
+
fsaintjacques commented on a change in pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#discussion_r429371319
##
File path: r/src/arrow_exports.h
##
@@ -0,0 +1,56 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
fsaintjacques commented on a change in pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#discussion_r429372456
##
File path: r/src/arrow_types.h
##
@@ -176,64 +37,21 @@ inline constexpr Rbyte default_value() {
} // namespace Rcpp
-namespace arrow {
-names
fsaintjacques commented on a change in pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#discussion_r429372721
##
File path: r/src/arrow_types.h
##
@@ -176,64 +37,21 @@ inline constexpr Rbyte default_value() {
} // namespace Rcpp
-namespace arrow {
-names
fsaintjacques commented on a change in pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#discussion_r429372456
##
File path: r/src/arrow_types.h
##
@@ -176,64 +37,21 @@ inline constexpr Rbyte default_value() {
} // namespace Rcpp
-namespace arrow {
-names
sunchao closed pull request #6935:
URL: https://github.com/apache/arrow/pull/6935
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
sunchao commented on pull request #6935:
URL: https://github.com/apache/arrow/pull/6935#issuecomment-632823350
Merged. Thanks @rdettai !
This is an automated message from the Apache Git Service.
To respond to the message, ple
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632824231
I just rebased and pushed MSVC build fixes (that works for me at least
locally on VS 2017). I'm going to fix the R failure next and then address the
other accumulated comments above.
fsaintjacques commented on pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#issuecomment-632825223
@nealrichardson the next step is probably to break `arrowExport.{h,cpp}`
into one per file cpp file, e.g.
```
src/buffer.cpp
src/buffer.h
src/buffer_export.cp
fsaintjacques edited a comment on pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#issuecomment-632825223
@nealrichardson the next step is probably to break `arrowExport.{h,cpp}`
into one per file cpp file, e.g.
```
src/buffer.cpp
src/buffer.h
src/buffer_ex
wesm merged pull request #7250:
URL: https://github.com/apache/arrow/pull/7250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm commented on pull request #7250:
URL: https://github.com/apache/arrow/pull/7250#issuecomment-632826289
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
nealrichardson commented on a change in pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#discussion_r429388011
##
File path: r/src/arrow_types.h
##
@@ -176,64 +37,21 @@ inline constexpr Rbyte default_value() {
} // namespace Rcpp
-namespace arrow {
-name
sunchao commented on a change in pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#discussion_r429388420
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -1004,8 +1004,8 @@ mod tests {
.build()?;
let expected = "Projection: #state, #to
fsaintjacques commented on a change in pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#discussion_r429395569
##
File path: r/src/arrow_types.h
##
@@ -176,64 +37,21 @@ inline constexpr Rbyte default_value() {
} // namespace Rcpp
-namespace arrow {
-names
fsaintjacques closed pull request #7251:
URL: https://github.com/apache/arrow/pull/7251
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
fsaintjacques commented on pull request #7244:
URL: https://github.com/apache/arrow/pull/7244#issuecomment-632842908
@wesm ready to merge.
This is an automated message from the Apache Git Service.
To respond to the message, p
BryanCutler commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-632887913
Thanks @liyafan82 , looks like they didn't pass on this first try. Any idea
what was causing the error:
```
Error accessing files
Current token (VALUE_STRING) not nume
BryanCutler edited a comment on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-632887913
Thanks @liyafan82 , looks like they didn't pass on this first try. Any idea
what was causing the error?
```
Error accessing files
Current token (VALUE_STRING) n
nealrichardson commented on a change in pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#discussion_r429431625
##
File path: r/src/arrow_types.h
##
@@ -176,64 +37,21 @@ inline constexpr Rbyte default_value() {
} // namespace Rcpp
-namespace arrow {
-name
nealrichardson commented on a change in pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#discussion_r429433084
##
File path: r/src/arrow_exports.h
##
@@ -0,0 +1,56 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
eerhardt commented on pull request #7246:
URL: https://github.com/apache/arrow/pull/7246#issuecomment-632909076
Also tagging @mr-smidge (sorry I forgot initially)
This is an automated message from the Apache Git Service.
To r
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632910238
This problem of kernel dispatch with timestamps that may or may not have
time zones actually brought out a limitation with input type checking. I'm
introducing a simple interface for
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632918704
The R test suite is fixed -- this also turned up some missing test coverage
for things that R was depending on
https://issues.apache.org/jira/browse/ARROW-8895.
I'm going to g
kou commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632919131
I'm working on this now.
It'll be finished in a few hours.
This is an automated message from the Apache Git Service
wesm commented on a change in pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#discussion_r429463237
##
File path: cpp/src/arrow/compute/kernels/scalar_cast_internal.h
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or m
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632919447
Awesome, thanks @kou!
This is an automated message from the Apache Git Service.
To respond to the message, please log
wesm commented on a change in pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#discussion_r429464227
##
File path: cpp/src/arrow/compute/kernels/scalar_cast_internal.h
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or m
wesm commented on a change in pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#discussion_r429464755
##
File path: cpp/src/arrow/compute/exec.h
##
@@ -0,0 +1,160 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
kou commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632925122
It seems that `IsIn(const Datum&, std::shared_ptr)` support is
removed. Is it expected?
This is an automated message
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632925336
@kou yes, that was an API change. I can try to restore this functionality
though?
This is an automated message from
wesm edited a comment on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632925336
@kou yes, that was an API change. I can try to restore this functionality
though? It shouldn't be too difficult.
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632925674
I'm taking a look now, I'll report back in a half hour or so
This is an automated message from the Apache Git Service
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632926484
I just pushed a fix for an issue that was showing up in some Windows builds
and some other cleaning
This is an auto
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632927540
The IsIn/Match changes don't look too hard, should be able to push them in
the next half hour or less
This is an aut
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632929465
@kou done, thank you for catching this, I think it's better to retain this
functionality.
This is an automated mess
kou commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632930767
Thanks!
I've also done the GLib part.
This is an automated message from the Apache Git Service.
To respond to the m
kou commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632931580
It seems that the added `TestIsInKernel.IsInChunkedArrayInvoke` test is
failed:
```text
[ RUN ] TestIsInKernel.IsInChunkedArrayInvoke
../src/arrow/testing/gtest_util.
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632936071
Thank you, I will fix.
This is an automated message from the Apache Git Service.
To respond to the message, please l
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632936766
OK, I have it fixed locally. I'm finishing some Python stuff and then I'll
push
This is an automated message from th
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632937311
Done. It looks like GitHub is having some problems today but will keep an
eye on the builds
This is an automated mes
sunchao commented on pull request #7176:
URL: https://github.com/apache/arrow/pull/7176#issuecomment-632941938
Seems this will be a breaking change as it requires writers to be used in a
different way?
This is an automated
sunchao edited a comment on pull request #7176:
URL: https://github.com/apache/arrow/pull/7176#issuecomment-632941938
Seems this will be a breaking change as it requires writers to be used in a
different way? and I think the new way is not as intuitive as the old one.
sunchao edited a comment on pull request #7176:
URL: https://github.com/apache/arrow/pull/7176#issuecomment-632943566
add @sadikovi also who authored this part of code.
This is an automated message from the Apache Git Service
sunchao commented on pull request #7176:
URL: https://github.com/apache/arrow/pull/7176#issuecomment-632943566
+ @sadikovi also who authored this part of code.
This is an automated message from the Apache Git Service.
To resp
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632944653
@xhochy @pitrou @kszucs @jorisvandenbossche I just added Python bindings
for this new functionality including generic argument packing and function
dispatching. The new implementati
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632945052
I'm just fixing a failing unit test now.
This is an automated message from the Apache Git Service.
To respond to the
kou commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632945098
I've fixed a build error with `-DCMAKE_UNITY_BUILD=ON`.
This is an automated message from the Apache Git Service.
To r
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632945792
Perfect thank you :pray:. I'm done hacking on this for now, I'll keep
investigating test failures
This is an automa
kou commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632946831
We need the following change for macOS. What do you thin about this change?
```diff
diff --git a/cpp/src/arrow/compute/kernel.cc
b/cpp/src/arrow/compute/kernel.cc
index 1d
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632947188
@kou that's fine, please go ahead and apply it
This is an automated message from the Apache Git Service.
To respond t
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632947370
Note that `kHashSeed` is declared as `uint64_t` so that must be changed also
```
static constexpr uint64_t kHashSeed = 0;
```
---
kou commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632947510
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sunchao commented on a change in pull request #7226:
URL: https://github.com/apache/arrow/pull/7226#discussion_r429492355
##
File path: rust/arrow/src/array/builder.rs
##
@@ -1334,6 +1334,57 @@ where
map: HashMap::new(),
}
}
+
+/// Creates a new `
kou commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632965028
All build errors are fixed.
There are some test failures with MSVC:
https://github.com/apache/arrow/pull/7240/checks?check_run_id=701142871
```text
2020-05-23T01
kou closed pull request #7192:
URL: https://github.com/apache/arrow/pull/7192
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632975274
Ok I will take a look
This is an automated message from the Apache Git Service.
To respond to the message, please log
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632975883
I see the problem, I am fixing
This is an automated message from the Apache Git Service.
To respond to the message, p
liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-632982040
> Thanks @liyafan82 , looks like they didn't pass on this first try. Any
idea what was causing the error?
>
> ```
> Error accessing files
> Current token (VALUE_STRI
houqp opened a new pull request #7252:
URL: https://github.com/apache/arrow/pull/7252
This change adds `infer_schema_from_files` function to arrow csv reader
module. Datafusion's `CsvExec` struct is now using this function to do schema
inference from multiple CSV files if needed.
Se
github-actions[bot] commented on pull request #7252:
URL: https://github.com/apache/arrow/pull/7252#issuecomment-632986177
https://issues.apache.org/jira/browse/ARROW-8906
This is an automated message from the Apache Git Serv
82 matches
Mail list logo
