github-actions[bot] commented on pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#issuecomment-646620870
Revision: 71ef516f0116c62225ab0d54ba6494ad426d9e63
Submitted crossbow builds: [ursa-labs/crossbow @
xhochy commented on pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#issuecomment-646620090
@github-actions crossbow submit conda-linux-gcc-py36-cpu
This is an automated message from the Apache Git Service.
kszucs commented on a change in pull request #7478:
URL: https://github.com/apache/arrow/pull/7478#discussion_r442823957
##
File path: cpp/src/arrow/compute/kernels/aggregate_test.cc
##
@@ -127,6 +127,41 @@ void ValidateSum(const Array& array) {
ValidateSum(array,
pitrou commented on pull request #7456:
URL: https://github.com/apache/arrow/pull/7456#issuecomment-646550402
I'll add a test that encoding errors are propagated correctly (hopefully
:-)).
This is an automated message from
github-actions[bot] commented on pull request #7496:
URL: https://github.com/apache/arrow/pull/7496#issuecomment-646557117
https://issues.apache.org/jira/browse/ARROW-7084
This is an automated message from the Apache Git
maartenbreddels commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-646605458
Note that the unitests should fail, the PR isn't done, but the tests seem to
run
This is an automated
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646594741
Revision: e98614e4a69ade342ec6bae3c2641117ecd1afdf
Submitted crossbow builds: [ursa-labs/crossbow @
kszucs commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646594021
@github-actions crossbow submit -g cpp -g wheel
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646594306
```
No such command 'run'.
```
This is an automated message from the Apache Git Service.
To
xhochy commented on pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#issuecomment-646594071
@github-actions crossbow submit conda-*
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] commented on pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#issuecomment-646594653
Revision: dbaef080c3e1ed81d9be8c0065ec34d2014a932b
Submitted crossbow builds: [ursa-labs/crossbow @
tianchen92 opened a new pull request #7496:
URL: https://github.com/apache/arrow/pull/7496
Related to [ARROW-7084](https://issues.apache.org/jira/browse/ARROW-7084).
It looks like ArrayRangeEquals in compare.cc only checks type IDs before
doing comparison actual values. This is
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646533368
@maartenbreddels This is passing now, feel free to rebase again.
@pitrou @kou @kszucs Any suggestions for Crossbow jobs I should run here?
kszucs commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646593973
@github-actions crossbow run -g cpp -g wheel
This is an automated message from the Apache Git Service.
To respond
xhochy opened a new pull request #7497:
URL: https://github.com/apache/arrow/pull/7497
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pravindra commented on a change in pull request #7402:
URL: https://github.com/apache/arrow/pull/7402#discussion_r442867225
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -284,6 +284,49 @@ const char* reverse_utf8(gdv_int64 context, const char*
data, gdv_int32
pravindra commented on a change in pull request #7402:
URL: https://github.com/apache/arrow/pull/7402#discussion_r442868857
##
File path: cpp/src/gandiva/precompiled/string_ops_test.cc
##
@@ -426,6 +426,33 @@ TEST(TestStringOps, TestReverse) {
ctx.Reset();
}
wesm closed pull request #7485:
URL: https://github.com/apache/arrow/pull/7485
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm commented on pull request #7485:
URL: https://github.com/apache/arrow/pull/7485#issuecomment-646694533
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nealrichardson commented on a change in pull request #7484:
URL: https://github.com/apache/arrow/pull/7484#discussion_r442910168
##
File path: cpp/build-support/cpplint.py
##
@@ -4008,9 +4008,9 @@ def CheckTrailingSemicolon(filename, clean_lines,
linenum, error):
# Block
nealrichardson commented on pull request #7487:
URL: https://github.com/apache/arrow/pull/7487#issuecomment-646723043
FYI @wesm I just pushed to this branch
This is an automated message from the Apache Git Service.
To
wesm commented on pull request #7491:
URL: https://github.com/apache/arrow/pull/7491#issuecomment-646729061
+1 -- merging this to help avoid rebase conflicts. We can continue to debate
terminology in ARROW-9161
This is an
xhochy commented on pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#issuecomment-646744806
@github-actions crossbow submit conda-linux-gcc-py36-cpu
This is an automated message from the Apache Git Service.
nealrichardson commented on a change in pull request #7478:
URL: https://github.com/apache/arrow/pull/7478#discussion_r442905880
##
File path: r/R/compute.R
##
@@ -58,13 +58,12 @@ scalar_aggregate <- function(FUN, ..., na.rm = FALSE) {
if (FUN %in% c("mean", "sum")) {
bkietz opened a new pull request #7498:
URL: https://github.com/apache/arrow/pull/7498
`CallFunction("minmax", {array})` no longer segfaults, instead using
`MinMaxOptions::Defaults()`.
Other Functions whose options have meaningful defaults will do the same.
`CallFunction("cast",
wesm commented on a change in pull request #7496:
URL: https://github.com/apache/arrow/pull/7496#discussion_r442906870
##
File path: cpp/src/arrow/compare.cc
##
@@ -984,7 +984,8 @@ bool ArrayRangeEquals(const Array& left, const Array&
right, int64_t left_start_
bool
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646749663
Revision: e98614e4a69ade342ec6bae3c2641117ecd1afdf
Submitted crossbow builds: [ursa-labs/crossbow @
wesm commented on pull request #7487:
URL: https://github.com/apache/arrow/pull/7487#issuecomment-646648019
I'll rebase and fix the test failures, but absent objections I'd like to
merge this before it causes more conflicts
kszucs commented on a change in pull request #7478:
URL: https://github.com/apache/arrow/pull/7478#discussion_r442863137
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -397,24 +452,26 @@ struct MinMaxImpl : public ScalarAggregator {
ArrayType
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646747888
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#issuecomment-646746701
Revision: 0004b7723a11c333f17befef8e5ec18b0d363eed
Submitted crossbow builds: [ursa-labs/crossbow @
kszucs commented on a change in pull request #7478:
URL: https://github.com/apache/arrow/pull/7478#discussion_r442864766
##
File path: cpp/src/arrow/compute/kernels/aggregate_test.cc
##
@@ -399,15 +434,59 @@ class TestNumericMinMaxKernel : public ::testing::Test {
};
pravindra commented on a change in pull request #7402:
URL: https://github.com/apache/arrow/pull/7402#discussion_r442869546
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -284,6 +284,49 @@ const char* reverse_utf8(gdv_int64 context, const char*
data, gdv_int32
kszucs commented on a change in pull request #7478:
URL: https://github.com/apache/arrow/pull/7478#discussion_r442864422
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -339,13 +366,38 @@ std::unique_ptr MeanInit(KernelContext* ctx,
const KernelInitArgs&
github-actions[bot] commented on pull request #7498:
URL: https://github.com/apache/arrow/pull/7498#issuecomment-646699466
https://issues.apache.org/jira/browse/ARROW-9091
This is an automated message from the Apache Git
bkietz commented on a change in pull request #7493:
URL: https://github.com/apache/arrow/pull/7493#discussion_r442924149
##
File path: cpp/src/arrow/util/atomic_shared_ptr.h
##
@@ -24,7 +24,9 @@
namespace arrow {
namespace internal {
-#if !defined(__clang__) &&
wesm commented on pull request #7487:
URL: https://github.com/apache/arrow/pull/7487#issuecomment-646727288
ah thank you
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wesm commented on pull request #7461:
URL: https://github.com/apache/arrow/pull/7461#issuecomment-646732180
I just requested JIRA reference autolinking
https://issues.apache.org/jira/browse/INFRA-20450
This is an automated
xhochy commented on pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#issuecomment-646793380
@github-actions crossbow submit conda-linux-gcc-py36-cuda
This is an automated message from the Apache Git
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646813324
@github-actions crossbow submit test-debian-10-cpp
This is an automated message from the Apache Git Service.
To
maxburke opened a new pull request #7500:
URL: https://github.com/apache/arrow/pull/7500
… these formats
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
github-actions[bot] commented on pull request #7500:
URL: https://github.com/apache/arrow/pull/7500#issuecomment-646890275
https://issues.apache.org/jira/browse/ARROW-9191
This is an automated message from the Apache Git
nealrichardson closed pull request #7499:
URL: https://github.com/apache/arrow/pull/7499
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kiszk commented on a change in pull request #7402:
URL: https://github.com/apache/arrow/pull/7402#discussion_r443101031
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -284,6 +284,49 @@ const char* reverse_utf8(gdv_int64 context, const char*
data, gdv_int32
kou commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646905286
+1 for Linux packages.
This is an automated message from the Apache Git Service.
To respond to the message, please
houqp opened a new pull request #7501:
URL: https://github.com/apache/arrow/pull/7501
The goal of this PR is not to fix all the clippy errors/warnings, but to
make sure no new linting errors are introduced in the future so we can slowly
fix the remaining errors.
github-actions[bot] commented on pull request #7501:
URL: https://github.com/apache/arrow/pull/7501#issuecomment-646927676
https://issues.apache.org/jira/browse/ARROW-9192
This is an automated message from the Apache Git
houqp closed pull request #7501:
URL: https://github.com/apache/arrow/pull/7501
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#issuecomment-646767943
Revision: 904e8761c468f5a46562cc9707d6746c5ca46cad
Submitted crossbow builds: [ursa-labs/crossbow @
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646784414
@github-actions crossbow submit -g wheel
This is an automated message from the Apache Git Service.
To respond to
nealrichardson commented on a change in pull request #7484:
URL: https://github.com/apache/arrow/pull/7484#discussion_r443032066
##
File path: cpp/build-support/cpplint.py
##
@@ -4008,9 +4008,9 @@ def CheckTrailingSemicolon(filename, clean_lines,
linenum, error):
# Block
kou commented on a change in pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#discussion_r443047872
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -493,6 +500,16 @@ else()
)
endif()
+if(DEFINED ENV{UTF8PROC_SOURCE_URL})
+
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646868366
Revision: 7883277a36f5c5b274eff2f42de5a6c28146d7c7
Submitted crossbow builds: [ursa-labs/crossbow @
nealrichardson opened a new pull request #7499:
URL: https://github.com/apache/arrow/pull/7499
FYI @romainfrancois @wesm
It's not a great dataset anyway for our tests because there's basically no
variation in data type or missingness. Switching some tests to use a more
wesm closed pull request #7487:
URL: https://github.com/apache/arrow/pull/7487
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm commented on pull request #7487:
URL: https://github.com/apache/arrow/pull/7487#issuecomment-646846922
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646785722
Revision: e98614e4a69ade342ec6bae3c2641117ecd1afdf
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#issuecomment-646815228
Revision: f9353e7445ec74bc9e8dd04e278bdc2cf2b5cfb0
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646871541
@github-actions crossbow submit centos-8-*
This is an automated message from the Apache Git Service.
To respond to
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646783738
Valgrind failure looks totally unrelated:
https://github.com/ursa-labs/crossbow/runs/788860352?check_suite_focus=true
xhochy commented on pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#issuecomment-646814560
@github-actions crossbow submit conda-linux-gcc-py36-cuda
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646813835
Revision: f1609e6dfe0dee96f2794edc77749cf62cc07f21
Submitted crossbow builds: [ursa-labs/crossbow @
maxburke commented on pull request #7480:
URL: https://github.com/apache/arrow/pull/7480#issuecomment-646766294
Re-opening this PR because the memory use changes are related to our use of
the underlying system allocator, not this change.
xhochy commented on pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#issuecomment-646766286
@github-actions crossbow submit conda-linux-gcc-py36-cpu
This is an automated message from the Apache Git Service.
github-actions[bot] commented on pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#issuecomment-646794145
Revision: 904e8761c468f5a46562cc9707d6746c5ca46cad
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #7499:
URL: https://github.com/apache/arrow/pull/7499#issuecomment-646824520
https://issues.apache.org/jira/browse/ARROW-9179
This is an automated message from the Apache Git
kou commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646867851
@github-actions crossbow submit -g linux
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646872055
Revision: 3ef68af4b928d3fadfa6aa4df82ecbba02113782
Submitted crossbow builds: [ursa-labs/crossbow @
projjal opened a new pull request #7495:
URL: https://github.com/apache/arrow/pull/7495
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #7495:
URL: https://github.com/apache/arrow/pull/7495#issuecomment-646474138
https://issues.apache.org/jira/browse/ARROW-9185
This is an automated message from the Apache Git
houqp opened a new pull request #7494:
URL: https://github.com/apache/arrow/pull/7494
Projection should be optional if user already wants to fetch all columns
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #7494:
URL: https://github.com/apache/arrow/pull/7494#issuecomment-646456940
https://issues.apache.org/jira/browse/ARROW-9184
This is an automated message from the Apache Git
72 matches
Mail list logo