[GitHub] [arrow] alamb commented on a change in pull request #8009: ARROW-9790: [Rust][Parquet]: Increase test coverage in arrow_reader.rs

alamb commented on a change in pull request #8009: URL: https://github.com/apache/arrow/pull/8009#discussion_r474756757 ## File path: rust/parquet/src/arrow/arrow_reader.rs ## @@ -348,30 +348,101 @@ mod tests { "; let converter = Utf8ArrayConverter {}; -

[GitHub] [arrow] nealrichardson opened a new pull request #8019: ARROW-9819: [C++] Bump mimalloc to 1.6.4

nealrichardson opened a new pull request #8019: URL: https://github.com/apache/arrow/pull/8019 1.6.4 includes a fix for https://github.com/microsoft/mimalloc/issues/277, which we need to enable it in the R Windows CRAN packages.

[GitHub] [arrow] alamb commented on pull request #8018: ARROW-9815 [Rust] [DataFusion] Fixed deadlock caused by accessing the scalar functions' registry.

alamb commented on pull request #8018: URL: https://github.com/apache/arrow/pull/8018#issuecomment-678333145 > I had another thought on this. We do need the `ExecutionContextState` to be mutable, but only up until execution begins. Perhaps we should rename `ExecutionContextState` to

[GitHub] [arrow] andygrove commented on pull request #8018: ARROW-9815 [Rust] [DataFusion] Fixed deadlock caused by accessing the scalar functions' registry.

andygrove commented on pull request #8018: URL: https://github.com/apache/arrow/pull/8018#issuecomment-678369613 @alamb I think you are right. Rather than having `Arc>` within `ExecutionContextState`, we should have `Arc>` where we need mutability and then `clone()` the state to get a

[GitHub] [arrow] patrickpai commented on pull request #7789: PARQUET-1878: [C++] lz4 codec is not compatible with Hadoop Lz4Codec

patrickpai commented on pull request #7789: URL: https://github.com/apache/arrow/pull/7789#issuecomment-678400124 Hey @pitrou, super sorry for the delay. I was caught up with other work and now job searching. I'll try to address comments as soon as I can.

[GitHub] [arrow] alamb commented on pull request #8018: ARROW-9815 [Rust] [DataFusion] Fixed deadlock caused by accessing the scalar functions' registry.

alamb commented on pull request #8018: URL: https://github.com/apache/arrow/pull/8018#issuecomment-678406791 That definitely sounds cleaner to me On Fri, Aug 21, 2020 at 12:07 PM Andy Grove wrote: > @alamb I think you are right. Rather than >

[GitHub] [arrow] kiszk commented on a change in pull request #7940: ARROW-9702: [C++] Register bpacking SIMD to runtime path.

kiszk commented on a change in pull request #7940: URL: https://github.com/apache/arrow/pull/7940#discussion_r474672365 ## File path: cpp/src/arrow/util/bpacking_avx2_codegen.py ## @@ -0,0 +1,200 @@ +#!/bin/python + +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] github-actions[bot] commented on pull request #8019: ARROW-9819: [C++] Bump mimalloc to 1.6.4

github-actions[bot] commented on pull request #8019: URL: https://github.com/apache/arrow/pull/8019#issuecomment-678354747 https://issues.apache.org/jira/browse/ARROW-9819 This is an automated message from the Apache Git

[GitHub] [arrow] cyb70289 commented on a change in pull request #7963: ARROW-9699: [C++][Compute] Optimize mode kernel for small integer types

cyb70289 commented on a change in pull request #7963: URL: https://github.com/apache/arrow/pull/7963#discussion_r474658427 ## File path: cpp/src/arrow/compute/kernels/aggregate_mode.cc ## @@ -69,28 +72,83 @@ struct ModeState { std::unordered_map value_counts{}; }; +//

[GitHub] [arrow] andygrove commented on pull request #8018: ARROW-9815 [Rust] [DataFusion] Fixed deadlock caused by accessing the scalar functions' registry.

andygrove commented on pull request #8018: URL: https://github.com/apache/arrow/pull/8018#issuecomment-678281123 I had another thought on this. We do need the `ExecutionContextState` to be mutable, but only up until execution begins. Perhaps we should rename `ExecutionContextState` to

[GitHub] [arrow] cyb70289 commented on a change in pull request #7963: ARROW-9699: [C++][Compute] Optimize mode kernel for small integer types

cyb70289 commented on a change in pull request #7963: URL: https://github.com/apache/arrow/pull/7963#discussion_r474660357 ## File path: cpp/src/arrow/compute/kernels/aggregate_test.cc ## @@ -685,5 +687,10 @@ TYPED_TEST(TestFloatingModeKernel, Floats) {

[GitHub] [arrow] github-actions[bot] commented on pull request #8020: ARROW-9821: [Rust][DataFusion] Prototype design for UserDefined Logical Plan Nodes NOT FOR MERGING

github-actions[bot] commented on pull request #8020: URL: https://github.com/apache/arrow/pull/8020#issuecomment-678526012 https://issues.apache.org/jira/browse/ARROW-9821 This is an automated message from the Apache Git

[GitHub] [arrow] kou opened a new pull request #8021: ARROW-9823: [CI][C++][MinGW] Enable S3

kou opened a new pull request #8021: URL: https://github.com/apache/arrow/pull/8021 But arrow-s3fs-test is disabled for now. Because the current aws-sdk-cpp MSYS2 package provides only static library. We can enable arrow-s3fs-test once aws-sdk-cpp MSYS2 package provides shared

[GitHub] [arrow] jianxind commented on a change in pull request #7940: ARROW-9702: [C++] Register bpacking SIMD to runtime path.

jianxind commented on a change in pull request #7940: URL: https://github.com/apache/arrow/pull/7940#discussion_r475018469 ## File path: cpp/src/arrow/util/bpacking_avx2_codegen.py ## @@ -0,0 +1,200 @@ +#!/bin/python + +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [arrow] alamb commented on a change in pull request #8020: ARROW-9821: [Rust][DataFusion] Prototype design for UserDefined Logical Plan Nodes NOT FOR MERGING

alamb commented on a change in pull request #8020: URL: https://github.com/apache/arrow/pull/8020#discussion_r474978077 ## File path: rust/datafusion/src/lp.rs ## @@ -0,0 +1,89 @@ +//! Prototype LogicalPlanNode interface for defining extensions for LogicalPlan nodes + +use

[GitHub] [arrow] alamb commented on a change in pull request #8020: ARROW-9821: [Rust][DataFusion] Prototype design for UserDefined Logical Plan Nodes NOT FOR MERGING

alamb commented on a change in pull request #8020: URL: https://github.com/apache/arrow/pull/8020#discussion_r474978196 ## File path: rust/datafusion/src/lp_limit.rs ## @@ -0,0 +1,99 @@ +//! Example of how a "User Defined logical plan node would work. Use Review comment:

[GitHub] [arrow] jorgecarleitao commented on pull request #8018: ARROW-9815 [Rust] [DataFusion] Fixed deadlock caused by accessing the scalar functions' registry.

jorgecarleitao commented on pull request #8018: URL: https://github.com/apache/arrow/pull/8018#issuecomment-678428145 You agree, I agree, we all agree!!! I will re-visit this and re-submit a PR with this. This is an

[GitHub] [arrow] github-actions[bot] commented on pull request #8021: ARROW-9823: [CI][C++][MinGW] Enable S3

github-actions[bot] commented on pull request #8021: URL: https://github.com/apache/arrow/pull/8021#issuecomment-678539644 https://issues.apache.org/jira/browse/ARROW-9823 This is an automated message from the Apache Git

[GitHub] [arrow] ryannicholson closed pull request #8022: [FlightRPC] Flight SQL POC

ryannicholson closed pull request #8022: URL: https://github.com/apache/arrow/pull/8022 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] ryannicholson opened a new pull request #8022: [FlightRPC] Flight SQL POC

ryannicholson opened a new pull request #8022: URL: https://github.com/apache/arrow/pull/8022 Add extensions in the Apache Arrow project’s Arrow Flight modules to provide a standard way for clients and servers to communicate with SQL-like semantics. Do not pull to master. A

[GitHub] [arrow] kiszk commented on pull request #8019: ARROW-9819: [C++] Bump mimalloc to 1.6.4

kiszk commented on pull request #8019: URL: https://github.com/apache/arrow/pull/8019#issuecomment-678571637 Here is a set of changes at 1.6.4. https://github.com/microsoft/mimalloc#releases This is an automated message