jorgecarleitao commented on pull request #8032:
URL: https://github.com/apache/arrow/pull/8032#issuecomment-679631810
> For built-in functions like `sqrt` I would expect DataFusion to provide
convenience functions to create an expression, like we do with `col` and the
aggregate functions.
jorgecarleitao edited a comment on pull request #8032:
URL: https://github.com/apache/arrow/pull/8032#issuecomment-679631810
> For built-in functions like `sqrt` I would expect DataFusion to provide
convenience functions to create an expression, like we do with `col` and the
aggregate
jorgecarleitao edited a comment on pull request #8032:
URL: https://github.com/apache/arrow/pull/8032#issuecomment-679631810
> For built-in functions like `sqrt` I would expect DataFusion to provide
convenience functions to create an expression, like we do with `col` and the
aggregate
alamb commented on a change in pull request #8031:
URL: https://github.com/apache/arrow/pull/8031#discussion_r475531252
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -477,9 +466,9 @@ impl ExecutionConfig {
/// Execution context for registering data sources and
emkornfield commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r475376926
##
File path: cpp/src/parquet/encryption.h
##
@@ -47,15 +47,15 @@ using ColumnPathToEncryptionPropertiesMap =
class PARQUET_EXPORT
thamht4190 commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r475442393
##
File path: cpp/src/parquet/kms_client_factory.h
##
@@ -0,0 +1,42 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
thamht4190 commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r475446337
##
File path: cpp/src/parquet/file_key_material_store.h
##
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
kszucs closed pull request #7985:
URL: https://github.com/apache/arrow/pull/7985
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kszucs commented on pull request #7985:
URL: https://github.com/apache/arrow/pull/7985#issuecomment-679030048
Closing since 1.0.1 has been released.
This is an automated message from the Apache Git Service.
To respond to the
alamb commented on pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#issuecomment-679069890
> I would prefer that the user does not have to have this burden: it
registers a UDF with the type, and then just plans a call without its return
type, during planning.
thamht4190 commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r475440024
##
File path: cpp/src/parquet/key_toolkit.h
##
@@ -0,0 +1,123 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
thamht4190 commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r475368729
##
File path: cpp/src/parquet/encryption.h
##
@@ -47,15 +47,15 @@ using ColumnPathToEncryptionPropertiesMap =
class PARQUET_EXPORT
jorisvandenbossche commented on a change in pull request #8008:
URL: https://github.com/apache/arrow/pull/8008#discussion_r475541170
##
File path: python/pyarrow/scalar.pxi
##
@@ -687,6 +687,44 @@ cdef class DictionaryScalar(Scalar):
Concrete class for dictionary-encoded
alamb commented on a change in pull request #8034:
URL: https://github.com/apache/arrow/pull/8034#discussion_r475537669
##
File path: rust/datafusion/src/execution/physical_plan/mod.rs
##
@@ -74,6 +85,15 @@ impl Partitioning {
}
}
+/// Distribution schemes
jorisvandenbossche commented on a change in pull request #8008:
URL: https://github.com/apache/arrow/pull/8008#discussion_r475540932
##
File path: python/pyarrow/scalar.pxi
##
@@ -687,6 +687,44 @@ cdef class DictionaryScalar(Scalar):
Concrete class for dictionary-encoded
github-actions[bot] commented on pull request #8038:
URL: https://github.com/apache/arrow/pull/8038#issuecomment-679157223
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
alamb commented on pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#issuecomment-679075478
I will try and review this carefully later today sometime -- I am on
vacation this week with my family so my responses will likely be delayed
compared to normal (not that I
github-actions[bot] commented on pull request #8037:
URL: https://github.com/apache/arrow/pull/8037#issuecomment-679121480
https://issues.apache.org/jira/browse/ARROW-9827
This is an automated message from the Apache Git
jorisvandenbossche commented on a change in pull request #8037:
URL: https://github.com/apache/arrow/pull/8037#discussion_r475594117
##
File path: cpp/src/arrow/dataset/file_parquet.cc
##
@@ -357,12 +357,14 @@ Result
ParquetFileFormat::ScanFile(std::shared_ptrsource(),
github-actions[bot] commented on pull request #8036:
URL: https://github.com/apache/arrow/pull/8036#issuecomment-679113683
https://issues.apache.org/jira/browse/ARROW-9811
This is an automated message from the Apache Git
liyafan82 opened a new pull request #8036:
URL: https://github.com/apache/arrow/pull/8036
See https://issues.apache.org/jira/browse/ARROW-9811
This is an automated message from the Apache Git Service.
To respond to the
klucar opened a new pull request #8038:
URL: https://github.com/apache/arrow/pull/8038
Documentation for the python filesystem interface was not updated when the
code changed FileStats to FileInfo.
The code still has a line saying FileStats = FileInfo "for backward
compatibility"
jorisvandenbossche opened a new pull request #8037:
URL: https://github.com/apache/arrow/pull/8037
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jorisvandenbossche closed pull request #8038:
URL: https://github.com/apache/arrow/pull/8038
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on pull request #8038:
URL: https://github.com/apache/arrow/pull/8038#issuecomment-679171658
https://issues.apache.org/jira/browse/ARROW-9840
This is an automated message from the Apache Git
thamht4190 commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r475668043
##
File path: cpp/src/parquet/encryption.h
##
@@ -47,15 +47,15 @@ using ColumnPathToEncryptionPropertiesMap =
class PARQUET_EXPORT
nevi-me opened a new pull request #8039:
URL: https://github.com/apache/arrow/pull/8039
Built and manually fixed errors on required fields
This is an automated message from the Apache Git Service.
To respond to the message,
github-actions[bot] commented on pull request #8039:
URL: https://github.com/apache/arrow/pull/8039#issuecomment-679228676
https://issues.apache.org/jira/browse/ARROW-9841
This is an automated message from the Apache Git
corleyma commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679406134
@kou I pushed some changes which optimistically re-enable building of AWS
C++ sdk from source.
@pitrou As said before, I'm not super familiar with conda but a cursory
corleyma commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679408850
> The approach we use for manylinux wheels is to build the AWS SDK from
source separately, and it works. Why would it be different on macOS?
I'm not sure if it would be
saethlin opened a new pull request #8042:
URL: https://github.com/apache/arrow/pull/8042
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
corleyma commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679418775
>So any C++ dependency that's expressed naturally in conda (as a dependency
on just another package) has to become statically bundled in a Python wheel.
Bundling those
andygrove closed pull request #8039:
URL: https://github.com/apache/arrow/pull/8039
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679407504
The approach we use for manylinux wheels is to build the AWS SDK from source
separately, and it works. Why would it be different on macOS?
pitrou commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679409666
I can't answer definitely, but I'm extremely skeptical that conda-build will
be able to proper usable Python wheels in anything other than the most simple
cases, and Arrow is
pitrou commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679409935
So I maintain that building AWS SDK from source during the wheel build
process is probably the most reasonable way forward here.
andygrove commented on a change in pull request #8020:
URL: https://github.com/apache/arrow/pull/8020#discussion_r475953168
##
File path: rust/datafusion/src/lp_limit.rs
##
@@ -0,0 +1,99 @@
+//! Example of how a "User Defined logical plan node would work. Use
+//! the
andygrove closed pull request #8030:
URL: https://github.com/apache/arrow/pull/8030
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8042:
URL: https://github.com/apache/arrow/pull/8042#issuecomment-679421435
https://issues.apache.org/jira/browse/ARROW-9845
This is an automated message from the Apache Git
andygrove closed pull request #8031:
URL: https://github.com/apache/arrow/pull/8031
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kou commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679470592
@github-actions crossbow submit wheel-osx-*
Oh, sorry. I didn't know that we have the
https://github.com/apache/arrow/blob/master/dev/archery/archery/bot.py#L180-L183
check.
andygrove commented on pull request #8042:
URL: https://github.com/apache/arrow/pull/8042#issuecomment-679470478
Build failure is unrelated to these changes - see
https://issues.apache.org/jira/browse/ARROW-9846
This is an
andygrove opened a new pull request #8043:
URL: https://github.com/apache/arrow/pull/8043
It is supposedly bad practice to check-in Cargo.lock for libraries, but I am
curious to see if this fixes the broken build.
This is
github-actions[bot] commented on pull request #8043:
URL: https://github.com/apache/arrow/pull/8043#issuecomment-679486365
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
github-actions[bot] commented on pull request #8044:
URL: https://github.com/apache/arrow/pull/8044#issuecomment-679599784
https://issues.apache.org/jira/browse/ARROW-7663
This is an automated message from the Apache Git
arw2019 opened a new pull request #8044:
URL: https://github.com/apache/arrow/pull/8044
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kou commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679356761
@github-actions crossbow submit wheel-osx-*
This is an automated message from the Apache Git Service.
To respond to
pitrou commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679350519
I don't remember the specifics, but IIRC the AWS SDK build procedure always
takes up the system version of OpenSSL, while in many cases (especially
packaging-related) we want to
pitrou commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679350747
That was with an older AWS SDK version some time ago, though, so you could
try to enable it and see what happens now.
github-actions[bot] commented on pull request #8041:
URL: https://github.com/apache/arrow/pull/8041#issuecomment-679365736
https://issues.apache.org/jira/browse/ARROW-8001
This is an automated message from the Apache Git
andygrove commented on pull request #8032:
URL: https://github.com/apache/arrow/pull/8032#issuecomment-679327189
For built-in functions like `sqrt` I would expect DataFusion to provide
convenience functions to create an expression, like we do with `col` and the
aggregate functions. I
corleyma commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679333928
@pitrou It seems like it might be worth digging into how to fix/enable
builds of AWS SDK in the `ThirdpartyToolchain.cmake`. Looks like you disabled
it
scober opened a new pull request #8040:
URL: https://github.com/apache/arrow/pull/8040
Export the file_offset field (which already exists in RowGroupMetaDataImpl)
in RowGroupMetaData.
This is an automated message from the
github-actions[bot] commented on pull request #8040:
URL: https://github.com/apache/arrow/pull/8040#issuecomment-679345538
https://issues.apache.org/jira/browse/ARROW-9824
This is an automated message from the Apache Git
emkornfield commented on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-679355309
> Also I suppose if we want to consider block level memory reservation then
we should dive into jemalloc and use some thing like a hook API right? That
will appear to take me
emkornfield commented on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-679355492
The logic might warrant its own interface instead of a std::Function.
This is an automated message from the
github-actions[bot] commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679357816
Revision: e2359f53f4f053ea9181963d3859d7d43c5dee04
Submitted crossbow builds: [ursa-labs/crossbow @
jacques-n commented on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-679358407
> The logic might warrant its own interface instead of a std::Function.
I believe we already have this functionality in Gandiva. Let's see if we can
use a consistent
nealrichardson opened a new pull request #8041:
URL: https://github.com/apache/arrow/pull/8041
* r/R/dataset.R is broken out into smaller files. I did this in the first
commit, isolated from the behavior changes, so if you do a diff without the
first commit, it's easier to see what has
nealrichardson commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679370468
FWIW the latest Travis failures do look like
https://github.com/aws/aws-sdk-cpp/issues/1309. I don't think Homebrew is a
viable source for aws-sdk-cpp for us.
andygrove commented on pull request #8033:
URL: https://github.com/apache/arrow/pull/8033#issuecomment-679429920
Hi @wqc200 please rebase against master rather than merge from master once
this is ready for review.
This is
github-actions[bot] commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679431464
Revision: 0b3365dbee909715c7fa7dbdaeebac50357f72d2
Submitted crossbow builds: [ursa-labs/crossbow @
corleyma commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679435086
@kou Ah, interesting, good to know! I could not seem to get
`@github-actions crossbow submit -g conda` to work as expected in a different
PR, but perhaps it's just the `-g`
corleyma commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679458248
@github-actions crossbow submit wheel-osx-*
This is an automated message from the Apache Git Service.
To respond
corleyma commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679461439
@kou seems crossbow builds won't run for me, alas.
This is an automated message from the Apache Git Service.
andygrove edited a comment on pull request #8034:
URL: https://github.com/apache/arrow/pull/8034#issuecomment-679426900
Thanks for the reviews @alamb and @jorgecarleitao .. I have implemented the
suggested changes and have also improved the error handling so that we return
`Err` results
andygrove commented on pull request #8034:
URL: https://github.com/apache/arrow/pull/8034#issuecomment-679426900
Thanks for the reviews @alamb and @jorgecarleitao .. I have implemented the
suggested and also improved the error handling so we return `Err` results
rather than panic if the
kou commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-679430872
@github-actions crossbow submit wheel-osx-*
FYI: Anybody can run jobs to build wheels for macOS by writing the above
comment.
68 matches
Mail list logo
