[GitHub] [arrow] alamb commented on pull request #8503: ARROW-10366: [Rust] [DataFusion] Remove collect from within threads on merge

2020-10-24 Thread GitBox
alamb commented on pull request #8503: URL: https://github.com/apache/arrow/pull/8503#issuecomment-715899914 I spent some more time looking and thinking about this issue. I have some more thoughts I plan to try out tomorrow. I'll keep you posed @jorgecarleitao

[GitHub] [arrow] nevi-me edited a comment on pull request #8402: ARROW-8426: [Rust] [Parquet] - Add more support for converting Dicts

2020-10-24 Thread GitBox
nevi-me edited a comment on pull request #8402: URL: https://github.com/apache/arrow/pull/8402#issuecomment-716092619 I've botched this branch a bit with my rebase on the parquet branch. I rebased it against the parquet branch, but then I started getting stack overflows on datafusion

[GitHub] [arrow] pprudhvi commented on pull request #8499: [CI] Pin homebrew LLVM@9

2020-10-24 Thread GitBox
pprudhvi commented on pull request #8499: URL: https://github.com/apache/arrow/pull/8499#issuecomment-716083203 @kou we are working on it This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] nevi-me commented on pull request #8402: ARROW-8426: [Rust] [Parquet] - Add more support for converting Dicts

2020-10-24 Thread GitBox
nevi-me commented on pull request #8402: URL: https://github.com/apache/arrow/pull/8402#issuecomment-716092619 I've botched this branch a bit with my rebase on the parquet branch. I rebased it against the parquet branch, but then I started getting stack overflows on datafusion and

[GitHub] [arrow] nevi-me commented on a change in pull request #8402: ARROW-8426: [Rust] [Parquet] - Add more support for converting Dicts

2020-10-24 Thread GitBox
nevi-me commented on a change in pull request #8402: URL: https://github.com/apache/arrow/pull/8402#discussion_r511538707 ## File path: cpp/src/arrow/ipc/metadata_internal.cc ## @@ -427,8 +427,7 @@ static Status GetDictionaryEncoding(FBB& fbb, const std::shared_ptr& fiel

[GitHub] [arrow] pprudhvi edited a comment on pull request #8499: [CI] Pin homebrew LLVM@9

2020-10-24 Thread GitBox
pprudhvi edited a comment on pull request #8499: URL: https://github.com/apache/arrow/pull/8499#issuecomment-716083203 @kou we are working on it. Also, we will do the llvm11 upgrade in linux docker image for gandiva-jar-xenial later

[GitHub] [arrow] kou commented on pull request #8521: ARROW-10385: [C++][Gandiva] Add support for LLVM 11

2020-10-24 Thread GitBox
kou commented on pull request #8521: URL: https://github.com/apache/arrow/pull/8521#issuecomment-716058955 @github-actions crossbow submit homebrew-cpp nuget This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #8521: ARROW-10385: [C++][Gandiva] Add support for LLVM 11

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #8521: URL: https://github.com/apache/arrow/pull/8521#issuecomment-716059179 Revision: fd073199faa1505db19224f039e8ba35a690364d Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #8521: ARROW-10385: [C++][Gandiva] Add support for LLVM 11

2020-10-24 Thread GitBox
kou commented on pull request #8521: URL: https://github.com/apache/arrow/pull/8521#issuecomment-716059059 Remaining issues: * MinGW link error This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] kou commented on pull request #8499: [CI] Pin homebrew LLVM@9

2020-10-24 Thread GitBox
kou commented on pull request #8499: URL: https://github.com/apache/arrow/pull/8499#issuecomment-716044635 We don't need this once #8521 is merged. @pprudhvi BTW, could you fix the gandiva-jar-xenial failure? It seems that this is caused by

[GitHub] [arrow] jorgecarleitao commented on pull request #8517: ARROW-10381: [Rust] Generalized Ordering for inter-array comparisons

2020-10-24 Thread GitBox
jorgecarleitao commented on pull request #8517: URL: https://github.com/apache/arrow/pull/8517#issuecomment-715986049 FYI @andygrove @alamb : I planning to approach the MergeSort in DataFusion: my current idea is to merge-sort record-batches within a part and then merge-sort then again

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8517: ARROW-10381: [Rust] Generalized Ordering for inter-array comparisons

2020-10-24 Thread GitBox
jorgecarleitao commented on a change in pull request #8517: URL: https://github.com/apache/arrow/pull/8517#discussion_r511491453 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -453,49 +466,46 @@ pub fn lexsort(columns: &[SortColumn]) -> Result> { /// Sort

[GitHub] [arrow] kiszk opened a new pull request #8518: ARROW-10382: [rust] fix typos

2020-10-24 Thread GitBox
kiszk opened a new pull request #8518: URL: https://github.com/apache/arrow/pull/8518 This PR fixes typos in files under `rust` directory. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] kiszk opened a new pull request #8519: ARROW-10383: [Doc] fix typos

2020-10-24 Thread GitBox
kiszk opened a new pull request #8519: URL: https://github.com/apache/arrow/pull/8519 This PR fixes typos in files under `docs` directory. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] github-actions[bot] commented on pull request #8518: ARROW-10382: [Rust] fix typos

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #8518: URL: https://github.com/apache/arrow/pull/8518#issuecomment-716002210 https://issues.apache.org/jira/browse/ARROW-10382 This is an automated message from the Apache Git

[GitHub] [arrow] kou closed pull request #8519: ARROW-10383: [Doc] fix typos

2020-10-24 Thread GitBox
kou closed pull request #8519: URL: https://github.com/apache/arrow/pull/8519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou closed pull request #8520: ARROW-10384: [C++] Fix typos

2020-10-24 Thread GitBox
kou closed pull request #8520: URL: https://github.com/apache/arrow/pull/8520 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou closed pull request #8518: ARROW-10382: [Rust] Fix typos

2020-10-24 Thread GitBox
kou closed pull request #8518: URL: https://github.com/apache/arrow/pull/8518 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou opened a new pull request #8521: ARROW-10385: [C++][Gandiva] Add support for LLVM 11

2020-10-24 Thread GitBox
kou opened a new pull request #8521: URL: https://github.com/apache/arrow/pull/8521 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] kou commented on pull request #8492: Allow LLVM 11

2020-10-24 Thread GitBox
kou commented on pull request #8492: URL: https://github.com/apache/arrow/pull/8492#issuecomment-716042133 #8521 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] kou closed pull request #8492: Allow LLVM 11

2020-10-24 Thread GitBox
kou closed pull request #8492: URL: https://github.com/apache/arrow/pull/8492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou commented on pull request #8521: ARROW-10385: [C++][Gandiva] Add support for LLVM 11

2020-10-24 Thread GitBox
kou commented on pull request #8521: URL: https://github.com/apache/arrow/pull/8521#issuecomment-716042188 @github-actions crossbow submit -g nightly This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] jorgecarleitao opened a new pull request #8517: ARROW-10381: [Rust] Generalized Ordering for inter-array comparisons

2020-10-24 Thread GitBox
jorgecarleitao opened a new pull request #8517: URL: https://github.com/apache/arrow/pull/8517 Currently, the code on `array/ord.rs` is centered around intra-array comparison. However, this does not allow to compare values from two different arrays, which is required on e.g. merge-sort

[GitHub] [arrow] github-actions[bot] commented on pull request #8517: ARROW-10381: [Rust] Generalized Ordering for inter-array comparisons

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #8517: URL: https://github.com/apache/arrow/pull/8517#issuecomment-715988969 https://issues.apache.org/jira/browse/ARROW-10381 This is an automated message from the Apache Git

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8517: ARROW-10381: [Rust] Generalized Ordering for inter-array comparisons

2020-10-24 Thread GitBox
jorgecarleitao commented on a change in pull request #8517: URL: https://github.com/apache/arrow/pull/8517#discussion_r511491453 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -453,49 +466,46 @@ pub fn lexsort(columns: &[SortColumn]) -> Result> { /// Sort

[GitHub] [arrow] kiszk opened a new pull request #8520: ARROW-10384: [c++] fix typos

2020-10-24 Thread GitBox
kiszk opened a new pull request #8520: URL: https://github.com/apache/arrow/pull/8520 This PR fixes typos in files under `cpp` directory. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] github-actions[bot] commented on pull request #8519: ARROW-10383: [Doc] fix typos

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #8519: URL: https://github.com/apache/arrow/pull/8519#issuecomment-716002215 https://issues.apache.org/jira/browse/ARROW-10383 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #8520: ARROW-10384: [C++] fix typos

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #8520: URL: https://github.com/apache/arrow/pull/8520#issuecomment-716002213 https://issues.apache.org/jira/browse/ARROW-10384 This is an automated message from the Apache Git

[GitHub] [arrow] andygrove commented on pull request #8517: ARROW-10381: [Rust] Generalized Ordering for inter-array comparisons

2020-10-24 Thread GitBox
andygrove commented on pull request #8517: URL: https://github.com/apache/arrow/pull/8517#issuecomment-716031171 @jorgecarleitao this sounds good. I am going to make time tomorrow to catch up on the current PRs. This is an

[GitHub] [arrow] github-actions[bot] commented on pull request #8521: ARROW-10385: [C++][Gandiva] Add support for LLVM 11

2020-10-24 Thread GitBox
github-actions[bot] commented on pull request #8521: URL: https://github.com/apache/arrow/pull/8521#issuecomment-716043160 https://issues.apache.org/jira/browse/ARROW-10385 This is an automated message from the Apache Git