[GitHub] [arrow] nevi-me commented on pull request #8223: ARROW-10040: [Rust] Add slice that realigns Buffer

2020-09-25 Thread GitBox
nevi-me commented on pull request #8223: URL: https://github.com/apache/arrow/pull/8223#issuecomment-698963093 Hey @jhorstmann, I haven't had time to look, but maybe I'm confused. What I recall is that I needed a way of converting a Buffer to a `Vec` when I write to Parquet. It might even

[GitHub] [arrow] nevi-me commented on pull request #8223: ARROW-10040: [Rust] Add slice that realigns Buffer

2020-09-22 Thread GitBox
nevi-me commented on pull request #8223: URL: https://github.com/apache/arrow/pull/8223#issuecomment-696669012 @jhorstmann can I close this PR, and rely on your implementation when ready? Also, do you think we'd be able to use your implementation in `parquet`, as we might need that for

[GitHub] [arrow] nevi-me commented on pull request #8223: ARROW-10040: [Rust] Add slice that realigns Buffer

2020-09-22 Thread GitBox
nevi-me commented on pull request #8223: URL: https://github.com/apache/arrow/pull/8223#issuecomment-696669012 @jhorstmann can I close this PR, and rely on your implementation when ready? Also, do you think we'd be able to use your implementation in `parquet`, as we might need that for

[GitHub] [arrow] nevi-me commented on pull request #8223: ARROW-10040: [Rust] Add slice that realigns Buffer

2020-09-19 Thread GitBox
nevi-me commented on pull request #8223: URL: https://github.com/apache/arrow/pull/8223#issuecomment-695347849 @jhorstmann @paddyhoran this is related to the alignment fixes made recently. I noticed while reviewing another PR that we had a limitation on boolean kernels if offsets weren't