ihji commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-631950394
R: @chamikaramj
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kamilwu commented on pull request #11760:
URL: https://github.com/apache/beam/pull/11760#issuecomment-631967204
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
kamilwu commented on pull request #11760:
URL: https://github.com/apache/beam/pull/11760#issuecomment-631976285
Thanks @epicfaace!
This is an automated message from the Apache Git Service.
To respond to the message, please
kamilwu merged pull request #11760:
URL: https://github.com/apache/beam/pull/11760
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ihji opened a new pull request #11771:
URL: https://github.com/apache/beam/pull/11771
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
DariuszAniszewski commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-632019864
Just a small comment about the force-push from above - it was mistakenly
done, then reverted. HEAD of this branch is still on **3ba192a** and comment is
a leftover.
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r428605560
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/BatchRequestForDLP.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to
mxm opened a new pull request #11772:
URL: https://github.com/apache/beam/pull/11772
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex | Dataflow | Flink | Gearpump |
kkucharc commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-631990753
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r428606587
##
File path:
sdks/java/extensions/ml/src/test/java/org/apache/beam/sdk/extensions/ml/DLPTextOperationsIT.java
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632397951
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
iemejia commented on pull request #11755:
URL: https://github.com/apache/beam/pull/11755#issuecomment-632404805
Yes we probably need those jenkins uber jobs (Flink too). Other use case
where this script proves really handy would be users asking committers to
trigger tests, maybe worth to
epicfaace opened a new pull request #11790:
URL: https://github.com/apache/beam/pull/11790
[draft - in progress]
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ]
youngoli commented on pull request #11791:
URL: https://github.com/apache/beam/pull/11791#issuecomment-632451757
For reference, the tests I'm trying to match:
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/worker/bundle_processor_test.py#L61
angoenka commented on pull request #11783:
URL: https://github.com/apache/beam/pull/11783#issuecomment-632370504
R: @ibzib
This is an automated message from the Apache Git Service.
To respond to the message, please log on
angoenka commented on pull request #11783:
URL: https://github.com/apache/beam/pull/11783#issuecomment-632370590
R: @tvalentyn
This is an automated message from the Apache Git Service.
To respond to the message, please log
angoenka opened a new pull request #11783:
URL: https://github.com/apache/beam/pull/11783
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
aaltay commented on pull request #10165:
URL: https://github.com/apache/beam/pull/10165#issuecomment-632377660
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia commented on pull request #11610:
URL: https://github.com/apache/beam/pull/11610#issuecomment-632377843
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632396377
retest all please
This is an automated message from the Apache Git Service.
To respond to the message, please
ibzib commented on pull request #11755:
URL: https://github.com/apache/beam/pull/11755#issuecomment-632405988
> Yes we probably need those jenkins uber jobs (Flink too). Other use case
where this script proves really handy would be users asking committers to
trigger tests, maybe worth to
udim commented on a change in pull request #11070:
URL: https://github.com/apache/beam/pull/11070#discussion_r428996230
##
File path: website/src/_posts/2020-03-06-python-typing.md
##
@@ -0,0 +1,117 @@
+---
+layout: post
+title: "Python SDK Typing Changes"
+date: 2020-03-06
robinyqiu commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-632331823
> are there any tests that use the DATE Type in an aggregation (e.g. MAX)?
No. Thanks for bringing this up. I think it is likely to run into the
problem.
reuvenlax commented on a change in pull request #11456:
URL: https://github.com/apache/beam/pull/11456#discussion_r428901750
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/MillisInstant.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the
aaltay commented on pull request #11682:
URL: https://github.com/apache/beam/pull/11682#issuecomment-632361896
Java precommit failed in the last 2 runs. Could you look at the logs? Is it
related to this change?
This is an
chamikaramj merged pull request #11360:
URL: https://github.com/apache/beam/pull/11360
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
robertwb commented on a change in pull request #11765:
URL: https://github.com/apache/beam/pull/11765#discussion_r428960780
##
File path: sdks/python/apache_beam/transforms/ptransform.py
##
@@ -270,11 +256,19 @@ def get_named_nested_pvalues(pvalueish):
tagged_values =
angoenka merged pull request #11783:
URL: https://github.com/apache/beam/pull/11783
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
angoenka commented on pull request #11783:
URL: https://github.com/apache/beam/pull/11783#issuecomment-632400825
Tests passed
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TheNeuralBit commented on pull request #11786:
URL: https://github.com/apache/beam/pull/11786#issuecomment-632412040
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chamikaramj commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632347848
LGTM. Thanks.
Ran the Kafka test few times and it seems to be working.
This is an automated message
ibzib opened a new pull request #11784:
URL: https://github.com/apache/beam/pull/11784
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
chamikaramj merged pull request #11771:
URL: https://github.com/apache/beam/pull/11771
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
epicfaace opened a new pull request #11789:
URL: https://github.com/apache/beam/pull/11789
Fix typo. R: @pabloem
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
youngoli opened a new pull request #11791:
URL: https://github.com/apache/beam/pull/11791
Adds code to more closely align with the implementations of splitting in
Python and Java. Note that not all cases are implemented. There is no
measurement of sub-element progress yet, nor is
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632349170
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit merged pull request #11625:
URL: https://github.com/apache/beam/pull/11625
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632382830
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit opened a new pull request #11786:
URL: https://github.com/apache/beam/pull/11786
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex | Dataflow | Flink |
epicfaace opened a new pull request #11788:
URL: https://github.com/apache/beam/pull/11788
Add Python 3.8 postcommit tests.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [
darshanj commented on pull request #11682:
URL: https://github.com/apache/beam/pull/11682#issuecomment-632447130
@apilloud @aaltay Looks like passing a class instead of partitionFn makes
Partition Transform unserializable. I have reverted that changes for
suggestion. Serializing a
youngoli commented on pull request #11791:
URL: https://github.com/apache/beam/pull/11791#issuecomment-632451211
R: @lostluck
CC: @robertwb @lukecwik @boyuanzz
This is an automated message from the Apache Git Service.
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632350790
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
angoenka commented on pull request #11783:
URL: https://github.com/apache/beam/pull/11783#issuecomment-632372278
Thanks!
Will wait for the tests to pass.
This is an automated message from the Apache Git Service.
To
chamikaramj commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632381115
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632390617
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
boyuanzz commented on pull request #11715:
URL: https://github.com/apache/beam/pull/11715#issuecomment-632408026
> What is the intrinsic limitation that did not allow old
`OffsetRangeTracker` to be refactored for this use case? or why we want to have
both?
>
robertwb opened a new pull request #11785:
URL: https://github.com/apache/beam/pull/11785
It's not a perfect signal, but will still cover a lot of doctests.
(It's also a bit hacky, but the TestRunner doesn't offer very good hooks for
customization here.)
robertwb commented on pull request #11785:
URL: https://github.com/apache/beam/pull/11785#issuecomment-632408257
R: @TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message, please
udim commented on pull request #11070:
URL: https://github.com/apache/beam/pull/11070#issuecomment-632433800
I've squashed the commits to more easily rename the file. Optimistically
merging by May 26! :)
This is an
aijamalnk commented on pull request #11780:
URL: https://github.com/apache/beam/pull/11780#issuecomment-632437739
@iemejia could you review please?
This is an automated message from the Apache Git Service.
To respond to the
aijamalnk commented on pull request #11780:
URL: https://github.com/apache/beam/pull/11780#issuecomment-632437689
Staged site:
http://apache-beam-website-pull-requests.storage.googleapis.com/11780/community/mascot/index.html
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632335832
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
TheNeuralBit commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632335607
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632335448
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
aaltay commented on pull request #10165:
URL: https://github.com/apache/beam/pull/10165#issuecomment-632398599
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb closed pull request #11608:
URL: https://github.com/apache/beam/pull/11608
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
robertwb commented on pull request #11632:
URL: https://github.com/apache/beam/pull/11632#issuecomment-632398759
Ping.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
iemejia commented on pull request #11715:
URL: https://github.com/apache/beam/pull/11715#issuecomment-632402839
Now that this is merged. Can I ask a question. What is the intrinsic
limitation that did not allow old `OffsetRangeTracker` to be refactored for
this use case? or why we want to
udim commented on a change in pull request #11070:
URL: https://github.com/apache/beam/pull/11070#discussion_r428993726
##
File path: website/src/_posts/2020-03-06-python-typing.md
##
@@ -0,0 +1,117 @@
+---
+layout: post
+title: "Python SDK Typing Changes"
+date: 2020-03-06
iemejia commented on pull request #11715:
URL: https://github.com/apache/beam/pull/11715#issuecomment-632434300
Thanks for answering and for the clear explaination @boyuanzz
I would have tended towards having the additional complexity in
`OffsetRangeTracker` just because it is the
lukecwik commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632342320
Test coverage is by existing IOs that enable these features which we don't
have enough of in Beam (since it requires portable runners to implement SDF to
a greater extent then
tvalentyn commented on pull request #11783:
URL: https://github.com/apache/beam/pull/11783#issuecomment-632371565
LGTM if tests pass.
This is an automated message from the Apache Git Service.
To respond to the message,
ibzib commented on pull request #11784:
URL: https://github.com/apache/beam/pull/11784#issuecomment-632403660
Run Java Spark PortableValidatesRunner Batch
This is an automated message from the Apache Git Service.
To respond
robertwb opened a new pull request #11787:
URL: https://github.com/apache/beam/pull/11787
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
kennknowles opened a new pull request #11792:
URL: https://github.com/apache/beam/pull/11792
WIP! Do not merge. (it is harmless but not successful)
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
kennknowles commented on a change in pull request #11792:
URL: https://github.com/apache/beam/pull/11792#discussion_r429031469
##
File path: runners/portability/java/build.gradle
##
@@ -31,9 +45,123 @@ dependencies {
compile project(path: ":sdks:java:harness",
kennknowles commented on a change in pull request #11792:
URL: https://github.com/apache/beam/pull/11792#discussion_r429031586
##
File path: runners/portability/java/build.gradle
##
@@ -31,9 +45,123 @@ dependencies {
compile project(path: ":sdks:java:harness",
youngoli commented on a change in pull request #11763:
URL: https://github.com/apache/beam/pull/11763#discussion_r429026079
##
File path: sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange_test.go
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF)
kennknowles commented on a change in pull request #11792:
URL: https://github.com/apache/beam/pull/11792#discussion_r429031354
##
File path: runners/portability/java/build.gradle
##
@@ -31,9 +45,123 @@ dependencies {
compile project(path: ":sdks:java:harness",
kennknowles commented on a change in pull request #11792:
URL: https://github.com/apache/beam/pull/11792#discussion_r429029786
##
File path: runners/portability/java/build.gradle
##
@@ -1,3 +1,13 @@
+import groovy.json.JsonOutput
+
+import java.nio.file.FileSystems
Review
youngoli commented on a change in pull request #11763:
URL: https://github.com/apache/beam/pull/11763#discussion_r429025895
##
File path: sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange_test.go
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF)
youngoli merged pull request #11763:
URL: https://github.com/apache/beam/pull/11763
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
y1chi commented on a change in pull request #11756:
URL: https://github.com/apache/beam/pull/11756#discussion_r428754395
##
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/FnApiDoFnRunnerTest.java
##
@@ -947,49 +910,213 @@ public void testTimers() throws
mxm opened a new pull request #11777:
URL: https://github.com/apache/beam/pull/11777
We have a test pipeline which runs with the DirectRunner. When upgrading
from 2.18.0 to 2.21.0 the test failed with the following exception:
```
tp = Exception('Monitor task detected a pipeline
ibzib merged pull request #11764:
URL: https://github.com/apache/beam/pull/11764
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632182849
retest all please
This is an automated message from the Apache Git Service.
To respond to the message, please
chamikaramj commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632219614
WDYT about https://github.com/ihji/beam/pull/1 ?
(only change is to Environments.java other changes should go away if you
rebase)
TheNeuralBit commented on pull request #11521:
URL: https://github.com/apache/beam/pull/11521#issuecomment-632237798
@robertwb I think this broke Java PVR Spark Batch. First failure is here:
https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/2887/ Not
sure if there is a
veblush opened a new pull request #11778:
URL: https://github.com/apache/beam/pull/11778
Backport of #11651
CC: @theneuralbit
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
TheNeuralBit commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632304060
Is there any test coverage of this?
This is an automated message from the Apache Git Service.
To respond to
apilloud commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-632330703
Interesting question. You should probably add a test for JOIN as well, which
will have a similar class of problems.
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632179933
Run Go PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632186469
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632186575
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
ibzib commented on a change in pull request #11764:
URL: https://github.com/apache/beam/pull/11764#discussion_r428774392
##
File path: website/www/site/content/en/contribute/release-guide.md
##
@@ -583,189 +582,44 @@ For this step, we recommend you using automation script
to
ihji commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632251342
> WDYT about [ihji#1](https://github.com/ihji/beam/pull/1) ?
> (only change is to Environments.java other changes should go away if you
rebase)
It will add 36 characters +
pabloem commented on pull request #11086:
URL: https://github.com/apache/beam/pull/11086#issuecomment-632277003
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
rohdesamuel commented on pull request #11745:
URL: https://github.com/apache/beam/pull/11745#issuecomment-632301124
R: @pabloem thanks Pablo!
This is an automated message from the Apache Git Service.
To respond to the
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632185565
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632185540
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
robertwb merged pull request #11503:
URL: https://github.com/apache/beam/pull/11503
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chamikaramj merged pull request #11757:
URL: https://github.com/apache/beam/pull/11757
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632260642
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
apilloud commented on a change in pull request #11682:
URL: https://github.com/apache/beam/pull/11682#discussion_r428778641
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java
##
@@ -85,7 +141,14 @@
* @throws IllegalArgumentException
mxm commented on a change in pull request #11777:
URL: https://github.com/apache/beam/pull/11777#discussion_r428778698
##
File path: sdks/python/apache_beam/transforms/trigger.py
##
@@ -1368,7 +1368,7 @@ def _output(
if timestamp is None:
# If no watermark hold was
apilloud commented on pull request #11682:
URL: https://github.com/apache/beam/pull/11682#issuecomment-632218345
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia commented on pull request #11610:
URL: https://github.com/apache/beam/pull/11610#issuecomment-632248973
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia commented on pull request #11610:
URL: https://github.com/apache/beam/pull/11610#issuecomment-632249476
run Java Precommit
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on pull request #8457:
URL: https://github.com/apache/beam/pull/8457#issuecomment-632270901
There are still failing tests on https://github.com/apache/beam/pull/11295.
@mf2199 - What is the next step for this PR?
1 - 100 of 156 matches
Mail list logo
