[GitHub] [beam] ibzib commented on a change in pull request #12637: [BEAM-10768] Don't assert the order in which elements are received.

2020-09-18 Thread GitBox
ibzib commented on a change in pull request #12637: URL: https://github.com/apache/beam/pull/12637#discussion_r491203318 ## File path: sdks/python/apache_beam/runners/worker/data_plane_test.py ## @@ -99,35 +100,33 @@ def send(instruction_id, transform_id, data): #

[GitHub] [beam] chamikaramj commented on a change in pull request #12806: [BEAM-10869] Make WriteToPubsub output serialized PubsubMessage proto bytes when using runner v2

2020-09-18 Thread GitBox
chamikaramj commented on a change in pull request #12806: URL: https://github.com/apache/beam/pull/12806#discussion_r491215092 ## File path: sdks/python/apache_beam/io/gcp/pubsub.py ## @@ -290,21 +290,26 @@ def __init__(self, topic, id_label, with_attributes,

[GitHub] [beam] robertwb commented on pull request #12872: [BEAM-7372] Remove Python 2 testing.

2020-09-18 Thread GitBox
robertwb commented on pull request #12872: URL: https://github.com/apache/beam/pull/12872#issuecomment-695107753 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] shollyman commented on pull request #12874: [BEAM-10930] Use dense JSON responses for BigQueryIO interactions

2020-09-18 Thread GitBox
shollyman commented on pull request #12874: URL: https://github.com/apache/beam/pull/12874#issuecomment-695108645 Looks like I missed some mock tests against the discovery client. Need to address. This is an automated

[GitHub] [beam] ibzib opened a new pull request #12876: [BEAM-10931] Remove obsolete ZetaSQL precommit Gradle task.

2020-09-18 Thread GitBox
ibzib opened a new pull request #12876: URL: https://github.com/apache/beam/pull/12876 The ZetaSQL precommit Jenkins job was previously removed. R: @amaliujia Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] aaltay commented on a change in pull request #12875: Clarify Beam's use of semantic versioning

2020-09-18 Thread GitBox
aaltay commented on a change in pull request #12875: URL: https://github.com/apache/beam/pull/12875#discussion_r491228378 ## File path: website/www/site/content/en/contribute/dependencies.md ## @@ -89,4 +89,4 @@ __Dependencies of Java SDK components that may cause issues to

[GitHub] [beam] shollyman commented on pull request #12874: [BEAM-10930] Use dense JSON responses for BigQueryIO interactions

2020-09-18 Thread GitBox
shollyman commented on pull request #12874: URL: https://github.com/apache/beam/pull/12874#issuecomment-695136864 Most recent failures appear unrelated to this change, but I'm not familiar enough with the project to say that definitively.

[GitHub] [beam] chadrik commented on pull request #12878: Convert type comments into full Python2 annotations.

2020-09-18 Thread GitBox
chadrik commented on pull request #12878: URL: https://github.com/apache/beam/pull/12878#issuecomment-695149768 I've been super busy on other stuff lately, so I haven't had much time to spend on Beam, but I wanted to point out one thing: if we do this all the unmerged typing PRs that I

[GitHub] [beam] emilymye commented on pull request #12505: [BEAM-8106] Add version to java container image name

2020-09-18 Thread GitBox
emilymye commented on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-694990632 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] robertwb commented on pull request #12869: Allow pandas 1.x.

2020-09-18 Thread GitBox
robertwb commented on pull request #12869: URL: https://github.com/apache/beam/pull/12869#issuecomment-695001896 Yes, I would rather have Pandas 1.x compatibility and best effort for <1.x than the other way around. This is

[GitHub] [beam] amaliujia opened a new pull request #12398: [DO NOT MERGE][Prototype] add java UDF

2020-09-18 Thread GitBox
amaliujia opened a new pull request #12398: URL: https://github.com/apache/beam/pull/12398 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] TheNeuralBit commented on pull request #12869: Allow pandas 1.x.

2020-09-18 Thread GitBox
TheNeuralBit commented on pull request #12869: URL: https://github.com/apache/beam/pull/12869#issuecomment-695012334 SG. Looks like we'll need to add some new exclusions to the doctests, if you just add them to `skipped` I can deal with the conflict in

[GitHub] [beam] TheNeuralBit opened a new pull request #12871: Fix broken link for ParDo docs

2020-09-18 Thread GitBox
TheNeuralBit opened a new pull request #12871: URL: https://github.com/apache/beam/pull/12871 Fixes the PyDoc link on https://beam.apache.org/documentation/transforms/python/elementwise/pardo/ R: @pabloem Post-Commit Tests Status (on master branch)

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] robertwb commented on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-18 Thread GitBox
robertwb commented on pull request #12841: URL: https://github.com/apache/beam/pull/12841#issuecomment-695036835 Thanks. I'll merge once I verify all tests are still passing after the merge. This is an automated message from

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] youngoli merged pull request #12745: Add a blog post for Apache Beam 2.24.0.

2020-09-18 Thread GitBox
youngoli merged pull request #12745: URL: https://github.com/apache/beam/pull/12745 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] youngoli merged pull request #12743: Update Beam website to release 2.24.0.

2020-09-18 Thread GitBox
youngoli merged pull request #12743: URL: https://github.com/apache/beam/pull/12743 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12576: URL: https://github.com/apache/beam/pull/12576#issuecomment-692353567 # [Codecov](https://codecov.io/gh/apache/beam/pull/12576?src=pr=h1) Report > Merging [#12576](https://codecov.io/gh/apache/beam/pull/12576?src=pr=desc) into

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r491178572 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py ## @@ -473,10 +474,19 @@ def run_pipeline(self, pipeline, options):

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] chamikaramj commented on pull request #12853: [BEAM-3083] Sets sdk_harness_container_images property for all Dataflow Runner V2 jobs

2020-09-18 Thread GitBox
chamikaramj commented on pull request #12853: URL: https://github.com/apache/beam/pull/12853#issuecomment-695074191 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12872: Remove Python 2 testing.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12872: URL: https://github.com/apache/beam/pull/12872#issuecomment-695091231 # [Codecov](https://codecov.io/gh/apache/beam/pull/12872?src=pr=h1) Report > Merging [#12872](https://codecov.io/gh/apache/beam/pull/12872?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] shollyman commented on pull request #12874: [BEAM-10930] Use dense JSON responses for BigQueryIO interactions

2020-09-18 Thread GitBox
shollyman commented on pull request #12874: URL: https://github.com/apache/beam/pull/12874#issuecomment-695100944 Alright, I think I've successfully navigated the basics for getting this PR setup. Time to get a reviewer. R: lukecwik

[GitHub] [beam] codecov[bot] edited a comment on pull request #12853: [BEAM-3083] Sets sdk_harness_container_images property for all Dataflow Runner V2 jobs

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12853: URL: https://github.com/apache/beam/pull/12853#issuecomment-693256374 # [Codecov](https://codecov.io/gh/apache/beam/pull/12853?src=pr=h1) Report > Merging [#12853](https://codecov.io/gh/apache/beam/pull/12853?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12872: [BEAM-7372] Remove Python 2 testing.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12872: URL: https://github.com/apache/beam/pull/12872#issuecomment-695091231 # [Codecov](https://codecov.io/gh/apache/beam/pull/12872?src=pr=h1) Report > Merging [#12872](https://codecov.io/gh/apache/beam/pull/12872?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12869: Allow pandas 1.x.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12869: URL: https://github.com/apache/beam/pull/12869#issuecomment-695113133 # [Codecov](https://codecov.io/gh/apache/beam/pull/12869?src=pr=h1) Report > Merging [#12869](https://codecov.io/gh/apache/beam/pull/12869?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12869: Allow pandas 1.x.

2020-09-18 Thread GitBox
codecov[bot] commented on pull request #12869: URL: https://github.com/apache/beam/pull/12869#issuecomment-695113133 # [Codecov](https://codecov.io/gh/apache/beam/pull/12869?src=pr=h1) Report > Merging [#12869](https://codecov.io/gh/apache/beam/pull/12869?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12869: Allow pandas 1.x.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12869: URL: https://github.com/apache/beam/pull/12869#issuecomment-695113133 # [Codecov](https://codecov.io/gh/apache/beam/pull/12869?src=pr=h1) Report > Merging [#12869](https://codecov.io/gh/apache/beam/pull/12869?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12869: Allow pandas 1.x.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12869: URL: https://github.com/apache/beam/pull/12869#issuecomment-695113133 # [Codecov](https://codecov.io/gh/apache/beam/pull/12869?src=pr=h1) Report > Merging [#12869](https://codecov.io/gh/apache/beam/pull/12869?src=pr=desc) into

[GitHub] [beam] robertwb merged pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-18 Thread GitBox
robertwb merged pull request #12841: URL: https://github.com/apache/beam/pull/12841 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] robertwb commented on pull request #12869: Allow pandas 1.x.

2020-09-18 Thread GitBox
robertwb commented on pull request #12869: URL: https://github.com/apache/beam/pull/12869#issuecomment-695121649 Skipping the new tests. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12844: [BEAM-10894] Support for more pandas formats.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12844: URL: https://github.com/apache/beam/pull/12844#issuecomment-694568117 # [Codecov](https://codecov.io/gh/apache/beam/pull/12844?src=pr=h1) Report > Merging [#12844](https://codecov.io/gh/apache/beam/pull/12844?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12505: [BEAM-8106] Add version to java container image name

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-684502100 # [Codecov](https://codecov.io/gh/apache/beam/pull/12505?src=pr=h1) Report > Merging [#12505](https://codecov.io/gh/apache/beam/pull/12505?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12844: [BEAM-10894] Support for more pandas formats.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12844: URL: https://github.com/apache/beam/pull/12844#issuecomment-694568117 # [Codecov](https://codecov.io/gh/apache/beam/pull/12844?src=pr=h1) Report > Merging [#12844](https://codecov.io/gh/apache/beam/pull/12844?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12879: [BEAM-9136] Add CSV for python dependency license names, URLs and types

2020-09-18 Thread GitBox
codecov[bot] commented on pull request #12879: URL: https://github.com/apache/beam/pull/12879#issuecomment-695137542 # [Codecov](https://codecov.io/gh/apache/beam/pull/12879?src=pr=h1) Report > Merging [#12879](https://codecov.io/gh/apache/beam/pull/12879?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12637: [BEAM-10768] Don't assert the order in which elements are received.

2020-09-18 Thread GitBox
codecov[bot] commented on pull request #12637: URL: https://github.com/apache/beam/pull/12637#issuecomment-695098854 # [Codecov](https://codecov.io/gh/apache/beam/pull/12637?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request head (`BEAM-10768@97d548e`). [Click here

[GitHub] [beam] codecov[bot] edited a comment on pull request #12872: Remove Python 2 testing.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12872: URL: https://github.com/apache/beam/pull/12872#issuecomment-695091231 # [Codecov](https://codecov.io/gh/apache/beam/pull/12872?src=pr=h1) Report > Merging [#12872](https://codecov.io/gh/apache/beam/pull/12872?src=pr=desc) into

[GitHub] [beam] shollyman commented on pull request #12874: [BEAM-10930] Use dense JSON responses for BigQueryIO interactions

2020-09-18 Thread GitBox
shollyman commented on pull request #12874: URL: https://github.com/apache/beam/pull/12874#issuecomment-695102135 R: @lukecwik This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] lukecwik commented on a change in pull request #12806: [BEAM-10869] Make WriteToPubsub output serialized PubsubMessage proto bytes when using runner v2

2020-09-18 Thread GitBox
lukecwik commented on a change in pull request #12806: URL: https://github.com/apache/beam/pull/12806#discussion_r491206866 ## File path: sdks/python/apache_beam/io/gcp/pubsub.py ## @@ -290,21 +290,26 @@ def __init__(self, topic, id_label, with_attributes,

[GitHub] [beam] robertwb commented on pull request #12872: [BEAM-7372] Remove Python 2 testing.

2020-09-18 Thread GitBox
robertwb commented on pull request #12872: URL: https://github.com/apache/beam/pull/12872#issuecomment-695117157 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] codecov[bot] commented on pull request #12877: Upgrade GCS IO to 2.1.5 and Google OAuth to 1.31.0

2020-09-18 Thread GitBox
codecov[bot] commented on pull request #12877: URL: https://github.com/apache/beam/pull/12877#issuecomment-695130274 # [Codecov](https://codecov.io/gh/apache/beam/pull/12877?src=pr=h1) Report > Merging [#12877](https://codecov.io/gh/apache/beam/pull/12877?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12877: Upgrade GCS IO to 2.1.5 and Google OAuth to 1.31.0

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12877: URL: https://github.com/apache/beam/pull/12877#issuecomment-695130274 # [Codecov](https://codecov.io/gh/apache/beam/pull/12877?src=pr=h1) Report > Merging [#12877](https://codecov.io/gh/apache/beam/pull/12877?src=pr=desc) into

[GitHub] [beam] alanmyrvold opened a new pull request #12879: [BEAM-9136] Add CSV for python dependency license names, URLs and types

2020-09-18 Thread GitBox
alanmyrvold opened a new pull request #12879: URL: https://github.com/apache/beam/pull/12879 To help check the python dependency licenses, add python-licenses.csv to /opt/apache/beam/third_party_licenses/ that lists the name, url, and license type for the licenses found by pip-licenses in

[GitHub] [beam] codecov[bot] edited a comment on pull request #12844: [BEAM-10894] Support for more pandas formats.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12844: URL: https://github.com/apache/beam/pull/12844#issuecomment-694568117 # [Codecov](https://codecov.io/gh/apache/beam/pull/12844?src=pr=h1) Report > Merging [#12844](https://codecov.io/gh/apache/beam/pull/12844?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12877: Upgrade GCS IO to 2.1.5 and Google OAuth to 1.31.0

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12877: URL: https://github.com/apache/beam/pull/12877#issuecomment-695130274 # [Codecov](https://codecov.io/gh/apache/beam/pull/12877?src=pr=h1) Report > Merging [#12877](https://codecov.io/gh/apache/beam/pull/12877?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12877: Upgrade GCS IO to 2.1.5 and Google OAuth to 1.31.0

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12877: URL: https://github.com/apache/beam/pull/12877#issuecomment-695130274 # [Codecov](https://codecov.io/gh/apache/beam/pull/12877?src=pr=h1) Report > Merging [#12877](https://codecov.io/gh/apache/beam/pull/12877?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12505: [BEAM-8106] Add version to java container image name

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-684502100 # [Codecov](https://codecov.io/gh/apache/beam/pull/12505?src=pr=h1) Report > Merging [#12505](https://codecov.io/gh/apache/beam/pull/12505?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12879: [BEAM-9136] Add CSV for python dependency license names, URLs and types

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12879: URL: https://github.com/apache/beam/pull/12879#issuecomment-695137542 # [Codecov](https://codecov.io/gh/apache/beam/pull/12879?src=pr=h1) Report > Merging [#12879](https://codecov.io/gh/apache/beam/pull/12879?src=pr=desc) into

[GitHub] [beam] TheNeuralBit merged pull request #12869: Allow pandas 1.x.

2020-09-18 Thread GitBox
TheNeuralBit merged pull request #12869: URL: https://github.com/apache/beam/pull/12869 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] TheNeuralBit commented on pull request #12869: Allow pandas 1.x.

2020-09-18 Thread GitBox
TheNeuralBit commented on pull request #12869: URL: https://github.com/apache/beam/pull/12869#issuecomment-695144785 Wow it's so green! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] lukecwik commented on a change in pull request #12836: [BEAM-10887] Expose clear() to FnApiTimer.

2020-09-18 Thread GitBox
lukecwik commented on a change in pull request #12836: URL: https://github.com/apache/beam/pull/12836#discussion_r491185424 ## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/WatermarkManager.java ## @@ -1613,7 +1613,15 @@ public TimerUpdateBuilder

[GitHub] [beam] codecov[bot] edited a comment on pull request #12872: [BEAM-7372] Remove Python 2 testing.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12872: URL: https://github.com/apache/beam/pull/12872#issuecomment-695091231 # [Codecov](https://codecov.io/gh/apache/beam/pull/12872?src=pr=h1) Report > Merging [#12872](https://codecov.io/gh/apache/beam/pull/12872?src=pr=desc) into

[GitHub] [beam] aaltay opened a new pull request #12875: Clarify Beam's use of semantic versioning

2020-09-18 Thread GitBox
aaltay opened a new pull request #12875: URL: https://github.com/apache/beam/pull/12875 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] codecov[bot] edited a comment on pull request #12872: [BEAM-7372] Remove Python 2 testing.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12872: URL: https://github.com/apache/beam/pull/12872#issuecomment-695091231 # [Codecov](https://codecov.io/gh/apache/beam/pull/12872?src=pr=h1) Report > Merging [#12872](https://codecov.io/gh/apache/beam/pull/12872?src=pr=desc) into

[GitHub] [beam] kennknowles opened a new pull request #12877: Upgrade GCS IO to 2.1.5 and Google OAuth to 1.31.0

2020-09-18 Thread GitBox
kennknowles opened a new pull request #12877: URL: https://github.com/apache/beam/pull/12877 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] kennknowles commented on pull request #12877: Upgrade GCS IO to 2.1.5 and Google OAuth to 1.31.0

2020-09-18 Thread GitBox
kennknowles commented on pull request #12877: URL: https://github.com/apache/beam/pull/12877#issuecomment-695124009 Still running linkage checker, will paste results here. This is an automated message from the Apache Git

[GitHub] [beam] kennknowles commented on pull request #12877: Upgrade GCS IO to 2.1.5 and Google OAuth to 1.31.0

2020-09-18 Thread GitBox
kennknowles commented on pull request #12877: URL: https://github.com/apache/beam/pull/12877#issuecomment-695124063 run java postcommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] robertwb merged pull request #12872: [BEAM-7372] Remove Python 2 testing.

2020-09-18 Thread GitBox
robertwb merged pull request #12872: URL: https://github.com/apache/beam/pull/12872 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] robertwb opened a new pull request #12878: Convert type comments into full Python2 annotations.

2020-09-18 Thread GitBox
robertwb opened a new pull request #12878: URL: https://github.com/apache/beam/pull/12878 A simple pass of com2ann and yapf. The only manual change was removing a stray comma. Thank you for your contribution! Follow this checklist to help us

[GitHub] [beam] codecov[bot] commented on pull request #12876: [BEAM-10931] Remove obsolete ZetaSQL precommit Gradle task.

2020-09-18 Thread GitBox
codecov[bot] commented on pull request #12876: URL: https://github.com/apache/beam/pull/12876#issuecomment-695127840 # [Codecov](https://codecov.io/gh/apache/beam/pull/12876?src=pr=h1) Report > Merging [#12876](https://codecov.io/gh/apache/beam/pull/12876?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12876: [BEAM-10931] Remove obsolete ZetaSQL precommit Gradle task.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12876: URL: https://github.com/apache/beam/pull/12876#issuecomment-695127840 # [Codecov](https://codecov.io/gh/apache/beam/pull/12876?src=pr=h1) Report > Merging [#12876](https://codecov.io/gh/apache/beam/pull/12876?src=pr=desc) into

[GitHub] [beam] robertwb commented on pull request #12878: Convert type comments into full Python2 annotations.

2020-09-18 Thread GitBox
robertwb commented on pull request #12878: URL: https://github.com/apache/beam/pull/12878#issuecomment-695127579 R: @tvalentyn CC: @udim @chadrik This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12876: [BEAM-10931] Remove obsolete ZetaSQL precommit Gradle task.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12876: URL: https://github.com/apache/beam/pull/12876#issuecomment-695127840 # [Codecov](https://codecov.io/gh/apache/beam/pull/12876?src=pr=h1) Report > Merging [#12876](https://codecov.io/gh/apache/beam/pull/12876?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12869: Allow pandas 1.x.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12869: URL: https://github.com/apache/beam/pull/12869#issuecomment-695113133 # [Codecov](https://codecov.io/gh/apache/beam/pull/12869?src=pr=h1) Report > Merging [#12869](https://codecov.io/gh/apache/beam/pull/12869?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12844: [BEAM-10894] Support for more pandas formats.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12844: URL: https://github.com/apache/beam/pull/12844#issuecomment-694568117 # [Codecov](https://codecov.io/gh/apache/beam/pull/12844?src=pr=h1) Report > Merging [#12844](https://codecov.io/gh/apache/beam/pull/12844?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12877: Upgrade GCS IO to 2.1.5 and Google OAuth to 1.31.0

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12877: URL: https://github.com/apache/beam/pull/12877#issuecomment-695130274 # [Codecov](https://codecov.io/gh/apache/beam/pull/12877?src=pr=h1) Report > Merging [#12877](https://codecov.io/gh/apache/beam/pull/12877?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12505: [BEAM-8106] Add version to java container image name

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-684502100 # [Codecov](https://codecov.io/gh/apache/beam/pull/12505?src=pr=h1) Report > Merging [#12505](https://codecov.io/gh/apache/beam/pull/12505?src=pr=desc) into

[GitHub] [beam] TheNeuralBit merged pull request #12857: [BEAM-9547] Add not_implemented_ok

2020-09-18 Thread GitBox
TheNeuralBit merged pull request #12857: URL: https://github.com/apache/beam/pull/12857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12841: URL: https://github.com/apache/beam/pull/12841#issuecomment-692395796 # [Codecov](https://codecov.io/gh/apache/beam/pull/12841?src=pr=h1) Report > Merging [#12841](https://codecov.io/gh/apache/beam/pull/12841?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12841: URL: https://github.com/apache/beam/pull/12841#issuecomment-692395796 # [Codecov](https://codecov.io/gh/apache/beam/pull/12841?src=pr=h1) Report > Merging [#12841](https://codecov.io/gh/apache/beam/pull/12841?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] emilymye commented on pull request #12505: [BEAM-8106] Add version to java container image name

2020-09-18 Thread GitBox
emilymye commented on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-694989275 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] robertwb commented on a change in pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-18 Thread GitBox
robertwb commented on a change in pull request #12841: URL: https://github.com/apache/beam/pull/12841#discussion_r491132484 ## File path: sdks/python/apache_beam/dataframe/io.py ## @@ -0,0 +1,180 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] robertwb commented on pull request #12873: Remove experimental declarations from fileio.

2020-09-18 Thread GitBox
robertwb commented on pull request #12873: URL: https://github.com/apache/beam/pull/12873#issuecomment-695037884 R: @pabloem CC: @chamikaramj Let me know if you think some or all of this should remain experimental.

[GitHub] [beam] robertwb opened a new pull request #12873: Remove experimental declarations from fileio.

2020-09-18 Thread GitBox
robertwb opened a new pull request #12873: URL: https://github.com/apache/beam/pull/12873 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12853: [BEAM-3083] Sets sdk_harness_container_images property for all Dataflow Runner V2 jobs

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12853: URL: https://github.com/apache/beam/pull/12853#issuecomment-693256374 # [Codecov](https://codecov.io/gh/apache/beam/pull/12853?src=pr=h1) Report > Merging [#12853](https://codecov.io/gh/apache/beam/pull/12853?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12844: [BEAM-10894] Support for more pandas formats.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12844: URL: https://github.com/apache/beam/pull/12844#issuecomment-694568117 # [Codecov](https://codecov.io/gh/apache/beam/pull/12844?src=pr=h1) Report > Merging [#12844](https://codecov.io/gh/apache/beam/pull/12844?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12576: URL: https://github.com/apache/beam/pull/12576#issuecomment-692353567 # [Codecov](https://codecov.io/gh/apache/beam/pull/12576?src=pr=h1) Report > Merging [#12576](https://codecov.io/gh/apache/beam/pull/12576?src=pr=desc) into

[GitHub] [beam] lukecwik commented on a change in pull request #12806: [BEAM-10869] Make WriteToPubsub output serialized PubsubMessage proto bytes when using runner v2

2020-09-18 Thread GitBox
lukecwik commented on a change in pull request #12806: URL: https://github.com/apache/beam/pull/12806#discussion_r491178237 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubMessageUtils.java ## @@ -0,0 +1,58 @@ +/* + *

[GitHub] [beam] aaltay commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
aaltay commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r491168283 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py ## @@ -473,10 +474,19 @@ def run_pipeline(self, pipeline, options):

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] robertwb opened a new pull request #12872: Remove Python 2 testing.

2020-09-18 Thread GitBox
robertwb opened a new pull request #12872: URL: https://github.com/apache/beam/pull/12872 This doesn't clean up the code, just removes the test targets. Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] codecov[bot] edited a comment on pull request #12841: [BEAM-10894] Basic CSV reading and writing.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12841: URL: https://github.com/apache/beam/pull/12841#issuecomment-692395796 # [Codecov](https://codecov.io/gh/apache/beam/pull/12841?src=pr=h1) Report > Merging [#12841](https://codecov.io/gh/apache/beam/pull/12841?src=pr=desc) into

[GitHub] [beam] robertwb commented on pull request #12872: Remove Python 2 testing.

2020-09-18 Thread GitBox
robertwb commented on pull request #12872: URL: https://github.com/apache/beam/pull/12872#issuecomment-695081028 (Note, I kept the name of Run Python2_PVR_Flink PreCommit for now.) This is an automated message from the

[GitHub] [beam] robertwb commented on pull request #12872: Remove Python 2 testing.

2020-09-18 Thread GitBox
robertwb commented on pull request #12872: URL: https://github.com/apache/beam/pull/12872#issuecomment-695080772 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] rworley-monster commented on pull request #12389: [BEAM-10587] Support Maps in BigQuery

2020-09-18 Thread GitBox
rworley-monster commented on pull request #12389: URL: https://github.com/apache/beam/pull/12389#issuecomment-695080557 I have added tests for the conversion of Beam schema maps to BigQuery and back. Can you please let me know if there is anything else that I can do to help prepare this

[GitHub] [beam] codecov[bot] commented on pull request #12872: Remove Python 2 testing.

2020-09-18 Thread GitBox
codecov[bot] commented on pull request #12872: URL: https://github.com/apache/beam/pull/12872#issuecomment-695091231 # [Codecov](https://codecov.io/gh/apache/beam/pull/12872?src=pr=h1) Report > Merging [#12872](https://codecov.io/gh/apache/beam/pull/12872?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12872: Remove Python 2 testing.

2020-09-18 Thread GitBox
codecov[bot] edited a comment on pull request #12872: URL: https://github.com/apache/beam/pull/12872#issuecomment-695091231 # [Codecov](https://codecov.io/gh/apache/beam/pull/12872?src=pr=h1) Report > Merging [#12872](https://codecov.io/gh/apache/beam/pull/12872?src=pr=desc) into

[GitHub] [beam] TheNeuralBit commented on pull request #12869: Allow pandas 1.x.

2020-09-18 Thread GitBox
TheNeuralBit commented on pull request #12869: URL: https://github.com/apache/beam/pull/12869#issuecomment-694986399 If we do this won't our unit tests for py3 run only with 1.x? This is an automated message from the Apache

  1   2   >