Re: [PR] Adding support for high priority queries to xlang transforms writing … [beam]

2024-04-10 Thread via GitHub
pabloem merged PR #30869: URL: https://github.com/apache/beam/pull/30869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Adding support for high priority queries to xlang transforms writing … [beam]

2024-04-10 Thread via GitHub
shunping commented on PR #30869: URL: https://github.com/apache/beam/pull/30869#issuecomment-2048617606 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Adding support for high priority queries to xlang transforms writing … [beam]

2024-04-08 Thread via GitHub
pabloem commented on PR #30869: URL: https://github.com/apache/beam/pull/30869#issuecomment-2043691501 is this good to go? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Adding support for high priority queries to xlang transforms writing … [beam]

2024-04-05 Thread via GitHub
codecov-commenter commented on PR #30869: URL: https://github.com/apache/beam/pull/30869#issuecomment-2040417337 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30869?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Adding support for high priority queries to xlang transforms writing … [beam]

2024-04-05 Thread via GitHub
pabloem commented on PR #30869: URL: https://github.com/apache/beam/pull/30869#issuecomment-2040321256 done thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Adding support for high priority queries to xlang transforms writing … [beam]

2024-04-05 Thread via GitHub
damondouglas commented on code in PR #30869: URL: https://github.com/apache/beam/pull/30869#discussion_r1554014922 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerTransformRegistrar.java: ## @@ -341,6 +346,9 @@ public PTransform,

Re: [PR] Adding support for high priority queries to xlang transforms writing … [beam]

2024-04-05 Thread via GitHub
github-actions[bot] commented on PR #30869: URL: https://github.com/apache/beam/pull/30869#issuecomment-2040229995 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @shunping for label python. R: @damondouglas for label java.

Re: [PR] Adding support for high priority queries to xlang transforms writing … [beam]

2024-04-05 Thread via GitHub
johnjcasey commented on code in PR #30869: URL: https://github.com/apache/beam/pull/30869#discussion_r1553965228 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerTransformRegistrar.java: ## @@ -341,6 +346,9 @@ public PTransform,

Re: [PR] Adding support for high priority queries to xlang transforms writing … [beam]

2024-04-05 Thread via GitHub
pabloem commented on PR #30869: URL: https://github.com/apache/beam/pull/30869#issuecomment-2040142904 is it still @johnjcasey ? : D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Adding support for high priority queries to xlang transforms writing … [beam]

2024-04-05 Thread via GitHub
pabloem commented on PR #30869: URL: https://github.com/apache/beam/pull/30869#issuecomment-2040137087 this is needed because spanner autoscaling depends on high priority queries - so a spanner database can easily be overloaded by a beam pipeline and still not scale up -- This is an

[PR] Adding support for high priority queries to xlang transforms writing … [beam]

2024-04-05 Thread via GitHub
pabloem opened a new pull request, #30869: URL: https://github.com/apache/beam/pull/30869 …to spanner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To