Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-30 Thread via GitHub
Abacn merged PR #30824: URL: https://github.com/apache/beam/pull/30824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-30 Thread via GitHub
prodriguezdefino commented on code in PR #30824: URL: https://github.com/apache/beam/pull/30824#discussion_r1585325343 ## sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java: ## @@ -832,15 +857,17 @@ public Read withMetadata() {

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-30 Thread via GitHub
Abacn commented on code in PR #30824: URL: https://github.com/apache/beam/pull/30824#discussion_r1585079959 ## sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java: ## @@ -832,15 +857,17 @@ public Read withMetadata() { /**

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-25 Thread via GitHub
prodriguezdefino commented on code in PR #30824: URL: https://github.com/apache/beam/pull/30824#discussion_r1580452732 ## sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java: ## @@ -834,13 +859,27 @@ public Read withMetadata() {

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-18 Thread via GitHub
Abacn commented on code in PR #30824: URL: https://github.com/apache/beam/pull/30824#discussion_r1571119296 ## sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java: ## @@ -834,13 +859,27 @@ public Read withMetadata() { *

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-17 Thread via GitHub
Abacn commented on PR #30824: URL: https://github.com/apache/beam/pull/30824#issuecomment-2061283049 sorry for delay, taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #30824: URL: https://github.com/apache/beam/pull/30824#issuecomment-2061119274 Reminder, please take a look at this pr: @Abacn @johnjcasey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #30824: URL: https://github.com/apache/beam/pull/30824#issuecomment-2046632425 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label java. R: @johnjcasey for label io.

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-09 Thread via GitHub
prodriguezdefino commented on PR #30824: URL: https://github.com/apache/beam/pull/30824#issuecomment-2044220747 Run Java_ElasticSearch_IO_Direct PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-09 Thread via GitHub
prodriguezdefino commented on PR #30824: URL: https://github.com/apache/beam/pull/30824#issuecomment-2044211304 Run Java_ElasticSearch_IO_Direct PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Elasticsearch enable Point In Time based searches [beam]

2024-04-02 Thread via GitHub
prodriguezdefino commented on PR #30824: URL: https://github.com/apache/beam/pull/30824#issuecomment-2033191290 Run Java_ElasticSearch_IO_Direct PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above