Re: [gitorious] HTTPS support for web hooks

2013-05-21 Thread Christian Johansen
Sorry for the late response, this email drowned in my inbox... > Thanks for the offer! I looked at FakeWeb and I see it doesn't > currently parse request bodies. Previously we "parsed" them by > stubbing post_form, so this would be a slight decrease in coverage: we > would only test that a POST ha

Re: [gitorious] HTTPS support for web hooks

2013-05-16 Thread Ken Dreyer
Hi Christian, On Wed, May 15, 2013 at 11:44 PM, Christian Johansen wrote: > Well, the old test simply stubs the method being used. In your updated > example that's not going to turn out pretty. I suggest giving FakeWeb a > look: https://github.com/chrisk/fakeweb > > Let me know if you need some h

Re: [gitorious] HTTPS support for web hooks

2013-05-15 Thread Christian Johansen
> I've added preliminary support for HTTPS web hooks: > > https://gitorious.org/~ktdreyer/gitorious/ktdreyers-mainline/commits/https-webhooks Cool! > I'm a newbie to Ruby testing so please be kind :-) ... I'm not sure > how to update the unit tests to match this change. See my "FIXME" > lines in

[gitorious] HTTPS support for web hooks

2013-05-15 Thread Ken Dreyer
Hi folks, I've added preliminary support for HTTPS web hooks: https://gitorious.org/~ktdreyer/gitorious/ktdreyers-mainline/commits/https-webhooks I'm a newbie to Ruby testing so please be kind :-) ... I'm not sure how to update the unit tests to match this change. See my "FIXME" lines in test/un