Re: [Gluster-devel] Review-request: Readdirp (ls -l) Performance Improvement

Result for a single ls on a dir with 10k directories inside (16*3 volume) * * * Configuration Plain volume Parallel-readdir Proposed Solution Single Dir ls (Seconds) - 135 32.744 * ** It is showing 321% improvements. Reg

[Gluster-devel] Review-request: Readdirp (ls -l) Performance Improvement

Hi All, I have been working on POC to improve readdirp performance improvement. At the end of the experiment, The results are showing promising result in performance, overall there is a 104% improvement for full filesystem crawl compared to the existing solution. Here is the short test numbers

[Gluster-devel] Review request

Hi, I would be happy if i can get more review for https://review.gluster.org/#/c/17137/28 -- Regards, Hari Gowtham. ___ Gluster-devel mailing list Gluster-devel@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] Review request for several Gluster/NFS changes

Hello, I'd like to have some reviews for the following changes: nfs: make nfs3_call_state_t refcounted - https://review.gluster.org/17696 nfs/nlm: unref fds in nlm_client_free() - https://review.gluster.org/17697 nfs/nlm: handle reconnect for non-NLM4_LOCK requests - https://review.gluster.org/

[Gluster-devel] Review request - #17105

program/GF-DUMP: Shield ping processing from traffic to Glusterfs Program Since poller thread bears the brunt of execution till the request is handed over to io-threads, poller thread experiencies lock contention(s) in the control flow till io-threads, which slows it down. This delay invariably af

Re: [Gluster-devel] Review request - patch #15036

Have just 1 comment. Once you answer it, its good to go. On Fri, May 12, 2017 at 9:48 AM, Raghavendra G wrote: > I'll wait for a day on this. If there are no reviews, I'll assume that as > a +1 and will go ahead and merge it. If anyone needs more time, please let > me know and I can wait. > > On

Re: [Gluster-devel] Review request - patch #15036

I'll wait for a day on this. If there are no reviews, I'll assume that as a +1 and will go ahead and merge it. If anyone needs more time, please let me know and I can wait. On Thu, May 11, 2017 at 12:22 PM, Raghavendra Gowdappa wrote: > All, > > Reviews are requested on [1]. Impact is non-trivia

[Gluster-devel] Review request - patch #15036

All, Reviews are requested on [1]. Impact is non-trivial as it introduces more concurrency in execution wrt processing of messages read from network. All tests are passed, though gerrit is not reflecting the last smoke which was successful. For reference, below is the verbatim copy of commit m

[Gluster-devel] Review request for 3.9 patches

Hi, Below are some of the backported patches that are important for 3.9, please review the same: http://review.gluster.org/#/c/15890/ (afr,dht,ec: Replace GF_EVENT_CHILD_MODIFIED with event SOME_DESCENDENT_DOWN/UP) http://review.gluster.org/#/c/15933/ , http://review.gluster.org/#/c/15935/

Re: [Gluster-devel] Review request - change pid file location to /var/run/gluster

Patch has been reviewed with some comments. On Thu, Oct 27, 2016 at 11:56 AM, Atin Mukherjee wrote: > Saravana, > > Thank you for working on this. We'll be considering this patch for 3.10. > > On Thu, Oct 27, 2016 at 11:54 AM, Saravanakumar Arumugam < > sarum...@redhat.com> wrote: > >> Hi, >> >>

[Gluster-devel] Review request: Data corruption in write ordering of rebalance and application writes

Hi all, Requesting for review of [1]. Bug: Lack of atomicity b/w read-src and write-dst of rebalance process [2] Description & proposed solution: Currently rebalance process does, 1. read (src) 2. write (dst) To make sure that src and dst are identical, we need to make 1 and 2 atomic. Otherwise

Re: [Gluster-devel] Review request - change pid file location to /var/run/gluster

Saravana, Thank you for working on this. We'll be considering this patch for 3.10. On Thu, Oct 27, 2016 at 11:54 AM, Saravanakumar Arumugam < sarum...@redhat.com> wrote: > Hi, > > I have refreshed this patch addressing review comments (originally > authored by Gaurav) which moves brick pid files

[Gluster-devel] Review request - change pid file location to /var/run/gluster

Hi, I have refreshed this patch addressing review comments (originally authored by Gaurav) which moves brick pid files from /var/lib/glusterd/* to /var/run/gluster. It will be great if you can review this: http://review.gluster.org/#/c/13580/ Thank you Regards, Saravana ___

Re: [Gluster-devel] review request - Change the way client uuid is built

On 09/23/2016 11:48 AM, Poornima Gurusiddaiah wrote: - Original Message - From: "Niels de Vos" To: "Raghavendra Gowdappa" Cc: "Gluster Devel" Sent: Wednesday, September 21, 2016 3:52:39 AM Subject: Re: [Gluster-devel] review request - Change the way

Re: [Gluster-devel] review request - Change the way client uuid is built

- Original Message - > From: "Niels de Vos" > To: "Raghavendra Gowdappa" > Cc: "Gluster Devel" > Sent: Wednesday, September 21, 2016 3:52:39 AM > Subject: Re: [Gluster-devel] review request - Change the way client uuid is > bui

Re: [Gluster-devel] review request - Change the way client uuid is built

+Poornima - Original Message - > From: "Niels de Vos" > To: "Raghavendra Gowdappa" > Cc: "Gluster Devel" > Sent: Wednesday, September 21, 2016 1:22:39 PM > Subject: Re: [Gluster-devel] review request - Change the way client uuid is > bui

Re: [Gluster-devel] review request - Change the way client uuid is built

On Wed, Sep 21, 2016 at 01:47:34AM -0400, Raghavendra Gowdappa wrote: > Hi all, > > [1] might have implications across different components in the stack. Your > reviews are requested. > > > > rpc : Change the way client uuid is built > > Problem: > Today the main users of client uuid are prot

[Gluster-devel] review request - Change the way client uuid is built

Hi all, [1] might have implications across different components in the stack. Your reviews are requested. rpc : Change the way client uuid is built Problem: Today the main users of client uuid are protocol layers, locks, leases. Protocolo layers requires each client uuid to be unique, even ac

Re: [Gluster-devel] Review request for 3.9 patches

From: "Poornima Gurusiddaiah" To: "Gluster Devel" , "Raghavendra Gowdappa" , "Rajesh Joseph" , "Raghavendra Talur" , "Soumya Koduri" , "Niels de Vos" , "Anoop Chirayath Manjiyil Sajan" Sent: Tuesday, August 30, 2016 5:13

Re: [Gluster-devel] Review request for 3.9 patches

jesh Joseph" > > , "Raghavendra Talur" , "Soumya > > Koduri" , "Niels de Vos" > > , "Anoop Chirayath Manjiyil Sajan" > > Sent: Tuesday, August 30, 2016 5:13:36 AM > > Subject: Re: [Gluster-devel] Review request for 3.9 patches

Re: [Gluster-devel] Review request for 3.9 patches

mya > Koduri" , "Niels de Vos" > , "Anoop Chirayath Manjiyil Sajan" > Sent: Tuesday, August 30, 2016 5:13:36 AM > Subject: Re: [Gluster-devel] Review request for 3.9 patches > > Hi, > > Few more patches, have addressed the review comments, could you plea

Re: [Gluster-devel] Review request: tier as a service.

ster-devel" > , "Kaushal Madappa" > > Sent: Friday, September 16, 2016 1:37:09 PM > Subject: Re: [Gluster-devel] Review request: tier as a service. > > Hi Hari, > > I have done a very initial review for some of the files. I have just > reviewed the c

Re: [Gluster-devel] Review request: tier as a service.

Hi Hari, I have done a very initial review for some of the files. I have just reviewed the code flow without having much idea on the actual functionality. Please feel free to address it when you have time(since most of them are coverity, indentation and memory issues related). I will also review

Re: [Gluster-devel] Review request: tier as a service.

On Thu, Sep 15, 2016 at 02:50:09AM -0400, Hari Gowtham wrote: > Hi, > > I would be happy to get reviews for this patch > http://review.gluster.org/#/c/13365/ > > more details can be found here about the changes: > https://docs.google.com/document/d/1_iyjiwTLnBJlCiUgjAWnpnPD801h5LNxLhHmN7zmk1o/edi

[Gluster-devel] Review request: tier as a service.

Hi, I would be happy to get reviews for this patch http://review.gluster.org/#/c/13365/ more details can be found here about the changes: https://docs.google.com/document/d/1_iyjiwTLnBJlCiUgjAWnpnPD801h5LNxLhHmN7zmk1o/edit?usp=sharing -- Regards, Hari. __

Re: [Gluster-devel] Review request for lock migration patches

+Poornima, Talur - Original Message - > From: "Pranith Kumar Karampuri" > To: "Susant Palai" > Cc: "Raghavendra Gowdappa" , "gluster-devel" > > Sent: Wednesday, 14 September, 2016 8:13:25 PM > Subject: Re: [Gluster-devel] Re

Re: [Gluster-devel] Review request for lock migration patches

> - Original Message - > > From: "Susant Palai" > > To: "Raghavendra Gowdappa" , "Pranith Kumar > Karampuri" > > Cc: "gluster-devel" > > Sent: Wednesday, 7 September, 2016 9:54:04 AM > > Subject: Re: [Gluster-

Re: [Gluster-devel] Review request for lock migration patches

Cc: "gluster-devel" > Sent: Wednesday, 7 September, 2016 9:54:04 AM > Subject: Re: [Gluster-devel] Review request for lock migration patches > > Gentle reminder for reviews. > > Thanks, > Susant > > - Original Message - > > From: "Susant Pala

[Gluster-devel] Review request for EC - set/unset dirty flag for data/metadata update

Hi, Please review the following patch for EC- http://review.gluster.org/#/c/13733/ Ashish ___ Gluster-devel mailing list Gluster-devel@gluster.org http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] Review request for lock migration patches

Gentle reminder for reviews. Thanks, Susant - Original Message - > From: "Susant Palai" > To: "Raghavendra Gowdappa" , "Pranith Kumar Karampuri" > > Cc: "gluster-devel" > Sent: Tuesday, 30 August, 2016 3:19:13 PM > Subject:

[Gluster-devel] Review request for lock migration patches

Hi, There are few patches targeted for lock migration. Requesting for review. 1. http://review.gluster.org/#/c/13901/ 2. http://review.gluster.org/#/c/14286/ 3. http://review.gluster.org/#/c/14492/ 4. http://review.gluster.org/#/c/15076/ Thanks, Susant~

Re: [Gluster-devel] Review request for 3.9 patches

Hi, Few more patches, have addressed the review comments, could you please review these patches: http://review.gluster.org/15002 md-cache: Register the list of xattrs with cache-invalidation http://review.gluster.org/15300 dht, md-cache, upcall: Add invalidation of IATT when the layout cha

[Gluster-devel] Review request for 3.9 patches

Hi, There are few patches that are part of the effort of integrating md-cache with upcall. Hope to take these patches for 3.9, it would be great if you can review these patches: upcall patches: http://review.gluster.org/#/c/15313/ http://review.gluster.org/#/c/15301/ md-cache patches: h

Re: [Gluster-devel] Review request for md-cache enhancements

On Wed, Jul 27, 2016 at 06:20:48AM -0400, Poornima Gurusiddaiah wrote: > Hi, > > Here is a patch http://review.gluster.org/#/c/15002 that lets md-cache > inform upcall about the list of xattrs, that it is interested, in > receiving invalidations. Could you please take a look at this. There > are

[Gluster-devel] Review request for md-cache enhancements

Hi, Here is a patch http://review.gluster.org/#/c/15002 that lets md-cache inform upcall about the list of xattrs, that it is interested, in receiving invalidations. Could you please take a look at this. There are dependent patches on this, which i will work on based on the review comments.

Re: [Gluster-devel] Review request for md-cache(performance xlator) patch

I've some comments on the patch. Please go through them. Once they are acked by you, I can merge the patch. - Original Message - > From: "Poornima Gurusiddaiah" > To: "Raghavendra Gowdappa" , "Gluster Devel" > > Sent: Monday, July 18, 2016 9:45:57 AM > Subject: Review request for md-ca

[Gluster-devel] Review request for md-cache(performance xlator) patch

Hi Raghavendra, http://review.gluster.org/#/c/12951/ is a patch that enables cache-invalidation for md-cache. Have got ack from Niels and Zhou Zhengping. Can you please review and merge the patch, as you are the maintainer. There are other dependent patches on this, which i will be sending onc

[Gluster-devel] Review request for http://review.gluster.org/#/c/14815/

Hi, I have added implementation for the posix_do_futimes function, which is not complete in the current implementation. I did the implementation by looking into the current implementation of posix_do_utimes function. Please review the patch and correct me if I am wrong anywhere. Bug: https://bugz

[Gluster-devel] review request - quota information mismatch which glusterfs on zfs environment

Hi all, 'quota information mismatch' problem occurs in the zfs underlying file system environment. request the code commits reviews for solving this problem. * Red Hat Bugzilla - Bug 1341355 - quota information mismatch which glusterfs on zfs environment

[Gluster-devel] review request

Hi, Requesting reviews for http://review.gluster.org/#/c/14251 and http://review.gluster.org/#/c/14252. Thanks, Susant~ ___ Gluster-devel mailing list Gluster-devel@gluster.org http://www.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] Review request - Gluster Eventing Feature

Hi, I submitted patch for the new feature "Gluster Eventing", Please review the patch. Patch: http://review.gluster.org/14248 Design: http://review.gluster.org/13115 Blog: http://aravindavk.in/blog/10-mins-intro-to-gluster-eventing Demo:https://www.youtube.com/watch?v=urzong5sKqc Thank

Re: [Gluster-devel] Review request for leases patches

Hi Poornima, On 03/07/2016 11:24 AM, Poornima Gurusiddaiah wrote: Hi All, Here is the link to feature page: http://review.gluster.org/#/c/11980/ Patches can be found @: http://review.gluster.org/#/q/status:

[Gluster-devel] Review request for leases patches

Hi All, Here is the link to feature page: http://review.gluster.org/#/c/11980/ Patches can be found @: http://review.gluster.org/#/q/status:open+project:glusterfs+branch:master+topic:leases Regards, Poornima ___ Gluster-devel mailing list Gluste

[Gluster-devel] Review request for md-cache improvement patches

Hi, Here are the improvements proposed for md-cache: - Integrate it with upcall cache-invalidation so that we can increase the cache timeout to be more than 1 sec. - Enable md-cache to cache xattrs. The doc explaining the same in detail can be found at http://review.gluster.org/#/c/13408/

Re: [Gluster-devel] Review request

On 02/17/2016 04:15 PM, Niels de Vos wrote: > On Wed, Feb 17, 2016 at 02:38:44PM +0530, Atin Mukherjee wrote: >> I've few patches which need some review attention, will appreciate if >> some of you can have a look at it. >> Here you go! >> http://review.gluster.org/#/c/13258/ - glusterd: use stri

Re: [Gluster-devel] Review request

On Wed, Feb 17, 2016 at 02:38:44PM +0530, Atin Mukherjee wrote: > I've few patches which need some review attention, will appreciate if > some of you can have a look at it. > > http://review.gluster.org/#/c/13258/ > http://review.gluster.org/#/c/13222/ > http://review.gluster.org/#/c/13272/ > http

[Gluster-devel] Review request

I've few patches which need some review attention, will appreciate if some of you can have a look at it. http://review.gluster.org/#/c/13258/ http://review.gluster.org/#/c/13222/ http://review.gluster.org/#/c/13272/ http://review.gluster.org/#/c/13323/ http://review.gluster.org/#/c/13390/ Thanks,

Re: [Gluster-devel] Review request

On 01/04/2016 12:08 PM, Prasanna Kumar Kalever wrote: > Giving one more try in the new year :) > > http://review.gluster.org/#/c/12709/ > http://review.gluster.org/#/c/12963/ Managed to review this one :) > http://review.gluster.org/#/c/13002/ > > > Happy New year 2016! > > Thanks, > -Prasan

Re: [Gluster-devel] Review request

Giving one more try in the new year :) http://review.gluster.org/#/c/12709/ http://review.gluster.org/#/c/12963/ http://review.gluster.org/#/c/13002/ Happy New year 2016! Thanks, -Prasanna - Original Message - > On Wednesday, December 23, 2015 10:07:53 PM, Atin Mukherjee wrote: > > I

Re: [Gluster-devel] Review request

On Wednesday, December 23, 2015 10:07:53 PM, Atin Mukherjee wrote: > I'd try to take up few of them in coming few days which are related > glusterd. Appreciate your patience! Thanks for taking them Atin -Prasanna > > -Atin > Sent from one plus one > On Dec 21, 2015 6:34 PM, "Prasanna Kumar Kale

Re: [Gluster-devel] Review request

I'd try to take up few of them in coming few days which are related glusterd. Appreciate your patience! -Atin Sent from one plus one On Dec 21, 2015 6:34 PM, "Prasanna Kumar Kalever" wrote: > Hello Everyone, > > > It would be helpful if someone can review: > > http://review.gluster.org/#/c/12709

[Gluster-devel] Review request

Hello Everyone, It would be helpful if someone can review: http://review.gluster.org/#/c/12709/ http://review.gluster.org/#/c/12963/ http://review.gluster.org/#/c/13002/ Thanks, -Prasanna ​ ___ Gluster-devel mailing list Gluster-devel@gluster.org

Re: [Gluster-devel] [Review request] write-behind to retry failed syncs

For ease of access, I am posting the summary from commit-msg below: 1. When sync fails, the cached-write is still preserved unless there is a flush/fsync waiting on it. 2. When a sync fails and there is a flush/fsync waiting on the cached-write, the cache is thrown away and no further retrie

[Gluster-devel] [Review request] write-behind to retry failed syncs

Hi all, [1] adds retry logic to failed syncs (to backend). It would be helpful if you can comment on: 1. Interface 2. Design 3. Implementation [1] review.gluster.org/#/c/12594/7 regards, Raghavendra. ___ Gluster-devel mailing list Gluster-devel@glust

[Gluster-devel] Review request

I've couple of patches which need review attention - http://review.gluster.org/#/c/12171/ - http://review.gluster.org/#/c/12329/ Raghavendra T - http://review.gluster.org/#/c/12328/ has got a +2 from Jeff, could you merge it? Thanks, Atin ___ Gluster-d

Re: [Gluster-devel] Review request for Gluster IPv6 bugfix (Bug 1117886)

On 09/10/2015 06:30 AM, nithin dabilpuram wrote: > Hi , > > Can this code be reviewed ? It is related to transport inet6 > > http://review.gluster.org/#/c/11988/ I've reviewed it and logged some comments. ~Atin > > thanks > Nithin > > On Wed, Jun 17, 2015 at 9:06 AM, Nithin Kumar Dabilpuram

[Gluster-devel] Review request for Gluster IPv6 bugfix (Bug 1117886)

Hi , Can this code be reviewed ? It is related to transport inet6 http://review.gluster.org/#/c/11988/ thanks Nithin On Wed, Jun 17, 2015 at 9:06 AM, Nithin Kumar Dabilpuram < nithind1...@yahoo.in> wrote: > Sure Richard. > > -Nithin > > > > On Tuesday, 16 June 2015 1:23 AM, Richard Wareing wr

[Gluster-devel] Review request for patch on run_tests.sh

Jeff and Manu already did review of http://review.gluster.org/#/c/12093/. Would like a few more reviews before I merge this. ___ Gluster-devel mailing list Gluster-devel@gluster.org http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] Review request for http://review.gluster.org/#/c/10262

Gentle reminder!! Since 3.7.3 is already out, I am willing to take that in for 3.7.4 On 07/24/2015 09:28 AM, Atin Mukherjee wrote: > Folks, > > Currently in our vme table we have few option names which are redundant > across different translators. For eg: cache-size, this option is same > across

[Gluster-devel] Review request for http://review.gluster.org/#/c/10262

Folks, Currently in our vme table we have few option names which are redundant across different translators. For eg: cache-size, this option is same across io-cache and quick-read xlator. Now if an user wants to have two different values set, we don't have a mechanism for it. What I have done here

Re: [Gluster-devel] Review request for patch: libglusterfs/syncop: Add xdata to all syncop calls

> Is it always ok to consider xdata to be valid, even if op_ret < 0? I would say yes, simply because it's useful. For example, xdata might contain extra information explaining the error, or suggesting a next step. In NSR, when a non-coordinator receives a request it returns EREMOTE. It would be

Re: [Gluster-devel] Review request for patch: libglusterfs/syncop: Add xdata to all syncop calls

On Tuesday 31 March 2015 09:36 PM, Raghavendra Talur wrote: Hi, I have sent updated patch which adds xdata support to all syncop calls. It adds xdata in both request and response path of syncop. Considering that this patch has changes in many files, I request a quick review and merge to avoid r

[Gluster-devel] Review request for patch: libglusterfs/syncop: Add xdata to all syncop calls

Hi, I have sent updated patch which adds xdata support to all syncop calls. It adds xdata in both request and response path of syncop. Considering that this patch has changes in many files, I request a quick review and merge to avoid rebase issues. Patch link http://review.gluster.org/#/c/9859/

[Gluster-devel] Review request for http://review.gluster.com/#/c/8244/

All, This patch was part of the glusterfsiostat GSOC effort[1]. The GSOC project was successfully completed, thanks to Vipul. This is the first for Gluster community. It would be great if we could merge this into our repository and mark the successful completion of our first GSOC proposal! [1] -

[Gluster-devel] Review request for http://review.gluster.org/#/c/8285/

All, This patch is useful for debugging network related issues in GlusterFS, esp. mount processes. Any review help is greatly appreciated. ~KP ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/glust