Re: [Gluster-devel] Testcase broken due to posix iatt commit

2016-03-28 Thread Vijaikumar Mallikarjuna
Previously function 'posix_acl_ctx_get' was creating inode_ctx if it is not present. So if sometime lookup does not come for root inode, then inode-ctx was created here without any perm set. Now inode-ctx is created only in lookup_cbk and setattr_cbk to populate the ctx with valid perm from

Re: [Gluster-devel] Testcase broken due to posix iatt commit

2016-03-28 Thread FNU Raghavendra Manjunath
Root inode gets linked during mount itselsf. We get lookups on root. But since root inode is always present in the inode table, after the mount if there is a fop on an entry whose parent is root, then that fop will be able to find the parent in the inode table as part of resolve. So it need not

Re: [Gluster-devel] Testcase broken due to posix iatt commit

2016-03-28 Thread Vijaikumar Mallikarjuna
Hi Du/Johny, Don't we get a lookup on root inode? Please confirm. If we don't get lookup on root inode, then we need to create inode-ctx in a posix_acl_ctx_get() function. Thanks, Vijay On 28-Mar-2016 7:37 PM, "FNU Raghavendra Manjunath" wrote: > CCing Vijay Kumar who made

Re: [Gluster-devel] Testcase broken due to posix iatt commit

2016-03-28 Thread FNU Raghavendra Manjunath
CCing Vijay Kumar who made the acl related changes in that patch. Vijay? Can you please look into it? Regards, Raghavendra On Mon, Mar 28, 2016 at 9:57 AM, Avra Sengupta wrote: > Hi Raghavendra, > > As part of the patch (http://review.gluster.org/#/c/13730/16), the >

[Gluster-devel] Testcase broken due to posix iatt commit

2016-03-28 Thread Avra Sengupta
Hi Raghavendra, As part of the patch (http://review.gluster.org/#/c/13730/16), the inode_ctx is not created in posix_acl_ctx_get(). Because of this the testcase in http://review.gluster.org/#/c/13623/ breaks. It fails with the following logs: [2016-03-28 13:43:39.216168] D [MSGID: 0]